182291 2018-01-30 06:45:07 -0800 StyleBench: Generate more mutation steps 2018-01-30 16:32:10 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned cdumez ews-watchlist lforschler rniwa webkit-bug-importer oldest_to_newest 1394527 0 koivisto 2018-01-30 06:45:07 -0800 The test should be doing multiple rounds of mutations in a single document to test what is supposed to test (like it did before r227756). 1394529 1 332652 koivisto 2018-01-30 06:54:13 -0800 Created attachment 332652 patch 1394732 2 332652 rniwa 2018-01-30 13:55:38 -0800 Comment on attachment 332652 patch View in context: https://bugs.webkit.org/attachment.cgi?id=332652&action=review > PerformanceTests/StyleBench/resources/tests.js:5 > + steps.push(new BenchmarkTestStep(`Adding classes, step ${i}`, (bench, contentWindow, contentDocument) => { Instead of explicitly saying step, why not just `Adding classes - ${i}`. Ditto for the rest. 1394743 3 koivisto 2018-01-30 14:08:53 -0800 https://trac.webkit.org/r227850 1394746 4 webkit-bug-importer 2018-01-30 14:10:24 -0800 <rdar://problem/37042601> 1394821 5 rniwa 2018-01-30 16:32:10 -0800 https://trac.webkit.org/changeset/227863 332652 2018-01-30 06:54:13 -0800 2018-01-30 13:55:38 -0800 patch stylebench-more-steps.patch text/plain 3880 koivisto SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjc3ODQpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE4LTAxLTMwICBB bnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBTdHlsZUJlbmNoOiBH ZW5lcmF0ZSBtb3JlIG11dGF0aW9uIHN0ZXBzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xODIyOTEKKworICAgICAgICBUaGUgdGVzdCBzaG91bGQgYmUg ZG9pbmcgbXVsdGlwbGUgcm91bmRzIG9mIG11dGF0aW9ucyBpbiBhIHNpbmdsZSBkb2N1bWVudCB0 byB0ZXN0IHdoYXQgaXMgc3VwcG9zZWQgdG8gdGVzdCAobGlrZSBpdCBkaWQgYmVmb3JlIHIyMjc3 NTYpLgorICAgICAgICBUaGlzIGFsc28gbWFrZXMgdGVzdCByZXN1bHRzIG1vcmUgc3RhYmxlIGFu ZCBsZXNzIGRlcGVuZGVudCBvbiBwb3NzaWJsZSBmaXJzdC10aW1lIGNvc3RzLgorCisgICAgICAg ICogU3R5bGVCZW5jaC9yZXNvdXJjZXMvYmVuY2htYXJrLXJ1bm5lci5qczoKKworICAgICAgICBB ZGp1c3QgY29ycmVjdGlvbkZhY3RvciB0byBtYXRjaCB0aGUgbmV3IHN0ZXBzIGNvdW50LiBXaXRo IDEuNSBGaXJlZm94IGlzIH43MnJwbS4KKworICAgICAgICAqIFN0eWxlQmVuY2gvcmVzb3VyY2Vz L3Rlc3RzLmpzOgorICAgICAgICAobWFrZVN0ZXBzKToKKworICAgICAgICBHZW5lcmF0ZSAxMCBy b3VuZHMgb2YgY2xhc3MvZWxlbWVudCBtdXRhdGlvbiBzdGVwcy4KKyAgICAgICAgR2l2ZSBlYWNo IGdlbmVyYXRlZCBzdGVwIHVuaXF1ZSBuYW1lIHNvIHJlcG9ydGluZyB3b3Jrcy4KKyAgICAgICAg TWFrZSBpbmRpdmlkdWFsIHN0ZXBzIGRvIGZld2VyIG11dGF0aW9ucy4KKwogMjAxOC0wMS0yOSAg QW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgU3R5bGVCZW5jaDog UmVtb3ZlIDogZnJvbSBhIHRlc3QgbmFtZQpJbmRleDogUGVyZm9ybWFuY2VUZXN0cy9TdHlsZUJl bmNoL3Jlc291cmNlcy9iZW5jaG1hcmstcnVubmVyLmpzCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvU3R5bGVCZW5jaC9yZXNvdXJjZXMvYmVuY2htYXJrLXJ1bm5lci5qcwkocmV2aXNp b24gMjI3Nzc5KQorKysgUGVyZm9ybWFuY2VUZXN0cy9TdHlsZUJlbmNoL3Jlc291cmNlcy9iZW5j aG1hcmstcnVubmVyLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0yODYsNyArMjg2LDcgQEAgQmVuY2ht YXJrUnVubmVyLnByb3RvdHlwZS5fZmluYWxpemUgPSBmdQogICAgICAgICB2YXIgdG90YWwgPSB2 YWx1ZXMucmVkdWNlKGZ1bmN0aW9uIChhLCBiKSB7IHJldHVybiBhICsgYiB9KTsKICAgICAgICAg dmFyIGdlb21lYW4gPSBNYXRoLnBvdyhwcm9kdWN0LCAxIC8gdmFsdWVzLmxlbmd0aCk7CiAKLSAg ICAgICAgdmFyIGNvcnJlY3Rpb25GYWN0b3IgPSA4OyAvLyBUaGlzIGZhY3RvciBtYWtlcyB0aGUg dGVzdCBzY29yZSBsb29rIHJlYXNvbmFibHkgZml0IHdpdGhpbiAwIHRvIDE0MC4KKyAgICAgICAg dmFyIGNvcnJlY3Rpb25GYWN0b3IgPSAxLjU7IC8vIFRoaXMgZmFjdG9yIG1ha2VzIHRoZSB0ZXN0 IHNjb3JlIGxvb2sgcmVhc29uYWJseSBmaXQgd2l0aGluIDAgdG8gMTQwLgogICAgICAgICB0aGlz Ll9tZWFzdXJlZFZhbHVlcy50b3RhbCA9IHRvdGFsOwogICAgICAgICB0aGlzLl9tZWFzdXJlZFZh bHVlcy5tZWFuID0gdG90YWwgLyB2YWx1ZXMubGVuZ3RoOwogICAgICAgICB0aGlzLl9tZWFzdXJl ZFZhbHVlcy5nZW9tZWFuID0gZ2VvbWVhbjsKSW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvU3R5bGVC ZW5jaC9yZXNvdXJjZXMvdGVzdHMuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gUGVyZm9ybWFuY2VUZXN0cy9T dHlsZUJlbmNoL3Jlc291cmNlcy90ZXN0cy5qcwkocmV2aXNpb24gMjI3Nzc5KQorKysgUGVyZm9y bWFuY2VUZXN0cy9TdHlsZUJlbmNoL3Jlc291cmNlcy90ZXN0cy5qcwkod29ya2luZyBjb3B5KQpA QCAtMSwxOCArMSwyMCBAQAogZnVuY3Rpb24gbWFrZVN0ZXBzKGNvdW50KQogewogICAgIGNvbnN0 IHN0ZXBzID0gW107Ci0gICAgc3RlcHMucHVzaChuZXcgQmVuY2htYXJrVGVzdFN0ZXAoJ0FkZGlu ZyBjbGFzc2VzJywgKGJlbmNoLCBjb250ZW50V2luZG93LCBjb250ZW50RG9jdW1lbnQpID0+IHsK LSAgICAgICAgYmVuY2guYWRkQ2xhc3NlcygxMDApOwotICAgIH0pKTsKLSAgICBzdGVwcy5wdXNo KG5ldyBCZW5jaG1hcmtUZXN0U3RlcCgnUmVtb3ZpbmcgY2xhc3NlcycsIChiZW5jaCwgY29udGVu dFdpbmRvdywgY29udGVudERvY3VtZW50KSA9PiB7Ci0gICAgICAgIGJlbmNoLnJlbW92ZUNsYXNz ZXMoMTAwKTsKLSAgICB9KSk7Ci0gICAgc3RlcHMucHVzaChuZXcgQmVuY2htYXJrVGVzdFN0ZXAo J0FkZGluZyBsZWFmIGVsZW1lbnRzJywgKGJlbmNoLCBjb250ZW50V2luZG93LCBjb250ZW50RG9j dW1lbnQpID0+IHsKLSAgICAgICAgYmVuY2guYWRkTGVhZkVsZW1lbnRzKDEwMCk7Ci0gICAgfSkp OwotICAgIHN0ZXBzLnB1c2gobmV3IEJlbmNobWFya1Rlc3RTdGVwKCdSZW1vdmluZyBsZWFmIGVs ZW1lbnRzJywgKGJlbmNoLCBjb250ZW50V2luZG93LCBjb250ZW50RG9jdW1lbnQpID0+IHsKLSAg ICAgICAgYmVuY2gucmVtb3ZlTGVhZkVsZW1lbnRzKDEwMCk7Ci0gICAgfSkpOworICAgIGZvciAo aSA9IDE7IGkgPD0gY291bnQ7ICsraSkgeworICAgICAgICBzdGVwcy5wdXNoKG5ldyBCZW5jaG1h cmtUZXN0U3RlcChgQWRkaW5nIGNsYXNzZXMsIHN0ZXAgJHtpfWAsIChiZW5jaCwgY29udGVudFdp bmRvdywgY29udGVudERvY3VtZW50KSA9PiB7CisgICAgICAgICAgICBiZW5jaC5hZGRDbGFzc2Vz KDI1KTsKKyAgICAgICAgfSkpOworICAgICAgICBzdGVwcy5wdXNoKG5ldyBCZW5jaG1hcmtUZXN0 U3RlcChgUmVtb3ZpbmcgY2xhc3Nlcywgc3RlcCAke2l9YCwgKGJlbmNoLCBjb250ZW50V2luZG93 LCBjb250ZW50RG9jdW1lbnQpID0+IHsKKyAgICAgICAgICAgIGJlbmNoLnJlbW92ZUNsYXNzZXMo MjUpOworICAgICAgICB9KSk7CisgICAgICAgIHN0ZXBzLnB1c2gobmV3IEJlbmNobWFya1Rlc3RT dGVwKGBBZGRpbmcgbGVhZiBlbGVtZW50cywgc3RlcCAke2l9YCwgKGJlbmNoLCBjb250ZW50V2lu ZG93LCBjb250ZW50RG9jdW1lbnQpID0+IHsKKyAgICAgICAgICAgIGJlbmNoLmFkZExlYWZFbGVt ZW50cygyNSk7CisgICAgICAgIH0pKTsKKyAgICAgICAgc3RlcHMucHVzaChuZXcgQmVuY2htYXJr VGVzdFN0ZXAoYFJlbW92aW5nIGxlYWYgZWxlbWVudHMsIHN0ZXAgJHtpfWAsIChiZW5jaCwgY29u dGVudFdpbmRvdywgY29udGVudERvY3VtZW50KSA9PiB7CisgICAgICAgICAgICBiZW5jaC5yZW1v dmVMZWFmRWxlbWVudHMoMjUpOworICAgICAgICB9KSk7CisgICAgfQogICAgIHJldHVybiBzdGVw czsKIH0KIApAQCAtMjYsNyArMjgsNyBAQCBmdW5jdGlvbiBtYWtlU3VpdGUoY29uZmlndXJhdGlv bikKICAgICAgICAgICAgICAgICByZXR1cm4gY29udGVudFdpbmRvdy5jcmVhdGVCZW5jaG1hcmso Y29uZmlndXJhdGlvbik7CiAgICAgICAgICAgICB9KTsKICAgICAgICAgfSwKLSAgICAgICAgdGVz dHM6IG1ha2VTdGVwcygpLAorICAgICAgICB0ZXN0czogbWFrZVN0ZXBzKDEwKSwKICAgICB9Owog fQogCg==