182287 2018-01-30 05:33:40 -0800 Rewrite fast/events/scroll-in-scaled-page-with-overflow-hidden.html to conform with CSSOM View 2018-02-01 06:05:13 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 5991 182230 1 fred.wang fred.wang cdumez lforschler simon.fraser tonikitoo webkit-bug-importer oldest_to_newest 1394509 0 fred.wang 2018-01-30 05:33:40 -0800 fast/events/scroll-in-scaled-page-with-overflow-hidden.html uses document.body.scrollTop to retrieve the vertical scroll offset of the viewport. This currently works because WebKit does not follow the CSSOM View spec (bug 5991). However, when CSSOMViewScrollingAPI is enabled, the HTML body is potentially scrollable (html, body have overflow: hidden see [1]) so document.body.scrollTop does not return the scroll offset [2]. Instead, the corresponding Chromium test [3] relies on internals.visualViewportScrollY(). [1] https://drafts.csswg.org/cssom-view/#potentially-scrollable [2] https://drafts.csswg.org/cssom-view/#dom-element-scrolltop [3] https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/events/scroll-in-scaled-page-with-overflow-hidden.html?q=scroll-in-scaled-page-with-overflow-hidden.html&sq=package:chromium&dr 1394956 1 332752 fred.wang 2018-01-31 03:08:01 -0800 Created attachment 332752 Patch 1394958 2 fred.wang 2018-01-31 03:10:39 -0800 (In reply to Frédéric Wang (:fredw) from comment #0) > Instead, the > corresponding Chromium test [3] relies on internals.visualViewportScrollY(). So it looks like internals.visualViewportRect().y would work too, but I've simply used window.scrollY which is what document.body.scrollTop is supposed to return when the body is not potentially scrollable: https://drafts.csswg.org/cssom-view/#dom-element-scrolltop 1395429 3 fred.wang 2018-02-01 06:03:51 -0800 Committed r227962: <https://trac.webkit.org/changeset/227962> 1395430 4 webkit-bug-importer 2018-02-01 06:05:13 -0800 <rdar://problem/37113985> 332752 2018-01-31 03:08:01 -0800 2018-02-01 04:50:04 -0800 Patch bug-182287-20180131120759.patch text/plain 3293 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3ODk4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNzZkNjhmNTZkMTZjYWY2MDNjODlm YmFkOGJmNDdmNzRlNjE0MWE0OC4uOWY3OGI0MzAwNGU4MTI3N2E0ODhlODlmMTJmYzZmMjJlYzA2 MmRlMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTAxLTMxICBGcmVkZXJpYyBXYW5nICA8 ZndhbmdAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXdyaXRlIGZhc3QvZXZlbnRzL3Njcm9sbC1p bi1zY2FsZWQtcGFnZS13aXRoLW92ZXJmbG93LWhpZGRlbi5odG1sIHRvIGNvbmZvcm0gd2l0aCBD U1NPTSBWaWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xODIyODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBQZXIgdGhlIENTU09NIFZpZXcgc3BlY2lmaWNhdGlvbiwgaXQgaXMgd3JvbmcgdG8gdXNlIGRv Y3VtZW50LmJvZHkuc2Nyb2xsVG9wIHRvIHJldHJpZXZlIHRoZQorICAgICAgICB2ZXJ0aWNhbCBv ZmZzZXQgb2YgdGhlIHZpZXdwb3J0IGluIHRoaXMgdGVzdCwgYmVjYXVzZSB0aGUgYm9keSBpcyBw b3RlbnRpYWxseSBzY3JvbGxhYmxlLgorICAgICAgICBUaGlzIGNvbW1pdCByZWxpZXMgb24gd2lu ZG93LnNjcm9sbFkgaW5zdGVhZCBzbyB0aGF0IHRoZSB0ZXN0IHN0aWxsIHdvcmtzIGFmdGVyIGJ1 ZyA1OTkxLgorCisgICAgICAgICogZmFzdC9ldmVudHMvc2Nyb2xsLWluLXNjYWxlZC1wYWdlLXdp dGgtb3ZlcmZsb3ctaGlkZGVuLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2V2ZW50cy9z Y3JvbGwtaW4tc2NhbGVkLXBhZ2Utd2l0aC1vdmVyZmxvdy1oaWRkZW4uaHRtbDoKKwogMjAxOC0w MS0zMSAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBKU0MgaW5j b3JyZWN0bHkgaW50ZXJwcmV0aW5nIHNjcmlwdCwgc2V0cyBHbG9iYWwgUHJvcGVydHkgaW5zdGVh ZCBvZiBHbG9iYWwgTGV4aWNhbCB2YXJpYWJsZSAoTGl0ZXJhbFBhcnNlciAvIEpTT05QIHBhdGgp CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9zY3JvbGwtaW4tc2NhbGVkLXBh Z2Utd2l0aC1vdmVyZmxvdy1oaWRkZW4tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9l dmVudHMvc2Nyb2xsLWluLXNjYWxlZC1wYWdlLXdpdGgtb3ZlcmZsb3ctaGlkZGVuLWV4cGVjdGVk LnR4dAppbmRleCBkZDQ2YmJiYTJlZTQxM2UwMWEwOTE4ZTFiMmU1MmNjYjQ3YjUxYjZjLi5iMTY0 ODRlNzM3OTZkMTkyOWQwMTc2ZDU4YmZjYzVjOWNkYzAyYzg1IDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9mYXN0L2V2ZW50cy9zY3JvbGwtaW4tc2NhbGVkLXBhZ2Utd2l0aC1vdmVyZmxvdy1oaWRk ZW4tZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3Njcm9sbC1pbi1z Y2FsZWQtcGFnZS13aXRoLW92ZXJmbG93LWhpZGRlbi1leHBlY3RlZC50eHQKQEAgLTEsNiArMSw2 IEBACiBUaGlzIHRlc3RzIHRoYXQgYSB1c3VhbGx5IG92ZXJmbG93OiBoaWRkZW4gdmlld3BvcnQg c2hvdWxkIGJlIHNjcm9sbGFibGUgd2hlbiBzY2FsZWQuIE90aGVyd2lzZSwgeW91IGNhbid0IGdl dCB0byBjb250ZW50IHlvdSB3b3VsZCBoYXZlIGJlZW4gYWJsZSB0byBnZXQgdG8gaGFkIHlvdSBu b3QgYmVlbiB6b29tZWQgaXQuCi1QQVNTIHdpbmRvdy5kb2N1bWVudC5ib2R5LnNjcm9sbFRvcCBp cyAwCi1QQVNTIHdpbmRvdy5kb2N1bWVudC5ib2R5LnNjcm9sbFRvcCBpcyAxMDAKK1BBU1Mgd2lu ZG93LnNjcm9sbFkgaXMgMAorUEFTUyB3aW5kb3cuc2Nyb2xsWSBpcyAxMDAKIFBBU1Mgc3VjY2Vz c2Z1bGx5UGFyc2VkIGlzIHRydWUKIAogVEVTVCBDT01QTEVURQpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC9ldmVudHMvc2Nyb2xsLWluLXNjYWxlZC1wYWdlLXdpdGgtb3ZlcmZsb3ctaGlk ZGVuLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9zY3JvbGwtaW4tc2NhbGVkLXBhZ2Ut d2l0aC1vdmVyZmxvdy1oaWRkZW4uaHRtbAppbmRleCA3YTI2OTQzNmRlNjJjODQ2YTk3ZDVkZmM5 NjJjZjZiYjJlY2RlMzE5Li42NmRjM2Y3OWM2NTFlNTk2NzAxYjg0ZjhmNzQ1OGE3M2NkNTA4MGEw IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9zY3JvbGwtaW4tc2NhbGVkLXBh Z2Utd2l0aC1vdmVyZmxvdy1oaWRkZW4uaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50 cy9zY3JvbGwtaW4tc2NhbGVkLXBhZ2Utd2l0aC1vdmVyZmxvdy1oaWRkZW4uaHRtbApAQCAtMjcs MTAgKzI3LDE2IEBACiAgICAgICAgIGlmICh3aW5kb3cuaW50ZXJuYWxzKQogICAgICAgICAgICAg d2luZG93LmludGVybmFscy5zZXRQYWdlU2NhbGVGYWN0b3IoMiwgMCwgMCk7CiAKLSAgICAgICAg c2hvdWxkQmUoIndpbmRvdy5kb2N1bWVudC5ib2R5LnNjcm9sbFRvcCIsICIwIik7CisgICAgICAg IC8vIE5vdGUgdGhhdCB3aXRoIENTU09NVmlld1Njcm9sbGluZ0FQSSBlbmFibGVkLCB0aGUgSFRN TCBib2R5IGlzIHBvdGVudGlhbGx5IHNjcm9sbGFibGUuCisgICAgICAgIC8vIEhlbmNlIGRvY3Vt ZW50LnNjcm9sbGluZ0VsZW1lbnQgaXMgbnVsbCBhbmQgd2UgY2FuJ3QgdXNlIGRvY3VtZW50LmJv ZHkuc2Nyb2xsVG9wIHRvCisgICAgICAgIC8vIHJldHJpZXZlIHRoZSB2ZXJ0aWNhbCBzY3JvbGwg b2Zmc2V0IG9mIHRoZSB2aWV3cG9ydC4KKyAgICAgICAgLy8gU2VlIGh0dHBzOi8vZHJhZnRzLmNz c3dnLm9yZy9jc3NvbS12aWV3LyNwb3RlbnRpYWxseS1zY3JvbGxhYmxlLAorICAgICAgICAvLyBo dHRwczovL2RyYWZ0cy5jc3N3Zy5vcmcvY3Nzb20tdmlldy8jZG9tLWRvY3VtZW50LXNjcm9sbGlu Z2VsZW1lbnQKKyAgICAgICAgLy8gYW5kIGh0dHBzOi8vZHJhZnRzLmNzc3dnLm9yZy9jc3NvbS12 aWV3LyNkb20tZWxlbWVudC1zY3JvbGx0b3AKKyAgICAgICAgc2hvdWxkQmUoIndpbmRvdy5zY3Jv bGxZIiwgIjAiKTsKIAogICAgICAgICBkb2N1bWVudC5ib2R5Lm9uc2Nyb2xsID0gZnVuY3Rpb24o KSB7Ci0gICAgICAgICAgICBzaG91bGRCZSgid2luZG93LmRvY3VtZW50LmJvZHkuc2Nyb2xsVG9w IiwgIjEwMCIpOworICAgICAgICAgICAgc2hvdWxkQmUoIndpbmRvdy5zY3JvbGxZIiwgIjEwMCIp OwogICAgICAgICAgICAgZmluaXNoSlNUZXN0KCk7CiAgICAgICAgIH0KIAo=