182284 2018-01-30 02:07:58 -0800 [WebVR][GTK][WPE] Exclude OpenVR from tarballs 2018-01-30 08:19:16 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 177298 1 svillar svillar mcatanzaro webkit-bug-importer oldest_to_newest 1394478 0 svillar 2018-01-30 02:07:58 -0800 [WebVR][GTK][WPE] Exclude OpenVR from tarballs 1394479 1 332640 svillar 2018-01-30 02:10:30 -0800 Created attachment 332640 Patch 1394512 2 332640 mcatanzaro 2018-01-30 05:59:04 -0800 Comment on attachment 332640 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332640&action=review Thanks > Source/cmake/OptionsWPE.cmake:51 > +WEBKIT_OPTION_DEFINE(USE_OPENVR "Whether to use OpenVR as WebVR backend." PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES}) This is right. I would just move it higher up in the file, above if (CMAKE_SYSTEM_NAME MATCHES "Linux"), and add a comment to parallel the other sections: # Private options specific to the WPE port. It won't be long before there are more such options. 1394552 3 svillar 2018-01-30 08:18:33 -0800 Committed r227788: <https://trac.webkit.org/changeset/227788> 1394553 4 webkit-bug-importer 2018-01-30 08:19:16 -0800 <rdar://problem/37029301> 332640 2018-01-30 02:10:30 -0800 2018-01-30 05:59:04 -0800 Patch bug-182284-20180130111029.patch text/plain 4379 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3Nzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IDkxYzQ1 ZjlkMjU3ZGUyZGM2NmNmMzU5ZDZhYmUwOTFjMWUzYTI5ZDEuLmJjNTRjYjAxM2VhZTU1MjAyMjVm ZjZlNjliYzEzYzU4NjliMWI2ZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC04Nyw2ICs4Nyw3 IEBAIFdFQktJVF9PUFRJT05fREVGSU5FKFVTRV9XT0ZGMiAiV2hldGhlciB0byBlbmFibGUgc3Vw cG9ydCBmb3IgV09GRjIgV2ViIEZvbnRzLiIKICMgUHJpdmF0ZSBvcHRpb25zIHNwZWNpZmljIHRv IHRoZSBHVEsrIHBvcnQuIENoYW5naW5nIHRoZXNlIG9wdGlvbnMgaXMKICMgY29tcGxldGVseSB1 bnN1cHBvcnRlZC4gVGhleSBhcmUgaW50ZW5kZWQgZm9yIHVzZSBvbmx5IGJ5IFdlYktpdCBkZXZl bG9wZXJzLgogV0VCS0lUX09QVElPTl9ERUZJTkUoVVNFX1JFRElSRUNURURfWENPTVBPU0lURV9X SU5ET1cgIldoZXRoZXIgdG8gdXNlIGEgUmVkaXJlY3RlZCBYQ29tcG9zaXRlIFdpbmRvdyBmb3Ig YWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgaW4gWDExLiIgUFJJVkFURSBPTikKK1dFQktJVF9PUFRJ T05fREVGSU5FKFVTRV9PUEVOVlIgIldoZXRoZXIgdG8gdXNlIE9wZW5WUiBhcyBXZWJWUiBiYWNr ZW5kLiIgUFJJVkFURSAke0VOQUJMRV9FWFBFUklNRU5UQUxfRkVBVFVSRVN9KQogCiAjIEZJWE1F OiBDYW4gd2UgdXNlIGNhaXJvLWdsZXN2MiB0byBhdm9pZCB0aGlzIGNvbmZsaWN0PwogV0VCS0lU X09QVElPTl9DT05GTElDVChFTkFCTEVfQUNDRUxFUkFURURfMkRfQ0FOVkFTIEVOQUJMRV9HTEVT MikKQEAgLTM0MCw4ICszNDEsNiBAQCBpZiAoVVNFX0xJQkhZUEhFTikKICAgICBlbmRpZiAoKQog ZW5kaWYgKCkKIAotU0VUX0FORF9FWFBPU0VfVE9fQlVJTEQoVVNFX09QRU5WUiBUUlVFKQotCiBp ZiAoVVNFX1VQT1dFUikKICAgICBmaW5kX3BhY2thZ2UoVVBvd2VyR0xpYikKICAgICBpZiAoTk9U IFVQT1dFUkdMSUJfRk9VTkQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc1dQRS5j bWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCmluZGV4IDdmNGY3ZGZmZWJlN2Q0 ZWM4OWQ1NzQyZmIyZjU4ZThiMTQ3ZDkyNzEuLjAyOWY3NjUzZWQzYWUwNDhlYmFkYmUxOWJiNWUx ZTEwMzZjNjUyMTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCisr KyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCkBAIC00OCw2ICs0OCw4IEBAIGVuZGlm ICgpCiAKIGluY2x1ZGUoR1N0cmVhbWVyRGVwZW5kZW5jaWVzKQogCitXRUJLSVRfT1BUSU9OX0RF RklORShVU0VfT1BFTlZSICJXaGV0aGVyIHRvIHVzZSBPcGVuVlIgYXMgV2ViVlIgYmFja2VuZC4i IFBSSVZBVEUgJHtFTkFCTEVfRVhQRVJJTUVOVEFMX0ZFQVRVUkVTfSkKKwogV0VCS0lUX09QVElP Tl9FTkQoKQogCiBmaW5kX3BhY2thZ2UoQ2Fpcm8gMS4xMC4yIFJFUVVJUkVEKQpAQCAtMTA1LDgg KzEwNyw2IEBAIFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKFVTRV9USUxFRF9CQUNLSU5HX1NUT1JF IFRSVUUpCiBTRVRfQU5EX0VYUE9TRV9UT19CVUlMRChVU0VfQ09PUkRJTkFURURfR1JBUEhJQ1Mg VFJVRSkKIFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKFVTRV9DT09SRElOQVRFRF9HUkFQSElDU19U SFJFQURFRCBUUlVFKQogCi1TRVRfQU5EX0VYUE9TRV9UT19CVUlMRChVU0VfT1BFTlZSIFRSVUUp Ci0KIHNldChGT1JXQVJESU5HX0hFQURFUlNfRElSICR7REVSSVZFRF9TT1VSQ0VTX0RJUn0vRm9y d2FyZGluZ0hlYWRlcnMpCiBzZXQoRk9SV0FSRElOR19IRUFERVJTX1dQRV9ESVIgJHtGT1JXQVJE SU5HX0hFQURFUlNfRElSfS93cGUpCiBzZXQoRk9SV0FSRElOR19IRUFERVJTX1dQRV9FWFRFTlNJ T05fRElSICR7Rk9SV0FSRElOR19IRUFERVJTX0RJUn0vd3BlLXdlYmV4dGVuc2lvbikKZGlmZiAt LWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2ZWUwN2E2YzZl N2I2NWVmZWE0MTliZTEyODM0MDU0MzY5MDQ5YzBmLi43YWRiZGEyZTQ0ZDE4OGQ0ZDdmYTljOTYw OWU0NzRmYzBmNTU3M2FmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDEtMzAgIFNlcmdpbyBWaWxsYXIgU2Vu aW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dlYlZSXVtHVEtdW1dQRV0gRXhj bHVkZSBPcGVuVlIgZnJvbSB0YXJiYWxscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTgyMjg0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBndGsvbWFuaWZlc3QudHh0LmluOiBBZGRlZCBUaGlyZFBhcnR5 L29wZW52ciB0byBleGNsdXNpb25zLgorICAgICAgICAqIHdwZS9tYW5pZmVzdC50eHQuaW46IERp dHRvLgorCiAyMDE4LTAxLTI5ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtp dC5vcmc+CiAKICAgICAgICAgQ2xlYW4gdXAgQVBJIGFmdGVyIGJ1Z3MgMTc4MjQwIGFuZCAxNzY0 NzQKZGlmZiAtLWdpdCBhL1Rvb2xzL2d0ay9tYW5pZmVzdC50eHQuaW4gYi9Ub29scy9ndGsvbWFu aWZlc3QudHh0LmluCmluZGV4IGU2MTQ2MDI0MmMyMTk1YTNhZjk3NjIyZGZmM2MwMTMyOWQ5YzUw OGQuLmY5NTgxNmY1ZDdmOGExNDBmN2NiYWYwNTAzZmVmNWUzY2FiOGY1ZGMgMTAwNjQ0Ci0tLSBh L1Rvb2xzL2d0ay9tYW5pZmVzdC50eHQuaW4KKysrIGIvVG9vbHMvZ3RrL21hbmlmZXN0LnR4dC5p bgpAQCAtNDksNiArNDksNyBAQCBkaXJlY3RvcnkgU291cmNlCiBleGNsdWRlIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS90ZXN0cwogZXhjbHVkZSBTb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMKIGV4 Y2x1ZGUgU291cmNlL1RoaXJkUGFydHkvcXVuaXQKK2V4Y2x1ZGUgU291cmNlL1RoaXJkUGFydHkv b3BlbnZyCiBleGNsdWRlIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL3Jlc291cmNlcwog ZXhjbHVkZSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QKIGV4Y2x1ZGUgU291 cmNlL1dlYkNvcmUvUmVzb3VyY2VzCmRpZmYgLS1naXQgYS9Ub29scy93cGUvbWFuaWZlc3QudHh0 LmluIGIvVG9vbHMvd3BlL21hbmlmZXN0LnR4dC5pbgppbmRleCA1ZmI3ZjI5OWM0MjcyZDAzNDBk NDc5ODNlNTRmY2MzYzhhZTgzOTRlLi5mYjk5MzZlZTVhMDMyNmUzMGE5NmUxOTBjNDUxZGJkZTIx ODZkMDIyIDEwMDY0NAotLS0gYS9Ub29scy93cGUvbWFuaWZlc3QudHh0LmluCisrKyBiL1Rvb2xz L3dwZS9tYW5pZmVzdC50eHQuaW4KQEAgLTQ5LDYgKzQ5LDcgQEAgZGlyZWN0b3J5IFNvdXJjZQog ZXhjbHVkZSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMKIGV4Y2x1ZGUgU291cmNlL1RoaXJk UGFydHkvbGlid2VicnRjCiBleGNsdWRlIFNvdXJjZS9UaGlyZFBhcnR5L3F1bml0CitleGNsdWRl IFNvdXJjZS9UaGlyZFBhcnR5L29wZW52cgogZXhjbHVkZSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9hdWRpby9yZXNvdXJjZXMKIGV4Y2x1ZGUgU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy90ZXN0CiBleGNsdWRlIFNvdXJjZS9XZWJDb3JlL1Jlc291cmNlcwpkaWZmIC0tZ2l0IGEvQ2hh bmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDE5Njg3OGRmZTQ2ZTZlZGRlMThhY2UxM2E0MjQ1NTY4 ZmRmOTFjODIuLmExYzJiYjRmM2NiNmVmOTVkYWNlZTc0NzU2MGE5ZjE3ZjA1Njc1OTcgMTAwNjQ0 Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxOC0w MS0zMCAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KKworICAgICAg ICBbV2ViVlJdW0dUS11bV1BFXSBFeGNsdWRlIE9wZW5WUiBmcm9tIHRhcmJhbGxzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODIyODQKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBwcml2YXRlIGJ1 aWxkIG9wdGlvbnMgZm9yIFVTRV9PUEVOVlIuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZToKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc1dQRS5jbWFrZToK KwogMjAxOC0wMS0yOSAgSmlld2VuIFRhbiAgPGppZXdlbl90YW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFtXZWJBdXRoTl0gQWRkIGEgY29tcGlsZS10aW1lIGZlYXR1cmUgZmxhZwo=