182263 2018-01-29 14:43:25 -0800 Make policy checks more robust against null pointer dereferencing 2018-01-29 15:18:31 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen thorton webkit-bug-importer oldest_to_newest 1394273 0 achristensen 2018-01-29 14:43:25 -0800 Make policy checks more robust against null pointer dereferencing 1394275 1 332583 achristensen 2018-01-29 14:54:17 -0800 Created attachment 332583 Patch 1394284 2 332583 thorton 2018-01-29 15:15:11 -0800 Comment on attachment 332583 Patch No test?! 1394286 3 achristensen 2018-01-29 15:17:47 -0800 I can't reproduce this. It's a rare crash from users' crash tracing. trac.webkit.org/r227758 1394287 4 webkit-bug-importer 2018-01-29 15:18:31 -0800 <rdar://problem/37004042> 332583 2018-01-29 14:54:17 -0800 2018-01-29 15:15:11 -0800 Patch bug-182263-20180129145417.patch text/plain 2245 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjc3NTcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE4LTAxLTI5ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTWFrZSBwb2xpY3kg Y2hlY2tzIG1vcmUgcm9idXN0IGFnYWluc3QgbnVsbCBwb2ludGVyIGRlcmVmZXJlbmNpbmcKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjI2MworICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMzQ4OTU3MTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2UncmUgc3RpbGwgZGVyZWZlcmVuY2luZyBudWxsLiAg Q2hlY2sgZXZlcnl0aGluZy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQv V2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZUxvYWRl ckNsaWVudDo6ZGlzcGF0Y2hEZWNpZGVQb2xpY3lGb3JSZXNwb25zZSk6CisKIDIwMTgtMDEtMjkg IEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHRlbGVt ZXRyeSB0byB0cmFjayBzdG9yYWdlIGFjY2VzcyBBUEkgYWRvcHRpb24KSW5kZXg6IFNvdXJjZS9X ZWJLaXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dl YkZyYW1lTG9hZGVyQ2xpZW50LmNwcAkocmV2aXNpb24gMjI3NjgyKQorKysgU291cmNlL1dlYktp dC9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcAkod29y a2luZyBjb3B5KQpAQCAtNzQ4LDcgKzc0OCwxMCBAQCB2b2lkIFdlYkZyYW1lTG9hZGVyQ2xpZW50 OjpkaXNwYXRjaERlY2lkCiAgICAgV2ViQ29yZTo6RnJhbWUqIGNvcmVGcmFtZSA9IG1fZnJhbWUt PmNvcmVGcmFtZSgpOwogICAgIGlmICghY29yZUZyYW1lKQogICAgICAgICByZXR1cm4gZnVuY3Rp b24oUG9saWN5QWN0aW9uOjpJZ25vcmUpOwotICAgIGF1dG8gbmF2aWdhdGlvbklEID0gc3RhdGlj X2Nhc3Q8V2ViRG9jdW1lbnRMb2FkZXImPigqY29yZUZyYW1lLT5sb2FkZXIoKS5wcm92aXNpb25h bERvY3VtZW50TG9hZGVyKCkpLm5hdmlnYXRpb25JRCgpOworICAgIGF1dG8qIHBvbGljeURvY3Vt ZW50TG9hZGVyID0gY29yZUZyYW1lLT5sb2FkZXIoKS5wcm92aXNpb25hbERvY3VtZW50TG9hZGVy KCk7CisgICAgaWYgKCFwb2xpY3lEb2N1bWVudExvYWRlcikKKyAgICAgICAgcmV0dXJuIGZ1bmN0 aW9uKFBvbGljeUFjdGlvbjo6SWdub3JlKTsKKyAgICBhdXRvIG5hdmlnYXRpb25JRCA9IHN0YXRp Y19jYXN0PFdlYkRvY3VtZW50TG9hZGVyJj4oKnBvbGljeURvY3VtZW50TG9hZGVyKS5uYXZpZ2F0 aW9uSUQoKTsKICAgICBpZiAoIXdlYlBhZ2UtPnNlbmRTeW5jKE1lc3NhZ2VzOjpXZWJQYWdlUHJv eHk6OkRlY2lkZVBvbGljeUZvclJlc3BvbnNlU3luYyhtX2ZyYW1lLT5mcmFtZUlEKCksIFNlY3Vy aXR5T3JpZ2luRGF0YTo6ZnJvbUZyYW1lKGNvcmVGcmFtZSksIG5hdmlnYXRpb25JRCwgcmVzcG9u c2UsIHJlcXVlc3QsIGNhblNob3dNSU1FVHlwZSwgbGlzdGVuZXJJRCwgVXNlckRhdGEoV2ViUHJv Y2Vzczo6c2luZ2xldG9uKCkudHJhbnNmb3JtT2JqZWN0c1RvSGFuZGxlcyh1c2VyRGF0YS5nZXQo KSkuZ2V0KCkpKSwgTWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6RGVjaWRlUG9saWN5Rm9yUmVzcG9u c2VTeW5jOjpSZXBseShyZWNlaXZlZFBvbGljeUFjdGlvbiwgcG9saWN5QWN0aW9uLCBkb3dubG9h ZElEKSwgU2Vjb25kczo6aW5maW5pdHkoKSwgSVBDOjpTZW5kU3luY09wdGlvbjo6SW5mb3JtUGxh dGZvcm1Qcm9jZXNzV2lsbFN1c3BlbmQpKSB7CiAgICAgICAgIG1fZnJhbWUtPmRpZFJlY2VpdmVQ b2xpY3lEZWNpc2lvbihsaXN0ZW5lcklELCBQb2xpY3lBY3Rpb246Oklnbm9yZSwgMCwgeyB9LCB7 IH0pOwogICAgICAgICByZXR1cm47Cg==