<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>182258</bug_id>
          
          <creation_ts>2018-01-29 12:55:14 -0800</creation_ts>
          <short_desc>StyleBench: Remove : from a test name</short_desc>
          <delta_ts>2018-01-29 18:06:28 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Antti Koivisto">koivisto</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>lforschler</cc>
    
    <cc>rniwa</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1394223</commentid>
    <comment_count>0</comment_count>
    <who name="Antti Koivisto">koivisto</who>
    <bug_when>2018-01-29 12:55:14 -0800</bug_when>
    <thetext>It breaks reporting</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1394225</commentid>
    <comment_count>1</comment_count>
      <attachid>332571</attachid>
    <who name="Antti Koivisto">koivisto</who>
    <bug_when>2018-01-29 12:56:56 -0800</bug_when>
    <thetext>Created attachment 332571
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1394231</commentid>
    <comment_count>2</comment_count>
      <attachid>332571</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2018-01-29 13:19:13 -0800</bug_when>
    <thetext>Comment on attachment 332571
patch

Actually, let&apos;s hold off on landing this until I can verify that the math I&apos;m doing in run-perf-tests is right.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1394359</commentid>
    <comment_count>3</comment_count>
      <attachid>332571</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2018-01-29 17:39:37 -0800</bug_when>
    <thetext>Comment on attachment 332571
patch

Okay. I&apos;ve temporarily skipped StyleBench explicitly in https://trac.webkit.org/r227767 since we need to fix webkit.org/b/182088 as well before the test could run.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1394360</commentid>
    <comment_count>4</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2018-01-29 17:39:54 -0800</bug_when>
    <thetext>But we need this patch to make run-benchmark work with StyleBench so landing this now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1394375</commentid>
    <comment_count>5</comment_count>
      <attachid>332571</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-01-29 18:04:14 -0800</bug_when>
    <thetext>Comment on attachment 332571
patch

Clearing flags on attachment: 332571

Committed r227769: &lt;https://trac.webkit.org/changeset/227769&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1394376</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-01-29 18:04:16 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1394378</commentid>
    <comment_count>7</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-01-29 18:06:28 -0800</bug_when>
    <thetext>&lt;rdar://problem/37010610&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>332571</attachid>
            <date>2018-01-29 12:56:56 -0800</date>
            <delta_ts>2018-01-29 18:04:14 -0800</delta_ts>
            <desc>patch</desc>
            <filename>no-colon.patch</filename>
            <type>text/plain</type>
            <size>1242</size>
            <attacher name="Antti Koivisto">koivisto</attacher>
            
              <data encoding="base64">SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h
bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjc3NTApCisrKyBQZXJmb3JtYW5jZVRlc3Rz
L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE4LTAxLTI5ICBB
bnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBTdHlsZUJlbmNoOiBS
ZW1vdmUgOiBmcm9tIGEgdGVzdCBuYW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD0xODIyNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBJdCBicmVha3MgcmVwb3J0aW5nLgorCisgICAgICAgICogU3R5bGVC
ZW5jaC9yZXNvdXJjZXMvc3R5bGUtYmVuY2guanM6CisgICAgICAgIChudGhQc2V1ZG9DbGFzc0Nv
bmZpZ3VyYXRpb24pOgorCiAyMDE4LTAxLTI2ICBDaHJpcyBOYXJkaSAgPGNuYXJkaUBjaHJvbWl1
bS5vcmc+CiAKICAgICAgICAgQWRkcmVzc2luZyBwb3N0LXJldmlldyBjb21tZW50cyBhZnRlciBy
MjI2NjE0CkluZGV4OiBQZXJmb3JtYW5jZVRlc3RzL1N0eWxlQmVuY2gvcmVzb3VyY2VzL3N0eWxl
LWJlbmNoLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1hbmNlVGVzdHMvU3R5bGVCZW5jaC9yZXNv
dXJjZXMvc3R5bGUtYmVuY2guanMJKHJldmlzaW9uIDIyNzcxNykKKysrIFBlcmZvcm1hbmNlVGVz
dHMvU3R5bGVCZW5jaC9yZXNvdXJjZXMvc3R5bGUtYmVuY2guanMJKHdvcmtpbmcgY29weSkKQEAg
LTEwMiw3ICsxMDIsNyBAQCBjbGFzcyBTdHlsZUJlbmNoCiAgICAgc3RhdGljIG50aFBzZXVkb0Ns
YXNzQ29uZmlndXJhdGlvbigpCiAgICAgewogICAgICAgICByZXR1cm4gT2JqZWN0LmFzc2lnbih0
aGlzLmRlZmF1bHRDb25maWd1cmF0aW9uKCksIHsKLSAgICAgICAgICAgIG5hbWU6ICc6bnRoIHBz
ZXVkbyBjbGFzc2VzJywKKyAgICAgICAgICAgIG5hbWU6ICdOdGggcHNldWRvIGNsYXNzZXMnLAog
ICAgICAgICAgICAgcHNldWRvQ2xhc3NDaGFuY2U6IDAuMSwKICAgICAgICAgICAgIHBzZXVkb0Ns
YXNzZXM6IFsKICAgICAgICAgICAgICAgICAnbnRoLWNoaWxkKDJuKzEpJywK
</data>

          </attachment>
      

    </bug>

</bugzilla>