182255 2018-01-29 11:33:59 -0800 webkitpy: Warn user when too many simulators are requested 2018-01-29 13:16:55 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=181702 P2 Normal --- 1 jbedard jbedard aakash_jain ap dbates dean_johnson ews-watchlist glenn lforschler oldest_to_newest 1394185 0 jbedard 2018-01-29 11:33:59 -0800 Some contributors are of the opinion that we should warn users when too many iOS Simulators are requested since this can cause some non-intuitive problems. 1394187 1 332562 jbedard 2018-01-29 11:36:30 -0800 Created attachment 332562 Patch 1394188 2 jbedard 2018-01-29 11:38:58 -0800 I don't feel very strongly either way about this change, but I told Dean that I would upload one for further discussion. Note that this logging will only occur when the user requests the simulators. Unlike previously, this logging is not associated with the port class but is instead directly tied to the booting of simulators. 332562 2018-01-29 11:36:30 -0800 2018-01-29 13:16:55 -0800 Patch bug-182255-20180129113630.patch text/plain 1744 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyNzc0NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE4LTAxLTI5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgy MjU1CisgICAgICAgIE5lZWQgdGhlIGJ1ZyBVUkwgKE9PUFMhKS4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiB0aGUgdXNlciByZXF1ZXN0cyBtb3Jl IHNpbXVsYXRvcnMgdGhhbiB0aGUgc3lzdGVtIHN1cHBvcnRzLCB3YXJuIHRoZSB1c2VyCisgICAg ICAgIGJlY2F1c2Ugc3VjaCBhIGNvbmZpZ3VyYXRpb24gY2FuIGNhdXNlIGxlc3MgdGhhbiBpbnR1 aXRpdmUgZXJyb3JzLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0 ZWRfZGV2aWNlLnB5OgorICAgICAgICAoU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5pbml0aWFsaXpl X2RldmljZXMpOiBMb2cgd2FybmluZyB3aGVuIHRvbyBtYW55CisgICAgICAgIHNpbXVsYXRvcnMg YXJlIHJlcXVlc3RlZC4KKwogMjAxOC0wMS0yOSAgTWF0dCBMZXdpcyAgPGpsZXdpczNAYXBwbGUu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMjc3MzEuCkluZGV4OiBU b29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHkKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5CShy ZXZpc2lvbiAyMjc3NDIpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRl ZF9kZXZpY2UucHkJKHdvcmtpbmcgY29weSkKQEAgLTMyNyw2ICszMjcsMTAgQEAgY2xhc3MgU2lt dWxhdGVkRGV2aWNlTWFuYWdlcihvYmplY3QpOgogICAgICAgICBpZiBub3QgaGFzYXR0cihyZXF1 ZXN0cywgJ19faXRlcl9fJyk6CiAgICAgICAgICAgICByZXF1ZXN0cyA9IFtyZXF1ZXN0c10KIAor ICAgICAgICBpZiBsZW4ocmVxdWVzdHMpID4gU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5tYXhfc3Vw cG9ydGVkX3NpbXVsYXRvcnMoaG9zdCk6CisgICAgICAgICAgICBfbG9nLndhcm4oJ1RoZSBzcGVj aWZpZWQgbnVtYmVyIG9mIFNpbXVsYXRlZCBkZXZpY2VzIHRvIGJlIHVzZWQgaXMgZ3JlYXRlciB0 aGFuIHRoZSBudW1iZXIgc3VwcG9ydGVkIGJ5IHRoaXMgbWFjaGluZS4nKQorICAgICAgICAgICAg X2xvZy53YXJuKCdBbG9uZyB3aXRoIHNsdWdnaXNobmVzcywgdGhpcyBtYXkgY2F1c2UgbGF5b3V0 IHRlc3RzIHRvIGZhaWwgb3IgZXZlbiBkYXRhLWxvc3MgaW4gb3RoZXIgcnVubmluZyBhcHBsaWNh dGlvbnMnKQorCiAgICAgICAgICMgQ2hlY2sgcnVubmluZyBzaW1zCiAgICAgICAgIGZvciBkZXZp Y2UgaW4gU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5hdmFpbGFibGVfZGV2aWNlcyhob3N0KToKICAg ICAgICAgICAgIG1hdGNoZWRfcmVxdWVzdCA9IFNpbXVsYXRlZERldmljZU1hbmFnZXIuX2RvZXNf ZnVsZmlsbF9yZXF1ZXN0KGRldmljZSwgcmVxdWVzdHMpCg==