182242 2018-01-29 08:28:15 -0800 WebDriver: properly recover w3c tests after a webdriver server crash 2018-01-29 08:47:20 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg clopez ews-watchlist glenn webkit-bug-importer oldest_to_newest 1394085 0 cgarcia 2018-01-29 08:28:15 -0800 When a test makes the webdriver server crash, all other subsequent tests fail because they still try to send messages to the server, gettin connection refused errors all the time. Selenium tests handle this correctly by relaunching the server after every test failure, because other failures even when not crashing the server might leve it in an bad state. WPT runner does the same for test files, it uses a subprocess to run the tests and when any subtest fails, a new subsprocess is used for the following test file. We could do the same. 1394090 1 332544 cgarcia 2018-01-29 08:34:13 -0800 Created attachment 332544 Patch 1394091 2 ews-watchlist 2018-01-29 08:35:31 -0800 Attachment 332544 did not pass style-queue: ERROR: Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:149: [WebDriverW3CExecutor.setup] Instance of 'WebDriverW3CExecutor' has no 'protocol' member [pylint/E1101] [5] ERROR: Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:150: [WebDriverW3CExecutor.setup] Instance of 'WebDriverW3CExecutor' has no 'protocol' member [pylint/E1101] [5] ERROR: Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:151: [WebDriverW3CExecutor.setup] Instance of 'WebDriverW3CExecutor' has no 'protocol' member [pylint/E1101] [5] ERROR: Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:152: [WebDriverW3CExecutor.setup] Instance of 'WebDriverW3CExecutor' has no 'server_config' member [pylint/E1101] [5] Total errors found: 4 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1394098 3 cgarcia 2018-01-29 08:46:03 -0800 Committed r227732: <https://trac.webkit.org/changeset/227732> 1394102 4 webkit-bug-importer 2018-01-29 08:47:20 -0800 <rdar://problem/36988099> 332544 2018-01-29 08:34:13 -0800 2018-01-29 08:42:36 -0800 Patch wd-server-crash.diff text/plain 7166 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhMmU1 NWRkOWU5Ny4uZmRjODhkOWMwZDIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAxOC0wMS0yOSAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgV2ViRHJpdmVyOiBwcm9w ZXJseSByZWNvdmVyIHczYyB0ZXN0cyBhZnRlciBhIHdlYmRyaXZlciBzZXJ2ZXIgY3Jhc2gKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjI0MgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gYSB0ZXN0 IG1ha2VzIHRoZSB3ZWJkcml2ZXIgc2VydmVyIGNyYXNoLCBhbGwgb3RoZXIgc3Vic2VxdWVudCB0 ZXN0cyBmYWlsIGJlY2F1c2UgdGhleSBzdGlsbCB0cnkgdG8gc2VuZAorICAgICAgICBtZXNzYWdl cyB0byB0aGUgc2VydmVyLCBnZXR0aW4gY29ubmVjdGlvbiByZWZ1c2VkIGVycm9ycyBhbGwgdGhl IHRpbWUuIFNlbGVuaXVtIHRlc3RzIGhhbmRsZSB0aGlzIGNvcnJlY3RseSBieQorICAgICAgICBy ZWxhdW5jaGluZyB0aGUgc2VydmVyIGFmdGVyIGV2ZXJ5IHRlc3QgZmFpbHVyZSwgYmVjYXVzZSBv dGhlciBmYWlsdXJlcywgZXZlbiB3aGVuIG5vdCBjcmFzaGluZyB0aGUgc2VydmVyLAorICAgICAg ICBtaWdodCBsZWF2ZSBpdCBpbiBhbiBiYWQgc3RhdGUuIFdQVCBydW5uZXIgZG9lcyB0aGUgc2Ft ZSBmb3IgdGVzdCBmaWxlcywgaXQgdXNlcyBhIHN1YnByb2Nlc3MgdG8gcnVuIHRoZSB0ZXN0cwor ICAgICAgICBhbmQgd2hlbiBhbnkgc3VidGVzdCBmYWlscywgYSBuZXcgc3Vic3Byb2Nlc3MgaXMg dXNlZCBmb3IgdGhlIGZvbGxvd2luZyB0ZXN0IGZpbGUuIFdlIGNvdWxkIGRvIHRoZSBzYW1lLgor CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS93ZWJkcml2ZXJfdGVzdHMvd2ViZHJpdmVyX3Rl c3RfcnVubmVyX3czYy5weToKKyAgICAgICAgKFdlYkRyaXZlclRlc3RSdW5uZXJXM0MucnVuKTog UmVzdGFydCB0aGUgZXhlY3V0b3IgaWYgYW55IHN1YnRlc3QgZmFpbGVkLgorICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvd2ViZHJpdmVyX3Rlc3RzL3dlYmRyaXZlcl93M2NfZXhlY3V0b3IucHk6 CisgICAgICAgIChXZWJEcml2ZXJXM0NFeGVjdXRvci5fX2luaXRfXyk6IFNhdmUgdGltZW91dCBh bmQgZXhwZWN0YXRpb25zIGFuZCBkbyBub3QgaW1wb3J0IHB5dGVzdC4KKyAgICAgICAgKFdlYkRy aXZlclczQ0V4ZWN1dG9yLnNldHVwKTogQ3JlYXRlIGEgc3VicHJvY2VzcyB0byBydW4gdGhlIHRl c3RzLgorICAgICAgICAoV2ViRHJpdmVyVzNDRXhlY3V0b3IudGVhcmRvd24pOiBTZW5kIGEgbWVz c2FnZSB0byB0aGUgc3VicHJvY2VzcyB0byB0ZXJtaW5hdGUuCisgICAgICAgIChXZWJEcml2ZXJX M0NFeGVjdXRvci5fcnVubmVyKTogUnVuIHRoZSB0ZXN0cyB1c2luZyBweXRlc3QgcnVubmVyLgor ICAgICAgICAoV2ViRHJpdmVyVzNDRXhlY3V0b3IucnVuKTogU2VuZCBhIG1lc3NhZ2UgdG8gdGhl IHN1YnByb2Nlc3MgdG8gcnVuIHRoZSBnaXZlbiB0ZXN0IGFuZCByZXR1cm4gdGhlIHJlc3VsdHMg bWVzc2FnZS4KKwogMjAxOC0wMS0yNyAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgog CiAgICAgICAgIEhhdmVJbnRlcm5hbFNESyBpbmNsdWRlcyBzaG91bGQgYmUgIiNpbmNsdWRlPyIK ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvd2ViZHJpdmVyX3Rlc3RzL3dlYmRy aXZlcl90ZXN0X3J1bm5lcl93M2MucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3dlYmRyaXZl cl90ZXN0cy93ZWJkcml2ZXJfdGVzdF9ydW5uZXJfdzNjLnB5CmluZGV4IGNkNzUxNTVjYTA2Li4x OGQ3Yzc3ZTZhZSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS93ZWJkcml2ZXJf dGVzdHMvd2ViZHJpdmVyX3Rlc3RfcnVubmVyX3czYy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3dlYmRyaXZlcl90ZXN0cy93ZWJkcml2ZXJfdGVzdF9ydW5uZXJfdzNjLnB5CkBAIC04 NiwyMSArODYsMjUgQEAgY2xhc3MgV2ViRHJpdmVyVGVzdFJ1bm5lclczQyhvYmplY3QpOgogICAg IGRlZiBydW4oc2VsZiwgdGVzdHM9W10pOgogICAgICAgICBzZWxmLl9zZXJ2ZXIuc3RhcnQoKQog Ci0gICAgICAgIGV4ZWN1dG9yID0gV2ViRHJpdmVyVzNDRXhlY3V0b3Ioc2VsZi5fZHJpdmVyLCBz ZWxmLl9zZXJ2ZXIsIHNlbGYuX2Rpc3BsYXlfZHJpdmVyKQorICAgICAgICBleGVjdXRvciA9IFdl YkRyaXZlclczQ0V4ZWN1dG9yKHNlbGYuX2RyaXZlciwgc2VsZi5fc2VydmVyLCBzZWxmLl9kaXNw bGF5X2RyaXZlciwgc2VsZi5fcG9ydC5nZXRfb3B0aW9uKCd0aW1lb3V0JyksIHNlbGYuX2V4cGVj dGF0aW9ucykKICAgICAgICAgZXhlY3V0b3Iuc2V0dXAoKQotICAgICAgICB0aW1lb3V0ID0gc2Vs Zi5fcG9ydC5nZXRfb3B0aW9uKCd0aW1lb3V0JykKKyAgICAgICAgbmVlZF9yZXN0YXJ0ID0gRmFs c2UKICAgICAgICAgdHJ5OgogICAgICAgICAgICAgZm9yIHRlc3QgaW4gdGVzdHM6CiAgICAgICAg ICAgICAgICAgdGVzdF9uYW1lID0gb3MucGF0aC5yZWxwYXRoKHRlc3QsIHNlbGYuX3Rlc3RzX2Rp cikKLSAgICAgICAgICAgICAgICBoYXJuZXNzX3Jlc3VsdCwgdGVzdF9yZXN1bHRzID0gZXhlY3V0 b3IucnVuKHRlc3QsIHRpbWVvdXQsIHNlbGYuX2V4cGVjdGF0aW9ucykKKyAgICAgICAgICAgICAg ICBoYXJuZXNzX3Jlc3VsdCwgdGVzdF9yZXN1bHRzID0gZXhlY3V0b3IucnVuKHRlc3QpCiAgICAg ICAgICAgICAgICAgcmVzdWx0ID0gV2ViRHJpdmVyVGVzdFJlc3VsdCh0ZXN0X25hbWUsICpoYXJu ZXNzX3Jlc3VsdCkKICAgICAgICAgICAgICAgICBpZiBoYXJuZXNzX3Jlc3VsdFswXSA9PSAnT0sn OgogICAgICAgICAgICAgICAgICAgICBmb3Igc3VidGVzdCwgc3RhdHVzLCBtZXNzYWdlLCBiYWNr dHJhY2UgaW4gdGVzdF9yZXN1bHRzOgogICAgICAgICAgICAgICAgICAgICAgICAgcmVzdWx0LmFk ZF9zdWJ0ZXN0X3Jlc3VsdHMoc2VsZi5fc3VidGVzdF9uYW1lKHN1YnRlc3QpLCBzdGF0dXMsIG1l c3NhZ2UsIGJhY2t0cmFjZSkKKyAgICAgICAgICAgICAgICAgICAgICAgIG5lZWRfcmVzdGFydCA9 IG5lZWRfcmVzdGFydCBvciBzdGF0dXMgaW4gKCdGQUlMJywgJ0VSUk9SJywgJ1hGQUlMJywgJ1RJ TUVPVVQnKQogICAgICAgICAgICAgICAgIGVsc2U6Ci0gICAgICAgICAgICAgICAgICAgICMgRklY TUU6IGhhbmRsZSBvdGhlciByZXN1bHRzLgotICAgICAgICAgICAgICAgICAgICBwYXNzCisgICAg ICAgICAgICAgICAgICAgIG5lZWRfcmVzdGFydCA9IFRydWUKICAgICAgICAgICAgICAgICBzZWxm Ll9yZXN1bHRzLmFwcGVuZChyZXN1bHQpCisKKyAgICAgICAgICAgICAgICBpZiBuZWVkX3Jlc3Rh cnQ6CisgICAgICAgICAgICAgICAgICAgIGV4ZWN1dG9yLnRlYXJkb3duKCkKKyAgICAgICAgICAg ICAgICAgICAgZXhlY3V0b3Iuc2V0dXAoKQogICAgICAgICBmaW5hbGx5OgogICAgICAgICAgICAg ZXhlY3V0b3IudGVhcmRvd24oKQogICAgICAgICAgICAgc2VsZi5fc2VydmVyLnN0b3AoKQpkaWZm IC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS93ZWJkcml2ZXJfdGVzdHMvd2ViZHJpdmVy X3czY19leGVjdXRvci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvd2ViZHJpdmVyX3Rlc3Rz L3dlYmRyaXZlcl93M2NfZXhlY3V0b3IucHkKaW5kZXggNmZhY2QyYTA4MmUuLmRhNTM5NjZhYjRi IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3dlYmRyaXZlcl90ZXN0cy93ZWJk cml2ZXJfdzNjX2V4ZWN1dG9yLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvd2ViZHJp dmVyX3Rlc3RzL3dlYmRyaXZlcl93M2NfZXhlY3V0b3IucHkKQEAgLTI1LDYgKzI1LDcgQEAgaW1w b3J0IG9zCiBpbXBvcnQganNvbgogaW1wb3J0IHN5cwogCitmcm9tIG11bHRpcHJvY2Vzc2luZyBp bXBvcnQgUHJvY2VzcywgUXVldWUKIGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5maWxlc3lz dGVtIGltcG9ydCBGaWxlU3lzdGVtCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi53ZWJraXRfZmluZGVy IGltcG9ydCBXZWJLaXRGaW5kZXIKIGltcG9ydCB3ZWJraXRweS50aGlyZHBhcnR5LmF1dG9pbnN0 YWxsZWQubW96bG9nCkBAIC0xMjksMjcgKzEzMCw1NCBAQCBjbGFzcyBXZWJLaXREcml2ZXJQcm90 b2NvbChXZWJEcml2ZXJQcm90b2NvbCk6CiBjbGFzcyBXZWJEcml2ZXJXM0NFeGVjdXRvcihXZHNw ZWNFeGVjdXRvcik6CiAgICAgcHJvdG9jb2xfY2xzID0gV2ViS2l0RHJpdmVyUHJvdG9jb2wKIAot ICAgIGRlZiBfX2luaXRfXyhzZWxmLCBkcml2ZXIsIHNlcnZlciwgZGlzcGxheV9kcml2ZXIpOgor ICAgIGRlZiBfX2luaXRfXyhzZWxmLCBkcml2ZXIsIHNlcnZlciwgZGlzcGxheV9kcml2ZXIsIHRp bWVvdXQsIGV4cGVjdGF0aW9ucyk6CiAgICAgICAgIFdlYktpdERyaXZlclNlcnZlci50ZXN0X2Vu diA9IGRpc3BsYXlfZHJpdmVyLl9zZXR1cF9lbnZpcm9uX2Zvcl90ZXN0KCkKICAgICAgICAgV2Vi S2l0RHJpdmVyU2VydmVyLnRlc3RfZW52LnVwZGF0ZShkcml2ZXIuYnJvd3Nlcl9lbnYoKSkKICAg ICAgICAgc2VydmVyX2NvbmZpZyA9IHsnaG9zdCc6IHNlcnZlci5ob3N0KCksICdwb3J0cyc6IHsn aHR0cCc6IFtzdHIoc2VydmVyLnBvcnQoKSldfX0KICAgICAgICAgV2RzcGVjRXhlY3V0b3IuX19p bml0X18oc2VsZiwgZHJpdmVyLmJyb3dzZXJfbmFtZSgpLCBzZXJ2ZXJfY29uZmlnLCBkcml2ZXIu YmluYXJ5X3BhdGgoKSwgTm9uZSwgY2FwYWJpbGl0aWVzPWRyaXZlci5jYXBhYmlsaXRpZXMoKSkK IAotICAgICAgICBpZiBweXRlc3RfcnVubmVyIGlzIE5vbmU6Ci0gICAgICAgICAgICBkb19kZWxh eWVkX2ltcG9ydHMoKQorICAgICAgICBzZWxmLl90aW1lb3V0ID0gdGltZW91dAorICAgICAgICBz ZWxmLl9leHBlY3RhdGlvbnMgPSBleHBlY3RhdGlvbnMKKyAgICAgICAgc2VsZi5fdGVzdF9xdWV1 ZSA9IFF1ZXVlKCkKKyAgICAgICAgc2VsZi5fcmVzdWx0X3F1ZXVlID0gUXVldWUoKQogCiAgICAg ZGVmIHNldHVwKHNlbGYpOgogICAgICAgICBzZWxmLnJ1bm5lciA9IFRlc3RSdW5uZXIoKQogICAg ICAgICBzZWxmLnByb3RvY29sLnNldHVwKHNlbGYucnVubmVyKQorICAgICAgICBhcmdzID0gKHNl bGYuX3Rlc3RfcXVldWUsCisgICAgICAgICAgICAgICAgc2VsZi5fcmVzdWx0X3F1ZXVlLAorICAg ICAgICAgICAgICAgIHNlbGYucHJvdG9jb2wuc2Vzc2lvbl9jb25maWdbJ2hvc3QnXSwKKyAgICAg ICAgICAgICAgICBzdHIoc2VsZi5wcm90b2NvbC5zZXNzaW9uX2NvbmZpZ1sncG9ydCddKSwKKyAg ICAgICAgICAgICAgICBqc29uLmR1bXBzKHNlbGYucHJvdG9jb2wuc2Vzc2lvbl9jb25maWdbJ2Nh cGFiaWxpdGllcyddKSwKKyAgICAgICAgICAgICAgICBqc29uLmR1bXBzKHNlbGYuc2VydmVyX2Nv bmZpZyksCisgICAgICAgICAgICAgICAgc2VsZi5fdGltZW91dCwKKyAgICAgICAgICAgICAgICBz ZWxmLl9leHBlY3RhdGlvbnMpCisgICAgICAgIHNlbGYuX3Byb2Nlc3MgPSBQcm9jZXNzKHRhcmdl dD1XZWJEcml2ZXJXM0NFeGVjdXRvci5fcnVubmVyLCBhcmdzPWFyZ3MpCisgICAgICAgIHNlbGYu X3Byb2Nlc3Muc3RhcnQoKQogCiAgICAgZGVmIHRlYXJkb3duKHNlbGYpOgogICAgICAgICBzZWxm LnByb3RvY29sLnRlYXJkb3duKCkKKyAgICAgICAgc2VsZi5fdGVzdF9xdWV1ZS5wdXQoJ1RFQVJE T1dOJykKKyAgICAgICAgc2VsZi5fcHJvY2VzcyA9IE5vbmUKKworICAgIEBzdGF0aWNtZXRob2QK KyAgICBkZWYgX3J1bm5lcih0ZXN0X3F1ZXVlLCByZXN1bHRfcXVldWUsIGhvc3QsIHBvcnQsIGNh cGFiaWxpdGllcywgc2VydmVyX2NvbmZpZywgdGltZW91dCwgZXhwZWN0YXRpb25zKToKKyAgICAg ICAgaWYgcHl0ZXN0X3J1bm5lciBpcyBOb25lOgorICAgICAgICAgICAgZG9fZGVsYXllZF9pbXBv cnRzKCkKIAotICAgIGRlZiBydW4oc2VsZiwgdGVzdCwgdGltZW91dCwgZXhwZWN0YXRpb25zKToK LSAgICAgICAgZW52ID0geydXRF9IT1NUJzogc2VsZi5wcm90b2NvbC5zZXNzaW9uX2NvbmZpZ1sn aG9zdCddLAotICAgICAgICAgICAgICAgJ1dEX1BPUlQnOiBzdHIoc2VsZi5wcm90b2NvbC5zZXNz aW9uX2NvbmZpZ1sncG9ydCddKSwKLSAgICAgICAgICAgICAgICdXRF9DQVBBQklMSVRJRVMnOiBq c29uLmR1bXBzKHNlbGYucHJvdG9jb2wuc2Vzc2lvbl9jb25maWdbJ2NhcGFiaWxpdGllcyddKSwK LSAgICAgICAgICAgICAgICdXRF9TRVJWRVJfQ09ORklHJzoganNvbi5kdW1wcyhzZWxmLnNlcnZl cl9jb25maWcpfQotICAgICAgICBlbnYudXBkYXRlKFdlYktpdERyaXZlclNlcnZlci50ZXN0X2Vu dikKLSAgICAgICAgYXJncyA9IFsnLS1zdHJpY3QnLCAnLXAnLCAnbm86bW96bG9nJ10KLSAgICAg ICAgcmV0dXJuIHB5dGVzdF9ydW5uZXIucnVuKHRlc3QsIGFyZ3MsIHRpbWVvdXQsIGVudiwgZXhw ZWN0YXRpb25zKQorICAgICAgICB3aGlsZSBUcnVlOgorICAgICAgICAgICAgdGVzdCA9IHRlc3Rf cXVldWUuZ2V0KCkKKyAgICAgICAgICAgIGlmIHRlc3QgPT0gJ1RFQVJET1dOJzoKKyAgICAgICAg ICAgICAgICBicmVhaworCisgICAgICAgICAgICBlbnYgPSB7J1dEX0hPU1QnOiBob3N0LAorICAg ICAgICAgICAgICAgICAgICdXRF9QT1JUJzogcG9ydCwKKyAgICAgICAgICAgICAgICAgICAnV0Rf Q0FQQUJJTElUSUVTJzogY2FwYWJpbGl0aWVzLAorICAgICAgICAgICAgICAgICAgICdXRF9TRVJW RVJfQ09ORklHJzogc2VydmVyX2NvbmZpZ30KKyAgICAgICAgICAgIGVudi51cGRhdGUoV2ViS2l0 RHJpdmVyU2VydmVyLnRlc3RfZW52KQorICAgICAgICAgICAgYXJncyA9IFsnLS1zdHJpY3QnLCAn LXAnLCAnbm86bW96bG9nJ10KKyAgICAgICAgICAgIHJlc3VsdF9xdWV1ZS5wdXQocHl0ZXN0X3J1 bm5lci5ydW4odGVzdCwgYXJncywgdGltZW91dCwgZW52LCBleHBlY3RhdGlvbnMpKQorCisgICAg ZGVmIHJ1bihzZWxmLCB0ZXN0KToKKyAgICAgICAgc2VsZi5fdGVzdF9xdWV1ZS5wdXQodGVzdCkK KyAgICAgICAgcmV0dXJuIHNlbGYuX3Jlc3VsdF9xdWV1ZS5nZXQoKQo=