182210 2018-01-26 22:05:30 -0800 REGRESSION(r225898): The perf dashboard fails to open when there are no summary pages 2018-01-29 12:37:00 -0800 1 1 1 Unclassified WebKit Perf Dashboard WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa ap cdumez dewei_zhu koivisto rniwa webkit-bug-importer oldest_to_newest 1393811 0 rniwa 2018-01-26 22:05:30 -0800 The perf dashboard fails to load/open when there are no summary pages specified in config.json. 1393812 1 332458 rniwa 2018-01-26 22:08:40 -0800 Created attachment 332458 Fixes the bug 1394200 2 332458 cdumez 2018-01-29 11:57:43 -0800 Comment on attachment 332458 Fixes the bug rs=me 1394217 3 rniwa 2018-01-29 12:35:13 -0800 Committed r227749: <https://trac.webkit.org/changeset/227749> 1394218 4 webkit-bug-importer 2018-01-29 12:37:00 -0800 <rdar://problem/36997299> 332458 2018-01-26 22:08:40 -0800 2018-01-29 11:57:43 -0800 Fixes the bug bug-182210-20180126220839.patch text/plain 4954 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3NzEwCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCA3MzEyMTc3Mzg5YTgyNzA3Njc1ZWEyMTU5NmQ0MTFlNWM0YWIwMWY4Li5hNjEzMTI2Y2Q2 NDRhYjFiNTUzMWI3ZGU4ZDQ1YmI2YzI5NzMzZTIwIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxOC0wMS0yNiAgUnlvc3VrZSBOaXdhICA8cm5pd2FA d2Via2l0Lm9yZz4KKworICAgICAgICBSRUdSRVNTSU9OKHIyMjU4OTgpOiBUaGUgcGVyZiBkYXNo Ym9hcmQgZmFpbHMgdG8gb3BlbiB3aGVuIHRoZXJlIGFyZSBubyBzdW1tYXJ5IHBhZ2VzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODIyMTAKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgYnVnIHdhcyBj YXVzZWQgYnkgVGVzdEZyZXNobmVzc1BhZ2UgdW5jb25kaXRpb25hbGx5IGFzc3VtaW5nIHRoYXQg c3VtbWFyeVBhZ2VDb25maWd1cmF0aW9uIGlzIHNldC4KKyAgICAgICAgRml4ZWQgaXQgYnkgbm90 IGNyZWF0aW5nIFRlc3RGcmVzaG5lc3NQYWdlIHdoZW4gdGhlcmUgYXJlIG5vIHN1bW1hcnkgcGFn ZXMgc3BlY2lmaWVkLgorCisgICAgICAgIEFsc28gbW9kZXJuaXplZCB0aGUgY29kZSB0byB1c2Ug Y29uc3QgJiBsZXQgaW5zdGVhZCBvZiB2YXIuCisKKyAgICAgICAgKiBwdWJsaWMvdjMvbWFpbi5q czoKKyAgICAgICAgKG1haW4pOgorCiAyMDE4LTAxLTI2ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3 ZWJraXQub3JnPgogCiAgICAgICAgIFBlcmYgZGFzaGJvYXJkJ3MgcGFnZSB0aXRsZSBjYW4gYmUg c2V0IHRvIGEgcHJldmlvdXNseSB2aXNpdGVkIHBhZ2UKZGlmZiAtLWdpdCBhL1dlYnNpdGVzL3Bl cmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvbWFpbi5qcyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9y Zy9wdWJsaWMvdjMvbWFpbi5qcwppbmRleCBhNTQ1ZDdhYzgwY2FjNjVmOTc2NzlkNzE1M2ZmYzM3 MWVmYTJhNzEyLi4wZWJjMmYwMWM3YmM0ZTY4M2U5Njg2OWI1ZjEyZTZjZGMyZjgwYWUzIDEwMDY0 NAotLS0gYS9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YzL21haW4uanMKKysrIGIv V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92My9tYWluLmpzCkBAIC0xMSw3ICsxMSw3 IEBAIGZ1bmN0aW9uIG1haW4oKSB7CiAgICAgICAgICdTaGFkb3cgRE9NIEFQSSc6ICgpID0+IHsg cmV0dXJuICEhRWxlbWVudC5wcm90b3R5cGUuYXR0YWNoU2hhZG93OyB9LAogICAgIH07CiAKLSAg ICBmb3IgKGxldCBuYW1lIGluIHJlcXVpcmVkRmVhdHVyZXMpIHsKKyAgICBmb3IgKGNvbnN0IG5h bWUgaW4gcmVxdWlyZWRGZWF0dXJlcykgewogICAgICAgICBpZiAoIXJlcXVpcmVkRmVhdHVyZXNb bmFtZV0oKSkKICAgICAgICAgICAgIHJldHVybiBhbGVydChgWW91ciBicm93c2VyIGRvZXMgbm90 IHN1cHBvcnQgJHtuYW1lfS4gVHJ5IHVzaW5nIHRoZSBsYXRlc3QgU2FmYXJpIG9yIENocm9tZS5g KTsKICAgICB9CkBAIC0xOSw1MiArMTksNTIgQEAgZnVuY3Rpb24gbWFpbigpIHsKICAgICAobmV3 IFNwaW5uaW5nUGFnZSkub3BlbigpOwogCiAgICAgTWFuaWZlc3QuZmV0Y2goKS50aGVuKGZ1bmN0 aW9uIChtYW5pZmVzdCkgewotICAgICAgICB2YXIgZGFzaGJvYXJkVG9vbGJhciA9IG5ldyBEYXNo Ym9hcmRUb29sYmFyOwotICAgICAgICB2YXIgZGFzaGJvYXJkUGFnZXMgPSBbXTsKKyAgICAgICAg Y29uc3QgZGFzaGJvYXJkVG9vbGJhciA9IG5ldyBEYXNoYm9hcmRUb29sYmFyOworICAgICAgICBj b25zdCBkYXNoYm9hcmRQYWdlcyA9IFtdOwogICAgICAgICBpZiAobWFuaWZlc3QuZGFzaGJvYXJk cykgewotICAgICAgICAgICAgZm9yICh2YXIgbmFtZSBpbiBtYW5pZmVzdC5kYXNoYm9hcmRzKQor ICAgICAgICAgICAgZm9yIChjb25zdCBuYW1lIGluIG1hbmlmZXN0LmRhc2hib2FyZHMpCiAgICAg ICAgICAgICAgICAgZGFzaGJvYXJkUGFnZXMucHVzaChuZXcgRGFzaGJvYXJkUGFnZShuYW1lLCBt YW5pZmVzdC5kYXNoYm9hcmRzW25hbWVdLCBkYXNoYm9hcmRUb29sYmFyKSk7CiAgICAgICAgIH0K IAotICAgICAgICB2YXIgcm91dGVyID0gbmV3IFBhZ2VSb3V0ZXIoKTsKLSAgICAgICAgdmFyIGNo YXJ0c1Rvb2xiYXIgPSBuZXcgQ2hhcnRzVG9vbGJhcjsKLQotICAgICAgICB2YXIgc3VtbWFyeVBh Z2VzID0gW107CisgICAgICAgIGNvbnN0IHN1bW1hcnlQYWdlcyA9IFtdOworICAgICAgICBsZXQg dGVzdEZyZXNobmVzc1BhZ2UgPSBudWxsOwogICAgICAgICBpZiAobWFuaWZlc3Quc3VtbWFyeVBh Z2VzKSB7Ci0gICAgICAgICAgICBmb3IgKHZhciBzdW1tYXJ5UGFnZSBvZiBtYW5pZmVzdC5zdW1t YXJ5UGFnZXMpCisgICAgICAgICAgICBmb3IgKGNvbnN0IHN1bW1hcnlQYWdlIG9mIG1hbmlmZXN0 LnN1bW1hcnlQYWdlcykKICAgICAgICAgICAgICAgICBzdW1tYXJ5UGFnZXMucHVzaChuZXcgU3Vt bWFyeVBhZ2Uoc3VtbWFyeVBhZ2UpKTsKKyAgICAgICAgICAgIHRlc3RGcmVzaG5lc3NQYWdlID0g bmV3IFRlc3RGcmVzaG5lc3NQYWdlKG1hbmlmZXN0LnN1bW1hcnlQYWdlcywgbWFuaWZlc3QudGVz dEFnZVRvbGVyYW5jZUluSG91cnMpOwogICAgICAgICB9CiAKLSAgICAgICAgdmFyIGNoYXJ0c1Bh Z2UgPSBuZXcgQ2hhcnRzUGFnZShjaGFydHNUb29sYmFyKTsKLSAgICAgICAgdmFyIGFuYWx5c2lz Q2F0ZWdvcnlQYWdlID0gbmV3IEFuYWx5c2lzQ2F0ZWdvcnlQYWdlKCk7CisgICAgICAgIGNvbnN0 IGNoYXJ0c1Rvb2xiYXIgPSBuZXcgQ2hhcnRzVG9vbGJhcjsKKyAgICAgICAgY29uc3QgY2hhcnRz UGFnZSA9IG5ldyBDaGFydHNQYWdlKGNoYXJ0c1Rvb2xiYXIpOworICAgICAgICBjb25zdCBhbmFs eXNpc0NhdGVnb3J5UGFnZSA9IG5ldyBBbmFseXNpc0NhdGVnb3J5UGFnZSgpOworCisgICAgICAg IHN1bW1hcnlQYWdlcy5wdXNoKGNoYXJ0c1BhZ2UpOworICAgICAgICBzdW1tYXJ5UGFnZXMucHVz aChhbmFseXNpc0NhdGVnb3J5UGFnZSk7CisgICAgICAgIGlmICh0ZXN0RnJlc2huZXNzUGFnZSkK KyAgICAgICAgICAgIHN1bW1hcnlQYWdlcy5wdXNoKHRlc3RGcmVzaG5lc3NQYWdlKTsKIAotICAg ICAgICB2YXIgY3JlYXRlQW5hbHlzaXNUYXNrUGFnZSA9IG5ldyBDcmVhdGVBbmFseXNpc1Rhc2tQ YWdlKCk7CisgICAgICAgIGNvbnN0IGNyZWF0ZUFuYWx5c2lzVGFza1BhZ2UgPSBuZXcgQ3JlYXRl QW5hbHlzaXNUYXNrUGFnZSgpOwogICAgICAgICBjcmVhdGVBbmFseXNpc1Rhc2tQYWdlLnNldFBh cmVudFBhZ2UoYW5hbHlzaXNDYXRlZ29yeVBhZ2UpOwogCi0gICAgICAgIHZhciBhbmFseXNpc1Rh c2tQYWdlID0gbmV3IEFuYWx5c2lzVGFza1BhZ2UoKTsKKyAgICAgICAgY29uc3QgYW5hbHlzaXNU YXNrUGFnZSA9IG5ldyBBbmFseXNpc1Rhc2tQYWdlKCk7CiAgICAgICAgIGFuYWx5c2lzVGFza1Bh Z2Uuc2V0UGFyZW50UGFnZShhbmFseXNpc0NhdGVnb3J5UGFnZSk7CiAKLSAgICAgICAgdmFyIGJ1 aWxkUmVxdWVzdFF1ZXVlUGFnZSA9IG5ldyBCdWlsZFJlcXVlc3RRdWV1ZVBhZ2UoKTsKKyAgICAg ICAgY29uc3QgYnVpbGRSZXF1ZXN0UXVldWVQYWdlID0gbmV3IEJ1aWxkUmVxdWVzdFF1ZXVlUGFn ZSgpOwogICAgICAgICBidWlsZFJlcXVlc3RRdWV1ZVBhZ2Uuc2V0UGFyZW50UGFnZShhbmFseXNp c0NhdGVnb3J5UGFnZSk7CiAKLSAgICAgICAgY29uc3QgdGVzdEhlYWx0aFBhZ2UgPSBuZXcgVGVz dEZyZXNobmVzc1BhZ2UobWFuaWZlc3Quc3VtbWFyeVBhZ2VzLCBtYW5pZmVzdC50ZXN0QWdlVG9s ZXJhbmNlSW5Ib3Vycyk7Ci0KLSAgICAgICAgdmFyIGhlYWRpbmcgPSBuZXcgSGVhZGluZyhtYW5p ZmVzdC5zaXRlVGl0bGUpOwotICAgICAgICBoZWFkaW5nLmFkZFBhZ2VHcm91cChzdW1tYXJ5UGFn ZXMuY29uY2F0KFtjaGFydHNQYWdlLCBhbmFseXNpc0NhdGVnb3J5UGFnZSwgdGVzdEhlYWx0aFBh Z2VdKSk7CisgICAgICAgIGNvbnN0IGhlYWRpbmcgPSBuZXcgSGVhZGluZyhtYW5pZmVzdC5zaXRl VGl0bGUpOworICAgICAgICBoZWFkaW5nLmFkZFBhZ2VHcm91cChzdW1tYXJ5UGFnZXMpOwogCiAg ICAgICAgIGhlYWRpbmcuc2V0VGl0bGUobWFuaWZlc3Quc2l0ZVRpdGxlKTsKICAgICAgICAgaGVh ZGluZy5hZGRQYWdlR3JvdXAoZGFzaGJvYXJkUGFnZXMpOwogCi0gICAgICAgIHZhciByb3V0ZXIg PSBuZXcgUGFnZVJvdXRlcigpOwotICAgICAgICBmb3IgKHZhciBzdW1tYXJ5UGFnZSBvZiBzdW1t YXJ5UGFnZXMpCisgICAgICAgIGNvbnN0IHJvdXRlciA9IG5ldyBQYWdlUm91dGVyKCk7CisgICAg ICAgIGZvciAoY29uc3Qgc3VtbWFyeVBhZ2Ugb2Ygc3VtbWFyeVBhZ2VzKQogICAgICAgICAgICAg cm91dGVyLmFkZFBhZ2Uoc3VtbWFyeVBhZ2UpOwotICAgICAgICByb3V0ZXIuYWRkUGFnZShjaGFy dHNQYWdlKTsKICAgICAgICAgcm91dGVyLmFkZFBhZ2UoY3JlYXRlQW5hbHlzaXNUYXNrUGFnZSk7 CiAgICAgICAgIHJvdXRlci5hZGRQYWdlKGFuYWx5c2lzVGFza1BhZ2UpOwogICAgICAgICByb3V0 ZXIuYWRkUGFnZShidWlsZFJlcXVlc3RRdWV1ZVBhZ2UpOwotICAgICAgICByb3V0ZXIuYWRkUGFn ZShhbmFseXNpc0NhdGVnb3J5UGFnZSk7Ci0gICAgICAgIHJvdXRlci5hZGRQYWdlKHRlc3RIZWFs dGhQYWdlKTsKLSAgICAgICAgZm9yICh2YXIgcGFnZSBvZiBkYXNoYm9hcmRQYWdlcykKKyAgICAg ICAgZm9yIChjb25zdCBwYWdlIG9mIGRhc2hib2FyZFBhZ2VzKQogICAgICAgICAgICAgcm91dGVy LmFkZFBhZ2UocGFnZSk7CiAKICAgICAgICAgaWYgKHN1bW1hcnlQYWdlcy5sZW5ndGgpCg==