182204 2018-01-26 17:51:39 -0800 Don't retain focus for input peripheral views 2018-01-26 18:14:17 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner mitz thorton wenson_hsieh oldest_to_newest 1393769 0 megan_gardner 2018-01-26 17:51:39 -0800 Don't retain focus for input peripheral views 1393771 1 332443 megan_gardner 2018-01-26 17:55:15 -0800 Created attachment 332443 Patch 1393773 2 megan_gardner 2018-01-26 17:56:02 -0800 <rdar://problem/36829288> 1393775 3 332443 thorton 2018-01-26 17:58:54 -0800 Comment on attachment 332443 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332443&action=review > Source/WebKit/ChangeLog:10 > + focus to be retains on these views anyways, as they don't have keyboard input, but this s/retains/retained/ > LayoutTests/fast/forms/ios/ipad/unfocus-inside-fixed-hittest.html:79 > + document.getElementById('result').textContent = 'PASS: hit testing found #target after select interaction'; Doesn’t this change the test result? 1393782 4 megan_gardner 2018-01-26 18:14:17 -0800 https://trac.webkit.org/r227710 332443 2018-01-26 17:55:15 -0800 2018-01-26 17:58:54 -0800 Patch bug-182204-20180126175515.patch text/plain 3438 megan_gardner SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjc3MDkpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE4LTAxLTI2ICBNZWdhbiBHYXJk bmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgRG9uJ3QgcmV0YWluIGZv Y3VzIGZvciBpbnB1dCBwZXJpcGhlcmFsIHZpZXdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODIyMDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZXRhaW5pbmcgZm9jdXMgb24gaW5wdXQgcGVyaXBoZXJh bCB2aWV3cyBtYWtlcyBpdCBzbyB0aGV5IGNhbm5vdCBkaXNtaXNzIHRoZW1zZWx2ZXMgd2l0aAor ICAgICAgICB0aGUgY3VycmVudCBhcmNoaXRlY3R1cmUuIFRoaXMgc2hvdWxkIHByb2JhYmx5IGJl IGZpeGVkIGluIFVJS2l0LCBhcyB0aGVyZSBpcyBubyByZWFzb24gZm9yCisgICAgICAgIGZvY3Vz IHRvIGJlIHJldGFpbnMgb24gdGhlc2Ugdmlld3MgYW55d2F5cywgYXMgdGhleSBkb24ndCBoYXZl IGtleWJvYXJkIGlucHV0LCBidXQgdGhpcworICAgICAgICBndWFyZHMgYWdhaW5zdCBvdmVyLWFn Z3Jlc3NpdmUgcmV0YWluIHJlcXVlc3RzLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0Nv bnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgX3Jlc3Rv cmVGb2N1c1dpdGhUb2tlbjpdKToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfcHJlc2VydmVG b2N1c1dpdGhUb2tlbjpkZXN0cnVjdGl2ZWx5Ol0pOgorCiAyMDE4LTAxLTI2ICBDaHJpcyBEdW1l eiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBzdXJlIHNlcnZpY2Ugd29ya2Vy IGNvZGUgZG9lcyBub3QgbGF1bmNoIGEgU3RvcmFnZVByb2Nlc3MgdW5uZWNlc3NhcmlseQpJbmRl eDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5t bQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmll d0ludGVyYWN0aW9uLm1tCShyZXZpc2lvbiAyMjczNzcpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCSh3b3JraW5nIGNvcHkpCkBAIC00 MTY5LDEyICs0MTY5LDE0IEBAIC0gKHZvaWQpZmlsZVVwbG9hZFBhbmVsRGlkRGlzbWlzczooV0tG aWwKIAogLSAodm9pZClfcmVzdG9yZUZvY3VzV2l0aFRva2VuOihpZCA8TlNDb3B5aW5nLCBOU1Nl Y3VyZUNvZGluZz4pdG9rZW4KIHsKLSAgICAtLV93ZWJWaWV3LT5fYWN0aXZlRm9jdXNlZFN0YXRl UmV0YWluQ291bnQ7CisgICAgaWYgKCFfaW5wdXRQZXJpcGhlcmFsKQorICAgICAgICAtLV93ZWJW aWV3LT5fYWN0aXZlRm9jdXNlZFN0YXRlUmV0YWluQ291bnQ7CiB9CiAKIC0gKHZvaWQpX3ByZXNl cnZlRm9jdXNXaXRoVG9rZW46KGlkIDxOU0NvcHlpbmcsIE5TU2VjdXJlQ29kaW5nPil0b2tlbiBk ZXN0cnVjdGl2ZWx5OihCT09MKWRlc3RydWN0aXZlbHkKIHsKLSAgICArK193ZWJWaWV3LT5fYWN0 aXZlRm9jdXNlZFN0YXRlUmV0YWluQ291bnQ7CisgICAgaWYgKCFfaW5wdXRQZXJpcGhlcmFsKQor ICAgICAgICArK193ZWJWaWV3LT5fYWN0aXZlRm9jdXNlZFN0YXRlUmV0YWluQ291bnQ7CiB9CiAK ICNwcmFnbWEgbWFyayAtIEltcGxlbWVudGF0aW9uIG9mIFVJV2ViVG91Y2hFdmVudHNHZXN0dXJl UmVjb2duaXplckRlbGVnYXRlLgpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMjI3Mzc2KQorKysgTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMDEt MjYgIE1lZ2FuIEdhcmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBE b24ndCByZXRhaW4gZm9jdXMgZm9yIGlucHV0IHBlcmlwaGVyYWwgdmlld3MKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjIwNAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVkIGEgc3BlbGxpbmcgZXJy b3Igd2hpbGUgZml4aW5nIGEgYnVnIHRoaXMgdGVzdCBjYXVnaHQuCisKKyAgICAgICAgKiBmYXN0 L2Zvcm1zL2lvcy9pcGFkL3VuZm9jdXMtaW5zaWRlLWZpeGVkLWhpdHRlc3QuaHRtbDoKKwogMjAx OC0wMS0yMiAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAg ICBSRUdSRVNTSU9OIChyMjI2OTgxKTogQVNTRVJUSU9OIEZBSUxFRDogc3RhcnRZID49IDAgJiYg ZW5kWSA8PSBoZWlnaHQgJiYgc3RhcnRZIDwgZW5kWSBpbiBXZWJDb3JlOjpGRU1vcnBob2xvZ3k6 OnBsYXRmb3JtQXBwbHlHZW5lcmljCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lvcy9p cGFkL3VuZm9jdXMtaW5zaWRlLWZpeGVkLWhpdHRlc3QuaHRtbAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9mYXN0L2Zvcm1zL2lvcy9pcGFkL3VuZm9jdXMtaW5zaWRlLWZpeGVkLWhpdHRlc3Qu aHRtbAkocmV2aXNpb24gMjI3Mzc2KQorKysgTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pb3MvaXBh ZC91bmZvY3VzLWluc2lkZS1maXhlZC1oaXR0ZXN0Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTc2 LDcgKzc2LDcgQEAKICAgICAgICAgdmFyIGNsaWNrZWQgPSBmYWxzZTsKICAgICAgICAgZnVuY3Rp b24gYnV0dG9uQ2xpY2tlZCgpCiAgICAgICAgIHsKLSAgICAgICAgICAgIGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCdyZXN1bHQnKS50ZXh0Q29udGVudCA9ICdQQVNTOiBoaXQgdGVzdGluZyBmb3Vu ZCAjdGFyZ2V0IGFmdGVyIHNlbGVjdCBpbnRlcmF0aW9uJzsKKyAgICAgICAgICAgIGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCdyZXN1bHQnKS50ZXh0Q29udGVudCA9ICdQQVNTOiBoaXQgdGVzdGlu ZyBmb3VuZCAjdGFyZ2V0IGFmdGVyIHNlbGVjdCBpbnRlcmFjdGlvbic7CiAgICAgICAgICAgICBp ZiAod2luZG93LnRlc3RSdW5uZXIpCiAgICAgICAgICAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlE b25lKCk7CiAgICAgICAgIH0K