182187 2018-01-26 14:26:55 -0800 Fix emitAllocateWithNonNullAllocator to work on arm 2018-01-26 16:05:22 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff rmorisset ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1393675 0 saam 2018-01-26 14:26:55 -0800 ... 1393676 1 saam 2018-01-26 14:27:25 -0800 <rdar://problem/36906550> 1393677 2 332418 saam 2018-01-26 14:34:24 -0800 Created attachment 332418 patch 1393701 3 332418 commit-queue 2018-01-26 16:05:21 -0800 Comment on attachment 332418 patch Clearing flags on attachment: 332418 Committed r227700: <https://trac.webkit.org/changeset/227700> 1393702 4 commit-queue 2018-01-26 16:05:22 -0800 All reviewed patches have been landed. Closing bug. 332418 2018-01-26 14:34:24 -0800 2018-01-26 16:05:21 -0800 patch b-backup.diff text/plain 6697 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI3Njk2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE4LTAxLTI2ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IEZpeCBlbWl0QWxsb2NhdGVXaXRoTm9uTnVsbEFsbG9jYXRvciB0byB3b3JrIG9uIGFybQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyMTg3CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8zNjkwNjU1MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIHVuaWZpZXMgdGhlIHg4NiBhbmQgQVJN IHBhdGhzIGluIGVtaXRBbGxvY2F0ZVdpdGhOb25OdWxsQWxsb2NhdG9yCisgICAgICAgIGFuZCBt YWtlcyBpdCBzbyB0aGF0IGVtaXRBbGxvY2F0ZVdpdGhOb25OdWxsQWxsb2NhdG9yIHVzZXMgdGhl IG1hY3JvIHNjcmF0Y2gKKyAgICAgICAgcmVnaXN0ZXIgb24gQVJNLgorCisgICAgICAgICogZnRs L0ZUTExvd2VyREZHVG9CMy5jcHA6CisgICAgICAgIChKU0M6OkZUTDo6REZHOjpMb3dlckRGR1Rv QjM6OmFsbG9jYXRlSGVhcENlbGwpOgorICAgICAgICAqIGppdC9Bc3NlbWJseUhlbHBlcnMuY3Bw OgorICAgICAgICAoSlNDOjpBc3NlbWJseUhlbHBlcnM6OmVtaXRBbGxvY2F0ZVdpdGhOb25OdWxs QWxsb2NhdG9yKToKKwogMjAxOC0wMS0yNiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBw bGUuY29tPgogCiAgICAgICAgIFJlYmFzZWxpbmluZyBidWlsdGluIGdlbmVyYXRvciB0ZXN0cyBh ZnRlciByMjI3Njg1LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRG R1RvQjMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93 ZXJERkdUb0IzLmNwcAkocmV2aXNpb24gMjI3Njg2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2Z0bC9GVExMb3dlckRGR1RvQjMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMSw2ICszMSw3IEBA CiAjaW5jbHVkZSAiQWlyQ29kZS5oIgogI2luY2x1ZGUgIkFpckdlbmVyYXRpb25Db250ZXh0Lmgi CiAjaW5jbHVkZSAiQWxsb3dNYWNyb1NjcmF0Y2hSZWdpc3RlclVzYWdlLmgiCisjaW5jbHVkZSAi QWxsb3dNYWNyb1NjcmF0Y2hSZWdpc3RlclVzYWdlSWYuaCIKICNpbmNsdWRlICJBdG9taWNzT2Jq ZWN0LmgiCiAjaW5jbHVkZSAiQjNDaGVja1ZhbHVlLmgiCiAjaW5jbHVkZSAiQjNGZW5jZVZhbHVl LmgiCkBAIC0xMjAxNiw2ICsxMjAxNywxMCBAQCBwcml2YXRlOgogICAgICAgICBMQmFzaWNCbG9j ayBsYXN0TmV4dCA9IG1fb3V0Lmluc2VydE5ld0Jsb2Nrc0JlZm9yZShjb250aW51YXRpb24pOwog ICAgICAgICAKICAgICAgICAgUGF0Y2hwb2ludFZhbHVlKiBwYXRjaHBvaW50ID0gbV9vdXQucGF0 Y2hwb2ludChwb2ludGVyVHlwZSgpKTsKKyAgICAgICAgaWYgKGlzQVJNNjQoKSkgeworICAgICAg ICAgICAgLy8gZW1pdEFsbG9jYXRlV2l0aE5vbk51bGxBbGxvY2F0b3IgdXNlcyB0aGUgc2NyYXRj aCByZWdpc3RlcnMgb24gQVJNLgorICAgICAgICAgICAgcGF0Y2hwb2ludC0+Y2xvYmJlcihSZWdp c3RlclNldDo6bWFjcm9TY3JhdGNoUmVnaXN0ZXJzKCkpOworICAgICAgICB9CiAgICAgICAgIHBh dGNocG9pbnQtPmVmZmVjdHMudGVybWluYWwgPSB0cnVlOwogICAgICAgICBpZiAoYWN0dWFsQWxs b2NhdG9yLmlzQ29uc3RhbnQoKSkKICAgICAgICAgICAgIHBhdGNocG9pbnQtPm51bUdQU2NyYXRj aFJlZ2lzdGVycysrOwpAQCAtMTIwMjksNiArMTIwMzQsNyBAQCBwcml2YXRlOgogICAgICAgICAK ICAgICAgICAgcGF0Y2hwb2ludC0+c2V0R2VuZXJhdG9yKAogICAgICAgICAgICAgWz1dIChDQ2Fs bEhlbHBlcnMmIGppdCwgY29uc3QgU3RhY2ttYXBHZW5lcmF0aW9uUGFyYW1zJiBwYXJhbXMpIHsK KyAgICAgICAgICAgICAgICBBbGxvd01hY3JvU2NyYXRjaFJlZ2lzdGVyVXNhZ2VJZiBhbGxvd1Nj cmF0Y2hJZihqaXQsIGlzQVJNNjQoKSk7CiAgICAgICAgICAgICAgICAgQ0NhbGxIZWxwZXJzOjpK dW1wTGlzdCBqdW1wVG9TbG93UGF0aDsKICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAg ICBHUFJSZWcgYWxsb2NhdG9yR1BSOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9B c3NlbWJseUhlbHBlcnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9q aXQvQXNzZW1ibHlIZWxwZXJzLmNwcAkocmV2aXNpb24gMjI3Njg2KQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL2ppdC9Bc3NlbWJseUhlbHBlcnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01ODQs MTQgKzU4NCwxNiBAQCB2b2lkIEFzc2VtYmx5SGVscGVyczo6ZW1pdFJhbmRvbVRodW5rKFZNCiAK IHZvaWQgQXNzZW1ibHlIZWxwZXJzOjplbWl0QWxsb2NhdGVXaXRoTm9uTnVsbEFsbG9jYXRvcihH UFJSZWcgcmVzdWx0R1BSLCBjb25zdCBKSVRBbGxvY2F0b3ImIGFsbG9jYXRvciwgR1BSUmVnIGFs bG9jYXRvckdQUiwgR1BSUmVnIHNjcmF0Y2hHUFIsIEp1bXBMaXN0JiBzbG93UGF0aCkKIHsKLSAg ICAvLyBOT1RFOiBUaGlzIGlzIGNhcmVmdWxseSB3cml0dGVuIHNvIHRoYXQgd2UgY2FuIGNhbGwg aXQgd2hpbGUgd2UgZGlzYWxsb3cgc2NyYXRjaAotICAgIC8vIHJlZ2lzdGVyIHVzYWdlLgotICAg ICAgICAKICAgICBpZiAoT3B0aW9uczo6Zm9yY2VHQ1Nsb3dQYXRocygpKSB7CiAgICAgICAgIHNs b3dQYXRoLmFwcGVuZChqdW1wKCkpOwogICAgICAgICByZXR1cm47CiAgICAgfQotICAgIAorCisg ICAgLy8gTk9URSwgc29tZSBpbnZhcmlhbnRzIG9mIHRoaXMgZnVuY3Rpb246CisgICAgLy8gLSBX aGVuIGdvaW5nIHRvIHRoZSBzbG93IHBhdGgsIHdlIG11c3QgbGVhdmUgcmVzdWx0R1BSIHdpdGgg emVybyBpbiBpdC4KKyAgICAvLyAtIFdlICpjYW4gbm90KiB1c2UgUmVnaXN0ZXJTZXQ6Om1hY3Jv U2NyYXRjaFJlZ2lzdGVycyBvbiB4ODYuCisgICAgLy8gLSBXZSAqY2FuKiB1c2UgUmVnaXN0ZXJT ZXQ6Om1hY3JvU2NyYXRjaFJlZ2lzdGVycyBvbiBBUk0uCisKICAgICBKdW1wIHBvcFBhdGg7CiAg ICAgSnVtcCBkb25lOwogICAgIApAQCAtNjAwLDE5ICs2MDIsMTEgQEAgdm9pZCBBc3NlbWJseUhl bHBlcnM6OmVtaXRBbGxvY2F0ZVdpdGhObwogI2Vsc2UKICAgICBsb2FkUHRyKCZ2bSgpLnRocmVh ZExvY2FsQ2FjaGVEYXRhLCBzY3JhdGNoR1BSKTsKICNlbmRpZgotICAgIGlmICghaXNYODYoKSkK LSAgICAgICAgbG9hZDMyKEFkZHJlc3Moc2NyYXRjaEdQUiwgVGhyZWFkTG9jYWxDYWNoZTo6b2Zm c2V0T2ZTaXplSW5EYXRhKCkpLCByZXN1bHRHUFIpOwogICAgIGlmIChhbGxvY2F0b3IuaXNDb25z dGFudCgpKSB7Ci0gICAgICAgIGlmIChpc1g4NigpKQotICAgICAgICAgICAgc2xvd1BhdGguYXBw ZW5kKGJyYW5jaDMyKEJlbG93T3JFcXVhbCwgQWRkcmVzcyhzY3JhdGNoR1BSLCBUaHJlYWRMb2Nh bENhY2hlOjpvZmZzZXRPZlNpemVJbkRhdGEoKSksIFRydXN0ZWRJbW0zMihhbGxvY2F0b3IuYWxs b2NhdG9yKCkub2Zmc2V0KCkpKSk7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgIHNsb3dQYXRo LmFwcGVuZChicmFuY2gzMihCZWxvd09yRXF1YWwsIHJlc3VsdEdQUiwgVHJ1c3RlZEltbTMyKGFs bG9jYXRvci5hbGxvY2F0b3IoKS5vZmZzZXQoKSkpKTsKKyAgICAgICAgc2xvd1BhdGguYXBwZW5k KGJyYW5jaDMyKEJlbG93T3JFcXVhbCwgQWRkcmVzcyhzY3JhdGNoR1BSLCBUaHJlYWRMb2NhbENh Y2hlOjpvZmZzZXRPZlNpemVJbkRhdGEoKSksIFRydXN0ZWRJbW0zMihhbGxvY2F0b3IuYWxsb2Nh dG9yKCkub2Zmc2V0KCkpKSk7CiAgICAgICAgIGFkZFB0cihUcnVzdGVkSW1tMzIoVGhyZWFkTG9j YWxDYWNoZTo6b2Zmc2V0T2ZGaXJzdEFsbG9jYXRvckluRGF0YSgpICsgYWxsb2NhdG9yLmFsbG9j YXRvcigpLm9mZnNldCgpKSwgc2NyYXRjaEdQUiwgYWxsb2NhdG9yR1BSKTsKICAgICB9IGVsc2Ug ewotICAgICAgICBpZiAoaXNYODYoKSkKLSAgICAgICAgICAgIHNsb3dQYXRoLmFwcGVuZChicmFu Y2gzMihCZWxvd09yRXF1YWwsIEFkZHJlc3Moc2NyYXRjaEdQUiwgVGhyZWFkTG9jYWxDYWNoZTo6 b2Zmc2V0T2ZTaXplSW5EYXRhKCkpLCBhbGxvY2F0b3JHUFIpKTsKLSAgICAgICAgZWxzZQotICAg ICAgICAgICAgc2xvd1BhdGguYXBwZW5kKGJyYW5jaDMyKEJlbG93T3JFcXVhbCwgcmVzdWx0R1BS LCBhbGxvY2F0b3JHUFIpKTsKKyAgICAgICAgc2xvd1BhdGguYXBwZW5kKGJyYW5jaDMyKEJlbG93 T3JFcXVhbCwgQWRkcmVzcyhzY3JhdGNoR1BSLCBUaHJlYWRMb2NhbENhY2hlOjpvZmZzZXRPZlNp emVJbkRhdGEoKSksIGFsbG9jYXRvckdQUikpOwogICAgICAgICBhZGRQdHIoVHJ1c3RlZEltbTMy KFRocmVhZExvY2FsQ2FjaGU6Om9mZnNldE9mRmlyc3RBbGxvY2F0b3JJbkRhdGEoKSksIGFsbG9j YXRvckdQUik7CiAgICAgICAgIGFkZFB0cihzY3JhdGNoR1BSLCBhbGxvY2F0b3JHUFIpOwogICAg IH0KQEAgLTYyMiwzNSArNjE2LDIwIEBAIHZvaWQgQXNzZW1ibHlIZWxwZXJzOjplbWl0QWxsb2Nh dGVXaXRoTm8KICAgICBpZiAoYWxsb2NhdG9yLmlzQ29uc3RhbnQoKSkKICAgICAgICAgYWRkMzIo VHJ1c3RlZEltbTMyKC1hbGxvY2F0b3IuYWxsb2NhdG9yKCkuY2VsbFNpemUodm0oKS5oZWFwKSks IHJlc3VsdEdQUiwgc2NyYXRjaEdQUik7CiAgICAgZWxzZSB7Ci0gICAgICAgIGlmIChpc1g4Nigp KSB7Ci0gICAgICAgICAgICBtb3ZlKHJlc3VsdEdQUiwgc2NyYXRjaEdQUik7Ci0gICAgICAgICAg ICBzdWIzMihBZGRyZXNzKGFsbG9jYXRvckdQUiwgTG9jYWxBbGxvY2F0b3I6Om9mZnNldE9mQ2Vs bFNpemUoKSksIHNjcmF0Y2hHUFIpOwotICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgbG9h ZDMyKEFkZHJlc3MoYWxsb2NhdG9yR1BSLCBMb2NhbEFsbG9jYXRvcjo6b2Zmc2V0T2ZDZWxsU2l6 ZSgpKSwgc2NyYXRjaEdQUik7Ci0gICAgICAgICAgICBzdWIzMihyZXN1bHRHUFIsIHNjcmF0Y2hH UFIsIHNjcmF0Y2hHUFIpOwotICAgICAgICB9CisgICAgICAgIG1vdmUocmVzdWx0R1BSLCBzY3Jh dGNoR1BSKTsKKyAgICAgICAgc3ViMzIoQWRkcmVzcyhhbGxvY2F0b3JHUFIsIExvY2FsQWxsb2Nh dG9yOjpvZmZzZXRPZkNlbGxTaXplKCkpLCBzY3JhdGNoR1BSKTsKICAgICB9CiAgICAgbmVnUHRy KHJlc3VsdEdQUik7CiAgICAgc3RvcmUzMihzY3JhdGNoR1BSLCBBZGRyZXNzKGFsbG9jYXRvckdQ UiwgTG9jYWxBbGxvY2F0b3I6Om9mZnNldE9mRnJlZUxpc3QoKSArIEZyZWVMaXN0OjpvZmZzZXRP ZlJlbWFpbmluZygpKSk7CiAgICAgQWRkcmVzcyBwYXlsb2FkRW5kQWRkciA9IEFkZHJlc3MoYWxs b2NhdG9yR1BSLCBMb2NhbEFsbG9jYXRvcjo6b2Zmc2V0T2ZGcmVlTGlzdCgpICsgRnJlZUxpc3Q6 Om9mZnNldE9mUGF5bG9hZEVuZCgpKTsKLSAgICBpZiAoaXNYODYoKSkKLSAgICAgICAgYWRkUHRy KHBheWxvYWRFbmRBZGRyLCByZXN1bHRHUFIpOwotICAgIGVsc2UgewotICAgICAgICBsb2FkUHRy KHBheWxvYWRFbmRBZGRyLCBzY3JhdGNoR1BSKTsKLSAgICAgICAgYWRkUHRyKHNjcmF0Y2hHUFIs IHJlc3VsdEdQUik7Ci0gICAgfQotICAgICAgICAKKyAgICBhZGRQdHIocGF5bG9hZEVuZEFkZHIs IHJlc3VsdEdQUik7CisKICAgICBkb25lID0ganVtcCgpOwogICAgICAgICAKICAgICBwb3BQYXRo LmxpbmsodGhpcyk7CiAgICAgICAgIAogICAgIGxvYWRQdHIoQWRkcmVzcyhhbGxvY2F0b3JHUFIs IExvY2FsQWxsb2NhdG9yOjpvZmZzZXRPZkZyZWVMaXN0KCkgKyBGcmVlTGlzdDo6b2Zmc2V0T2ZT Y3JhbWJsZWRIZWFkKCkpLCByZXN1bHRHUFIpOwotICAgIGlmIChpc1g4NigpKQotICAgICAgICB4 b3JQdHIoQWRkcmVzcyhhbGxvY2F0b3JHUFIsIExvY2FsQWxsb2NhdG9yOjpvZmZzZXRPZkZyZWVM aXN0KCkgKyBGcmVlTGlzdDo6b2Zmc2V0T2ZTZWNyZXQoKSksIHJlc3VsdEdQUik7Ci0gICAgZWxz ZSB7Ci0gICAgICAgIGxvYWRQdHIoQWRkcmVzcyhhbGxvY2F0b3JHUFIsIExvY2FsQWxsb2NhdG9y OjpvZmZzZXRPZkZyZWVMaXN0KCkgKyBGcmVlTGlzdDo6b2Zmc2V0T2ZTZWNyZXQoKSksIHNjcmF0 Y2hHUFIpOwotICAgICAgICB4b3JQdHIoc2NyYXRjaEdQUiwgcmVzdWx0R1BSKTsKLSAgICB9Cisg ICAgeG9yUHRyKEFkZHJlc3MoYWxsb2NhdG9yR1BSLCBMb2NhbEFsbG9jYXRvcjo6b2Zmc2V0T2ZG cmVlTGlzdCgpICsgRnJlZUxpc3Q6Om9mZnNldE9mU2VjcmV0KCkpLCByZXN1bHRHUFIpOwogICAg IHNsb3dQYXRoLmFwcGVuZChicmFuY2hUZXN0UHRyKFplcm8sIHJlc3VsdEdQUikpOwogICAgICAg ICAKICAgICAvLyBUaGUgb2JqZWN0IGlzIGhhbGYtYWxsb2NhdGVkOiB3ZSBoYXZlIHdoYXQgd2Ug a25vdyBpcyBhIGZyZXNoIG9iamVjdCwgYnV0Cg==