182184 2018-01-26 13:11:46 -0800 Layout Test http/wpt/beacon/beacon-async-error-logging.html is flaky 2018-01-26 20:26:17 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jlewis3 cdumez achristensen cdumez commit-queue lforschler rniwa ryanhaddad webkit-bug-importer youennf oldest_to_newest 1393639 0 jlewis3 2018-01-26 13:11:46 -0800 The following layout test is flaky on WK2 http/wpt/beacon/beacon-async-error-logging.html Probable cause: This doesn't currently have a clear regression point. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Fwpt%2Fbeacon%2Fbeacon-async-error-logging.html https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r227682%20(2547)/results.html https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/builds/2547 diff: --- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/wpt/beacon/beacon-async-error-logging-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/wpt/beacon/beacon-async-error-logging-actual.txt @@ -1,4 +1,3 @@ -CONSOLE MESSAGE: Beacon API cannot load http://invalid.localhost/. A server with the specified hostname could not be found. PASS Should log an error message in the console 1393718 1 webkit-bug-importer 2018-01-26 16:43:43 -0800 <rdar://problem/36929478> 1393723 2 cdumez 2018-01-26 16:46:05 -0800 Don't worry about the regression point. The test currently relies on a setTimeout. I'll fix. 1393728 3 332430 cdumez 2018-01-26 16:49:26 -0800 Created attachment 332430 WIP Patch 1393789 4 332449 cdumez 2018-01-26 19:01:32 -0800 Created attachment 332449 Patch 1393797 5 332449 youennf 2018-01-26 19:44:34 -0800 Comment on attachment 332449 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332449&action=review > LayoutTests/http/wpt/beacon/beacon-async-error-logging.html:10 > + internals.setConsoleMessageListener(function() { Can we make it sort of working on regular environment by testing for window.internals and adding a text message stating to look for console message? 1393799 6 332451 cdumez 2018-01-26 19:49:55 -0800 Created attachment 332451 Patch 1393800 7 332451 commit-queue 2018-01-26 20:26:15 -0800 Comment on attachment 332451 Patch Clearing flags on attachment: 332451 Committed r227712: <https://trac.webkit.org/changeset/227712> 1393801 8 commit-queue 2018-01-26 20:26:17 -0800 All reviewed patches have been landed. Closing bug. 332430 2018-01-26 16:49:26 -0800 2018-01-26 19:01:30 -0800 WIP Patch 182184_beacon_flake_wip.patch text/plain 767 cdumez ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvd3B0L2JlYWNvbi9iZWFjb24tYXN5bmMtZXJy b3ItbG9nZ2luZy5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC93cHQvYmVhY29uL2JlYWNvbi1hc3lu Yy1lcnJvci1sb2dnaW5nLmh0bWwKaW5kZXggYzI3NmNmZTUwODEuLjkyZmE0ZmVmZDk2IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3dwdC9iZWFjb24vYmVhY29uLWFzeW5jLWVycm9yLWxv Z2dpbmcuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3dwdC9iZWFjb24vYmVhY29uLWFzeW5j LWVycm9yLWxvZ2dpbmcuaHRtbApAQCAtNywxMSArNywxMSBAQAogPGJvZHk+CiA8c2NyaXB0Pgog ICAgIGFzeW5jX3Rlc3QoZnVuY3Rpb24odCkgeworICAgICAgICBpbnRlcm5hbHMuc2V0Q29uc29s ZU1lc3NhZ2VMaXN0ZW5lcihmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIHQuZG9uZSgpOworICAg ICAgICB9KTsKICAgICAgICAgbGV0IGludmFsaWRIb3N0ID0gImh0dHA6Ly9pbnZhbGlkLmxvY2Fs aG9zdCI7CiAgICAgICAgIGFzc2VydF90cnVlKG5hdmlnYXRvci5zZW5kQmVhY29uKGludmFsaWRI b3N0LCAndGVzdCcpLCAic2VuZEJlYWNvbiBzaG91bGQgcmV0dXJuIHRydWUiKTsKLSAgICAgICAg c2V0VGltZW91dChmdW5jdGlvbigpIHsKLSAgICAgICAgICAgIHQuZG9uZSgpOwotICAgICAgICB9 LCA1MDApOwogICAgIH0sICJTaG91bGQgbG9nIGFuIGVycm9yIG1lc3NhZ2UgaW4gdGhlIGNvbnNv bGUiKTsKIDwvc2NyaXB0PgogPC9ib2R5Pgo= 332449 2018-01-26 19:01:32 -0800 2018-01-26 19:49:53 -0800 Patch bug-182184-20180126190131.patch text/plain 1685 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3NzAyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMWRhMzc4OWY4NWJjZGRhYzNhMGI3 YWZlNzM3ZmZiZWUyYTNmOWNmZC4uMWJhYmEyYWJjYzU2MzYxNzExODgxOWY4NTFmNTYyMGY5ZWE1 NzQwYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTAxLTI2ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0IFRlc3QgaHR0cC93cHQvYmVhY29uL2Jl YWNvbi1hc3luYy1lcnJvci1sb2dnaW5nLmh0bWwgaXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjE4NAorICAgICAgICA8cmRhcjovL3By b2JsZW0vMzY5Mjk0Nzg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgU3RvcCByZWx5aW5nIG9uIGEgc2V0VGltZW91dCg1MDApIHRvIGVuZCB0aGUgdGVz dC4gSW5zdGVhZCByZWx5IG9uIHRoZQorICAgICAgICBpbnRlcm5hbHMuc2V0Q29uc29sZU1lc3Nh Z2VMaXN0ZW5lcigpIEFQSSB0byB3YWl0IGZvciB0aGUgY29uc29sZSBtZXNzYWdlCisgICAgICAg IHdlIGFyZSBleHBlY3RpbmcuCisKKyAgICAgICAgKiBodHRwL3dwdC9iZWFjb24vYmVhY29uLWFz eW5jLWVycm9yLWxvZ2dpbmcuaHRtbDoKKwogMjAxOC0wMS0yNiAgUGVyIEFybmUgVm9sbGFuICA8 cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dpbl0gVXBkYXRlIHRlc3QgZXhwZWN0YXRp b25zLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC93cHQvYmVhY29uL2JlYWNvbi1hc3lu Yy1lcnJvci1sb2dnaW5nLmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3dwdC9iZWFjb24vYmVhY29u LWFzeW5jLWVycm9yLWxvZ2dpbmcuaHRtbAppbmRleCBjMjc2Y2ZlNTA4MWRjZjI4MmI1OTQxZDBi MGY3MWIzNmEyNDU5ZTQzLi45MmZhNGZlZmQ5NmNiM2FlOWYxNmZkZTkwNjIxODY3NDM2ZDMxODhl IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3dwdC9iZWFjb24vYmVhY29uLWFzeW5jLWVy cm9yLWxvZ2dpbmcuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3dwdC9iZWFjb24vYmVhY29u LWFzeW5jLWVycm9yLWxvZ2dpbmcuaHRtbApAQCAtNywxMSArNywxMSBAQAogPGJvZHk+CiA8c2Ny aXB0PgogICAgIGFzeW5jX3Rlc3QoZnVuY3Rpb24odCkgeworICAgICAgICBpbnRlcm5hbHMuc2V0 Q29uc29sZU1lc3NhZ2VMaXN0ZW5lcihmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIHQuZG9uZSgp OworICAgICAgICB9KTsKICAgICAgICAgbGV0IGludmFsaWRIb3N0ID0gImh0dHA6Ly9pbnZhbGlk LmxvY2FsaG9zdCI7CiAgICAgICAgIGFzc2VydF90cnVlKG5hdmlnYXRvci5zZW5kQmVhY29uKGlu dmFsaWRIb3N0LCAndGVzdCcpLCAic2VuZEJlYWNvbiBzaG91bGQgcmV0dXJuIHRydWUiKTsKLSAg ICAgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsKLSAgICAgICAgICAgIHQuZG9uZSgpOwotICAg ICAgICB9LCA1MDApOwogICAgIH0sICJTaG91bGQgbG9nIGFuIGVycm9yIG1lc3NhZ2UgaW4gdGhl IGNvbnNvbGUiKTsKIDwvc2NyaXB0PgogPC9ib2R5Pgo= 332451 2018-01-26 19:49:55 -0800 2018-01-26 20:26:15 -0800 Patch bug-182184-20180126194954.patch text/plain 1814 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3NzAyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMWRhMzc4OWY4NWJjZGRhYzNhMGI3 YWZlNzM3ZmZiZWUyYTNmOWNmZC4uNmQ0MzNhNTEwOGQ5MTNlODEwZGM3NWI2YjQ3MzE0NmIyY2Y4 OWVmYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTAxLTI2ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0IFRlc3QgaHR0cC93cHQvYmVhY29uL2Jl YWNvbi1hc3luYy1lcnJvci1sb2dnaW5nLmh0bWwgaXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjE4NAorICAgICAgICA8cmRhcjovL3By b2JsZW0vMzY5Mjk0Nzg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgWW91ZW5uIEZhYmxldC4KKwor ICAgICAgICBTdG9wIHJlbHlpbmcgb24gYSBzZXRUaW1lb3V0KDUwMCkgdG8gZW5kIHRoZSB0ZXN0 LiBJbnN0ZWFkIHJlbHkgb24gdGhlCisgICAgICAgIGludGVybmFscy5zZXRDb25zb2xlTWVzc2Fn ZUxpc3RlbmVyKCkgQVBJIHRvIHdhaXQgZm9yIHRoZSBjb25zb2xlIG1lc3NhZ2UKKyAgICAgICAg d2UgYXJlIGV4cGVjdGluZy4KKworICAgICAgICAqIGh0dHAvd3B0L2JlYWNvbi9iZWFjb24tYXN5 bmMtZXJyb3ItbG9nZ2luZy5odG1sOgorCiAyMDE4LTAxLTI2ICBQZXIgQXJuZSBWb2xsYW4gIDxw dm9sbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2luXSBVcGRhdGUgdGVzdCBleHBlY3RhdGlv bnMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3dwdC9iZWFjb24vYmVhY29uLWFzeW5j LWVycm9yLWxvZ2dpbmcuaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvd3B0L2JlYWNvbi9iZWFjb24t YXN5bmMtZXJyb3ItbG9nZ2luZy5odG1sCmluZGV4IGMyNzZjZmU1MDgxZGNmMjgyYjU5NDFkMGIw ZjcxYjM2YTI0NTllNDMuLjAwYmM5ZDdhNjUyMzhjMGFjYTRmMGIwZmE4YzcyNGEyZmZkNjBhZjcg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvd3B0L2JlYWNvbi9iZWFjb24tYXN5bmMtZXJy b3ItbG9nZ2luZy5odG1sCisrKyBiL0xheW91dFRlc3RzL2h0dHAvd3B0L2JlYWNvbi9iZWFjb24t YXN5bmMtZXJyb3ItbG9nZ2luZy5odG1sCkBAIC03LDExICs3LDE1IEBACiA8Ym9keT4KIDxzY3Jp cHQ+CiAgICAgYXN5bmNfdGVzdChmdW5jdGlvbih0KSB7CisgICAgICAgIGlmICh3aW5kb3cuaW50 ZXJuYWxzKSB7CisgICAgICAgICAgICBpbnRlcm5hbHMuc2V0Q29uc29sZU1lc3NhZ2VMaXN0ZW5l cihmdW5jdGlvbigpIHsKKyAgICAgICAgICAgICAgICB0LmRvbmUoKTsKKyAgICAgICAgICAgIH0p OworICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsg dC5kb25lKCk7IH0sIDUwMCk7CisgICAgICAgIH0KICAgICAgICAgbGV0IGludmFsaWRIb3N0ID0g Imh0dHA6Ly9pbnZhbGlkLmxvY2FsaG9zdCI7CiAgICAgICAgIGFzc2VydF90cnVlKG5hdmlnYXRv ci5zZW5kQmVhY29uKGludmFsaWRIb3N0LCAndGVzdCcpLCAic2VuZEJlYWNvbiBzaG91bGQgcmV0 dXJuIHRydWUiKTsKLSAgICAgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsKLSAgICAgICAgICAg IHQuZG9uZSgpOwotICAgICAgICB9LCA1MDApOwogICAgIH0sICJTaG91bGQgbG9nIGFuIGVycm9y IG1lc3NhZ2UgaW4gdGhlIGNvbnNvbGUiKTsKIDwvc2NyaXB0PgogPC9ib2R5Pgo=