182170 2018-01-26 05:07:30 -0800 WebDriver: service hangs after a browser crash 2018-01-26 05:21:18 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg clopez webkit-bug-importer oldest_to_newest 1393505 0 cgarcia 2018-01-26 05:07:30 -0800 This is currently happening in the GTK+ debug bot. There's a test that makes the browser crash due to an assert, hanging the whole process and preventing the rest of the tests from running. When the browser crashes, we correctly handle the pending requests, by completing them with an error. However, if the client tries to send another command we fail to send the message to the browser and the reply is never sent to the client. In the case of the tests, delete session command is sent, but never gets a reply. 1393508 1 332368 cgarcia 2018-01-26 05:11:54 -0800 Created attachment 332368 Patch 1393510 2 cgarcia 2018-01-26 05:20:19 -0800 Committed r227674: <https://trac.webkit.org/changeset/227674> 1393512 3 webkit-bug-importer 2018-01-26 05:21:18 -0800 <rdar://problem/36906514> 332368 2018-01-26 05:11:54 -0800 2018-01-26 05:14:58 -0800 Patch wd-browser-crash.diff text/plain 6853 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKaW5kZXggMDc1ODdkOWRhNDEuLjA5ZTE4ZmVkMDEwIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDI4IEBACisyMDE4LTAxLTI2ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJEcml2ZXI6IHNlcnZpY2UgaGFuZ3MgYWZ0 ZXIgYSBicm93c2VyIGNyYXNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xODIxNzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGlzIGlzIGN1cnJlbnRseSBoYXBwZW5pbmcgaW4gdGhlIEdUSysgZGVidWcg Ym90LiBUaGVyZSdzIGEgdGVzdCB0aGF0IG1ha2VzIHRoZSBicm93c2VyIGNyYXNoIGR1ZSB0byBh biBhc3NlcnQsCisgICAgICAgIGhhbmdpbmcgdGhlIHdob2xlIHByb2Nlc3MgYW5kIHByZXZlbnRp bmcgdGhlIHJlc3Qgb2YgdGhlIHRlc3RzIGZyb20gcnVubmluZy4gV2hlbiB0aGUgYnJvd3NlciBj cmFzaGVzLCB3ZQorICAgICAgICBjb3JyZWN0bHkgaGFuZGxlIHRoZSBwZW5kaW5nIHJlcXVlc3Rz LCBieSBjb21wbGV0aW5nIHRoZW0gd2l0aCBhbiBlcnJvci4gSG93ZXZlciwgaWYgdGhlIGNsaWVu dCB0cmllcyB0byBzZW5kCisgICAgICAgIGFub3RoZXIgY29tbWFuZCB3ZSBmYWlsIHRvIHNlbmQg dGhlIG1lc3NhZ2UgdG8gdGhlIGJyb3dzZXIgYW5kIHRoZSByZXBseSBpcyBuZXZlciBzZW50IHRv IHRoZSBjbGllbnQuIEluIHRoZQorICAgICAgICBjYXNlIG9mIHRoZSB0ZXN0cywgZGVsZXRlIHNl c3Npb24gY29tbWFuZCBpcyBzZW50LCBidXQgbmV2ZXIgZ2V0cyBhIHJlcGx5LgorCisgICAgICAg ICogU2Vzc2lvbi5jcHA6CisgICAgICAgIChXZWJEcml2ZXI6OlNlc3Npb246OmlzQ29ubmVjdGVk IGNvbnN0KTogUmV0dXJuIHdoZXRoZXIgdGhlIHNlc3Npb24gaXMgY29ubmVjdGVkIHRvIHRoZSBi cm93c2VyLgorICAgICAgICAqIFNlc3Npb24uaDoKKyAgICAgICAgKiBTZXNzaW9uSG9zdC5jcHA6 CisgICAgICAgIChXZWJEcml2ZXI6OlNlc3Npb25Ib3N0OjpzZW5kQ29tbWFuZFRvQmFja2VuZCk6 IFBhc3MgdGhlIG1lc3NhZ2UgSUQgdG8gU2Vzc2lvbkhvc3Q6OnNlbmRNZXNzYWdlVG9CYWNrZW5k KCkuCisgICAgICAgICogU2Vzc2lvbkhvc3QuaDoKKyAgICAgICAgKiBXZWJEcml2ZXJTZXJ2aWNl LmNwcDoKKyAgICAgICAgKFdlYkRyaXZlcjo6V2ViRHJpdmVyU2VydmljZTo6ZGVsZXRlU2Vzc2lv bik6IElnbm9yZSB1bmtub3duIGVycm9ycyBpZiB0aGUgc2Vzc2lvbiBpcyBubyBsb25nZXIgY29u bmVjdGVkLgorICAgICAgICAqIGdsaWIvU2Vzc2lvbkhvc3RHbGliLmNwcDoKKyAgICAgICAgKFdl YkRyaXZlcjo6U2Vzc2lvbkhvc3Q6OnNlbmRNZXNzYWdlVG9CYWNrZW5kKTogSGFuZGxlIGVycm9y cyB3aGVuIHNlbmRpbmcgdGhlIGNvbW1hbmQgYnkgY29tcGxldGluZyB0aGUgcmVxdWVzdAorICAg ICAgICB3aXRoIGFuIGVycm9yLgorCiAyMDE4LTAxLTI2ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAg PGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBXZWJEcml2ZXI6IHRpbWVvdXRzIHZhbHVl IGFuZCBjb29raWUgZXhwaXJ5IHNob3VsZCBiZSBsaW1pdGVkIHRvIG1heCBzYWZlIGludGVnZXIK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvU2Vzc2lvbi5jcHAgYi9Tb3VyY2UvV2ViRHJp dmVyL1Nlc3Npb24uY3BwCmluZGV4IDQ4YWRmZTgwMjNiLi41ODIyMTc0Mjk5NCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkRyaXZlci9TZXNzaW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViRHJpdmVyL1Nl c3Npb24uY3BwCkBAIC02OSw2ICs2OSwxMSBAQCBjb25zdCBDYXBhYmlsaXRpZXMmIFNlc3Npb246 OmNhcGFiaWxpdGllcygpIGNvbnN0CiAgICAgcmV0dXJuIG1faG9zdC0+Y2FwYWJpbGl0aWVzKCk7 CiB9CiAKK2Jvb2wgU2Vzc2lvbjo6aXNDb25uZWN0ZWQoKSBjb25zdAoreworICAgIHJldHVybiBt X2hvc3QtPmlzQ29ubmVjdGVkKCk7Cit9CisKIHN0YXRpYyBzdGQ6Om9wdGlvbmFsPFN0cmluZz4g Zmlyc3RXaW5kb3dIYW5kbGVJblJlc3VsdChKU09OOjpWYWx1ZSYgcmVzdWx0KQogewogICAgIFJl ZlB0cjxKU09OOjpBcnJheT4gaGFuZGxlczsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIv U2Vzc2lvbi5oIGIvU291cmNlL1dlYkRyaXZlci9TZXNzaW9uLmgKaW5kZXggNjVkM2ZmYmMzZGEu LjhlODlkYTdmMzI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViRHJpdmVyL1Nlc3Npb24uaAorKysg Yi9Tb3VyY2UvV2ViRHJpdmVyL1Nlc3Npb24uaApAQCAtNDgsNiArNDgsNyBAQCBwdWJsaWM6CiAK ICAgICBjb25zdCBTdHJpbmcmIGlkKCkgY29uc3Q7CiAgICAgY29uc3QgQ2FwYWJpbGl0aWVzJiBj YXBhYmlsaXRpZXMoKSBjb25zdDsKKyAgICBib29sIGlzQ29ubmVjdGVkKCkgY29uc3Q7CiAgICAg U2Vjb25kcyBzY3JpcHRUaW1lb3V0KCkgY29uc3QgIHsgcmV0dXJuIG1fc2NyaXB0VGltZW91dDsg fQogICAgIFNlY29uZHMgcGFnZUxvYWRUaW1lb3V0KCkgY29uc3QgeyByZXR1cm4gbV9wYWdlTG9h ZFRpbWVvdXQ7IH0KICAgICBTZWNvbmRzIGltcGxpY2l0V2FpdFRpbWVvdXQoKSBjb25zdCB7IHJl dHVybiBtX2ltcGxpY2l0V2FpdFRpbWVvdXQ7IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2 ZXIvU2Vzc2lvbkhvc3QuY3BwIGIvU291cmNlL1dlYkRyaXZlci9TZXNzaW9uSG9zdC5jcHAKaW5k ZXggMThkNTBjMTlhZjYuLmYxNjQ5MjljOWQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViRHJpdmVy L1Nlc3Npb25Ib3N0LmNwcAorKysgYi9Tb3VyY2UvV2ViRHJpdmVyL1Nlc3Npb25Ib3N0LmNwcApA QCAtNTUsNyArNTUsNyBAQCBsb25nIFNlc3Npb25Ib3N0OjpzZW5kQ29tbWFuZFRvQmFja2VuZChj b25zdCBTdHJpbmcmIGNvbW1hbmQsIFJlZlB0cjxKU09OOjpPYmplYwogICAgICAgICBtZXNzYWdl QnVpbGRlci5hcHBlbmQocGFyYW1ldGVycy0+dG9KU09OU3RyaW5nKCkpOwogICAgIH0KICAgICBt ZXNzYWdlQnVpbGRlci5hcHBlbmQoJ30nKTsKLSAgICBzZW5kTWVzc2FnZVRvQmFja2VuZChtZXNz YWdlQnVpbGRlci50b1N0cmluZygpKTsKKyAgICBzZW5kTWVzc2FnZVRvQmFja2VuZChzZXF1ZW5j ZUlELCBtZXNzYWdlQnVpbGRlci50b1N0cmluZygpKTsKIAogICAgIHJldHVybiBzZXF1ZW5jZUlE OwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkRyaXZlci9TZXNzaW9uSG9zdC5oIGIvU291cmNl L1dlYkRyaXZlci9TZXNzaW9uSG9zdC5oCmluZGV4IGVmYWYxMjdkMTRmLi43OWNlOWMxZjkwNiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkRyaXZlci9TZXNzaW9uSG9zdC5oCisrKyBiL1NvdXJjZS9X ZWJEcml2ZXIvU2Vzc2lvbkhvc3QuaApAQCAtNzEsNyArNzEsNyBAQCBwcml2YXRlOgogICAgIH07 CiAKICAgICB2b2lkIGluc3BlY3RvckRpc2Nvbm5lY3RlZCgpOwotICAgIHZvaWQgc2VuZE1lc3Nh Z2VUb0JhY2tlbmQoY29uc3QgU3RyaW5nJik7CisgICAgdm9pZCBzZW5kTWVzc2FnZVRvQmFja2Vu ZChsb25nLCBjb25zdCBTdHJpbmcmKTsKICAgICB2b2lkIGRpc3BhdGNoTWVzc2FnZShjb25zdCBT dHJpbmcmKTsKIAogI2lmIFVTRShHTElCKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkRyaXZlci9X ZWJEcml2ZXJTZXJ2aWNlLmNwcCBiL1NvdXJjZS9XZWJEcml2ZXIvV2ViRHJpdmVyU2VydmljZS5j cHAKaW5kZXggMzkzNDA3MGM4NjIuLjczZWJkNTc4YzIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi RHJpdmVyL1dlYkRyaXZlclNlcnZpY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJEcml2ZXIvV2ViRHJp dmVyU2VydmljZS5jcHAKQEAgLTc1NCw3ICs3NTQsMTEgQEAgdm9pZCBXZWJEcml2ZXJTZXJ2aWNl OjpkZWxldGVTZXNzaW9uKFJlZlB0cjxKU09OOjpPYmplY3Q+JiYgcGFyYW1ldGVycywgRnVuY3Rp b24KIAogICAgIGF1dG8gc2Vzc2lvbiA9IHN0ZDo6ZXhjaGFuZ2UobV9zZXNzaW9uLCBudWxscHRy KTsKICAgICBzZXNzaW9uLT5jbG9zZShbdGhpcywgc2Vzc2lvbiwgY29tcGxldGlvbkhhbmRsZXIg PSBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKV0oQ29tbWFuZFJlc3VsdCYmIHJlc3VsdCkgbXV0 YWJsZSB7Ci0gICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKFdURk1vdmUocmVzdWx0KSk7CisgICAg ICAgIC8vIElnbm9yZSB1bmtub3duIGVycm9ycyB3aGVuIGNsb3NpbmcgdGhlIHNlc3Npb24gaWYg dGhlIGJyb3dzZXIgaXMgY2xvc2VkLgorICAgICAgICBpZiAocmVzdWx0LmlzRXJyb3IoKSAmJiBy ZXN1bHQuZXJyb3JDb2RlKCkgPT0gQ29tbWFuZFJlc3VsdDo6RXJyb3JDb2RlOjpVbmtub3duRXJy b3IgJiYgIXNlc3Npb24tPmlzQ29ubmVjdGVkKCkpCisgICAgICAgICAgICBjb21wbGV0aW9uSGFu ZGxlcihDb21tYW5kUmVzdWx0OjpzdWNjZXNzKCkpOworICAgICAgICBlbHNlCisgICAgICAgICAg ICBjb21wbGV0aW9uSGFuZGxlcihXVEZNb3ZlKHJlc3VsdCkpOwogICAgIH0pOwogfQogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViRHJpdmVyL2dsaWIvU2Vzc2lvbkhvc3RHbGliLmNwcCBiL1NvdXJj ZS9XZWJEcml2ZXIvZ2xpYi9TZXNzaW9uSG9zdEdsaWIuY3BwCmluZGV4IDc5NWIwOTIxMzljLi4x MmM5YzFlNTA1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkRyaXZlci9nbGliL1Nlc3Npb25Ib3N0 R2xpYi5jcHAKKysrIGIvU291cmNlL1dlYkRyaXZlci9nbGliL1Nlc3Npb25Ib3N0R2xpYi5jcHAK QEAgLTM0MCwxOSArMzQwLDM4IEBAIHZvaWQgU2Vzc2lvbkhvc3Q6OnNlbmRNZXNzYWdlVG9Gcm9u dGVuZCh1aW50NjRfdCBjb25uZWN0aW9uSUQsIHVpbnQ2NF90IHRhcmdldElECiAgICAgZGlzcGF0 Y2hNZXNzYWdlKFN0cmluZzo6ZnJvbVVURjgobWVzc2FnZSkpOwogfQogCi12b2lkIFNlc3Npb25I b3N0OjpzZW5kTWVzc2FnZVRvQmFja2VuZChjb25zdCBTdHJpbmcmIG1lc3NhZ2UpCitzdHJ1Y3Qg TWVzc2FnZUNvbnRleHQgeworICAgIGxvbmcgbWVzc2FnZUlEOworICAgIFNlc3Npb25Ib3N0KiBo b3N0OworfTsKKwordm9pZCBTZXNzaW9uSG9zdDo6c2VuZE1lc3NhZ2VUb0JhY2tlbmQobG9uZyBt ZXNzYWdlSUQsIGNvbnN0IFN0cmluZyYgbWVzc2FnZSkKIHsKICAgICBBU1NFUlQobV9kYnVzQ29u bmVjdGlvbik7CiAgICAgQVNTRVJUKG1fY29ubmVjdGlvbklEKTsKICAgICBBU1NFUlQobV90YXJn ZXQuaWQpOwogCisgICAgYXV0byBtZXNzYWdlQ29udGV4dCA9IHN0ZDo6bWFrZV91bmlxdWU8TWVz c2FnZUNvbnRleHQ+KE1lc3NhZ2VDb250ZXh0IHsgbWVzc2FnZUlELCB0aGlzIH0pOwogICAgIGdf ZGJ1c19jb25uZWN0aW9uX2NhbGwobV9kYnVzQ29ubmVjdGlvbi5nZXQoKSwgbnVsbHB0ciwKICAg ICAgICAgSU5TUEVDVE9SX0RCVVNfT0JKRUNUX1BBVEgsCiAgICAgICAgIElOU1BFQ1RPUl9EQlVT X0lOVEVSRkFDRSwKICAgICAgICAgIlNlbmRNZXNzYWdlVG9CYWNrZW5kIiwKICAgICAgICAgZ192 YXJpYW50X25ldygiKHR0cykiLCBtX2Nvbm5lY3Rpb25JRCwgbV90YXJnZXQuaWQsIG1lc3NhZ2Uu dXRmOCgpLmRhdGEoKSksCiAgICAgICAgIG51bGxwdHIsIEdfREJVU19DQUxMX0ZMQUdTX05PX0FV VE9fU1RBUlQsCi0gICAgICAgIC0xLCBtX2NhbmNlbGxhYmxlLmdldCgpLCBkYnVzQ29ubmVjdGlv bkNhbGxBc3luY1JlYWR5Q2FsbGJhY2ssIG51bGxwdHIpOworICAgICAgICAtMSwgbV9jYW5jZWxs YWJsZS5nZXQoKSwgW10oR09iamVjdCogc291cmNlLCBHQXN5bmNSZXN1bHQqIHJlc3VsdCwgZ3Bv aW50ZXIgdXNlckRhdGEpIHsKKyAgICAgICAgICAgIGF1dG8gbWVzc2FnZUNvbnRleHQgPSBzdGQ6 OnVuaXF1ZV9wdHI8TWVzc2FnZUNvbnRleHQ+KHN0YXRpY19jYXN0PE1lc3NhZ2VDb250ZXh0Kj4o dXNlckRhdGEpKTsKKyAgICAgICAgICAgIEdVbmlxdWVPdXRQdHI8R0Vycm9yPiBlcnJvcjsKKyAg ICAgICAgICAgIEdSZWZQdHI8R1ZhcmlhbnQ+IHJlc3VsdFZhcmlhbnQgPSBhZG9wdEdSZWYoZ19k YnVzX2Nvbm5lY3Rpb25fY2FsbF9maW5pc2goR19EQlVTX0NPTk5FQ1RJT04oc291cmNlKSwgcmVz dWx0LCAmZXJyb3Iub3V0UHRyKCkpKTsKKyAgICAgICAgICAgIGlmICghcmVzdWx0VmFyaWFudCAm JiAhZ19lcnJvcl9tYXRjaGVzKGVycm9yLmdldCgpLCBHX0lPX0VSUk9SLCBHX0lPX0VSUk9SX0NB TkNFTExFRCkpIHsKKyAgICAgICAgICAgICAgICBhdXRvIHJlc3BvbnNlSGFuZGxlciA9IG1lc3Nh Z2VDb250ZXh0LT5ob3N0LT5tX2NvbW1hbmRSZXF1ZXN0cy50YWtlKG1lc3NhZ2VDb250ZXh0LT5t ZXNzYWdlSUQpOworICAgICAgICAgICAgICAgIGlmIChyZXNwb25zZUhhbmRsZXIpIHsKKyAgICAg ICAgICAgICAgICAgICAgYXV0byBlcnJvck9iamVjdCA9IEpTT046Ok9iamVjdDo6Y3JlYXRlKCk7 CisgICAgICAgICAgICAgICAgICAgIGVycm9yT2JqZWN0LT5zZXRJbnRlZ2VyKEFTQ0lJTGl0ZXJh bCgiY29kZSIpLCAtMzI2MDMpOworICAgICAgICAgICAgICAgICAgICBlcnJvck9iamVjdC0+c2V0 U3RyaW5nKEFTQ0lJTGl0ZXJhbCgibWVzc2FnZSIpLCBTdHJpbmc6OmZyb21VVEY4KGVycm9yLT5t ZXNzYWdlKSk7CisgICAgICAgICAgICAgICAgICAgIHJlc3BvbnNlSGFuZGxlcih7IFdURk1vdmUo ZXJyb3JPYmplY3QpLCB0cnVlIH0pOworICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgIH0K KyAgICAgICAgfSwgbWVzc2FnZUNvbnRleHQucmVsZWFzZSgpKTsKIH0KIAogfSAvLyBuYW1lc3Bh Y2UgV2ViRHJpdmVyCg==