182167 2018-01-26 01:37:29 -0800 WebDriver: timeouts value and cookie expiry should be limited to max safe integer 2018-01-26 01:52:29 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg webkit-bug-importer zan oldest_to_newest 1393475 0 cgarcia 2018-01-26 01:37:29 -0800 This changed recently in the spec: https://github.com/w3c/webdriver/pull/1210 Our implementation was wrong in any case since we are limiting to INT_MAX. 1393477 1 332360 cgarcia 2018-01-26 01:44:34 -0800 Created attachment 332360 Patch 1393478 2 cgarcia 2018-01-26 01:51:06 -0800 Committed r227671: <https://trac.webkit.org/changeset/227671> 1393481 3 webkit-bug-importer 2018-01-26 01:52:29 -0800 <rdar://problem/36903286> 332360 2018-01-26 01:44:34 -0800 2018-01-26 01:48:18 -0800 Patch wd-timeouts-limit.diff text/plain 6394 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKaW5kZXggOWYyMDgzY2QwNWEuLjEzOTY0YmNkMWI4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDI0IEBACisyMDE4LTAxLTI2ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJEcml2ZXI6IHRpbWVvdXRzIHZhbHVlIGFu ZCBjb29raWUgZXhwaXJ5IHNob3VsZCBiZSBsaW1pdGVkIHRvIG1heCBzYWZlIGludGVnZXIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjE2NworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgY2hhbmdl ZCByZWNlbnRseSBpbiB0aGUgc3BlYywgYnV0IG91ciBpbXBsZW1lbnRhdGlvbiB3YXMgd3Jvbmcg aW4gYW55IGNhc2Ugc2luY2Ugd2Ugd2VyZSBsaW1pdGluZyB0bworICAgICAgICBJTlRfTUFYLiBV c2UgdmFsdWVBc051bWJlckluUmFuZ2UoKSB0byBlbnN1cmUgd2UgZ2V0IGEgdmFsaWQgZG91Ymxl IHZhbHVlIGluIHRoZSBnaXZlbiByYW5nZSwgYW5kIHRoZW4gY29udmVydAorICAgICAgICB0byB1 bnNpZ25lZCBpZiBpdCdzIGEgdmFsaWQgaW50ZWdlci4KKworICAgICAgICBGaXhlczogaW1wb3J0 ZWQvdzNjL3dlYmRyaXZlci90ZXN0cy9zZXNzaW9ucy9uZXdfc2Vzc2lvbi9jcmVhdGVfZmlyc3RN YXRjaC5weTo6dGVzdF92YWxpZFt0aW1lb3V0cy12YWx1ZTEwXQorICAgICAgICAgICAgICAgaW1w b3J0ZWQvdzNjL3dlYmRyaXZlci90ZXN0cy9zZXNzaW9ucy9uZXdfc2Vzc2lvbi9jcmVhdGVfYWx3 YXlzTWF0Y2gucHk6OnRlc3RfdmFsaWRbdGltZW91dHMtdmFsdWUxMF0KKworICAgICAgICAqIFNl c3Npb24uaDoKKyAgICAgICAgKiBXZWJEcml2ZXJTZXJ2aWNlLmNwcDoKKyAgICAgICAgKFdlYkRy aXZlcjo6dmFsdWVBc051bWJlckluUmFuZ2UpOgorICAgICAgICAoV2ViRHJpdmVyOjp1bnNpZ25l ZFZhbHVlKToKKyAgICAgICAgKFdlYkRyaXZlcjo6ZGVzZXJpYWxpemVUaW1lb3V0cyk6CisgICAg ICAgIChXZWJEcml2ZXI6OmRlc2VyaWFsaXplQ29va2llKToKKwogMjAxOC0wMS0yNSAgQ2FybG9z IEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgV2ViRHJpdmVy OiB0ZXN0IGltcG9ydGVkL3czYy93ZWJkcml2ZXIvdGVzdHMvc2Vzc2lvbnMvbmV3X3Nlc3Npb24v bWVyZ2UucHk6OnRlc3RfbWVyZ2VfYnJvd3Nlck5hbWUgZmFpbHMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJEcml2ZXIvU2Vzc2lvbi5oIGIvU291cmNlL1dlYkRyaXZlci9TZXNzaW9uLmgKaW5kZXgg MDNmNzdkZjA3M2MuLjY1ZDNmZmJjM2RhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViRHJpdmVyL1Nl c3Npb24uaAorKysgYi9Tb3VyY2UvV2ViRHJpdmVyL1Nlc3Npb24uaApAQCAtNjIsNyArNjIsNyBA QCBwdWJsaWM6CiAgICAgICAgIHN0ZDo6b3B0aW9uYWw8U3RyaW5nPiBkb21haW47CiAgICAgICAg IHN0ZDo6b3B0aW9uYWw8Ym9vbD4gc2VjdXJlOwogICAgICAgICBzdGQ6Om9wdGlvbmFsPGJvb2w+ IGh0dHBPbmx5OwotICAgICAgICBzdGQ6Om9wdGlvbmFsPHVuc2lnbmVkPiBleHBpcnk7CisgICAg ICAgIHN0ZDo6b3B0aW9uYWw8dWludDY0X3Q+IGV4cGlyeTsKICAgICB9OwogCiAgICAgdm9pZCB3 YWl0Rm9yTmF2aWdhdGlvblRvQ29tcGxldGUoRnVuY3Rpb248dm9pZCAoQ29tbWFuZFJlc3VsdCYm KT4mJik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViRHJpdmVyL1dlYkRyaXZlclNlcnZpY2UuY3Bw IGIvU291cmNlL1dlYkRyaXZlci9XZWJEcml2ZXJTZXJ2aWNlLmNwcAppbmRleCBlMWRjODNjMTc5 Mi4uMzkzNDA3MGM4NjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJEcml2ZXIvV2ViRHJpdmVyU2Vy dmljZS5jcHAKKysrIGIvU291cmNlL1dlYkRyaXZlci9XZWJEcml2ZXJTZXJ2aWNlLmNwcApAQCAt MzQsNiArMzQsOSBAQAogCiBuYW1lc3BhY2UgV2ViRHJpdmVyIHsKIAorLy8gaHR0cHM6Ly93M2Mu Z2l0aHViLmlvL3dlYmRyaXZlci93ZWJkcml2ZXItc3BlYy5odG1sI2Rmbi1tYXhpbXVtLXNhZmUt aW50ZWdlcgorc3RhdGljIGNvbnN0IGRvdWJsZSBtYXhTYWZlSW50ZWdlciA9IDkwMDcxOTkyNTQ3 NDA5OTEuMDsgLy8gMiBeIDUzIC0gMQorCiBXZWJEcml2ZXJTZXJ2aWNlOjpXZWJEcml2ZXJTZXJ2 aWNlKCkKICAgICA6IG1fc2VydmVyKCp0aGlzKQogewpAQCAtMjcyLDIwICsyNzUsMzUgQEAgdm9p ZCBXZWJEcml2ZXJTZXJ2aWNlOjpzZW5kUmVzcG9uc2UoRnVuY3Rpb248dm9pZCAoSFRUUFJlcXVl c3RIYW5kbGVyOjpSZXNwb25zZSYKICAgICByZXBseUhhbmRsZXIoeyByZXN1bHQuaHR0cFN0YXR1 c0NvZGUoKSwgcmVzcG9uc2VPYmplY3QtPnRvSlNPTlN0cmluZygpLnV0ZjgoKSwgQVNDSUlMaXRl cmFsKCJhcHBsaWNhdGlvbi9qc29uOyBjaGFyc2V0PXV0Zi04IikgfSk7CiB9CiAKLXN0YXRpYyBi b29sIGludGVnZXJWYWx1ZShKU09OOjpWYWx1ZSYgdmFsdWUsIGludCYgb3V0cHV0KQorc3RhdGlj IHN0ZDo6b3B0aW9uYWw8ZG91YmxlPiB2YWx1ZUFzTnVtYmVySW5SYW5nZShjb25zdCBKU09OOjpW YWx1ZSYgdmFsdWUsIGRvdWJsZSBtaW5BbGxvd2VkID0gMCwgZG91YmxlIG1heEFsbG93ZWQgPSBz dGQ6Om51bWVyaWNfbGltaXRzPGludD46Om1heCgpKQogewotICAgIC8vIEJhaWwgaWYgYW4gaW50 ZWdlciB2YWx1ZSBjYW5ub3QgYmUgcmV0cmlldmVkLgotICAgIGlmICghdmFsdWUuYXNJbnRlZ2Vy KG91dHB1dCkpCi0gICAgICAgIHJldHVybiBmYWxzZTsKKyAgICBkb3VibGUgbnVtYmVyOworICAg IGlmICghdmFsdWUuYXNEb3VibGUobnVtYmVyKSkKKyAgICAgICAgcmV0dXJuIHN0ZDo6bnVsbG9w dDsKKworICAgIGlmIChzdGQ6OmlzbmFuKG51bWJlcikgfHwgc3RkOjppc2luZihudW1iZXIpKQor ICAgICAgICByZXR1cm4gc3RkOjpudWxsb3B0OworCisgICAgaWYgKG51bWJlciA8IG1pbkFsbG93 ZWQgfHwgbnVtYmVyID4gbWF4QWxsb3dlZCkKKyAgICAgICAgcmV0dXJuIHN0ZDo6bnVsbG9wdDsK KworICAgIHJldHVybiBudW1iZXI7Cit9CiAKK3N0YXRpYyBzdGQ6Om9wdGlvbmFsPHVpbnQ2NF90 PiB1bnNpZ25lZFZhbHVlKEpTT046OlZhbHVlJiB2YWx1ZSkKK3sKKyAgICBhdXRvIG51bWJlciA9 IHZhbHVlQXNOdW1iZXJJblJhbmdlKHZhbHVlLCAwLCBtYXhTYWZlSW50ZWdlcik7CisgICAgaWYg KCFudW1iZXIpCisgICAgICAgIHJldHVybiBzdGQ6Om51bGxvcHQ7CisKKyAgICBhdXRvIGludFZh bHVlID0gc3RhdGljX2Nhc3Q8dWludDY0X3Q+KG51bWJlci52YWx1ZSgpKTsKICAgICAvLyBJZiB0 aGUgY29udGFpbmVkIHZhbHVlIGlzIGEgZG91YmxlLCBiYWlsIGluIGNhc2UgaXQgZG9lc24ndCBt YXRjaCB0aGUgaW50ZWdlcgogICAgIC8vIHZhbHVlLCBpLmUuIGlmIHRoZSBkb3VibGUgdmFsdWUg d2FzIG5vdCBvcmlnaW5hbGx5IGluIGludGVnZXIgZm9ybS4KICAgICAvLyBodHRwczovL3czYy5n aXRodWIuaW8vd2ViZHJpdmVyL3dlYmRyaXZlci1zcGVjLmh0bWwjZGZuLWludGVnZXIKLSAgICBk b3VibGUgZG91YmxlVmFsdWU7Ci0gICAgaWYgKHZhbHVlLmFzRG91YmxlKGRvdWJsZVZhbHVlKSAm JiBkb3VibGVWYWx1ZSAhPSBvdXRwdXQpCi0gICAgICAgIHJldHVybiBmYWxzZTsKKyAgICBpZiAo bnVtYmVyLnZhbHVlKCkgIT0gaW50VmFsdWUpCisgICAgICAgIHJldHVybiBzdGQ6Om51bGxvcHQ7 CiAKLSAgICByZXR1cm4gdHJ1ZTsKKyAgICByZXR1cm4gaW50VmFsdWU7CiB9CiAKIHN0YXRpYyBz dGQ6Om9wdGlvbmFsPFRpbWVvdXRzPiBkZXNlcmlhbGl6ZVRpbWVvdXRzKEpTT046Ok9iamVjdCYg dGltZW91dHNPYmplY3QpCkBAIC0yOTgsMTYgKzMxNiwxNyBAQCBzdGF0aWMgc3RkOjpvcHRpb25h bDxUaW1lb3V0cz4gZGVzZXJpYWxpemVUaW1lb3V0cyhKU09OOjpPYmplY3QmIHRpbWVvdXRzT2Jq ZWN0KQogICAgICAgICBpZiAoaXQtPmtleSA9PSAic2Vzc2lvbklkIikKICAgICAgICAgICAgIGNv bnRpbnVlOwogCi0gICAgICAgIGludCB0aW1lb3V0TVM7Ci0gICAgICAgIGlmICghaW50ZWdlclZh bHVlKCppdC0+dmFsdWUsIHRpbWVvdXRNUykgfHwgdGltZW91dE1TIDwgMCB8fCB0aW1lb3V0TVMg PiBJTlRfTUFYKQorICAgICAgICAvLyBJZiB2YWx1ZSBpcyBub3QgYW4gaW50ZWdlciwgb3IgaXQg aXMgbGVzcyB0aGFuIDAgb3IgZ3JlYXRlciB0aGFuIHRoZSBtYXhpbXVtIHNhZmUgaW50ZWdlciwg cmV0dXJuIGVycm9yIHdpdGggZXJyb3IgY29kZSBpbnZhbGlkIGFyZ3VtZW50LgorICAgICAgICBh dXRvIHRpbWVvdXRNUyA9IHVuc2lnbmVkVmFsdWUoKml0LT52YWx1ZSk7CisgICAgICAgIGlmICgh dGltZW91dE1TKQogICAgICAgICAgICAgcmV0dXJuIHN0ZDo6bnVsbG9wdDsKIAogICAgICAgICBp ZiAoaXQtPmtleSA9PSAic2NyaXB0IikKLSAgICAgICAgICAgIHRpbWVvdXRzLnNjcmlwdCA9IFNl Y29uZHM6OmZyb21NaWxsaXNlY29uZHModGltZW91dE1TKTsKKyAgICAgICAgICAgIHRpbWVvdXRz LnNjcmlwdCA9IFNlY29uZHM6OmZyb21NaWxsaXNlY29uZHModGltZW91dE1TLnZhbHVlKCkpOwog ICAgICAgICBlbHNlIGlmIChpdC0+a2V5ID09ICJwYWdlTG9hZCIpCi0gICAgICAgICAgICB0aW1l b3V0cy5wYWdlTG9hZCA9IFNlY29uZHM6OmZyb21NaWxsaXNlY29uZHModGltZW91dE1TKTsKKyAg ICAgICAgICAgIHRpbWVvdXRzLnBhZ2VMb2FkID0gU2Vjb25kczo6ZnJvbU1pbGxpc2Vjb25kcyh0 aW1lb3V0TVMudmFsdWUoKSk7CiAgICAgICAgIGVsc2UgaWYgKGl0LT5rZXkgPT0gImltcGxpY2l0 IikKLSAgICAgICAgICAgIHRpbWVvdXRzLmltcGxpY2l0ID0gU2Vjb25kczo6ZnJvbU1pbGxpc2Vj b25kcyh0aW1lb3V0TVMpOworICAgICAgICAgICAgdGltZW91dHMuaW1wbGljaXQgPSBTZWNvbmRz Ojpmcm9tTWlsbGlzZWNvbmRzKHRpbWVvdXRNUy52YWx1ZSgpKTsKICAgICAgICAgZWxzZQogICAg ICAgICAgICAgcmV0dXJuIHN0ZDo6bnVsbG9wdDsKICAgICB9CkBAIC04OTMsMjEgKzkxMiw2IEBA IHZvaWQgV2ViRHJpdmVyU2VydmljZTo6Z2V0V2luZG93UmVjdChSZWZQdHI8SlNPTjo6T2JqZWN0 PiYmIHBhcmFtZXRlcnMsIEZ1bmN0aW9uCiAgICAgICAgIG1fc2Vzc2lvbi0+Z2V0V2luZG93UmVj dChXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKSk7CiB9CiAKLXN0YXRpYyBzdGQ6Om9wdGlvbmFs PGRvdWJsZT4gdmFsdWVBc051bWJlckluUmFuZ2UoY29uc3QgSlNPTjo6VmFsdWUmIHZhbHVlLCBk b3VibGUgbWluQWxsb3dlZCA9IDAsIGRvdWJsZSBtYXhBbGxvd2VkID0gSU5UX01BWCkKLXsKLSAg ICBkb3VibGUgbnVtYmVyOwotICAgIGlmICghdmFsdWUuYXNEb3VibGUobnVtYmVyKSkKLSAgICAg ICAgcmV0dXJuIHN0ZDo6bnVsbG9wdDsKLQotICAgIGlmIChzdGQ6OmlzbmFuKG51bWJlcikgfHwg c3RkOjppc2luZihudW1iZXIpKQotICAgICAgICByZXR1cm4gc3RkOjpudWxsb3B0OwotCi0gICAg aWYgKG51bWJlciA8IG1pbkFsbG93ZWQgfHwgbnVtYmVyID4gbWF4QWxsb3dlZCkKLSAgICAgICAg cmV0dXJuIHN0ZDo6bnVsbG9wdDsKLQotICAgIHJldHVybiBudW1iZXI7Ci19Ci0KIHZvaWQgV2Vi RHJpdmVyU2VydmljZTo6c2V0V2luZG93UmVjdChSZWZQdHI8SlNPTjo6T2JqZWN0PiYmIHBhcmFt ZXRlcnMsIEZ1bmN0aW9uPHZvaWQgKENvbW1hbmRSZXN1bHQmJik+JiYgY29tcGxldGlvbkhhbmRs ZXIpCiB7CiAgICAgLy8gwqcxMC43LjIgU2V0IFdpbmRvdyBSZWN0LgpAQCAtMTUwNCwxMSArMTUw OCwxMCBAQCBzdGF0aWMgc3RkOjpvcHRpb25hbDxTZXNzaW9uOjpDb29raWU+IGRlc2VyaWFsaXpl Q29va2llKEpTT046Ok9iamVjdCYgY29va2llT2JqZQogICAgICAgICBjb29raWUuaHR0cE9ubHkg PSBodHRwT25seTsKICAgICB9CiAgICAgaWYgKGNvb2tpZU9iamVjdC5nZXRWYWx1ZShBU0NJSUxp dGVyYWwoImV4cGlyeSIpLCB2YWx1ZSkpIHsKLSAgICAgICAgaW50IGV4cGlyeTsKLSAgICAgICAg aWYgKCF2YWx1ZS0+YXNJbnRlZ2VyKGV4cGlyeSkgfHwgZXhwaXJ5IDwgMCB8fCBleHBpcnkgPiBJ TlRfTUFYKQorICAgICAgICBhdXRvIGV4cGlyeSA9IHVuc2lnbmVkVmFsdWUoKnZhbHVlKTsKKyAg ICAgICAgaWYgKCFleHBpcnkpCiAgICAgICAgICAgICByZXR1cm4gc3RkOjpudWxsb3B0OwotCi0g ICAgICAgIGNvb2tpZS5leHBpcnkgPSBzdGF0aWNfY2FzdDx1bnNpZ25lZD4oZXhwaXJ5KTsKKyAg ICAgICAgY29va2llLmV4cGlyeSA9IGV4cGlyeS52YWx1ZSgpOwogICAgIH0KIAogICAgIHJldHVy biBjb29raWU7Cg==