182164 2018-01-25 20:52:28 -0800 Web Inspector: Network Table: Sort indicator is not displayed when sorted column is hidden and re-shown 2018-01-25 21:30:36 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1393417 0 joepeck 2018-01-25 20:52:28 -0800 Network Table: Sort indicator is not displayed when sorted column is hidden and re-shown Steps to Reproduce: 1. Inspect <https://webkit.org> 2. Show Network Tab 3. Sort by Domain column 4. Hide the Domain column 5. Show the Domain column => Expected sort indicator, but there is none Notes: • showColumn needs to re-add the sort class names if this was the active sort column 1393418 1 joepeck 2018-01-25 20:52:34 -0800 <rdar://problem/36892619> 1393419 2 332349 joepeck 2018-01-25 20:53:27 -0800 Created attachment 332349 [PATCH] Proposed Fix 1393421 3 332349 bburg 2018-01-25 20:55:00 -0800 Comment on attachment 332349 [PATCH] Proposed Fix r=me 1393440 4 332349 commit-queue 2018-01-25 21:30:34 -0800 Comment on attachment 332349 [PATCH] Proposed Fix Clearing flags on attachment: 332349 Committed r227667: <https://trac.webkit.org/changeset/227667> 1393441 5 commit-queue 2018-01-25 21:30:36 -0800 All reviewed patches have been landed. Closing bug. 332349 2018-01-25 20:53:27 -0800 2018-01-25 21:30:34 -0800 [PATCH] Proposed Fix sort-on-show-1.patch text/plain 1830 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDYxMjRiODE3ZTI3Li43ZmU2OTRkODEzNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMTgtMDEtMjUgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9y OiBOZXR3b3JrIFRhYmxlOiBTb3J0IGluZGljYXRvciBpcyBub3QgZGlzcGxheWVkIHdoZW4gc29y dGVkIGNvbHVtbiBpcyBoaWRkZW4gYW5kIHJlLXNob3duCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODIxNjQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzM2ODkyNjE5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UYWJsZS5qczoKKyAgICAgICAgKFdJLlRhYmxlLnBy b3RvdHlwZS5zaG93Q29sdW1uKToKKyAgICAgICAgUmUtYWRkIHRoZSBzb3J0IGNsYXNzZXMgaWYg dGhlIGNvbHVtbiBiZWluZyBzaG93biBpcyB0aGUgYWN0aXZlIHNvcnQgY29sdW1uLgorCisyMDE4 LTAxLTI1ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAg V2ViIEluc3BlY3RvcjogTmV0d29yayAtIENvb2tpZXMgdmlldyBzaG91bGQgYmVoYXZlIGJldHRl ciBhdCBuYXJyb3cgd2lkdGhzLCBhbGwgZGF0YSBpcyBoaWRkZW4KICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjE2MwogICAgICAgICA8cmRhcjovL3By b2JsZW0vMzY4OTMyNDE+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9UYWJsZS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1RhYmxlLmpzCmluZGV4IGZhM2I0ODU4NDQ0Li5jMjYzMjM5OTBiZiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFibGUuanMK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFibGUuanMK QEAgLTM5NCw2ICszOTQsMTIgQEAgV0kuVGFibGUgPSBjbGFzcyBUYWJsZSBleHRlbmRzIFdJLlZp ZXcKICAgICAgICAgaWYgKGNvbHVtbi5oZWFkZXJWaWV3KQogICAgICAgICAgICAgdGhpcy5hZGRT dWJ2aWV3KGNvbHVtbi5oZWFkZXJWaWV3KTsKIAorICAgICAgICBpZiAodGhpcy5fc29ydENvbHVt bklkZW50aWZpZXIgPT09IGNvbHVtbi5pZGVudGlmaWVyKSB7CisgICAgICAgICAgICBsZXQgaGVh ZGVyQ2VsbCA9IHRoaXMuX2hlYWRlckVsZW1lbnQuY2hpbGRyZW5bbmV3Q29sdW1uSW5kZXhdOwor ICAgICAgICAgICAgaGVhZGVyQ2VsbC5jbGFzc0xpc3QudG9nZ2xlKCJzb3J0LWFzY2VuZGluZyIs IHRoaXMuX3NvcnRPcmRlciA9PT0gV0kuVGFibGUuU29ydE9yZGVyLkFzY2VuZGluZyk7CisgICAg ICAgICAgICBoZWFkZXJDZWxsLmNsYXNzTGlzdC50b2dnbGUoInNvcnQtZGVzY2VuZGluZyIsIHRo aXMuX3NvcnRPcmRlciA9PT0gV0kuVGFibGUuU29ydE9yZGVyLkRlc2NlbmRpbmcpOworICAgICAg ICB9CisKICAgICAgICAgLy8gV2UgaGF2ZW4ndCB5ZXQgZG9uZSBhbnkgbGF5b3V0LCBub3RoaW5n IHRvIGRvLgogICAgICAgICBpZiAoIXRoaXMuX2NvbHVtbldpZHRocykKICAgICAgICAgICAgIHJl dHVybjsK