182162 2018-01-25 20:09:59 -0800 Web Inspector: "Displayed Columns" should not be displayed in context menu if all columns are required columns 2018-01-25 20:58:39 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1393407 0 joepeck 2018-01-25 20:09:59 -0800 "Displayed Columns" should not be displayed in context menu if all columns are required columns * Steps to reproduce 1. Inspect <http://webkit.org> 2. Show Network Tab 3. Select a resource with cookie data (reload if needed) 4. Select the Cookie tab 5. Right-click the column header for Request Cookies => Context menu should not have "Displayed Columns" header since no columns can be toggled 1393408 1 joepeck 2018-01-25 20:10:10 -0800 <rdar://problem/36893758> 1393409 2 332347 joepeck 2018-01-25 20:14:26 -0800 Created attachment 332347 [PATCH] Proposed Fix 1393413 3 332347 mattbaker 2018-01-25 20:35:12 -0800 Comment on attachment 332347 [PATCH] Proposed Fix r=me 1393422 4 332347 commit-queue 2018-01-25 20:58:38 -0800 Comment on attachment 332347 [PATCH] Proposed Fix Clearing flags on attachment: 332347 Committed r227652: <https://trac.webkit.org/changeset/227652> 1393423 5 commit-queue 2018-01-25 20:58:39 -0800 All reviewed patches have been landed. Closing bug. 332347 2018-01-25 20:14:26 -0800 2018-01-25 20:58:38 -0800 [PATCH] Proposed Fix hideable-1.patch text/plain 2037 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGZkMGNiZWRlZjhlLi40MGFlODIxMGFkMiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMDEtMjUgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiAiRGlzcGxheWVkIENvbHVtbnMiIHNob3VsZCBub3QgYmUgZGlzcGxheWVkIGluIGNvbnRleHQg bWVudSBpZiBhbGwgY29sdW1ucyBhcmUgcmVxdWlyZWQgY29sdW1ucworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyMTYyCisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS8zNjg5Mzc1OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGFibGUuanM6CisgICAgICAgIChXSS5U YWJsZS5wcm90b3R5cGUuX2hhbmRsZUhlYWRlckNvbnRleHRNZW51KToKKyAgICAgICAgT25seSBh ZGQgdGhlIGhlYWRlciBjb2x1bW4gd2hlbiB3ZSBrbm93IHRoZXJlIGFyZSBoaWRlYWJsZSBjb2x1 bW5zLgorCiAyMDE4LTAxLTI0ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogU2ltcGxpZnkgdXBkYXRlLUxlZ2FjeUluc3BlY3Rv ckJhY2tlbmRDb21tYW5kcy5yYgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvVGFibGUuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9UYWJsZS5qcwppbmRleCA4Njk5NmFmYzJjNy4uZmEzYjQ4NTg0NDQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYmxl LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYmxl LmpzCkBAIC0xMjUwLDggKzEyNTAsNyBAQCBXSS5UYWJsZSA9IGNsYXNzIFRhYmxlIGV4dGVuZHMg V0kuVmlldwogCiAgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZFNlcGFyYXRvcigpOwogCi0gICAg ICAgIGNvbnN0IGRpc2FibGVkID0gdHJ1ZTsKLSAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kSXRl bShXSS5VSVN0cmluZygiRGlzcGxheWVkIENvbHVtbnMiKSwgKCkgPT4ge30sIGRpc2FibGVkKTsK KyAgICAgICAgbGV0IGRpZEFwcGVuZEhlYWRlckl0ZW0gPSBmYWxzZTsKIAogICAgICAgICBmb3Ig KGxldCBbY29sdW1uSWRlbnRpZmllciwgY29sdW1uXSBvZiB0aGlzLl9jb2x1bW5TcGVjcykgewog ICAgICAgICAgICAgaWYgKGNvbHVtbi5sb2NrZWQpCkBAIC0xMjU5LDYgKzEyNTgsMTMgQEAgV0ku VGFibGUgPSBjbGFzcyBUYWJsZSBleHRlbmRzIFdJLlZpZXcKICAgICAgICAgICAgIGlmICghY29s dW1uLmhpZGVhYmxlKQogICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogCisgICAgICAgICAgICAv LyBBZGQgYSBoZWFkZXIgaXRlbSBiZWZvcmUgdGhlIGxpc3Qgb2YgdG9nZ2xlYWJsZSBjb2x1bW5z LgorICAgICAgICAgICAgaWYgKCFkaWRBcHBlbmRIZWFkZXJJdGVtKSB7CisgICAgICAgICAgICAg ICAgY29uc3QgZGlzYWJsZWQgPSB0cnVlOworICAgICAgICAgICAgICAgIGNvbnRleHRNZW51LmFw cGVuZEl0ZW0oV0kuVUlTdHJpbmcoIkRpc3BsYXllZCBDb2x1bW5zIiksICgpID0+IHt9LCBkaXNh YmxlZCk7CisgICAgICAgICAgICAgICAgZGlkQXBwZW5kSGVhZGVySXRlbSA9IHRydWU7CisgICAg ICAgICAgICB9CisKICAgICAgICAgICAgIGxldCBjaGVja2VkID0gIWNvbHVtbi5oaWRkZW47CiAg ICAgICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRDaGVja2JveEl0ZW0oY29sdW1uLm5hbWUsICgp ID0+IHsKICAgICAgICAgICAgICAgICBpZiAoY29sdW1uLmhpZGRlbikK