182157 2018-01-25 16:28:13 -0800 [YarrJIT][ARM] We need to save r8 as it is the initial start register 2018-02-13 14:44:18 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Other Linux RESOLVED FIXED InRadar P2 Normal --- 1 guijemont webkit-unassigned commit-queue dominik.infuehr ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1393348 0 guijemont 2018-01-25 16:28:13 -0800 We still need to keep on saving r6 as it is used by the MacroAssembler, which we use (we get crashes in some situations otherwise). This issue was discovered because stress/regress-174044.js crashes on a raspberry pi 2 when compiled in -O2. 1393350 1 332334 guijemont 2018-01-25 16:32:25 -0800 Created attachment 332334 Patch Patch fixing the issue. 1393993 2 332334 saam 2018-01-28 23:56:09 -0800 Comment on attachment 332334 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332334&action=review > Source/JavaScriptCore/ChangeLog:8 > + We still need to keep on saving r6 as it is used by the MacroAssembler you mean r8, not r6? 1394072 3 332334 guijemont 2018-01-29 07:42:32 -0800 Comment on attachment 332334 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332334&action=review >> Source/JavaScriptCore/ChangeLog:8 >> + We still need to keep on saving r6 as it is used by the MacroAssembler > > you mean r8, not r6? Sorry, I meant that in addition to saving $r8, as the title suggest, we can't stop saving $r6, as I initially wrongly deducted in a first version of the patch that was creating weird crashes :). My initial wrong deduction was because the initial register used to be $r6 before #182157. 1394169 4 332334 saam 2018-01-29 11:02:39 -0800 Comment on attachment 332334 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332334&action=review >>> Source/JavaScriptCore/ChangeLog:8 >>> + We still need to keep on saving r6 as it is used by the MacroAssembler >> >> you mean r8, not r6? > > Sorry, I meant that in addition to saving $r8, as the title suggest, we can't stop saving $r6, as I initially wrongly deducted in a first version of the patch that was creating weird crashes :). My initial wrong deduction was because the initial register used to be $r6 before #182157. Probably worth rewording this to reflect what the patch is actually doing. 1398746 5 333719 guijemont 2018-02-13 13:34:25 -0800 Created attachment 333719 Patch New patch with a more explicit ChangeLog message. Sorry it took me a while to get to it. 1398787 6 333719 commit-queue 2018-02-13 14:43:20 -0800 Comment on attachment 333719 Patch Clearing flags on attachment: 333719 Committed r228436: <https://trac.webkit.org/changeset/228436> 1398788 7 commit-queue 2018-02-13 14:43:22 -0800 All reviewed patches have been landed. Closing bug. 1398791 8 webkit-bug-importer 2018-02-13 14:44:18 -0800 <rdar://problem/37514115> 332334 2018-01-25 16:32:25 -0800 2018-02-13 13:34:22 -0800 Patch bug-182157-20180125183225.patch text/plain 1886 guijemont U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3NDI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh NWY2MzdlNGU5MWZjZjA3MzJhNWNiYzIwOGMxZjExYzQ2ODJkMDY1Li5lMWYxYmY2YTNkMzY1NDIw N2ZlMWVkODY2NzNkYWYzZmEzMmZhYTY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxOC0wMS0yNSAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250QGlnYWxp YS5jb20+CisKKyAgICAgICAgW1lhcnJKSVRdW0FSTV0gV2UgbmVlZCB0byBzYXZlIHI4IGFzIGl0 IGlzIHRoZSBpbml0aWFsIHN0YXJ0IHJlZ2lzdGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODIxNTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZSBzdGlsbCBuZWVkIHRvIGtlZXAgb24gc2F2aW5nIHI2 IGFzIGl0IGlzIHVzZWQgYnkgdGhlIE1hY3JvQXNzZW1ibGVyCisgICAgICAgIHdoaWNoIHdlIHVz ZSAod2UgZ2V0IGNyYXNoZXMgaW4gc29tZSBzaXR1YXRpb25zIG90aGVyd2lzZSkuCisgICAgICAg IFRoaXMgaXNzdWUgd2FzIGRpc2NvdmVyZWQgYmVjYXVzZSBzdHJlc3MvcmVncmVzcy0xNzQwNDQu anMgY3Jhc2hlcyBvbgorICAgICAgICBhIHJhc3BiZXJyeSBwaSAyIHdoZW4gY29tcGlsZWQgaW4g LU8yLgorCisgICAgICAgICogeWFyci9ZYXJySklULmNwcDoKKyAgICAgICAgKEpTQzo6WWFycjo6 WWFyckdlbmVyYXRvcjo6Z2VuZXJhdGVFbnRlcik6CisgICAgICAgIChKU0M6OllhcnI6OllhcnJH ZW5lcmF0b3I6OmdlbmVyYXRlUmV0dXJuKToKKwogMjAxOC0wMS0yMyAgRmlsaXAgUGl6bG8gIDxm cGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEpTQyBzaG91bGQgdXNlIGEgc3BlY3VsYXRpb24g ZmVuY2Ugb24gVk0gZW50cnkvZXhpdApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3lhcnIvWWFyckpJVC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUveWFyci9ZYXJySklULmNw cAppbmRleCAwM2ZjMDZkZDdkZmEyM2YzMjU0ZjNmNDI1ODZiOGY1YzU2NmU1MzQ3Li4zZjliODE2 YWEzODQwZmI5NTNmNDE2OTNiNTE0MDc4MzYwMWQ5ZmI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUveWFyci9ZYXJySklULmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv eWFyci9ZYXJySklULmNwcApAQCAtMzMzNiw2ICszMzM2LDcgQEAgY2xhc3MgWWFyckdlbmVyYXRv ciA6IHByaXZhdGUgTWFjcm9Bc3NlbWJsZXIgewogICAgICAgICBwdXNoKEFSTVJlZ2lzdGVyczo6 cjQpOwogICAgICAgICBwdXNoKEFSTVJlZ2lzdGVyczo6cjUpOwogICAgICAgICBwdXNoKEFSTVJl Z2lzdGVyczo6cjYpOworICAgICAgICBwdXNoKEFSTVJlZ2lzdGVyczo6cjgpOwogI2VsaWYgQ1BV KE1JUFMpCiAgICAgICAgIC8vIERvIG5vdGhpbmcuCiAjZW5kaWYKQEAgLTMzODMsNiArMzM4NCw3 IEBAIGNsYXNzIFlhcnJHZW5lcmF0b3IgOiBwcml2YXRlIE1hY3JvQXNzZW1ibGVyIHsKICAgICAg ICAgaWYgKG1fZGVjb2RlU3Vycm9nYXRlUGFpcnMpCiAgICAgICAgICAgICBwb3BQYWlyKGZyYW1l UG9pbnRlclJlZ2lzdGVyLCBsaW5rUmVnaXN0ZXIpOwogI2VsaWYgQ1BVKEFSTSkKKyAgICAgICAg cG9wKEFSTVJlZ2lzdGVyczo6cjgpOwogICAgICAgICBwb3AoQVJNUmVnaXN0ZXJzOjpyNik7CiAg ICAgICAgIHBvcChBUk1SZWdpc3RlcnM6OnI1KTsKICAgICAgICAgcG9wKEFSTVJlZ2lzdGVyczo6 cjQpOwo= 333719 2018-02-13 13:34:25 -0800 2018-02-13 14:43:20 -0800 Patch bug-182157-20180213153424.patch text/plain 2063 guijemont U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3NDI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh NWY2MzdlNGU5MWZjZjA3MzJhNWNiYzIwOGMxZjExYzQ2ODJkMDY1Li4zYmQyNzc4NjIyNjhjODJi OTMwMzk4YTY4YTFkN2MzZGZhMjc2NGIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxOC0wMS0yNSAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250QGlnYWxp YS5jb20+CisKKyAgICAgICAgW1lhcnJKSVRdW0FSTV0gV2UgbmVlZCB0byBzYXZlIHI4IGFzIGl0 IGlzIHRoZSBpbml0aWFsIHN0YXJ0IHJlZ2lzdGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODIxNTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZWdpc3RlciByOCBpcyB0aGUgaW5pdGlhbCBzdGFydCBy ZWdpc3RlciBzaW5jZSByMjI0MTcyLCBzbyB3ZSBuZWVkIHRvCisgICAgICAgIHNhdmUgaXQuIFdl IHN0aWxsIG5lZWQgdG8gc2F2ZSByNiBhcyB3ZWxsIGV2ZW4gdGhvdWdoIGl0IGlzIG5vdCB0aGUK KyAgICAgICAgaW5pdGlhbCBzdGFydCByZWdpc3RlciBhbnkgbW9yZSwgc2luY2UgaXQgaXMgdXNl ZCBieSB0aGUKKyAgICAgICAgTWFjcm9Bc3NlbWJsZXIgd2hpY2ggd2UgdXNlICh3ZSBnZXQgY3Jh c2hlcyBpbiBzb21lIHNpdHVhdGlvbnMgaWYgd2UKKyAgICAgICAgZG9uJ3Qgc2F2ZSByNikuIFRo aXMgaXNzdWUgd2FzIGRpc2NvdmVyZWQgYmVjYXVzZQorICAgICAgICBzdHJlc3MvcmVncmVzcy0x NzQwNDQuanMgY3Jhc2hlcyBvbiBhIHJhc3BiZXJyeSBwaSAyIHdoZW4gY29tcGlsZWQgaW4KKyAg ICAgICAgLU8yLgorCisgICAgICAgICogeWFyci9ZYXJySklULmNwcDoKKyAgICAgICAgKEpTQzo6 WWFycjo6WWFyckdlbmVyYXRvcjo6Z2VuZXJhdGVFbnRlcik6CisgICAgICAgIChKU0M6OllhcnI6 OllhcnJHZW5lcmF0b3I6OmdlbmVyYXRlUmV0dXJuKToKKwogMjAxOC0wMS0yMyAgRmlsaXAgUGl6 bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEpTQyBzaG91bGQgdXNlIGEgc3BlY3Vs YXRpb24gZmVuY2Ugb24gVk0gZW50cnkvZXhpdApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL3lhcnIvWWFyckpJVC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUveWFyci9ZYXJy SklULmNwcAppbmRleCAwM2ZjMDZkZDdkZmEyM2YzMjU0ZjNmNDI1ODZiOGY1YzU2NmU1MzQ3Li4z ZjliODE2YWEzODQwZmI5NTNmNDE2OTNiNTE0MDc4MzYwMWQ5ZmI3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUveWFyci9ZYXJySklULmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUveWFyci9ZYXJySklULmNwcApAQCAtMzMzNiw2ICszMzM2LDcgQEAgY2xhc3MgWWFyckdl bmVyYXRvciA6IHByaXZhdGUgTWFjcm9Bc3NlbWJsZXIgewogICAgICAgICBwdXNoKEFSTVJlZ2lz dGVyczo6cjQpOwogICAgICAgICBwdXNoKEFSTVJlZ2lzdGVyczo6cjUpOwogICAgICAgICBwdXNo KEFSTVJlZ2lzdGVyczo6cjYpOworICAgICAgICBwdXNoKEFSTVJlZ2lzdGVyczo6cjgpOwogI2Vs aWYgQ1BVKE1JUFMpCiAgICAgICAgIC8vIERvIG5vdGhpbmcuCiAjZW5kaWYKQEAgLTMzODMsNiAr MzM4NCw3IEBAIGNsYXNzIFlhcnJHZW5lcmF0b3IgOiBwcml2YXRlIE1hY3JvQXNzZW1ibGVyIHsK ICAgICAgICAgaWYgKG1fZGVjb2RlU3Vycm9nYXRlUGFpcnMpCiAgICAgICAgICAgICBwb3BQYWly KGZyYW1lUG9pbnRlclJlZ2lzdGVyLCBsaW5rUmVnaXN0ZXIpOwogI2VsaWYgQ1BVKEFSTSkKKyAg ICAgICAgcG9wKEFSTVJlZ2lzdGVyczo6cjgpOwogICAgICAgICBwb3AoQVJNUmVnaXN0ZXJzOjpy Nik7CiAgICAgICAgIHBvcChBUk1SZWdpc3RlcnM6OnI1KTsKICAgICAgICAgcG9wKEFSTVJlZ2lz dGVyczo6cjQpOwo=