182156 2018-01-25 15:50:46 -0800 Web Inspector: Remove unnecessary developerExtrasEnabled checks 2018-01-25 19:32:31 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1393331 0 joepeck 2018-01-25 15:50:46 -0800 Remove unnecessary developerExtrasEnabled checks 1393332 1 332328 joepeck 2018-01-25 15:53:30 -0800 Created attachment 332328 [PATCH] Proposed Fix 1393393 2 332328 mattbaker 2018-01-25 19:08:10 -0800 Comment on attachment 332328 [PATCH] Proposed Fix r=me 1393394 3 332328 commit-queue 2018-01-25 19:31:42 -0800 Comment on attachment 332328 [PATCH] Proposed Fix Clearing flags on attachment: 332328 Committed r227650: <https://trac.webkit.org/changeset/227650> 1393395 4 commit-queue 2018-01-25 19:31:43 -0800 All reviewed patches have been landed. Closing bug. 1393396 5 webkit-bug-importer 2018-01-25 19:32:31 -0800 <rdar://problem/36894583> 332328 2018-01-25 15:53:30 -0800 2018-01-25 19:31:42 -0800 [PATCH] Proposed Fix ii-1.patch text/plain 2681 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1ZWVmMmUwZGFiNi4uZDQyZjRjZjY4MjIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOC0wMS0yNSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJlbW92ZSB1bm5lY2Vzc2FyeSBkZXZlbG9w ZXJFeHRyYXNFbmFibGVkIGNoZWNrcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTgyMTU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6ZGlkTG9hZFJlc291 cmNlRnJvbU1lbW9yeUNhY2hlSW1wbCk6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JJbnN0 cnVtZW50YXRpb246OmZyYW1lRG9jdW1lbnRVcGRhdGVkSW1wbCk6CisgICAgICAgIChXZWJDb3Jl OjpJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OmRpZENyZWF0ZVdlYlNvY2tldEltcGwpOgorICAg ICAgICBUaGVzZSBjaGVja3Mgc2hvdWxkIG5vdCBiZSBuZWVkZWQuIFRoZSBzdGVwIGFib3ZlIGJh aWxzIGlmIHRoZXJlIGlzCisgICAgICAgIG5vIGluc3BlY3RvciBmcm9udGVuZCwgYW5kIHRoZXJl IGNhbiBiZSBubyBpbnNwZWN0b3IgZnJvbnRlbmQgdW5sZXNzCisgICAgICAgIGRldmVsb3BlciBl eHRyYXMgZW5hYmxlZCBhcmUgZW5hYmxlZC4KKwogMjAxOC0wMS0yNCAgSm9zZXBoIFBlY29yYXJv ICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFkZCBJbnNw ZWN0b3JTaGFkZXJQcm9ncmFtIHRvIFVuaWZpZWQgU291cmNlcyBidWlsZApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvckluc3RydW1lbnRhdGlvbi5jcHAgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uLmNwcAppbmRl eCBjNjhiZTc2NzkxZS4uYzAyODYxMTQzODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9JbnNwZWN0b3JJbnN0cnVtZW50YXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JJbnN0cnVtZW50YXRpb24uY3BwCkBAIC01NzMsOSArNTczLDYg QEAgdm9pZCBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OndpbGxTZW5kUmVxdWVzdE9mVHlwZUlt cGwoSW5zdHJ1bWVudGluZ0FnZW50cyYgaW4KIAogdm9pZCBJbnNwZWN0b3JJbnN0cnVtZW50YXRp b246OmRpZExvYWRSZXNvdXJjZUZyb21NZW1vcnlDYWNoZUltcGwoSW5zdHJ1bWVudGluZ0FnZW50 cyYgaW5zdHJ1bWVudGluZ0FnZW50cywgRG9jdW1lbnRMb2FkZXIqIGxvYWRlciwgQ2FjaGVkUmVz b3VyY2UqIGNhY2hlZFJlc291cmNlKQogewotICAgIGlmICghaW5zdHJ1bWVudGluZ0FnZW50cy5p bnNwZWN0b3JFbnZpcm9ubWVudCgpLmRldmVsb3BlckV4dHJhc0VuYWJsZWQoKSkKLSAgICAgICAg cmV0dXJuOwotICAgIAogICAgIGlmICghbG9hZGVyIHx8ICFjYWNoZWRSZXNvdXJjZSkKICAgICAg ICAgcmV0dXJuOwogCkBAIC03MzMsOCArNzMwLDYgQEAgdm9pZCBJbnNwZWN0b3JJbnN0cnVtZW50 YXRpb246OmRpZENvbW1pdExvYWRJbXBsKEluc3RydW1lbnRpbmdBZ2VudHMmIGluc3RydW1lbnQK IAogdm9pZCBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OmZyYW1lRG9jdW1lbnRVcGRhdGVkSW1w bChJbnN0cnVtZW50aW5nQWdlbnRzJiBpbnN0cnVtZW50aW5nQWdlbnRzLCBGcmFtZSYgZnJhbWUp CiB7Ci0gICAgaWYgKCFpbnN0cnVtZW50aW5nQWdlbnRzLmluc3BlY3RvckVudmlyb25tZW50KCku ZGV2ZWxvcGVyRXh0cmFzRW5hYmxlZCgpKQotICAgICAgICByZXR1cm47CiAgICAgaWYgKEluc3Bl Y3RvckRPTUFnZW50KiBkb21BZ2VudCA9IGluc3RydW1lbnRpbmdBZ2VudHMuaW5zcGVjdG9yRE9N QWdlbnQoKSkKICAgICAgICAgZG9tQWdlbnQtPmZyYW1lRG9jdW1lbnRVcGRhdGVkKGZyYW1lKTsK IH0KQEAgLTkxNSw5ICs5MTAsNiBAQCB2b2lkIEluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6d29y a2VyVGVybWluYXRlZEltcGwoSW5zdHJ1bWVudGluZ0FnZW50cyYgaW5zdHJ1bQogCiB2b2lkIElu c3BlY3Rvckluc3RydW1lbnRhdGlvbjo6ZGlkQ3JlYXRlV2ViU29ja2V0SW1wbChJbnN0cnVtZW50 aW5nQWdlbnRzJiBpbnN0cnVtZW50aW5nQWdlbnRzLCB1bnNpZ25lZCBsb25nIGlkZW50aWZpZXIs IGNvbnN0IFVSTCYgcmVxdWVzdFVSTCkKIHsKLSAgICBpZiAoIWluc3RydW1lbnRpbmdBZ2VudHMu aW5zcGVjdG9yRW52aXJvbm1lbnQoKS5kZXZlbG9wZXJFeHRyYXNFbmFibGVkKCkpCi0gICAgICAg IHJldHVybjsKLQogICAgIGlmIChJbnNwZWN0b3JOZXR3b3JrQWdlbnQqIG5ldHdvcmtBZ2VudCA9 IGluc3RydW1lbnRpbmdBZ2VudHMuaW5zcGVjdG9yTmV0d29ya0FnZW50KCkpCiAgICAgICAgIG5l dHdvcmtBZ2VudC0+ZGlkQ3JlYXRlV2ViU29ja2V0KGlkZW50aWZpZXIsIHJlcXVlc3RVUkwpOwog fQo=