182148 2018-01-25 14:09:27 -0800 Rename some local vars from type to typedArrayType for greater clarity. 2018-01-25 14:57:50 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam webkit-bug-importer oldest_to_newest 1393274 0 mark.lam 2018-01-25 14:09:27 -0800 Patch coming. 1393275 1 webkit-bug-importer 2018-01-25 14:10:37 -0800 <rdar://problem/36882310> 1393280 2 332315 mark.lam 2018-01-25 14:15:34 -0800 Created attachment 332315 proposed patch. 1393307 3 mark.lam 2018-01-25 14:57:50 -0800 Thanks for the review. Landed in r227636: <http://trac.webkit.org/r227636>. 332315 2018-01-25 14:15:34 -0800 2018-01-25 14:19:36 -0800 proposed patch. bug-182148.patch text/plain 6329 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI3NjI5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE4LTAxLTI1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZW5hbWUgc29tZSBsb2NhbCB2YXJzIGZyb20gdHlwZSB0byB0eXBlZEFycmF5VHlwZSBmb3IgZ3Jl YXRlciBjbGFyaXR5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTgyMTQ4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNjg4MjMxMD4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRmZy9ERkdTcGVjdWxh dGl2ZUpJVC5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVO ZXdUeXBlZEFycmF5V2l0aFNpemUpOgorICAgICAgICAqIGZ0bC9GVExMb3dlckRGR1RvQjMuY3Bw OgorICAgICAgICAoSlNDOjpGVEw6OkRGRzo6TG93ZXJERkdUb0IzOjpjb21waWxlTmV3VHlwZWRB cnJheSk6CisKIDIwMTgtMDEtMjUgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAog ICAgICAgICBKU0MgR0Mgc2hvdWxkIHN1cHBvcnQgVExDcyAodGhyZWFkIGxvY2FsIGNhY2hlcykK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQu Y3BwCShyZXZpc2lvbiAyMjc2MjcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Nw ZWN1bGF0aXZlSklULmNwcAkod29ya2luZyBjb3B5KQpAQCAtODk4Miw4ICs4OTgyLDggQEAgdm9p ZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZU5ld1N0cmluZ09iagogdm9pZCBTcGVjdWxhdGl2ZUpJ VDo6Y29tcGlsZU5ld1R5cGVkQXJyYXlXaXRoU2l6ZShOb2RlKiBub2RlKQogewogICAgIEpTR2xv YmFsT2JqZWN0KiBnbG9iYWxPYmplY3QgPSBtX2ppdC5ncmFwaCgpLmdsb2JhbE9iamVjdEZvcihu b2RlLT5vcmlnaW4uc2VtYW50aWMpOwotICAgIFR5cGVkQXJyYXlUeXBlIHR5cGUgPSBub2RlLT50 eXBlZEFycmF5VHlwZSgpOwotICAgIFJlZ2lzdGVyZWRTdHJ1Y3R1cmUgc3RydWN0dXJlID0gbV9q aXQuZ3JhcGgoKS5yZWdpc3RlclN0cnVjdHVyZShnbG9iYWxPYmplY3QtPnR5cGVkQXJyYXlTdHJ1 Y3R1cmVDb25jdXJyZW50bHkodHlwZSkpOworICAgIGF1dG8gdHlwZWRBcnJheVR5cGUgPSBub2Rl LT50eXBlZEFycmF5VHlwZSgpOworICAgIFJlZ2lzdGVyZWRTdHJ1Y3R1cmUgc3RydWN0dXJlID0g bV9qaXQuZ3JhcGgoKS5yZWdpc3RlclN0cnVjdHVyZShnbG9iYWxPYmplY3QtPnR5cGVkQXJyYXlT dHJ1Y3R1cmVDb25jdXJyZW50bHkodHlwZWRBcnJheVR5cGUpKTsKICAgICBSRUxFQVNFX0FTU0VS VChzdHJ1Y3R1cmUuZ2V0KCkpOwogICAgIAogICAgIFNwZWN1bGF0ZUludDMyT3BlcmFuZCBzaXpl KHRoaXMsIG5vZGUtPmNoaWxkMSgpKTsKQEAgLTkwMDksOCArOTAwOSw4IEBAIHZvaWQgU3BlY3Vs YXRpdmVKSVQ6OmNvbXBpbGVOZXdUeXBlZEFycmEKICAgICBzbG93Q2FzZXMuYXBwZW5kKG1faml0 LmJyYW5jaFRlc3QzMihNYWNyb0Fzc2VtYmxlcjo6WmVybywgc2l6ZUdQUikpOwogICAgIAogICAg IG1faml0Lm1vdmUoc2l6ZUdQUiwgc2NyYXRjaEdQUik7Ci0gICAgbV9qaXQubHNoaWZ0MzIoVHJ1 c3RlZEltbTMyKGxvZ0VsZW1lbnRTaXplKHR5cGUpKSwgc2NyYXRjaEdQUik7Ci0gICAgaWYgKGVs ZW1lbnRTaXplKHR5cGUpIDwgOCkgeworICAgIG1faml0LmxzaGlmdDMyKFRydXN0ZWRJbW0zMihs b2dFbGVtZW50U2l6ZSh0eXBlZEFycmF5VHlwZSkpLCBzY3JhdGNoR1BSKTsKKyAgICBpZiAoZWxl bWVudFNpemUodHlwZWRBcnJheVR5cGUpIDwgOCkgewogICAgICAgICBtX2ppdC5hZGQzMihUcnVz dGVkSW1tMzIoNyksIHNjcmF0Y2hHUFIpOwogICAgICAgICBtX2ppdC5hbmQzMihUcnVzdGVkSW1t MzIofjcpLCBzY3JhdGNoR1BSKTsKICAgICB9CkBAIC05MDIwLDEyICs5MDIwLDEyIEBAIHZvaWQg U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVOZXdUeXBlZEFycmEKICAgICAKICAgICBNYWNyb0Fzc2Vt Ymxlcjo6SnVtcCBkb25lID0gbV9qaXQuYnJhbmNoVGVzdDMyKE1hY3JvQXNzZW1ibGVyOjpaZXJv LCBzaXplR1BSKTsKICAgICBtX2ppdC5tb3ZlKHNpemVHUFIsIHNjcmF0Y2hHUFIpOwotICAgIGlm IChlbGVtZW50U2l6ZSh0eXBlKSAhPSA0KSB7Ci0gICAgICAgIGlmIChlbGVtZW50U2l6ZSh0eXBl KSA+IDQpCi0gICAgICAgICAgICBtX2ppdC5sc2hpZnQzMihUcnVzdGVkSW1tMzIobG9nRWxlbWVu dFNpemUodHlwZSkgLSAyKSwgc2NyYXRjaEdQUik7CisgICAgaWYgKGVsZW1lbnRTaXplKHR5cGVk QXJyYXlUeXBlKSAhPSA0KSB7CisgICAgICAgIGlmIChlbGVtZW50U2l6ZSh0eXBlZEFycmF5VHlw ZSkgPiA0KQorICAgICAgICAgICAgbV9qaXQubHNoaWZ0MzIoVHJ1c3RlZEltbTMyKGxvZ0VsZW1l bnRTaXplKHR5cGVkQXJyYXlUeXBlKSAtIDIpLCBzY3JhdGNoR1BSKTsKICAgICAgICAgZWxzZSB7 Ci0gICAgICAgICAgICBpZiAoZWxlbWVudFNpemUodHlwZSkgPiAxKQotICAgICAgICAgICAgICAg IG1faml0LmxzaGlmdDMyKFRydXN0ZWRJbW0zMihsb2dFbGVtZW50U2l6ZSh0eXBlKSksIHNjcmF0 Y2hHUFIpOworICAgICAgICAgICAgaWYgKGVsZW1lbnRTaXplKHR5cGVkQXJyYXlUeXBlKSA+IDEp CisgICAgICAgICAgICAgICAgbV9qaXQubHNoaWZ0MzIoVHJ1c3RlZEltbTMyKGxvZ0VsZW1lbnRT aXplKHR5cGVkQXJyYXlUeXBlKSksIHNjcmF0Y2hHUFIpOwogICAgICAgICAgICAgbV9qaXQuYWRk MzIoVHJ1c3RlZEltbTMyKDMpLCBzY3JhdGNoR1BSKTsKICAgICAgICAgICAgIG1faml0LnVyc2hp ZnQzMihUcnVzdGVkSW1tMzIoMiksIHNjcmF0Y2hHUFIpOwogICAgICAgICB9CkBAIC05MDU3LDcg KzkwNTcsNyBAQCB2b2lkIFNwZWN1bGF0aXZlSklUOjpjb21waWxlTmV3VHlwZWRBcnJhCiAgICAg bV9qaXQubXV0YXRvckZlbmNlKCptX2ppdC52bSgpKTsKICAgICAKICAgICBhZGRTbG93UGF0aEdl bmVyYXRvcihzbG93UGF0aENhbGwoCi0gICAgICAgIHNsb3dDYXNlcywgdGhpcywgb3BlcmF0aW9u TmV3VHlwZWRBcnJheVdpdGhTaXplRm9yVHlwZSh0eXBlKSwKKyAgICAgICAgc2xvd0Nhc2VzLCB0 aGlzLCBvcGVyYXRpb25OZXdUeXBlZEFycmF5V2l0aFNpemVGb3JUeXBlKHR5cGVkQXJyYXlUeXBl KSwKICAgICAgICAgcmVzdWx0R1BSLCBzdHJ1Y3R1cmUsIHNpemVHUFIsIHN0b3JhZ2VHUFIpKTsK ICAgICAKICAgICBjZWxsUmVzdWx0KHJlc3VsdEdQUiwgbm9kZSk7CkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9CMy5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvQjMuY3BwCShyZXZpc2lvbiAyMjc2Mjcp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9CMy5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTU1ODIsMTIgKzU1ODIsMTIgQEAgcHJpdmF0ZToKIAogICAgIHZvaWQgY29t cGlsZU5ld1R5cGVkQXJyYXkoKQogICAgIHsKLSAgICAgICAgVHlwZWRBcnJheVR5cGUgdHlwZSA9 IG1fbm9kZS0+dHlwZWRBcnJheVR5cGUoKTsKKyAgICAgICAgVHlwZWRBcnJheVR5cGUgdHlwZWRB cnJheVR5cGUgPSBtX25vZGUtPnR5cGVkQXJyYXlUeXBlKCk7CiAgICAgICAgIEpTR2xvYmFsT2Jq ZWN0KiBnbG9iYWxPYmplY3QgPSBtX2dyYXBoLmdsb2JhbE9iamVjdEZvcihtX25vZGUtPm9yaWdp bi5zZW1hbnRpYyk7CiAgICAgICAgIAogICAgICAgICBzd2l0Y2ggKG1fbm9kZS0+Y2hpbGQxKCku dXNlS2luZCgpKSB7CiAgICAgICAgIGNhc2UgSW50MzJVc2U6IHsKLSAgICAgICAgICAgIFJlZ2lz dGVyZWRTdHJ1Y3R1cmUgc3RydWN0dXJlID0gbV9ncmFwaC5yZWdpc3RlclN0cnVjdHVyZShnbG9i YWxPYmplY3QtPnR5cGVkQXJyYXlTdHJ1Y3R1cmVDb25jdXJyZW50bHkodHlwZSkpOworICAgICAg ICAgICAgUmVnaXN0ZXJlZFN0cnVjdHVyZSBzdHJ1Y3R1cmUgPSBtX2dyYXBoLnJlZ2lzdGVyU3Ry dWN0dXJlKGdsb2JhbE9iamVjdC0+dHlwZWRBcnJheVN0cnVjdHVyZUNvbmN1cnJlbnRseSh0eXBl ZEFycmF5VHlwZSkpOwogCiAgICAgICAgICAgICBMVmFsdWUgc2l6ZSA9IGxvd0ludDMyKG1fbm9k ZS0+Y2hpbGQxKCkpOwogCkBAIC01NjA5LDggKzU2MDksOCBAQCBwcml2YXRlOgogICAgICAgICAg ICAgbV9vdXQuYXBwZW5kVG8obm9uWmVyb0Nhc2UsIHNsb3dDYXNlKTsKIAogICAgICAgICAgICAg TFZhbHVlIGJ5dGVTaXplID0KLSAgICAgICAgICAgICAgICBtX291dC5zaGwobV9vdXQuemVyb0V4 dFB0cihzaXplKSwgbV9vdXQuY29uc3RJbnQzMihsb2dFbGVtZW50U2l6ZSh0eXBlKSkpOwotICAg ICAgICAgICAgaWYgKGVsZW1lbnRTaXplKHR5cGUpIDwgOCkgeworICAgICAgICAgICAgICAgIG1f b3V0LnNobChtX291dC56ZXJvRXh0UHRyKHNpemUpLCBtX291dC5jb25zdEludDMyKGxvZ0VsZW1l bnRTaXplKHR5cGVkQXJyYXlUeXBlKSkpOworICAgICAgICAgICAgaWYgKGVsZW1lbnRTaXplKHR5 cGVkQXJyYXlUeXBlKSA8IDgpIHsKICAgICAgICAgICAgICAgICBieXRlU2l6ZSA9IG1fb3V0LmJp dEFuZCgKICAgICAgICAgICAgICAgICAgICAgbV9vdXQuYWRkKGJ5dGVTaXplLCBtX291dC5jb25z dEludFB0cig3KSksCiAgICAgICAgICAgICAgICAgICAgIG1fb3V0LmNvbnN0SW50UHRyKH5zdGF0 aWNfY2FzdDxpbnRwdHJfdD4oNykpKTsKQEAgLTU2NDcsNyArNTY0Nyw3IEBAIHByaXZhdGU6CiAg ICAgICAgICAgICBMVmFsdWUgc2xvd1Jlc3VsdFZhbHVlID0gbGF6eVNsb3dQYXRoKAogICAgICAg ICAgICAgICAgIFs9LCAmdm1dIChjb25zdCBWZWN0b3I8TG9jYXRpb24+JiBsb2NhdGlvbnMpIC0+ IFJlZlB0cjxMYXp5U2xvd1BhdGg6OkdlbmVyYXRvcj4gewogICAgICAgICAgICAgICAgICAgICBy ZXR1cm4gY3JlYXRlTGF6eUNhbGxHZW5lcmF0b3Iodm0sCi0gICAgICAgICAgICAgICAgICAgICAg ICBvcGVyYXRpb25OZXdUeXBlZEFycmF5V2l0aFNpemVGb3JUeXBlKHR5cGUpLCBsb2NhdGlvbnNb MF0uZGlyZWN0R1BSKCksCisgICAgICAgICAgICAgICAgICAgICAgICBvcGVyYXRpb25OZXdUeXBl ZEFycmF5V2l0aFNpemVGb3JUeXBlKHR5cGVkQXJyYXlUeXBlKSwgbG9jYXRpb25zWzBdLmRpcmVj dEdQUigpLAogICAgICAgICAgICAgICAgICAgICAgICAgQ0NhbGxIZWxwZXJzOjpUcnVzdGVkSW1t UHRyKHN0cnVjdHVyZS5nZXQoKSksIGxvY2F0aW9uc1sxXS5kaXJlY3RHUFIoKSwKICAgICAgICAg ICAgICAgICAgICAgICAgIGxvY2F0aW9uc1syXS5kaXJlY3RHUFIoKSk7CiAgICAgICAgICAgICAg ICAgfSwKQEAgLTU2NjQsOCArNTY2NCw4IEBAIHByaXZhdGU6CiAgICAgICAgICAgICBMVmFsdWUg YXJndW1lbnQgPSBsb3dKU1ZhbHVlKG1fbm9kZS0+Y2hpbGQxKCkpOwogCiAgICAgICAgICAgICBM VmFsdWUgcmVzdWx0ID0gdm1DYWxsKAotICAgICAgICAgICAgICAgIHBvaW50ZXJUeXBlKCksIG1f b3V0Lm9wZXJhdGlvbihvcGVyYXRpb25OZXdUeXBlZEFycmF5V2l0aE9uZUFyZ3VtZW50Rm9yVHlw ZSh0eXBlKSksCi0gICAgICAgICAgICAgICAgbV9jYWxsRnJhbWUsIHdlYWtQb2ludGVyKGdsb2Jh bE9iamVjdC0+dHlwZWRBcnJheVN0cnVjdHVyZUNvbmN1cnJlbnRseSh0eXBlKSksIGFyZ3VtZW50 KTsKKyAgICAgICAgICAgICAgICBwb2ludGVyVHlwZSgpLCBtX291dC5vcGVyYXRpb24ob3BlcmF0 aW9uTmV3VHlwZWRBcnJheVdpdGhPbmVBcmd1bWVudEZvclR5cGUodHlwZWRBcnJheVR5cGUpKSwK KyAgICAgICAgICAgICAgICBtX2NhbGxGcmFtZSwgd2Vha1BvaW50ZXIoZ2xvYmFsT2JqZWN0LT50 eXBlZEFycmF5U3RydWN0dXJlQ29uY3VycmVudGx5KHR5cGVkQXJyYXlUeXBlKSksIGFyZ3VtZW50 KTsKIAogICAgICAgICAgICAgc2V0SlNWYWx1ZShyZXN1bHQpOwogICAgICAgICAgICAgcmV0dXJu Owo=