182143 2018-01-25 13:29:20 -0800 Rename the Poisoned::isPoisoned constant to Poisoned::isPoisonedType. 2018-01-25 13:54:58 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam benjamin cdumez cmarcelo dbates ews-watchlist jfbastien webkit-bug-importer oldest_to_newest 1393238 0 mark.lam 2018-01-25 13:29:20 -0800 This is so that it doesn't conflict with the isPoisoned() debugging methods that are normally not built. Also renamed PoisonedUniquePtr::isPoisonedUniquePtr to PoisonedUniquePtr::isPoisonedUniquePtrType to be consistent. 1393240 1 webkit-bug-importer 2018-01-25 13:29:56 -0800 <rdar://problem/36880970> 1393256 2 332311 mark.lam 2018-01-25 13:46:46 -0800 Created attachment 332311 proposed patch. 1393258 3 332311 jfbastien 2018-01-25 13:48:08 -0800 Comment on attachment 332311 proposed patch. r=me 1393260 4 mark.lam 2018-01-25 13:54:58 -0800 Thanks for the review. Landed in r227628: <http://trac.webkit.org/r227628>. 332311 2018-01-25 13:46:46 -0800 2018-01-25 13:48:08 -0800 proposed patch. bug-182143.patch text/plain 7368 mark.lam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMjc2MjcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE4LTAxLTI1ICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KKworICAgICAgICBSZW5hbWUgdGhlIFBvaXNvbmVkOjppc1BvaXNvbmVkIGNv bnN0YW50IHRvIFBvaXNvbmVkOjppc1BvaXNvbmVkVHlwZS4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjE0MworICAgICAgICA8cmRhcjovL3Byb2Js ZW0vMzY4ODA5NzA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGhpcyBpcyBzbyB0aGF0IGl0IGRvZXNuJ3QgY29uZmxpY3Qgd2l0aCB0aGUgaXNQb2lz b25lZCgpIGRlYnVnZ2luZyBtZXRob2RzIHRoYXQKKyAgICAgICAgYXJlIG5vcm1hbGx5IG5vdCBi dWlsdC4gIEFsc28gcmVuYW1lZCBQb2lzb25lZFVuaXF1ZVB0cjo6aXNQb2lzb25lZFVuaXF1ZVB0 ciB0bworICAgICAgICBQb2lzb25lZFVuaXF1ZVB0cjo6aXNQb2lzb25lZFVuaXF1ZVB0clR5cGUg dG8gYmUgY29uc2lzdGVudC4KKworICAgICAgICAqIHd0Zi9Qb2lzb25lZC5oOgorICAgICAgICAq IHd0Zi9Qb2lzb25lZFVuaXF1ZVB0ci5oOgorCiAyMDE4LTAxLTI1ICBGaWxpcCBQaXpsbyAgPGZw aXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgSlNDIEdDIHNob3VsZCBzdXBwb3J0IFRMQ3MgKHRo cmVhZCBsb2NhbCBjYWNoZXMpCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9Qb2lzb25lZC5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL1BvaXNvbmVkLmgJKHJldmlzaW9uIDIyNzYyNSkKKysr IFNvdXJjZS9XVEYvd3RmL1BvaXNvbmVkLmgJKHdvcmtpbmcgY29weSkKQEAgLTc4LDcgKzc4LDcg QEAgcHVibGljOgogdGVtcGxhdGU8dHlwZW5hbWUgUG9pc29uLCB0eXBlbmFtZSBULCB0eXBlbmFt ZSA9IHN0ZDo6ZW5hYmxlX2lmX3Q8c3RkOjppc19wb2ludGVyPFQ+Ojp2YWx1ZT4+CiBjbGFzcyBQ b2lzb25lZCB7CiBwdWJsaWM6Ci0gICAgc3RhdGljIGNvbnN0ZXhwciBib29sIGlzUG9pc29uZWQg PSB0cnVlOworICAgIHN0YXRpYyBjb25zdGV4cHIgYm9vbCBpc1BvaXNvbmVkVHlwZSA9IHRydWU7 CiAKICAgICBQb2lzb25lZCgpIHsgfQogCkBAIC05MCw3ICs5MCw3IEBAIHB1YmxpYzoKIAogICAg IFBvaXNvbmVkKGNvbnN0IFBvaXNvbmVkJikgPSBkZWZhdWx0OwogCi0gICAgdGVtcGxhdGU8dHlw ZW5hbWUgT3RoZXIsIHR5cGVuYW1lID0gc3RkOjplbmFibGVfaWZfdDxPdGhlcjo6aXNQb2lzb25l ZD4+CisgICAgdGVtcGxhdGU8dHlwZW5hbWUgT3RoZXIsIHR5cGVuYW1lID0gc3RkOjplbmFibGVf aWZfdDxPdGhlcjo6aXNQb2lzb25lZFR5cGU+PgogICAgIFBvaXNvbmVkKGNvbnN0IE90aGVyJiBv dGhlcikKICAgICAgICAgOiBtX3BvaXNvbmVkQml0cyhwb2lzb248VD4ob3RoZXIudW5wb2lzb25l ZCgpKSkKICAgICB7IH0KQEAgLTE1Miw3ICsxNTIsNyBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVy biAqdGhpczsKICAgICB9CiAKLSAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBPdGhlciwgdHlwZW5hbWUg PSBzdGQ6OmVuYWJsZV9pZl90PE90aGVyOjppc1BvaXNvbmVkPj4KKyAgICB0ZW1wbGF0ZTx0eXBl bmFtZSBPdGhlciwgdHlwZW5hbWUgPSBzdGQ6OmVuYWJsZV9pZl90PE90aGVyOjppc1BvaXNvbmVk VHlwZT4+CiAgICAgUG9pc29uZWQmIG9wZXJhdG9yPShjb25zdCBPdGhlciYgb3RoZXIpCiAgICAg ewogICAgICAgICBtX3BvaXNvbmVkQml0cyA9IHBvaXNvbjxUPihvdGhlci51bnBvaXNvbmVkKCkp OwpAQCAtMTY2LDcgKzE2Niw3IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgc3dhcChzdGQ6Om51bGxw dHJfdCkgeyBjbGVhcigpOyB9CiAKLSAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBPdGhlciwgdHlwZW5h bWUgPSBzdGQ6OmVuYWJsZV9pZl90PE90aGVyOjppc1BvaXNvbmVkPj4KKyAgICB0ZW1wbGF0ZTx0 eXBlbmFtZSBPdGhlciwgdHlwZW5hbWUgPSBzdGQ6OmVuYWJsZV9pZl90PE90aGVyOjppc1BvaXNv bmVkVHlwZT4+CiAgICAgdm9pZCBzd2FwKE90aGVyJiBvdGhlcikKICAgICB7CiAgICAgICAgIFQg dDEgPSB0aGlzLT51bnBvaXNvbmVkKCk7CkBAIC0yMTUsMjUgKzIxNSwyNSBAQCBwcml2YXRlOgog ICAgIHRlbXBsYXRlPHR5cGVuYW1lLCB0eXBlbmFtZSwgdHlwZW5hbWU+IGZyaWVuZCBjbGFzcyBQ b2lzb25lZDsKIH07CiAKLXRlbXBsYXRlPHR5cGVuYW1lIFQsIHR5cGVuYW1lIFUsIHR5cGVuYW1l ID0gc3RkOjplbmFibGVfaWZfdDxUOjppc1BvaXNvbmVkICYmIFU6OmlzUG9pc29uZWQgJiYgIXN0 ZDo6aXNfc2FtZTxULCBVPjo6dmFsdWU+PgordGVtcGxhdGU8dHlwZW5hbWUgVCwgdHlwZW5hbWUg VSwgdHlwZW5hbWUgPSBzdGQ6OmVuYWJsZV9pZl90PFQ6OmlzUG9pc29uZWRUeXBlICYmIFU6Omlz UG9pc29uZWRUeXBlICYmICFzdGQ6OmlzX3NhbWU8VCwgVT46OnZhbHVlPj4KIGlubGluZSBib29s IG9wZXJhdG9yPT0oY29uc3QgVCYgYSwgY29uc3QgVSYgYikgeyByZXR1cm4gYS51bnBvaXNvbmVk KCkgPT0gYi51bnBvaXNvbmVkKCk7IH0KIAotdGVtcGxhdGU8dHlwZW5hbWUgVCwgdHlwZW5hbWUg VSwgdHlwZW5hbWUgPSBzdGQ6OmVuYWJsZV9pZl90PFQ6OmlzUG9pc29uZWQgJiYgVTo6aXNQb2lz b25lZCAmJiAhc3RkOjppc19zYW1lPFQsIFU+Ojp2YWx1ZT4+Cit0ZW1wbGF0ZTx0eXBlbmFtZSBU LCB0eXBlbmFtZSBVLCB0eXBlbmFtZSA9IHN0ZDo6ZW5hYmxlX2lmX3Q8VDo6aXNQb2lzb25lZFR5 cGUgJiYgVTo6aXNQb2lzb25lZFR5cGUgJiYgIXN0ZDo6aXNfc2FtZTxULCBVPjo6dmFsdWU+Pgog aW5saW5lIGJvb2wgb3BlcmF0b3IhPShjb25zdCBUJiBhLCBjb25zdCBVJiBiKSB7IHJldHVybiBh LnVucG9pc29uZWQoKSAhPSBiLnVucG9pc29uZWQoKTsgfQogCi10ZW1wbGF0ZTx0eXBlbmFtZSBU LCB0eXBlbmFtZSBVLCB0eXBlbmFtZSA9IHN0ZDo6ZW5hYmxlX2lmX3Q8VDo6aXNQb2lzb25lZCAm JiBVOjppc1BvaXNvbmVkPj4KK3RlbXBsYXRlPHR5cGVuYW1lIFQsIHR5cGVuYW1lIFUsIHR5cGVu YW1lID0gc3RkOjplbmFibGVfaWZfdDxUOjppc1BvaXNvbmVkVHlwZSAmJiBVOjppc1BvaXNvbmVk VHlwZT4+CiBpbmxpbmUgYm9vbCBvcGVyYXRvcjwoY29uc3QgVCYgYSwgY29uc3QgVSYgYikgeyBy ZXR1cm4gYS51bnBvaXNvbmVkKCkgPCBiLnVucG9pc29uZWQoKTsgfQogCi10ZW1wbGF0ZTx0eXBl bmFtZSBULCB0eXBlbmFtZSBVLCB0eXBlbmFtZSA9IHN0ZDo6ZW5hYmxlX2lmX3Q8VDo6aXNQb2lz b25lZCAmJiBVOjppc1BvaXNvbmVkPj4KK3RlbXBsYXRlPHR5cGVuYW1lIFQsIHR5cGVuYW1lIFUs IHR5cGVuYW1lID0gc3RkOjplbmFibGVfaWZfdDxUOjppc1BvaXNvbmVkVHlwZSAmJiBVOjppc1Bv aXNvbmVkVHlwZT4+CiBpbmxpbmUgYm9vbCBvcGVyYXRvcjw9KGNvbnN0IFQmIGEsIGNvbnN0IFUm IGIpIHsgcmV0dXJuIGEudW5wb2lzb25lZCgpIDw9IGIudW5wb2lzb25lZCgpOyB9CiAKLXRlbXBs YXRlPHR5cGVuYW1lIFQsIHR5cGVuYW1lIFUsIHR5cGVuYW1lID0gc3RkOjplbmFibGVfaWZfdDxU Ojppc1BvaXNvbmVkICYmIFU6OmlzUG9pc29uZWQ+PgordGVtcGxhdGU8dHlwZW5hbWUgVCwgdHlw ZW5hbWUgVSwgdHlwZW5hbWUgPSBzdGQ6OmVuYWJsZV9pZl90PFQ6OmlzUG9pc29uZWRUeXBlICYm IFU6OmlzUG9pc29uZWRUeXBlPj4KIGlubGluZSBib29sIG9wZXJhdG9yPihjb25zdCBUJiBhLCBj b25zdCBVJiBiKSB7IHJldHVybiBhLnVucG9pc29uZWQoKSA+IGIudW5wb2lzb25lZCgpOyB9CiAK LXRlbXBsYXRlPHR5cGVuYW1lIFQsIHR5cGVuYW1lIFUsIHR5cGVuYW1lID0gc3RkOjplbmFibGVf aWZfdDxUOjppc1BvaXNvbmVkICYmIFU6OmlzUG9pc29uZWQ+PgordGVtcGxhdGU8dHlwZW5hbWUg VCwgdHlwZW5hbWUgVSwgdHlwZW5hbWUgPSBzdGQ6OmVuYWJsZV9pZl90PFQ6OmlzUG9pc29uZWRU eXBlICYmIFU6OmlzUG9pc29uZWRUeXBlPj4KIGlubGluZSBib29sIG9wZXJhdG9yPj0oY29uc3Qg VCYgYSwgY29uc3QgVSYgYikgeyByZXR1cm4gYS51bnBvaXNvbmVkKCkgPj0gYi51bnBvaXNvbmVk KCk7IH0KIAotdGVtcGxhdGU8dHlwZW5hbWUgVCwgdHlwZW5hbWUgVSwgdHlwZW5hbWUgPSBzdGQ6 OmVuYWJsZV9pZl90PFQ6OmlzUG9pc29uZWQ+PgordGVtcGxhdGU8dHlwZW5hbWUgVCwgdHlwZW5h bWUgVSwgdHlwZW5hbWUgPSBzdGQ6OmVuYWJsZV9pZl90PFQ6OmlzUG9pc29uZWRUeXBlPj4KIGlu bGluZSB2b2lkIHN3YXAoVCYgYSwgVSYgYikKIHsKICAgICBhLnN3YXAoYik7CkluZGV4OiBTb3Vy Y2UvV1RGL3d0Zi9Qb2lzb25lZFVuaXF1ZVB0ci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYv d3RmL1BvaXNvbmVkVW5pcXVlUHRyLmgJKHJldmlzaW9uIDIyNzYyNSkKKysrIFNvdXJjZS9XVEYv d3RmL1BvaXNvbmVkVW5pcXVlUHRyLmgJKHdvcmtpbmcgY29weSkKQEAgLTM3LDcgKzM3LDcgQEAg Y2xhc3MgUG9pc29uZWRVbmlxdWVQdHIgOiBwdWJsaWMgUG9pc29uZQogICAgIFdURl9NQUtFX0ZB U1RfQUxMT0NBVEVEOwogICAgIHVzaW5nIEJhc2UgPSBQb2lzb25lZDxQb2lzb24sIFQqPjsKIHB1 YmxpYzoKLSAgICBzdGF0aWMgY29uc3RleHByIGJvb2wgaXNQb2lzb25lZFVuaXF1ZVB0ciA9IHRy dWU7CisgICAgc3RhdGljIGNvbnN0ZXhwciBib29sIGlzUG9pc29uZWRVbmlxdWVQdHJUeXBlID0g dHJ1ZTsKICAgICB1c2luZyBWYWx1ZVR5cGUgPSBUOwogCiAgICAgUG9pc29uZWRVbmlxdWVQdHIo KSA9IGRlZmF1bHQ7CkBAIC01MSw3ICs1MSw3IEBAIHB1YmxpYzoKICAgICAgICAgOiBCYXNlKHVu aXF1ZS5yZWxlYXNlKCkpCiAgICAgeyB9CiAKLSAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBPdGhlciwg dHlwZW5hbWUgPSBzdGQ6OmVuYWJsZV9pZl90PE90aGVyOjppc1BvaXNvbmVkVW5pcXVlUHRyICYm IHN0ZDo6aXNfYmFzZV9vZjxULCB0eXBlbmFtZSBPdGhlcjo6VmFsdWVUeXBlPjo6dmFsdWU+Pgor ICAgIHRlbXBsYXRlPHR5cGVuYW1lIE90aGVyLCB0eXBlbmFtZSA9IHN0ZDo6ZW5hYmxlX2lmX3Q8 T3RoZXI6OmlzUG9pc29uZWRVbmlxdWVQdHJUeXBlICYmIHN0ZDo6aXNfYmFzZV9vZjxULCB0eXBl bmFtZSBPdGhlcjo6VmFsdWVUeXBlPjo6dmFsdWU+PgogICAgIFBvaXNvbmVkVW5pcXVlUHRyKE90 aGVyJiYgcHRyKQogICAgICAgICA6IEJhc2UocHRyLnVucG9pc29uZWQoKSkKICAgICB7CkBAIC05 Miw3ICs5Miw3IEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuICp0aGlzOwogICAgIH0KIAotICAg IHRlbXBsYXRlPHR5cGVuYW1lIE90aGVyLCB0eXBlbmFtZSA9IHN0ZDo6ZW5hYmxlX2lmX3Q8T3Ro ZXI6OmlzUG9pc29uZWRVbmlxdWVQdHIgJiYgc3RkOjppc19iYXNlX29mPFQsIHR5cGVuYW1lIE90 aGVyOjpWYWx1ZVR5cGU+Ojp2YWx1ZT4+CisgICAgdGVtcGxhdGU8dHlwZW5hbWUgT3RoZXIsIHR5 cGVuYW1lID0gc3RkOjplbmFibGVfaWZfdDxPdGhlcjo6aXNQb2lzb25lZFVuaXF1ZVB0clR5cGUg JiYgc3RkOjppc19iYXNlX29mPFQsIHR5cGVuYW1lIE90aGVyOjpWYWx1ZVR5cGU+Ojp2YWx1ZT4+ CiAgICAgUG9pc29uZWRVbmlxdWVQdHImIG9wZXJhdG9yPShPdGhlciYmIHB0cikKICAgICB7CiAg ICAgICAgIEFTU0VSVCh0aGlzID09IHN0YXRpY19jYXN0PHZvaWQqPigmcHRyKSB8fCB0aGlzLT51 bnBvaXNvbmVkKCkgIT0gcHRyLnVucG9pc29uZWQoKSk7CkBAIC0xMzMsNyArMTMzLDcgQEAgY2xh c3MgUG9pc29uZWRVbmlxdWVQdHI8UG9pc29uLCBUW10+IDogcAogICAgIFdURl9NQUtFX0ZBU1Rf QUxMT0NBVEVEOwogICAgIHVzaW5nIEJhc2UgPSBQb2lzb25lZDxQb2lzb24sIFQqPjsKIHB1Ymxp YzoKLSAgICBzdGF0aWMgY29uc3RleHByIGJvb2wgaXNQb2lzb25lZFVuaXF1ZVB0ciA9IHRydWU7 CisgICAgc3RhdGljIGNvbnN0ZXhwciBib29sIGlzUG9pc29uZWRVbmlxdWVQdHJUeXBlID0gdHJ1 ZTsKICAgICB1c2luZyBWYWx1ZVR5cGUgPSBUW107CiAKICAgICBQb2lzb25lZFVuaXF1ZVB0cigp ID0gZGVmYXVsdDsKQEAgLTE0Miw3ICsxNDIsNyBAQCBwdWJsaWM6CiAgICAgUG9pc29uZWRVbmlx dWVQdHIoUG9pc29uZWRVbmlxdWVQdHImJiBwdHIpIDogQmFzZShXVEZNb3ZlKHB0cikpIHsgcHRy LmNsZWFyV2l0aG91dERlc3Ryb3koKTsgfQogICAgIFBvaXNvbmVkVW5pcXVlUHRyKHN0ZDo6dW5p cXVlX3B0cjxUW10+JiYgdW5pcXVlKSA6IFBvaXNvbmVkVW5pcXVlUHRyKHVuaXF1ZS5yZWxlYXNl KCkpIHsgfQogCi0gICAgdGVtcGxhdGU8dHlwZW5hbWUgT3RoZXIsIHR5cGVuYW1lID0gc3RkOjpl bmFibGVfaWZfdDxPdGhlcjo6aXNQb2lzb25lZFVuaXF1ZVB0ciAmJiBzdGQ6OmlzX3NhbWU8VFtd LCB0eXBlbmFtZSBPdGhlcjo6VmFsdWVUeXBlPjo6dmFsdWU+PgorICAgIHRlbXBsYXRlPHR5cGVu YW1lIE90aGVyLCB0eXBlbmFtZSA9IHN0ZDo6ZW5hYmxlX2lmX3Q8T3RoZXI6OmlzUG9pc29uZWRV bmlxdWVQdHJUeXBlICYmIHN0ZDo6aXNfc2FtZTxUW10sIHR5cGVuYW1lIE90aGVyOjpWYWx1ZVR5 cGU+Ojp2YWx1ZT4+CiAgICAgUG9pc29uZWRVbmlxdWVQdHIoT3RoZXImJiBwdHIpCiAgICAgICAg IDogQmFzZShwdHIudW5wb2lzb25lZCgpKQogICAgIHsKQEAgLTE3OCw3ICsxNzgsNyBAQCBwdWJs aWM6CiAgICAgICAgIHJldHVybiAqdGhpczsKICAgICB9CiAKLSAgICB0ZW1wbGF0ZTx0eXBlbmFt ZSBPdGhlciwgdHlwZW5hbWUgPSBzdGQ6OmVuYWJsZV9pZl90PE90aGVyOjppc1BvaXNvbmVkVW5p cXVlUHRyICYmIHN0ZDo6aXNfc2FtZTxUW10sIHR5cGVuYW1lIE90aGVyOjpWYWx1ZVR5cGU+Ojp2 YWx1ZT4+CisgICAgdGVtcGxhdGU8dHlwZW5hbWUgT3RoZXIsIHR5cGVuYW1lID0gc3RkOjplbmFi bGVfaWZfdDxPdGhlcjo6aXNQb2lzb25lZFVuaXF1ZVB0clR5cGUgJiYgc3RkOjppc19zYW1lPFRb XSwgdHlwZW5hbWUgT3RoZXI6OlZhbHVlVHlwZT46OnZhbHVlPj4KICAgICBQb2lzb25lZFVuaXF1 ZVB0ciYgb3BlcmF0b3I9KE90aGVyJiYgcHRyKQogICAgIHsKICAgICAgICAgQVNTRVJUKHRoaXMg PT0gc3RhdGljX2Nhc3Q8dm9pZCo+KCZwdHIpIHx8IHRoaXMtPnVucG9pc29uZWQoKSAhPSBwdHIu dW5wb2lzb25lZCgpKTsK