182142 2018-01-25 13:28:57 -0800 Trivially cleanup std::optional usage in RenderBlockFlow. 2018-01-29 14:36:41 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 emilio webkit-unassigned bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1393237 0 emilio 2018-01-25 13:28:57 -0800 Just removing some unneeded casts and using nullopt. 1393243 1 332307 emilio 2018-01-25 13:30:35 -0800 Created attachment 332307 Patch 1394257 2 332307 koivisto 2018-01-29 14:09:21 -0800 Comment on attachment 332307 Patch r=me 1394269 3 332307 commit-queue 2018-01-29 14:35:11 -0800 Comment on attachment 332307 Patch Clearing flags on attachment: 332307 Committed r227757: <https://trac.webkit.org/changeset/227757> 1394270 4 commit-queue 2018-01-29 14:35:12 -0800 All reviewed patches have been landed. Closing bug. 1394272 5 webkit-bug-importer 2018-01-29 14:36:41 -0800 <rdar://problem/37002109> 332307 2018-01-25 13:30:35 -0800 2018-01-29 14:35:11 -0800 Patch bug-182142-20180125223034.patch text/plain 3487 emilio U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3Mjk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmMwZTkyNGNmMGE3MTc5 NDc1NzExMDc0ZWUyYjNlNTA2ODg0M2NjNS4uZmIxNWFhYTMyMjIyYmQyMTE0ZmJlNzc2YzhiYTY5 YWU0ZjcwMzM1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTAxLTI1ICBFbWls aW8gQ29ib3Mgw4FsdmFyZXogIDxlbWlsaW9AY3Jpc2FsLmlvPgorCisgICAgICAgIFRyaXZpYWxs eSBjbGVhbnVwIHN0ZDo6b3B0aW9uYWwgdXNhZ2UgaW4gUmVuZGVyQmxvY2tGbG93LgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyMTQyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBu byBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrRmxvdzo6Zmlyc3RMaW5lQmFzZWxp bmUgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2tGbG93OjppbmxpbmVCbG9j a0Jhc2VsaW5lIGNvbnN0KToKKwogMjAxOC0wMS0yNSAgRW1pbGlvIENvYm9zIMOBbHZhcmV6ICA8 ZW1pbGlvQGNyaXNhbC5pbz4KIAogICAgICAgICBSZW1vdmUgdXNlbGVzcyBSZW5kZXJCbG9ja0Zs b3cgb3ZlcnJpZGVzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJsb2NrRmxvdy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93 LmNwcAppbmRleCBjY2NmOTdmODk1YWE0YThmY2UyMTQ4ZTBiOGFlNTVhNDYwNGEyOTYzLi4xMGQ3 YjcxNTEyOTAzNWJjMmMyNjU0N2EzNjhlNTRjZjI1YWRjZjcyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcApAQCAtMzAxMCwxMyArMzAxMCwxMyBAQCB2 b2lkIFJlbmRlckJsb2NrRmxvdzo6bWFya0xpbmVzRGlydHlJbkJsb2NrUmFuZ2UoTGF5b3V0VW5p dCBsb2dpY2FsVG9wLCBMYXlvdXRVbgogc3RkOjpvcHRpb25hbDxpbnQ+IFJlbmRlckJsb2NrRmxv dzo6Zmlyc3RMaW5lQmFzZWxpbmUoKSBjb25zdAogewogICAgIGlmIChpc1dyaXRpbmdNb2RlUm9v dCgpICYmICFpc1J1YnlSdW4oKSkKLSAgICAgICAgcmV0dXJuIHN0ZDo6b3B0aW9uYWw8aW50Pigp OworICAgICAgICByZXR1cm4gc3RkOjpudWxsb3B0OwogCiAgICAgaWYgKCFjaGlsZHJlbklubGlu ZSgpKQogICAgICAgICByZXR1cm4gUmVuZGVyQmxvY2s6OmZpcnN0TGluZUJhc2VsaW5lKCk7CiAK ICAgICBpZiAoIWhhc0xpbmVzKCkpCi0gICAgICAgIHJldHVybiBzdGQ6Om9wdGlvbmFsPGludD4o KTsKKyAgICAgICAgcmV0dXJuIHN0ZDo6bnVsbG9wdDsKIAogICAgIGlmIChhdXRvIHNpbXBsZUxp bmVMYXlvdXQgPSB0aGlzLT5zaW1wbGVMaW5lTGF5b3V0KCkpCiAgICAgICAgIHJldHVybiBzdGQ6 Om9wdGlvbmFsPGludD4oU2ltcGxlTGluZUxheW91dDo6Y29tcHV0ZUZsb3dGaXJzdExpbmVCYXNl bGluZSgqdGhpcywgKnNpbXBsZUxpbmVMYXlvdXQpKTsKQEAgLTMwMjgsNyArMzAyOCw3IEBAIHN0 ZDo6b3B0aW9uYWw8aW50PiBSZW5kZXJCbG9ja0Zsb3c6OmZpcnN0TGluZUJhc2VsaW5lKCkgY29u c3QKIHN0ZDo6b3B0aW9uYWw8aW50PiBSZW5kZXJCbG9ja0Zsb3c6OmlubGluZUJsb2NrQmFzZWxp bmUoTGluZURpcmVjdGlvbk1vZGUgbGluZURpcmVjdGlvbikgY29uc3QKIHsKICAgICBpZiAoaXNX cml0aW5nTW9kZVJvb3QoKSAmJiAhaXNSdWJ5UnVuKCkpCi0gICAgICAgIHJldHVybiBzdGQ6Om9w dGlvbmFsPGludD4oKTsKKyAgICAgICAgcmV0dXJuIHN0ZDo6bnVsbG9wdDsKIAogICAgIC8vIE5v dGUgdGhhdCBoZXJlIHdlIG9ubHkgdGFrZSB0aGUgbGVmdCBhbmQgYm90dG9tIGludG8gY29uc2lk ZXJhdGlvbi4gT3VyIGNhbGxlciB0YWtlcyB0aGUgcmlnaHQgYW5kIHRvcCBpbnRvIGNvbnNpZGVy YXRpb24uCiAgICAgZmxvYXQgYm94SGVpZ2h0ID0gbGluZURpcmVjdGlvbiA9PSBIb3Jpem9udGFs TGluZSA/IGhlaWdodCgpICsgbV9tYXJnaW5Cb3guYm90dG9tKCkgOiB3aWR0aCgpICsgbV9tYXJn aW5Cb3gubGVmdCgpOwpAQCAtMzA0MSw3ICszMDQxLDcgQEAgc3RkOjpvcHRpb25hbDxpbnQ+IFJl bmRlckJsb2NrRmxvdzo6aW5saW5lQmxvY2tCYXNlbGluZShMaW5lRGlyZWN0aW9uTW9kZSBsaW5l RGkKICAgICB9IGVsc2UgewogICAgICAgICBpZiAoIWhhc0xpbmVzKCkpIHsKICAgICAgICAgICAg IGlmICghaGFzTGluZUlmRW1wdHkoKSkKLSAgICAgICAgICAgICAgICByZXR1cm4gc3RkOjpvcHRp b25hbDxpbnQ+KCk7CisgICAgICAgICAgICAgICAgcmV0dXJuIHN0ZDo6bnVsbG9wdDsKICAgICAg ICAgICAgIGNvbnN0IGF1dG8mIGZvbnRNZXRyaWNzID0gZmlyc3RMaW5lU3R5bGUoKS5mb250TWV0 cmljcygpOwogICAgICAgICAgICAgcmV0dXJuIHN0ZDo6b3B0aW9uYWw8aW50Pihmb250TWV0cmlj cy5hc2NlbnQoKQogICAgICAgICAgICAgICAgICsgKGxpbmVIZWlnaHQodHJ1ZSwgbGluZURpcmVj dGlvbiwgUG9zaXRpb25PZkludGVyaW9yTGluZUJveGVzKSAtIGZvbnRNZXRyaWNzLmhlaWdodCgp KSAvIDIKQEAgLTMwNTksNyArMzA1OSw3IEBAIHN0ZDo6b3B0aW9uYWw8aW50PiBSZW5kZXJCbG9j a0Zsb3c6OmlubGluZUJsb2NrQmFzZWxpbmUoTGluZURpcmVjdGlvbk1vZGUgbGluZURpCiAgICAg Ly8gQWNjb3JkaW5nIHRvIHRoZSBDU1Mgc3BlYyBodHRwOi8vd3d3LnczLm9yZy9UUi9DU1MyMS92 aXN1ZGV0Lmh0bWwsIHdlIHNob3VsZG4ndCBiZSBwZXJmb3JtaW5nIHRoaXMgbWluLCBidXQgc2hv dWxkCiAgICAgLy8gaW5zdGVhZCBiZSByZXR1cm5pbmcgYm94SGVpZ2h0IGRpcmVjdGx5LiBIb3dl dmVyLCB3ZSBmZWVsIHRoYXQgYSBtaW4gaGVyZSBpcyBiZXR0ZXIgYmVoYXZpb3IgKGFuZCBpcyBj b25zaXN0ZW50CiAgICAgLy8gZW5vdWdoIHdpdGggdGhlIHNwZWMgdG8gbm90IGNhdXNlIHRvbnMg b2YgYnJlYWthZ2VzKS4KLSAgICByZXR1cm4gc3RkOjpvcHRpb25hbDxpbnQ+KHN0eWxlKCkub3Zl cmZsb3dZKCkgPT0gT1ZJU0lCTEUgPyBsYXN0QmFzZWxpbmUgOiBzdGQ6Om1pbihib3hIZWlnaHQs IGxhc3RCYXNlbGluZSkpOworICAgIHJldHVybiBzdHlsZSgpLm92ZXJmbG93WSgpID09IE9WSVNJ QkxFID8gbGFzdEJhc2VsaW5lIDogc3RkOjptaW4oYm94SGVpZ2h0LCBsYXN0QmFzZWxpbmUpOwog fQogCiB2b2lkIFJlbmRlckJsb2NrRmxvdzo6c2V0U2VsZWN0aW9uU3RhdGUoU2VsZWN0aW9uU3Rh dGUgc3RhdGUpCg==