182136 2018-01-25 12:22:05 -0800 [webkitpy] Stop modifying path information only when running on Cygwin 2018-01-26 09:03:16 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 basuke basuke achristensen basuke bfulgham commit-queue don.olmstead ews-watchlist glenn jbedard lforschler pvollan rniwa webkit-bug-importer oldest_to_newest 1393204 0 basuke 2018-01-25 12:22:05 -0800 On LayoutTestApacheHttpd, some path configuration is modified when platform is Windows. This modification is only required for AppleWin running on Cygwin. WinCairo uses native Windows environment, so the condition should be changed. 1393206 1 332299 basuke 2018-01-25 12:24:22 -0800 Created attachment 332299 Patch 1393216 2 332299 pvollan 2018-01-25 12:59:29 -0800 Comment on attachment 332299 Patch R=me. 1393221 3 jbedard 2018-01-25 13:08:05 -0800 Can we wait until Windows EWS comes back green to land this? 1393223 4 basuke 2018-01-25 13:08:45 -0800 Of course. 1393224 5 basuke 2018-01-25 13:11:32 -0800 It is green, but win EWS doesn't say test passed. Does it actually run layout tests? 1393265 6 332299 commit-queue 2018-01-25 14:04:14 -0800 Comment on attachment 332299 Patch Clearing flags on attachment: 332299 Committed r227629: <https://trac.webkit.org/changeset/227629> 1393266 7 commit-queue 2018-01-25 14:04:16 -0800 All reviewed patches have been landed. Closing bug. 1393267 8 webkit-bug-importer 2018-01-25 14:05:25 -0800 <rdar://problem/36882114> 1393316 9 jbedard 2018-01-25 15:13:16 -0800 (In reply to Basuke Suzuki from comment #5) > It is green, but win EWS doesn't say test passed. Does it actually run > layout tests? I forgot about that....I think you are correct, windows EWS does not run layout tests. 1393538 10 jbedard 2018-01-26 09:03:16 -0800 The patch was picked up by CI, but something else seems to have broken windows http servers. They start failing here https://build.webkit.org/builders/Apple%20Win%207%20Debug%20%28Tests%29/builds/2015, but this is before <https://trac.webkit.org/changeset/227629>. 332299 2018-01-25 12:24:22 -0800 2018-01-25 14:04:14 -0800 Patch 182136.diff text/plain 2233 basuke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxYzcz Zjk3OWJiOS4uZTNhNmQ5MDdkODUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxOC0wMS0yNSAgQmFzdWtlIFN1enVr aSAgPEJhc3VrZS5TdXp1a2lAc29ueS5jb20+CisKKyAgICAgICAgW3dlYmtpdHB5XSBTdG9wIG1v ZGlmeWluZyBwYXRoIGluZm9ybWF0aW9uIG9ubHkgd2hlbiBydW5uaW5nIG9uIEN5Z3dpbgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyMTM2CisKKyAg ICAgICAgT24gTGF5b3V0VGVzdEFwYWNoZUh0dHBkLCBzb21lIHBhdGggY29uZmlndXJhdGlvbiBp cyBtb2RpZmllZCB3aGVuIHBsYXRmb3JtCisgICAgICAgIGlzIFdpbmRvd3MuIFRoaXMgbW9kaWZp Y2F0aW9uIGlzIG9ubHkgcmVxdWlyZWQgZm9yIEFwcGxlV2luIHJ1bm5pbmcgb24gQ3lnd2luLgor ICAgICAgICBXaW5DYWlybyB1c2VzIG5hdGl2ZSBXaW5kb3dzIGVudmlyb25tZW50LCBzbyB0aGUg Y29uZGl0aW9uIHNob3VsZCBiZSBjaGFuZ2VkLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvc2Vy dmVycy9hcGFjaGVfaHR0cF9zZXJ2ZXIucHk6CisgICAgICAgIChMYXlvdXRUZXN0QXBhY2hlSHR0 cGQuX19pbml0X18pOgorICAgICAgICAoTGF5b3V0VGVzdEFwYWNoZUh0dHBkLl9nZXRfYXBhY2hl X2NvbmZpZ19maWxlX3BhdGgpOgorCiAyMDE4LTAxLTIzICBDb21taXQgUXVldWUgIDxjb21taXQt cXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjI3 Mjc5IGFuZCByMjI3MzczLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvc2VydmVycy9hcGFjaGVfaHR0cF9zZXJ2ZXIucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9zZXJ2ZXJzL2FwYWNoZV9odHRwX3NlcnZlci5weQppbmRleCA3 NTVjZjc4YTI0Ny4uOGI3Y2VjM2YzMjEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3NlcnZlcnMvYXBhY2hlX2h0dHBfc2VydmVyLnB5CisrKyBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3NlcnZlcnMvYXBhY2hlX2h0dHBfc2VydmVy LnB5CkBAIC02NCw3ICs2NCw3IEBAIGNsYXNzIExheW91dFRlc3RBcGFjaGVIdHRwZChodHRwX3Nl cnZlcl9iYXNlLkh0dHBTZXJ2ZXJCYXNlKToKIAogICAgICAgICBzZWxmLl9waWRfZmlsZSA9IHNl bGYuX2ZpbGVzeXN0ZW0uam9pbihzZWxmLl9ydW50aW1lX3BhdGgsICclcy5waWQnICUgc2VsZi5f bmFtZSkKIAotICAgICAgICBpZiBwb3J0X29iai5ob3N0LnBsYXRmb3JtLmlzX3dpbigpOgorICAg ICAgICBpZiBwb3J0X29iai5ob3N0LnBsYXRmb3JtLmlzX2N5Z3dpbigpOgogICAgICAgICAgICAg IyBDb252ZXJ0IHRvIE1TRE9TIGZpbGUgbmFtaW5nOgogICAgICAgICAgICAgcHJlY29tcGlsZWRC dWlsZGJvdCA9IHJlLmNvbXBpbGUoJ14vaG9tZS9idWlsZGJvdCcpCiAgICAgICAgICAgICBwcmVj b21waWxlZERyaXZlID0gcmUuY29tcGlsZSgnXi9jeWdkcml2ZS9bY0NdJykKQEAgLTE2Niw3ICsx NjYsNyBAQCBjbGFzcyBMYXlvdXRUZXN0QXBhY2hlSHR0cGQoaHR0cF9zZXJ2ZXJfYmFzZS5IdHRw U2VydmVyQmFzZSk6CiAgICAgICAgICMgRklYTUU6IFdoeSBkbyB3ZSBuZWVkIHRvIGNvcHkgdGhl IGNvbmZpZyBmaWxlIHNpbmNlIHdlJ3JlIG5vdCBtb2RpZnlpbmcgaXQ/CiAgICAgICAgIHNlbGYu X2ZpbGVzeXN0ZW0ud3JpdGVfdGV4dF9maWxlKGh0dHBkX2NvbmZpZ19jb3B5LCBodHRwZF9jb25m KQogCi0gICAgICAgIGlmIHNlbGYuX3BvcnRfb2JqLmhvc3QucGxhdGZvcm0uaXNfd2luKCk6Cisg ICAgICAgIGlmIHNlbGYuX3BvcnRfb2JqLmhvc3QucGxhdGZvcm0uaXNfY3lnd2luKCk6CiAgICAg ICAgICAgICAjIENvbnZlcnQgdG8gTVNET1MgZmlsZSBuYW1pbmc6CiAgICAgICAgICAgICBwcmVj b21waWxlZERyaXZlID0gcmUuY29tcGlsZSgnXi9jeWdkcml2ZS9bY0NdJykKICAgICAgICAgICAg IGh0dHBkX2NvbmZpZ19jb3B5ID0gcHJlY29tcGlsZWREcml2ZS5zdWIoIkM6IiwgaHR0cGRfY29u ZmlnX2NvcHkpCg==