182131 2018-01-25 12:06:50 -0800 [webkitpy] Config file for apache is copied twice. 2018-01-31 10:06:29 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 basuke basuke achristensen basuke bfulgham commit-queue dbates ews-watchlist glenn jbedard lforschler pvollan rniwa webkit-bug-importer oldest_to_newest 1393179 0 basuke 2018-01-25 12:06:50 -0800 Config file is copied in _get_apache_config_file_path(), but it is called twice. 1393201 1 332297 basuke 2018-01-25 12:16:49 -0800 Created attachment 332297 fix 1394883 2 332297 dbates 2018-01-30 20:14:37 -0800 Comment on attachment 332297 fix View in context: https://bugs.webkit.org/attachment.cgi?id=332297&action=review > Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server.py:95 > + '-f', "\"%s\"" % config_file_path, It would be good to understand why we need to copy the config file to begin with. This is unrelated to your patch. 1394889 3 332297 commit-queue 2018-01-30 20:27:46 -0800 Comment on attachment 332297 fix Clearing flags on attachment: 332297 Committed r227871: <https://trac.webkit.org/changeset/227871> 1394890 4 commit-queue 2018-01-30 20:27:47 -0800 All reviewed patches have been landed. Closing bug. 1394892 5 webkit-bug-importer 2018-01-30 20:28:21 -0800 <rdar://problem/37054960> 1395042 6 basuke 2018-01-31 10:06:29 -0800 > It would be good to understand why we need to copy the config file to begin > with. This is unrelated to your patch. Agreed. Who has the context of this? My guess is that somebody had tried to modify config file to configure, but later passing them by arguments was okay and accepted. Then coping just left as is. 332297 2018-01-25 12:16:49 -0800 2018-01-30 20:27:46 -0800 fix 182131.diff text/plain 2681 basuke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxYzcz Zjk3OWJiOS4uYjIxZTc5NWQxYzcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxOC0wMS0yNSAgQmFzdWtlIFN1enVr aSAgPEJhc3VrZS5TdXp1a2lAc29ueS5jb20+CisKKyAgICAgICAgW3dlYmtpdHB5XSBDb25maWcg ZmlsZSBmb3IgYXBhY2hlIGlzIGNvcGllZCB0d2ljZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjEzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv c2VydmVycy9hcGFjaGVfaHR0cF9zZXJ2ZXIucHk6CisgICAgICAgIChMYXlvdXRUZXN0QXBhY2hl SHR0cGQuX19pbml0X18pOgorICAgICAgICAoTGF5b3V0VGVzdEFwYWNoZUh0dHBkLl9jb3B5X2Fw YWNoZV9jb25maWdfZmlsZSk6CisgICAgICAgIChMYXlvdXRUZXN0QXBhY2hlSHR0cGQuX2dldF9h cGFjaGVfY29uZmlnX2ZpbGVfcGF0aCk6IERlbGV0ZWQuCisKIDIwMTgtMDEtMjMgIENvbW1pdCBR dWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJv bGxpbmcgb3V0IHIyMjcyNzkgYW5kIHIyMjczNzMuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9zZXJ2ZXJzL2FwYWNoZV9odHRwX3NlcnZlci5weSBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3NlcnZlcnMvYXBhY2hlX2h0dHBfc2Vy dmVyLnB5CmluZGV4IDc1NWNmNzhhMjQ3Li4wZDIzZDMxYTY2YiAxMDA2NDQKLS0tIGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvc2VydmVycy9hcGFjaGVfaHR0cF9zZXJ2ZXIu cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvc2VydmVycy9hcGFj aGVfaHR0cF9zZXJ2ZXIucHkKQEAgLTg5LDkgKzg5LDEwIEBAIGNsYXNzIExheW91dFRlc3RBcGFj aGVIdHRwZChodHRwX3NlcnZlcl9iYXNlLkh0dHBTZXJ2ZXJCYXNlKToKIAogICAgICAgICAjIEZJ WE1FOiBXZSBzaG91bGRuJ3QgYmUgY2FsbGluZyBhIHByb3RlY3RlZCBtZXRob2Qgb2YgX3BvcnRf b2JqIQogICAgICAgICBleGVjdXRhYmxlID0gc2VsZi5fcG9ydF9vYmouX3BhdGhfdG9fYXBhY2hl KCkKKyAgICAgICAgY29uZmlnX2ZpbGVfcGF0aCA9IHNlbGYuX2NvcHlfYXBhY2hlX2NvbmZpZ19m aWxlKHNlbGYudGVzdHNfZGlyLCBvdXRwdXRfZGlyKQogCiAgICAgICAgIHN0YXJ0X2NtZCA9IFtl eGVjdXRhYmxlLAotICAgICAgICAgICAgJy1mJywgIlwiJXNcIiIgJSBzZWxmLl9nZXRfYXBhY2hl X2NvbmZpZ19maWxlX3BhdGgoc2VsZi50ZXN0c19kaXIsIG91dHB1dF9kaXIpLAorICAgICAgICAg ICAgJy1mJywgIlwiJXNcIiIgJSBjb25maWdfZmlsZV9wYXRoLAogICAgICAgICAgICAgJy1DJywg IlwnRG9jdW1lbnRSb290IFwiJXNcIlwnIiAlIGRvY3VtZW50X3Jvb3QsCiAgICAgICAgICAgICAn LWMnLCAiXCdUeXBlc0NvbmZpZyBcIiVzXCJcJyIgJSBtaW1lX3R5cGVzX3BhdGgsCiAgICAgICAg ICAgICAnLWMnLCAiXCdQSFBJTklEaXIgXCIlc1wiXCciICUgcGhwX2luaV9kaXIsCkBAIC0xNDEs NyArMTQyLDcgQEAgY2xhc3MgTGF5b3V0VGVzdEFwYWNoZUh0dHBkKGh0dHBfc2VydmVyX2Jhc2Uu SHR0cFNlcnZlckJhc2UpOgogICAgICAgICAgICAgICAgICAgICAgICAgJy1jJywgIlwnPC9Mb2Nh dGlvbj5cJyJdCiAKICAgICAgICAgc3RvcF9jbWQgPSBbZXhlY3V0YWJsZSwKLSAgICAgICAgICAg ICctZicsICJcIiVzXCIiICUgc2VsZi5fZ2V0X2FwYWNoZV9jb25maWdfZmlsZV9wYXRoKHNlbGYu dGVzdHNfZGlyLCBvdXRwdXRfZGlyKSwKKyAgICAgICAgICAgICctZicsICJcIiVzXCIiICUgY29u ZmlnX2ZpbGVfcGF0aCwKICAgICAgICAgICAgICctYycsICJcJ1BpZEZpbGUgJXMnIiAlIHNlbGYu X3BpZF9maWxlLAogICAgICAgICAgICAgJy1rJywgInN0b3AiXQogCkBAIC0xNTMsOCArMTU0LDgg QEAgY2xhc3MgTGF5b3V0VGVzdEFwYWNoZUh0dHBkKGh0dHBfc2VydmVyX2Jhc2UuSHR0cFNlcnZl ckJhc2UpOgogICAgICAgICBzZWxmLl9zdGFydF9jbWQgPSAiICIuam9pbihzdGFydF9jbWQpCiAg ICAgICAgIHNlbGYuX3N0b3BfY21kID0gIiAiLmpvaW4oc3RvcF9jbWQpCiAKLSAgICBkZWYgX2dl dF9hcGFjaGVfY29uZmlnX2ZpbGVfcGF0aChzZWxmLCB0ZXN0X2Rpciwgb3V0cHV0X2Rpcik6Ci0g ICAgICAgICIiIlJldHVybnMgdGhlIHBhdGggdG8gdGhlIGFwYWNoZSBjb25maWcgZmlsZSB0byB1 c2UuCisgICAgZGVmIF9jb3B5X2FwYWNoZV9jb25maWdfZmlsZShzZWxmLCB0ZXN0X2Rpciwgb3V0 cHV0X2Rpcik6CisgICAgICAgICIiIkNvcHkgYXBhY2hlIGNvbmZpZyBmaWxlIGFuZCByZXR1cm5z IHRoZSBwYXRoIHRvIHVzZS4KICAgICAgICAgQXJnczoKICAgICAgICAgICB0ZXN0X2RpcjogYWJz b2x1dGUgcGF0aCB0byB0aGUgTGF5b3V0VGVzdHMgZGlyZWN0b3J5LgogICAgICAgICAgIG91dHB1 dF9kaXI6IGFic29sdXRlIHBhdGggdG8gdGhlIGxheW91dCB0ZXN0IHJlc3VsdHMgZGlyZWN0b3J5 Lgo=