182116 2018-01-25 11:34:20 -0800 Make sure we have a frame as we iterate in ResourceLoadObserver::nonNullOwnerURL() 2018-01-25 14:31:36 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wilander wilander achristensen bfulgham cdumez dbates ews-watchlist japhet webkit-bug-importer oldest_to_newest 1393151 0 wilander 2018-01-25 11:34:20 -0800 We need to check that we have a frame before using it as we traverse the frame hierarchy up to find a non-null URL in ResourceLoadObserver::nonNullOwnerURL(). 1393152 1 wilander 2018-01-25 11:34:40 -0800 rdar://problem/36210134 1393159 2 332294 wilander 2018-01-25 11:39:11 -0800 Created attachment 332294 Patch 1393163 3 wilander 2018-01-25 11:46:04 -0800 In the case where we don't have a frame, the returned URL is empty which through the call to ResourceLoadStatistics::primaryDomain() becomes "nullOrigin". 1393295 4 wilander 2018-01-25 14:31:21 -0800 Committed r227632: <https://trac.webkit.org/changeset/227632> 1393296 5 wilander 2018-01-25 14:31:36 -0800 Thanks, Alex! 332294 2018-01-25 11:39:11 -0800 2018-01-25 14:28:18 -0800 Patch bug-182116-20180125113911.patch text/plain 1460 wilander SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNzYxOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE4LTAxLTI1ICBKb2huIFdp bGFuZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgorCisgICAgICAgIE1ha2Ugc3VyZSB3ZSBoYXZl IGEgZnJhbWUgYXMgd2UgaXRlcmF0ZSBpbiBSZXNvdXJjZUxvYWRPYnNlcnZlcjo6bm9uTnVsbE93 bmVyVVJMKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4MjExNgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzYyMTAxMzQ+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBrbm93 biByZXBybyBjYXNlLCBqdXN0IGNyYXNoIGxvZ3MuCisKKyAgICAgICAgKiBsb2FkZXIvUmVzb3Vy Y2VMb2FkT2JzZXJ2ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VMb2FkT2JzZXJ2 ZXI6Om5vbk51bGxPd25lclVSTCBjb25zdCk6CisKIDIwMTgtMDEtMjUgIEFudG9pbmUgUXVpbnQg IDxncmFvdXRzQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViIEFuaW1hdGlvbnNdIEF2b2lkIHF1 ZXJ5aW5nIHRoZSBjdXJyZW50IHRpbWUgbXVsdGlwbGUgdGltZSB3aGVuIHJlc29sdmluZyB0aGUg cGxheSBzdGF0ZQpJbmRleDogU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZE9ic2Vy dmVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2Fk T2JzZXJ2ZXIuY3BwCShyZXZpc2lvbiAyMjc2MTUpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIv UmVzb3VyY2VMb2FkT2JzZXJ2ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zODMsNyArMzgzLDcg QEAgVVJMIFJlc291cmNlTG9hZE9ic2VydmVyOjpub25OdWxsT3duZXJVUgogICAgIGF1dG8qIGZy YW1lID0gZG9jdW1lbnQuZnJhbWUoKTsKICAgICBhdXRvIGhvc3QgPSBkb2N1bWVudC51cmwoKS5o b3N0KCk7CiAKLSAgICB3aGlsZSAoKGhvc3QuaXNOdWxsKCkgfHwgaG9zdC5pc0VtcHR5KCkpICYm ICFmcmFtZS0+aXNNYWluRnJhbWUoKSkgeworICAgIHdoaWxlICgoaG9zdC5pc051bGwoKSB8fCBo b3N0LmlzRW1wdHkoKSkgJiYgZnJhbWUgJiYgIWZyYW1lLT5pc01haW5GcmFtZSgpKSB7CiAgICAg ICAgIGF1dG8qIG93bmVyRWxlbWVudCA9IGZyYW1lLT5vd25lckVsZW1lbnQoKTsKIAogICAgICAg ICBBU1NFUlQob3duZXJFbGVtZW50ICE9IG51bGxwdHIpOwo=