182114 2018-01-25 11:16:36 -0800 Fix crash when preconnecting while closing private browsing 2018-01-25 12:14:22 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen joepeck webkit-bug-importer oldest_to_newest 1393134 0 achristensen 2018-01-25 11:16:36 -0800 Fix crash when preconnecting while closing private browsing 1393136 1 332288 achristensen 2018-01-25 11:18:31 -0800 Created attachment 332288 Patch 1393165 2 332288 joepeck 2018-01-25 11:47:46 -0800 Comment on attachment 332288 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332288&action=review r=me > Source/WebKit/NetworkProcess/PreconnectTask.cpp:50 > ASSERT(networkSession); We should probably remove this assert. Or make a better assert inside of the block, since it sounds like we have a series of events where we know this can happen. 1393184 3 achristensen 2018-01-25 12:13:53 -0800 trac.webkit.org/r227621 1393187 4 webkit-bug-importer 2018-01-25 12:14:22 -0800 <rdar://problem/36877885> 332288 2018-01-25 11:18:31 -0800 2018-01-25 11:47:46 -0800 Patch bug-182114-20180125111830.patch text/plain 1736 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjc2MTUpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE4LTAxLTI1ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGNyYXNoIHdo ZW4gcHJlY29ubmVjdGluZyB3aGlsZSBjbG9zaW5nIHByaXZhdGUgYnJvd3NpbmcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjExNAorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMzU2MzcyODQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9QcmVjb25uZWN0VGFzay5jcHA6Cisg ICAgICAgIFRoZXJlIGlzIGEgcmFjZSBjb25kaXRpb24gd2hlbiBkZXN0cm95aW5nIGEgc2Vzc2lv biB3aGlsZSBhIHBhZ2UgaXMgaW5pdGlhdGluZyBhIHByZWNvbm5lY3QuCisgICAgICAgIElmIHRo aXMgaGFwcGVucywgZmFpbCBncmFjZWZ1bGx5IGluc3RlYWQgb2YgdHJ5aW5nIHRvIHByZWNvbm5l Y3Qgd2l0aCBhIG51bGwgc2Vzc2lvbi4KKwogMjAxOC0wMS0yNSAgRGF2aWQgSHlhdHQgIDxoeWF0 dEBhcHBsZS5jb20+CiAKICAgICAgICAgRW5hYmxlIGxpbmVzIGNsYW1wIHN1cHBvcnQgZm9yIEFw cGxlIE1haWwgYnkgZGVmYXVsdApJbmRleDogU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9Q cmVjb25uZWN0VGFzay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9OZXR3b3JrUHJv Y2Vzcy9QcmVjb25uZWN0VGFzay5jcHAJKHJldmlzaW9uIDIyNzU5MCkKKysrIFNvdXJjZS9XZWJL aXQvTmV0d29ya1Byb2Nlc3MvUHJlY29ubmVjdFRhc2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0z Myw2ICszMyw3IEBACiAjaW5jbHVkZSAiTmV0d29ya0xvYWRQYXJhbWV0ZXJzLmgiCiAjaW5jbHVk ZSAiTmV0d29ya1Byb2Nlc3MuaCIKICNpbmNsdWRlICJTZXNzaW9uVHJhY2tlci5oIgorI2luY2x1 ZGUgIldlYkVycm9ycy5oIgogI2luY2x1ZGUgPFdlYkNvcmUvUmVzb3VyY2VFcnJvci5oPgogCiBu YW1lc3BhY2UgV2ViS2l0IHsKQEAgLTQ3LDYgKzQ4LDEwIEBAIFByZWNvbm5lY3RUYXNrOjpQcmVj b25uZWN0VGFzayhOZXR3b3JrTG8KIAogICAgIGF1dG8qIG5ldHdvcmtTZXNzaW9uID0gU2Vzc2lv blRyYWNrZXI6Om5ldHdvcmtTZXNzaW9uKHBhcmFtZXRlcnMuc2Vzc2lvbklEKTsKICAgICBBU1NF UlQobmV0d29ya1Nlc3Npb24pOworICAgIGlmICghbmV0d29ya1Nlc3Npb24pIHsKKyAgICAgICAg bV9jb21wbGV0aW9uSGFuZGxlcihpbnRlcm5hbEVycm9yKHBhcmFtZXRlcnMucmVxdWVzdC51cmwo KSkpOworICAgICAgICByZXR1cm47CisgICAgfQogCiAgICAgQVNTRVJUKHBhcmFtZXRlcnMuc2hv dWxkUHJlY29ubmVjdE9ubHkgPT0gUHJlY29ubmVjdE9ubHk6Olllcyk7CiAgICAgbV9uZXR3b3Jr TG9hZCA9IHN0ZDo6bWFrZV91bmlxdWU8TmV0d29ya0xvYWQ+KCp0aGlzLCBXVEZNb3ZlKHBhcmFt ZXRlcnMpLCAqbmV0d29ya1Nlc3Npb24pOwo=