182102 2018-01-25 07:39:40 -0800 [WebVR][GTK][WPE] Remove the WebVR public API added in r227518 2018-01-25 09:59:23 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 svillar svillar berto cgarcia ews-watchlist gustavo mcatanzaro webkit-bug-importer oldest_to_newest 1393038 0 svillar 2018-01-25 07:39:40 -0800 [WebVR][GTK][WPE] Remove the WebVR public API added in r227518 1393040 1 332265 svillar 2018-01-25 07:40:25 -0800 Created attachment 332265 Patch 1393041 2 ews-watchlist 2018-01-25 07:41:20 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1393042 3 332265 cgarcia 2018-01-25 07:45:02 -0800 Comment on attachment 332265 Patch Remember the changes in MB too. Thanks! 1393043 4 svillar 2018-01-25 07:47:51 -0800 Right I forgot to remove that too. Thanks for the quick review 1393045 5 svillar 2018-01-25 07:52:12 -0800 I also removed the new API from the docs 1393046 6 svillar 2018-01-25 07:52:27 -0800 Committed r227607: <https://trac.webkit.org/changeset/227607> 1393047 7 webkit-bug-importer 2018-01-25 07:53:15 -0800 <rdar://problem/36868357> 1393092 8 mcatanzaro 2018-01-25 09:59:23 -0800 Careful with prepare-ChangeLog! It's annoying; I usually double-check it before landing, and still forget sometimes.... 332265 2018-01-25 07:40:25 -0800 2018-01-25 07:45:14 -0800 Patch bug-182102-20180125164023.patch text/plain 6252 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3NjA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDY1MGM5OTEzZWNjMWUxYmYz NzM4MWIxZjkyNDkyYWNlM2JjYzNkZDYuLjIxOTU4ODUxZGE1MmI2Yzg5ZjM1NzVmY2U1Njk4ZDJi YWE3NTRjZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTgtMDEtMjUgIFNlcmdpbyBW aWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dlYlZSXVtHVEtd W1dQRV0gUmVtb3ZlIHRoZSBXZWJWUiBwdWJsaWMgQVBJIGFkZGVkIGluIHIyMjc1MTgKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjEwMgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgbmV3IHB1Ymxp YyBBUEkgd2FzIG5vdCBzdXBwb3NlZCB0byBiZSBpbmNsdWRlZCBpbiB0aGUgcGF0Y2gKKyAgICAg ICAgdGhhdCBhZGRlZCBPcGVuVlIgdG8gdGhlIHRyZWUgYW5kIHRvIHRoZSBidWlsZC4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRTZXR0aW5ncy5jcHA6CisgICAgICAgICh3 ZWJLaXRTZXR0aW5nc1NldFByb3BlcnR5KToKKyAgICAgICAgKHdlYktpdFNldHRpbmdzR2V0UHJv cGVydHkpOgorICAgICAgICAod2Via2l0X3NldHRpbmdzX2NsYXNzX2luaXQpOgorICAgICAgICAo d2Via2l0X3NldHRpbmdzX2dldF9lbmFibGVfd2VidnIpOiBEZWxldGVkLgorICAgICAgICAod2Vi a2l0X3NldHRpbmdzX3NldF9lbmFibGVfd2VidnIpOiBEZWxldGVkLgorICAgICAgICAqIFVJUHJv Y2Vzcy9BUEkvZ3RrL1dlYktpdFNldHRpbmdzLmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS93 cGUvV2ViS2l0U2V0dGluZ3MuaDoKKwogMjAxOC0wMS0yNSAgQ2FybG9zIEdhcmNpYSBDYW1wb3Mg IDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgV2ViRHJpdmVyOiB0ZXN0IGltcG9ydGVk L3NlbGVuaXVtL3B5L3Rlc3Qvc2VsZW5pdW0vd2ViZHJpdmVyL2NvbW1vbi9hbGVydHNfdGVzdHMu cHkgY3Jhc2hlcyBpbiBkZWJ1ZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv QVBJL2dsaWIvV2ViS2l0U2V0dGluZ3MuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L2dsaWIvV2ViS2l0U2V0dGluZ3MuY3BwCmluZGV4IDc4ZWUwMjhlODI3ODFiZWUxNDk3NWI4MWE4 YjM1YWYyMWQ0NjhhMWYuLmMzNzJiM2FlYjhiNWU5ZGQ2ZjVjZTIxYjM0YTA4YzYzYTVhY2ViYzcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFNldHRp bmdzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRTZXR0 aW5ncy5jcHAKQEAgLTE1OCw3ICsxNTgsNiBAQCBlbnVtIHsKICNpZiBQTEFURk9STShHVEspCiAg ICAgUFJPUF9IQVJEV0FSRV9BQ0NFTEVSQVRJT05fUE9MSUNZLAogI2VuZGlmCi0gICAgUFJPUF9F TkFCTEVfV0VCVlIsCiB9OwogCiBzdGF0aWMgdm9pZCB3ZWJLaXRTZXR0aW5nc0Rpc3Bvc2UoR09i amVjdCogb2JqZWN0KQpAQCAtMzY0LDkgKzM2Myw2IEBAIHN0YXRpYyB2b2lkIHdlYktpdFNldHRp bmdzU2V0UHJvcGVydHkoR09iamVjdCogb2JqZWN0LCBndWludCBwcm9wSWQsIGNvbnN0IEdWYWx1 CiAgICAgICAgIHdlYmtpdF9zZXR0aW5nc19zZXRfaGFyZHdhcmVfYWNjZWxlcmF0aW9uX3BvbGlj eShzZXR0aW5ncywgc3RhdGljX2Nhc3Q8V2ViS2l0SGFyZHdhcmVBY2NlbGVyYXRpb25Qb2xpY3k+ KGdfdmFsdWVfZ2V0X2VudW0odmFsdWUpKSk7CiAgICAgICAgIGJyZWFrOwogI2VuZGlmCi0gICAg Y2FzZSBQUk9QX0VOQUJMRV9XRUJWUjoKLSAgICAgICAgd2Via2l0X3NldHRpbmdzX3NldF9lbmFi bGVfd2VidnIoc2V0dGluZ3MsIGdfdmFsdWVfZ2V0X2Jvb2xlYW4odmFsdWUpKTsKLSAgICAgICAg YnJlYWs7CiAgICAgZGVmYXVsdDoKICAgICAgICAgR19PQkpFQ1RfV0FSTl9JTlZBTElEX1BST1BF UlRZX0lEKG9iamVjdCwgcHJvcElkLCBwYXJhbVNwZWMpOwogICAgICAgICBicmVhazsKQEAgLTUz OCw5ICs1MzQsNiBAQCBzdGF0aWMgdm9pZCB3ZWJLaXRTZXR0aW5nc0dldFByb3BlcnR5KEdPYmpl Y3QqIG9iamVjdCwgZ3VpbnQgcHJvcElkLCBHVmFsdWUqIHZhbAogICAgICAgICBnX3ZhbHVlX3Nl dF9lbnVtKHZhbHVlLCB3ZWJraXRfc2V0dGluZ3NfZ2V0X2hhcmR3YXJlX2FjY2VsZXJhdGlvbl9w b2xpY3koc2V0dGluZ3MpKTsKICAgICAgICAgYnJlYWs7CiAjZW5kaWYKLSAgICBjYXNlIFBST1Bf RU5BQkxFX1dFQlZSOgotICAgICAgICBnX3ZhbHVlX3NldF9ib29sZWFuKHZhbHVlLCB3ZWJraXRf c2V0dGluZ3NfZ2V0X2VuYWJsZV93ZWJ2cihzZXR0aW5ncykpOwotICAgICAgICBicmVhazsKICAg ICBkZWZhdWx0OgogICAgICAgICBHX09CSkVDVF9XQVJOX0lOVkFMSURfUFJPUEVSVFlfSUQob2Jq ZWN0LCBwcm9wSWQsIHBhcmFtU3BlYyk7CiAgICAgICAgIGJyZWFrOwpAQCAtMTM4NCwxOSArMTM3 Nyw2IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF9zZXR0aW5nc19jbGFzc19pbml0KFdlYktpdFNldHRp bmdzQ2xhc3MqIGtsYXNzKQogICAgICAgICAgICAgV0VCS0lUX0hBUkRXQVJFX0FDQ0VMRVJBVElP Tl9QT0xJQ1lfT05fREVNQU5ELAogICAgICAgICAgICAgcmVhZFdyaXRlQ29uc3RydWN0UGFyYW1G bGFncykpOwogI2VuZGlmIC8vIFBMQVRGT1RNKEdUSykKLQotICAgIC8qKgotICAgICogV2ViS2l0 U2V0dGluZ3M6ZW5hYmxlLXdlYnZyOgotICAgICoKLSAgICAqIEVuYWJsZSBvciBkaXNhYmxlIHN1 cHBvcnQgZm9yIFdlYlZSIG9uIHBhZ2VzLgotICAgICovCi0gICAgZ19vYmplY3RfY2xhc3NfaW5z dGFsbF9wcm9wZXJ0eShnT2JqZWN0Q2xhc3MsCi0gICAgICAgIFBST1BfRU5BQkxFX1dFQlZSLAot ICAgICAgICBnX3BhcmFtX3NwZWNfYm9vbGVhbigiZW5hYmxlLXdlYnZyIiwKLSAgICAgICAgICAg IF8oIkVuYWJsZSBXZWJWUiIpLAotICAgICAgICAgICAgXygiV2hldGhlciBXZWJWUiBjb250ZW50 IHNob3VsZCBiZSByZW5kZXJlZCIpLAotICAgICAgICAgICAgRkFMU0UsCi0gICAgICAgICAgICBy ZWFkV3JpdGVDb25zdHJ1Y3RQYXJhbUZsYWdzKSk7CiB9CiAKIFdlYlByZWZlcmVuY2VzKiB3ZWJr aXRTZXR0aW5nc0dldFByZWZlcmVuY2VzKFdlYktpdFNldHRpbmdzKiBzZXR0aW5ncykKQEAgLTM0 MjIsMzggKzM0MDIsMyBAQCBndWludDMyIHdlYmtpdF9zZXR0aW5nc19mb250X3NpemVfdG9fcGl4 ZWxzKGd1aW50MzIgcG9pbnRzKQogICAgIHJldHVybiBzdGQ6OnJvdW5kKHBvaW50cyAqIFdlYkNv cmU6OnNjcmVlbkRQSSgpIC8gNzIpOwogfQogI2VuZGlmIC8vIFBMQVRGT1JNKEdUSykKLQotLyoq Ci0gKiB3ZWJraXRfc2V0dGluZ3NfZ2V0X2VuYWJsZV93ZWJ2cjoKLSAqIEBzZXR0aW5nczogYSAj V2ViS2l0U2V0dGluZ3MKLSAqCi0gKiBHZXQgdGhlICNXZWJLaXRTZXR0aW5nczplbmFibGUtd2Vi dnIgcHJvcGVydHkuCi0gKgotICogUmV0dXJuczogJVRSVUUgSWYgV2VidnIgc3VwcG9ydCBpcyBl bmFibGVkIG9yICVGQUxTRSBvdGhlcndpc2UuCi0gKi8KLWdib29sZWFuIHdlYmtpdF9zZXR0aW5n c19nZXRfZW5hYmxlX3dlYnZyKFdlYktpdFNldHRpbmdzKiBzZXR0aW5ncykKLXsKLSAgICBnX3Jl dHVybl92YWxfaWZfZmFpbChXRUJLSVRfSVNfU0VUVElOR1Moc2V0dGluZ3MpLCBGQUxTRSk7Ci0K LSAgICByZXR1cm4gc2V0dGluZ3MtPnByaXYtPnByZWZlcmVuY2VzLT53ZWJWUkVuYWJsZWQoKTsK LX0KLQotLyoqCi0gKiB3ZWJraXRfc2V0dGluZ3Nfc2V0X2VuYWJsZV93ZWJ2cjoKLSAqIEBzZXR0 aW5nczogYSAjV2ViS2l0U2V0dGluZ3MKLSAqIEBlbmFibGVkOiBWYWx1ZSB0byBiZSBzZXQKLSAq Ci0gKiBTZXQgdGhlICNXZWJLaXRTZXR0aW5nczplbmFibGUtd2VidnIgcHJvcGVydHkuCi0gKi8K LXZvaWQgd2Via2l0X3NldHRpbmdzX3NldF9lbmFibGVfd2VidnIoV2ViS2l0U2V0dGluZ3MqIHNl dHRpbmdzLCBnYm9vbGVhbiBlbmFibGVkKQotewotICAgIGdfcmV0dXJuX2lmX2ZhaWwoV0VCS0lU X0lTX1NFVFRJTkdTKHNldHRpbmdzKSk7Ci0KLSAgICBXZWJLaXRTZXR0aW5nc1ByaXZhdGUqIHBy aXYgPSBzZXR0aW5ncy0+cHJpdjsKLSAgICBib29sIGN1cnJlbnRWYWx1ZSA9IHByaXYtPnByZWZl cmVuY2VzLT53ZWJWUkVuYWJsZWQoKTsKLSAgICBpZiAoY3VycmVudFZhbHVlID09IGVuYWJsZWQp Ci0gICAgICAgIHJldHVybjsKLQotICAgIHByaXYtPnByZWZlcmVuY2VzLT5zZXRXZWJWUkVuYWJs ZWQoZW5hYmxlZCk7Ci0gICAgZ19vYmplY3Rfbm90aWZ5KEdfT0JKRUNUKHNldHRpbmdzKSwgImVu YWJsZS13ZWJ2ciIpOwotfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L2d0ay9XZWJLaXRTZXR0aW5ncy5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRTZXR0aW5ncy5oCmluZGV4IDc1ZjhlYzVkZTM0MjRhYTdiZDMxNjFiYzRkNWEyMjYyZjhm MjEzNWMuLmE3NDlkNDA2YzVmY2M0NDA0MjY1ZjMwZDJiMjlmYmNjZGQzZWRkYjEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0U2V0dGluZ3MuaAorKysg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFNldHRpbmdzLmgKQEAgLTQ2 NCwxMyArNDY0LDYgQEAgd2Via2l0X3NldHRpbmdzX2ZvbnRfc2l6ZV90b19wb2ludHMgICAgICAg ICAgICAgICAgICAgICAgICAgICAgKGd1aW50MzIgcGl4ZWxzKTsKIFdFQktJVF9BUEkgZ3VpbnQz Mgogd2Via2l0X3NldHRpbmdzX2ZvbnRfc2l6ZV90b19waXhlbHMgICAgICAgICAgICAgICAgICAg ICAgICAgICAgKGd1aW50MzIgcG9pbnRzKTsKIAotV0VCS0lUX0FQSSBnYm9vbGVhbgotd2Via2l0 X3NldHRpbmdzX2dldF9lbmFibGVfd2VidnIgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KFdlYktpdFNldHRpbmdzICpzZXR0aW5ncyk7Ci0KLVdFQktJVF9BUEkgdm9pZAotd2Via2l0X3Nl dHRpbmdzX3NldF9lbmFibGVfd2VidnIgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKFdl YktpdFNldHRpbmdzICpzZXR0aW5ncywKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnYm9vbGVhbiAgICAgICAgZW5hYmxlZCk7 Ci0KIEdfRU5EX0RFQ0xTCiAKICNlbmRpZiAvKiBXZWJLaXRTZXR0aW5nc19oICovCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL1dlYktpdFNldHRpbmdzLmggYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL1dlYktpdFNldHRpbmdzLmgKaW5kZXggZTdi NzcxNTliNmVlZDllYjk3ZDY2OTQwYzA4M2VlYzFhZjM0YzgyMi4uM2I3ZjA2ZDk3ZmU3ZTQwMDE2 YmE3OTkwZGU0YmQwZmFkZjVmY2E4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQVBJL3dwZS9XZWJLaXRTZXR0aW5ncy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS93cGUvV2ViS2l0U2V0dGluZ3MuaApAQCAtNDM1LDEzICs0MzUsNiBAQCBXRUJLSVRfQVBJ IHZvaWQKIHdlYmtpdF9zZXR0aW5nc19zZXRfYWxsb3dfdW5pdmVyc2FsX2FjY2Vzc19mcm9tX2Zp bGVfdXJscyAgICAgIChXZWJLaXRTZXR0aW5ncyAqc2V0dGluZ3MsCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ2Jvb2xlYW4g ICAgICAgIGFsbG93ZWQpOwogCi1XRUJLSVRfQVBJIGdib29sZWFuCi13ZWJraXRfc2V0dGluZ3Nf Z2V0X2VuYWJsZV93ZWJ2ciAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoV2ViS2l0U2V0 dGluZ3MgKnNldHRpbmdzKTsKLQotV0VCS0lUX0FQSSB2b2lkCi13ZWJraXRfc2V0dGluZ3Nfc2V0 X2VuYWJsZV93ZWJ2ciAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoV2ViS2l0U2V0dGlu Z3MgKnNldHRpbmdzLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGdib29sZWFuICAgICAgICBlbmFibGVkKTsKLQogR19FTkRf REVDTFMKIAogI2VuZGlmIC8qIFdlYktpdFNldHRpbmdzX2ggKi8K