182094 2018-01-25 02:44:38 -0800 [Cairo] Use GraphicsContextImplCairo in Nicosia::PaintingContextCairo 2018-01-25 04:20:32 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zan zan cgarcia ews-watchlist webkit-bug-importer oldest_to_newest 1392972 0 zan 2018-01-25 02:44:38 -0800 [Cairo] Use GraphicsContextImplCairo in Nicosia::PaintingContextCairo 1392975 1 332245 zan 2018-01-25 02:52:20 -0800 Created attachment 332245 Patch 1392977 2 ews-watchlist 2018-01-25 02:55:10 -0800 Attachment 332245 did not pass style-queue: ERROR: Source/WebCore/platform/graphics/nicosia/NicosiaPaintingContextCairo.cpp:73: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] WARNING: This machine could support 4 simulators, but is only configured for 3. WARNING: Please see <https://trac.webkit.org/wiki/IncreasingKernelLimits>. Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1392978 3 332245 cgarcia 2018-01-25 02:56:47 -0800 Comment on attachment 332245 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332245&action=review > Source/WebCore/platform/graphics/nicosia/NicosiaPaintingContextCairo.cpp:76 > + m_graphicsContext = std::make_unique<WebCore::GraphicsContext>( > + [this](WebCore::GraphicsContext& context) > + { > + return std::make_unique<WebCore::GraphicsContextImplCairo>(context, *m_platformContext); > + }); Fix the indentation here. 1392986 4 332252 zan 2018-01-25 03:46:39 -0800 Created attachment 332252 Patch for landing 1392993 5 332252 zan 2018-01-25 04:18:39 -0800 Comment on attachment 332252 Patch for landing Clearing flags on attachment: 332252 Committed r227599: <https://trac.webkit.org/changeset/227599> 1392994 6 zan 2018-01-25 04:18:43 -0800 All reviewed patches have been landed. Closing bug. 1392995 7 webkit-bug-importer 2018-01-25 04:20:32 -0800 <rdar://problem/36862641> 332245 2018-01-25 02:52:20 -0800 2018-01-25 03:46:35 -0800 Patch bug-182094-20180125115219.patch text/plain 2408 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3NTk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjBjMmM0NjBjMmY0M2Zm NzM2ZDVmZGM3NDc5NWM5NmU3MjA0ZDViYS4uODkxNGQyMjQ1OTFiNjRkOGRkZWYwMTQ5NTE1MGFh OTE3OTA5YzNlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTAxLTI1ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbQ2Fpcm9dIFVzZSBH cmFwaGljc0NvbnRleHRJbXBsQ2Fpcm8gaW4gTmljb3NpYTo6UGFpbnRpbmdDb250ZXh0Q2Fpcm8K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjA5NAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhhdmUgTmlj b3NpYTo6UGFpbnRpbmdDb250ZXh0Q2Fpcm8gY3JlYXRlIGEgR3JhcGhpY3NDb250ZXh0IG9iamVj dCB0aGF0CisgICAgICAgIHV0aWxpemVzIGEgZmFjdG9yeSBmdW5jdGlvbiB3aGljaCByZXR1cm5z IGEgZnJlc2hseS1hbGxvY2F0ZWQKKyAgICAgICAgR3JhcGhpY3NDb250ZXh0SW1wbENhaXJvIHRo cm91Z2ggd2hpY2ggYWxsIHRoZSBwYWludGluZyBpcyB0aGVuIGRvbmUuCisgICAgICAgIFRoaXMg bW92ZXMgR3JhcGhpY3NMYXllciBwYWludGluZyBvdmVyIHRvIHVzaW5nIHRoZSBHcmFwaGljc0Nv bnRleHRJbXBsCisgICAgICAgIGluZnJhc3RydWN0dXJlLgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cyAtLSBubyBjaGFuZ2VzIGluIGJlaGF2aW9yLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3Mvbmljb3NpYS9OaWNvc2lhUGFpbnRpbmdDb250ZXh0Q2Fpcm8uY3BwOgorICAgICAgICAoTmlj b3NpYTo6UGFpbnRpbmdDb250ZXh0Q2Fpcm86OlBhaW50aW5nQ29udGV4dENhaXJvKToKKwogMjAx OC0wMS0yNCAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAg W0NhaXJvXSBVc2UgR3JhcGhpY3NDb250ZXh0SW1wbENhaXJvIGZvciBJbWFnZUJ1ZmZlciBjb250 ZXh0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9uaWNvc2lh L05pY29zaWFQYWludGluZ0NvbnRleHRDYWlyby5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9uaWNvc2lhL05pY29zaWFQYWludGluZ0NvbnRleHRDYWlyby5jcHAKaW5kZXgg Yzc2NTNjNDAyM2NjZWMwMmIyZTg5MGNjNWZiZWY3OGExMjcyMzRhZS4uM2YzNmI1NjY4MzczODQ5 YjM0ZmVkMjdiMTU3ZjI1YmFjZThmYTc0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3Mvbmljb3NpYS9OaWNvc2lhUGFpbnRpbmdDb250ZXh0Q2Fpcm8uY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL25pY29zaWEvTmljb3NpYVBhaW50 aW5nQ29udGV4dENhaXJvLmNwcApAQCAtMzIsNiArMzIsNyBAQAogI2lmIFVTRShDQUlSTykKIAog I2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dC5oIgorI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dElt cGxDYWlyby5oIgogI2luY2x1ZGUgIk5pY29zaWFCdWZmZXIuaCIKICNpbmNsdWRlICJQbGF0Zm9y bUNvbnRleHRDYWlyby5oIgogI2luY2x1ZGUgIlJlZlB0ckNhaXJvLmgiCkBAIC02OCw3ICs2OSwx MSBAQCBQYWludGluZ0NvbnRleHRDYWlybzo6UGFpbnRpbmdDb250ZXh0Q2Fpcm8oQnVmZmVyJiBi dWZmZXIpCiAKICAgICBtX2NhaXJvLmNvbnRleHQgPSBhZG9wdFJlZihjYWlyb19jcmVhdGUobV9j YWlyby5zdXJmYWNlLmdldCgpKSk7CiAgICAgbV9wbGF0Zm9ybUNvbnRleHQgPSBzdGQ6Om1ha2Vf dW5pcXVlPFdlYkNvcmU6OlBsYXRmb3JtQ29udGV4dENhaXJvPihtX2NhaXJvLmNvbnRleHQuZ2V0 KCkpOwotICAgIG1fZ3JhcGhpY3NDb250ZXh0ID0gc3RkOjptYWtlX3VuaXF1ZTxXZWJDb3JlOjpH cmFwaGljc0NvbnRleHQ+KG1fcGxhdGZvcm1Db250ZXh0LmdldCgpKTsKKyAgICBtX2dyYXBoaWNz Q29udGV4dCA9IHN0ZDo6bWFrZV91bmlxdWU8V2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0PigKKyAg ICAgICAgICAgIFt0aGlzXShXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQmIGNvbnRleHQpCisgICAg ICAgICAgICB7CisgICAgICAgICAgICAgICAgcmV0dXJuIHN0ZDo6bWFrZV91bmlxdWU8V2ViQ29y ZTo6R3JhcGhpY3NDb250ZXh0SW1wbENhaXJvPihjb250ZXh0LCAqbV9wbGF0Zm9ybUNvbnRleHQp OworICAgICAgICAgICAgfSk7CiB9CiAKIFBhaW50aW5nQ29udGV4dENhaXJvOjp+UGFpbnRpbmdD b250ZXh0Q2Fpcm8oKQo= 332252 2018-01-25 03:46:39 -0800 2018-01-25 03:46:39 -0800 Patch for landing bug-182094-20180125124638.patch text/plain 2280 zan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNzU5OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE4LTAxLTI1ICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbQ2Fpcm9dIFVzZSBHcmFw aGljc0NvbnRleHRJbXBsQ2Fpcm8gaW4gTmljb3NpYTo6UGFpbnRpbmdDb250ZXh0Q2Fpcm8KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjA5NAorCisg ICAgICAgIFJldmlld2VkIGJ5IENhcmxvcyBHYXJjaWEgQ2FtcG9zLgorCisgICAgICAgIEhhdmUg Tmljb3NpYTo6UGFpbnRpbmdDb250ZXh0Q2Fpcm8gY3JlYXRlIGEgR3JhcGhpY3NDb250ZXh0IG9i amVjdCB0aGF0CisgICAgICAgIHV0aWxpemVzIGEgZmFjdG9yeSBmdW5jdGlvbiB3aGljaCByZXR1 cm5zIGEgZnJlc2hseS1hbGxvY2F0ZWQKKyAgICAgICAgR3JhcGhpY3NDb250ZXh0SW1wbENhaXJv IHRocm91Z2ggd2hpY2ggYWxsIHRoZSBwYWludGluZyBpcyB0aGVuIGRvbmUuCisgICAgICAgIFRo aXMgbW92ZXMgR3JhcGhpY3NMYXllciBwYWludGluZyBvdmVyIHRvIHVzaW5nIHRoZSBHcmFwaGlj c0NvbnRleHRJbXBsCisgICAgICAgIGluZnJhc3RydWN0dXJlLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cyAtLSBubyBjaGFuZ2VzIGluIGJlaGF2aW9yLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3Mvbmljb3NpYS9OaWNvc2lhUGFpbnRpbmdDb250ZXh0Q2Fpcm8uY3BwOgorICAgICAgICAo Tmljb3NpYTo6UGFpbnRpbmdDb250ZXh0Q2Fpcm86OlBhaW50aW5nQ29udGV4dENhaXJvKToKKwog MjAxOC0wMS0yNCAgRnJlZGVyaWMgV2FuZyAgPGZ3YW5nQGlnYWxpYS5jb20+CiAKICAgICAgICAg U2Nyb2xsaW5nU3RhdGVOb2RlOjpyZWNvbmNpbGVMYXllclBvc2l0aW9uRm9yVmlld3BvcnRSZWN0 IGlzIG9ubHkgY2FsbGVkIG9uIGRpcmVjdCBjaGlsZHJlbiBvZiB0aGUgcm9vdApJbmRleDogU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvbmljb3NpYS9OaWNvc2lhUGFpbnRpbmdDb250 ZXh0Q2Fpcm8uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL25pY29zaWEvTmljb3NpYVBhaW50aW5nQ29udGV4dENhaXJvLmNwcAkocmV2aXNpb24gMjI3 NTk4KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvbmljb3NpYS9OaWNvc2lh UGFpbnRpbmdDb250ZXh0Q2Fpcm8uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMiw2ICszMiw3IEBA CiAjaWYgVVNFKENBSVJPKQogCiAjaW5jbHVkZSAiR3JhcGhpY3NDb250ZXh0LmgiCisjaW5jbHVk ZSAiR3JhcGhpY3NDb250ZXh0SW1wbENhaXJvLmgiCiAjaW5jbHVkZSAiTmljb3NpYUJ1ZmZlci5o IgogI2luY2x1ZGUgIlBsYXRmb3JtQ29udGV4dENhaXJvLmgiCiAjaW5jbHVkZSAiUmVmUHRyQ2Fp cm8uaCIKQEAgLTY4LDcgKzY5LDExIEBAIFBhaW50aW5nQ29udGV4dENhaXJvOjpQYWludGluZ0Nv bnRleHRDYWkKIAogICAgIG1fY2Fpcm8uY29udGV4dCA9IGFkb3B0UmVmKGNhaXJvX2NyZWF0ZSht X2NhaXJvLnN1cmZhY2UuZ2V0KCkpKTsKICAgICBtX3BsYXRmb3JtQ29udGV4dCA9IHN0ZDo6bWFr ZV91bmlxdWU8V2ViQ29yZTo6UGxhdGZvcm1Db250ZXh0Q2Fpcm8+KG1fY2Fpcm8uY29udGV4dC5n ZXQoKSk7Ci0gICAgbV9ncmFwaGljc0NvbnRleHQgPSBzdGQ6Om1ha2VfdW5pcXVlPFdlYkNvcmU6 OkdyYXBoaWNzQ29udGV4dD4obV9wbGF0Zm9ybUNvbnRleHQuZ2V0KCkpOworICAgIG1fZ3JhcGhp Y3NDb250ZXh0ID0gc3RkOjptYWtlX3VuaXF1ZTxXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ+KAor ICAgICAgICBbdGhpc10oV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0JiBjb250ZXh0KQorICAgICAg ICB7CisgICAgICAgICAgICByZXR1cm4gc3RkOjptYWtlX3VuaXF1ZTxXZWJDb3JlOjpHcmFwaGlj c0NvbnRleHRJbXBsQ2Fpcm8+KGNvbnRleHQsICptX3BsYXRmb3JtQ29udGV4dCk7CisgICAgICAg IH0pOwogfQogCiBQYWludGluZ0NvbnRleHRDYWlybzo6flBhaW50aW5nQ29udGV4dENhaXJvKCkK