182088 2018-01-25 00:59:02 -0800 Make run-perf-tests work with Speedometer 2.0 and re-enable the tests 2018-02-09 22:14:54 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=182322 InRadar P2 Normal --- 182089 1 rniwa rniwa cdumez commit-queue koivisto lforschler ryanhaddad webkit-bug-importer oldest_to_newest 1392948 0 rniwa 2018-01-25 00:59:02 -0800 Make the new score computation reflected in run-perf-tests and unskip the test. 1392949 1 332237 rniwa 2018-01-25 01:05:47 -0800 Created attachment 332237 Patch 1392950 2 rniwa 2018-01-25 01:06:10 -0800 Unfortunately, we can't land this patch until we fix perf dashboard as well. 1392955 3 332237 rniwa 2018-01-25 01:08:13 -0800 Comment on attachment 332237 Patch As such, we can't land this patch. Landing this patch would prevent all test results from being processed in the perf dashboard. 1392956 4 webkit-bug-importer 2018-01-25 01:15:10 -0800 <rdar://problem/36859067> 1394358 5 rniwa 2018-01-29 17:38:33 -0800 We actually need this fix for StyleBench as well. 1396702 6 ryanhaddad 2018-02-05 21:24:29 -0800 *** Bug 182079 has been marked as a duplicate of this bug. *** 1398204 7 332237 commit-queue 2018-02-09 21:22:51 -0800 Comment on attachment 332237 Patch Rejecting attachment 332237 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 332237, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ile PerformanceTests/resources/results-template.html Hunk #1 FAILED at 227. 1 out of 1 hunk FAILED -- saving rejects to file PerformanceTests/resources/results-template.html.rej patching file PerformanceTests/resources/runner.js Hunk #1 FAILED at 223. 1 out of 1 hunk FAILED -- saving rejects to file PerformanceTests/resources/runner.js.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/6442748 1398208 8 rniwa 2018-02-09 22:14:54 -0800 Committed r228361: <https://trac.webkit.org/changeset/228361> 332237 2018-01-25 01:05:47 -0800 2018-02-09 21:22:51 -0800 Patch bug-182088-20180125010547.patch text/plain 6417 rniwa SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjc1OTYpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDE4LTAxLTI1ICBS eW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIE1ha2UgcnVuLXBlcmYt dGVzdHMgd29yayB3aXRoIFNwZWVkb21ldGVyIDIuMCBhbmQgcmUtZW5hYmxlIHRoZSB0ZXN0Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODIwODgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNo IHVwZGF0ZXMgdGhlIHRlc3QgaGFybmVzcyB0byByZXBvcnQgbmV3IG1ldHJpY3Mgb2YgU3BlZWRv bWV0ZXIgMi4wLgorCisgICAgICAgIFJlcGxhY2VkIHRoZSB0b3RhbCB0aW1lIGJ5IHRoZSBnZW9t ZXRyaWMgbWVhbiBvZiB0aGUgdGltZSBzcGVudCBpbiBlYWNoIHN1aXRlLCBhbmQgYWRkZWQgc2Nv cmVzCisgICAgICAgIGFzIGEgbWV0cmljIGluIGFkZGl0aW9uIHRvIHRpbWUuIEFsc28sIHVwZGF0 ZWQgdGhlIFBlcmZUZXN0UnVubmVyIGhhcm5lc3MgYW5kIHRoZSByZXN1bHRzIHRlbXBsYXRlCisg ICAgICAgIHRvIHN1cHBvcnQgIlNjb3JlIiBtZXRyaWMgd2l0aCAicHQiIGFzIGl0cyB1bml0Lgor CisgICAgICAgICogU2tpcHBlZDogVW5za2lwcGVkIHRoZSB0ZXN0LgorICAgICAgICAqIFNwZWVk b21ldGVyL3Jlc291cmNlcy9iZW5jaG1hcmstcmVwb3J0LmpzOgorICAgICAgICAod2luZG93LmJl bmNobWFya0NsaWVudC53aWxsU3RhcnRGaXJzdEl0ZXJhdGlvbi4uY3JlYXRlVGVzdCk6IEFkZGVk IHRoZSB1bml0IGFzIGFuIG9wdGlvbmFsIGFyZ3VtZW50CisgICAgICAgIHRvIHJlcG9ydCB0aGUg c2NvcmUgaW4gYWRkaXRpb24gdG8gdGltZS4gQWxzbyByZXBvcnQgdGhlIGdlb21lYW4gb2YgdGlt ZSBpbnN0ZWFkIG9mIHRoZSB0b3RhbCB0aW1lLgorICAgICAgICAod2luZG93LmJlbmNobWFya0Ns aWVudC53aWxsU3RhcnRGaXJzdEl0ZXJhdGlvbik6IFJlcG9ydCB0aGUgZ2VvbWVhbiBvZiB0aW1l LgorICAgICAgICAod2luZG93LmJlbmNobWFya0NsaWVudC5kaWRSdW5TdWl0ZXMpOiBSZWNvcmQg dGhlIGVudGlyZSBtZWFzdXJlZFZhbHVlcyBpbnN0ZWFkIG9mIGp1c3QgdGVzdHMuCisgICAgICAg ICh3aW5kb3cuYmVuY2htYXJrQ2xpZW50LmRpZEZpbmlzaExhc3RJdGVyYXRpb24pOiBSZXBvcnQg dGhlIHNjb3Jlcy4KKyAgICAgICAgKiByZXNvdXJjZXMvcmVzdWx0cy10ZW1wbGF0ZS5odG1sOiBB ZGRlZCAiU2NvcmUiIGFzIGEgbWV0cmljIGFuZCAicHQiIGFzIGl0cyB1bml0LgorICAgICAgICAq IHJlc291cmNlcy9ydW5uZXIuanM6CisgICAgICAgIChQZXJmVGVzdFJ1bm5lci4uZmluaXNoKTog RGl0dG8uCisKIDIwMTgtMDEtMjIgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgog CiAgICAgICAgIFN0eWxlQmVuY2g6IFNlcGFyYXRlIHRlc3QgZm9yIDpudGggcHNldWRvIGNsYXNz ZXMKSW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvU2tpcHBlZAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBQZXJmb3Jt YW5jZVRlc3RzL1NraXBwZWQJKHJldmlzaW9uIDIyNzU5MCkKKysrIFBlcmZvcm1hbmNlVGVzdHMv U2tpcHBlZAkod29ya2luZyBjb3B5KQpAQCAtODIsNyArODIsNiBAQCBQYXJzZXIvaHRtbC1wYXJz ZXItdGhyZWFkZWQuaHRtbAogTGF5b3V0L0xpbmVMYXlvdXRKYXBhbmVzZS5odG1sCiAKICMgRG9u J3QgcnVuIHRoZSBpbnRlcmFjdGl2ZSBydW5uZXIuIFdlIHJ1biBpbmRleC5odG1sCi1TcGVlZG9t ZXRlci9pbmRleC5odG1sCiBTcGVlZG9tZXRlci9JbnRlcmFjdGl2ZVJ1bm5lci5odG1sCiBTdHls ZUJlbmNoL0ludGVyYWN0aXZlUnVubmVyLmh0bWwKIApJbmRleDogUGVyZm9ybWFuY2VUZXN0cy9T cGVlZG9tZXRlci9yZXNvdXJjZXMvYmVuY2htYXJrLXJlcG9ydC5qcwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBQ ZXJmb3JtYW5jZVRlc3RzL1NwZWVkb21ldGVyL3Jlc291cmNlcy9iZW5jaG1hcmstcmVwb3J0Lmpz CShyZXZpc2lvbiAyMjc1OTApCisrKyBQZXJmb3JtYW5jZVRlc3RzL1NwZWVkb21ldGVyL3Jlc291 cmNlcy9iZW5jaG1hcmstcmVwb3J0LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0yNiwyMSArMjYsMjEg QEAKICAgICB3aW5kb3cuYmVuY2htYXJrQ2xpZW50ID0gewogICAgICAgICBpdGVyYXRpb25Db3Vu dDogNSwgLy8gVXNlIDQgZGlmZmVyZW50IGluc3RhbmNlcyBvZiBEUlQvV1RSIHRvIHJ1biA1IGl0 ZXJhdGlvbnMuCiAgICAgICAgIHdpbGxTdGFydEZpcnN0SXRlcmF0aW9uOiBmdW5jdGlvbiAoaXRl cmF0aW9uQ291bnQpIHsKLSAgICAgICAgICAgIGNyZWF0ZVRlc3QgPSBmdW5jdGlvbiAobmFtZSwg YWdncmVnYXRvciwgaXNMYXN0VGVzdCkgeworICAgICAgICAgICAgY3JlYXRlVGVzdCA9IGZ1bmN0 aW9uIChuYW1lLCBhZ2dyZWdhdG9yLCBpc0xhc3RUZXN0LCB1bml0ID0gJ21zJykgewogICAgICAg ICAgICAgICAgIHJldHVybiB7CiAgICAgICAgICAgICAgICAgICAgIGN1c3RvbUl0ZXJhdGlvbkNv dW50OiBpdGVyYXRpb25Db3VudCwKICAgICAgICAgICAgICAgICAgICAgZG9Ob3RJZ25vcmVJbml0 aWFsUnVuOiB0cnVlLAogICAgICAgICAgICAgICAgICAgICBkb05vdE1lYXN1cmVNZW1vcnlVc2Fn ZTogdHJ1ZSwKICAgICAgICAgICAgICAgICAgICAgY29udGludWVUZXN0aW5nOiAhaXNMYXN0VGVz dCwKLSAgICAgICAgICAgICAgICAgICAgdW5pdDogJ21zJywKKyAgICAgICAgICAgICAgICAgICAg dW5pdDogdW5pdCwKICAgICAgICAgICAgICAgICAgICAgbmFtZTogbmFtZSwKICAgICAgICAgICAg ICAgICAgICAgYWdncmVnYXRvcjogYWdncmVnYXRvcn07CiAgICAgICAgICAgICB9Ci0gICAgICAg ICAgICBQZXJmVGVzdFJ1bm5lci5wcmVwYXJlVG9NZWFzdXJlVmFsdWVzQXN5bmMoY3JlYXRlVGVz dChudWxsLCAnVG90YWwnKSk7CisgICAgICAgICAgICBQZXJmVGVzdFJ1bm5lci5wcmVwYXJlVG9N ZWFzdXJlVmFsdWVzQXN5bmMoY3JlYXRlVGVzdChudWxsLCAnR2VvbWV0cmljJykpOwogICAgICAg ICB9LAogICAgICAgICBkaWRSdW5TdWl0ZXM6IGZ1bmN0aW9uIChtZWFzdXJlZFZhbHVlcykgewot ICAgICAgICAgICAgUGVyZlRlc3RSdW5uZXIubWVhc3VyZVZhbHVlQXN5bmMobWVhc3VyZWRWYWx1 ZXMudG90YWwpOwotICAgICAgICAgICAgdmFsdWVzQnlJdGVyYXRpb24ucHVzaChtZWFzdXJlZFZh bHVlcy50ZXN0cyk7CisgICAgICAgICAgICBQZXJmVGVzdFJ1bm5lci5tZWFzdXJlVmFsdWVBc3lu YyhtZWFzdXJlZFZhbHVlcy5nZW9tZWFuKTsKKyAgICAgICAgICAgIHZhbHVlc0J5SXRlcmF0aW9u LnB1c2gobWVhc3VyZWRWYWx1ZXMpOwogICAgICAgICB9LAogICAgICAgICBkaWRGaW5pc2hMYXN0 SXRlcmF0aW9uOiBmdW5jdGlvbiAoKSB7CiAgICAgICAgICAgICBkb2N1bWVudC5oZWFkLnJlbW92 ZUNoaWxkKGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ3N0eWxlJykpOwpAQCAtNTMsOSArNTMsMTEg QEAKICAgICAgICAgICAgICAgICB2YWx1ZXMuYWdncmVnYXRvciA9IGFnZ3JlZ2F0b3I7CiAgICAg ICAgICAgICB9CiAKKyAgICAgICAgICAgIHZhciBzY29yZXMgPSBbXTsKICAgICAgICAgICAgIHZh bHVlc0J5SXRlcmF0aW9uLmZvckVhY2goZnVuY3Rpb24gKG1lYXN1cmVkVmFsdWVzKSB7Ci0gICAg ICAgICAgICAgICAgZm9yICh2YXIgc3VpdGVOYW1lIGluIG1lYXN1cmVkVmFsdWVzKSB7Ci0gICAg ICAgICAgICAgICAgICAgIHZhciBzdWl0ZSA9IG1lYXN1cmVkVmFsdWVzW3N1aXRlTmFtZV07Cisg ICAgICAgICAgICAgICAgc2NvcmVzLnB1c2gobWVhc3VyZWRWYWx1ZXMuc2NvcmUpOworICAgICAg ICAgICAgICAgIGZvciAodmFyIHN1aXRlTmFtZSBpbiBtZWFzdXJlZFZhbHVlcy50ZXN0cykgewor ICAgICAgICAgICAgICAgICAgICB2YXIgc3VpdGUgPSBtZWFzdXJlZFZhbHVlcy50ZXN0c1tzdWl0 ZU5hbWVdOwogICAgICAgICAgICAgICAgICAgICBmb3IgKHZhciB0ZXN0TmFtZSBpbiBzdWl0ZS50 ZXN0cykgewogICAgICAgICAgICAgICAgICAgICAgICAgdmFyIHRlc3QgPSBzdWl0ZS50ZXN0c1t0 ZXN0TmFtZV07CiAgICAgICAgICAgICAgICAgICAgICAgICBmb3IgKHZhciBzdWJ0ZXN0TmFtZSBp biB0ZXN0LnRlc3RzKQpAQCAtNjYsNiArNjgsOCBAQAogICAgICAgICAgICAgICAgIH0KICAgICAg ICAgICAgIH0pOwogCisgICAgICAgICAgICBQZXJmVGVzdFJ1bm5lci5yZXBvcnRWYWx1ZXMoY3Jl YXRlVGVzdChudWxsLCBudWxsLCBmYWxzZSwgJ3B0JyksIHNjb3Jlcyk7CisKICAgICAgICAgICAg IHZhciBmdWxsTmFtZXMgPSBuZXcgQXJyYXk7CiAgICAgICAgICAgICBmb3IgKHZhciBmdWxsTmFt ZSBpbiBtZWFzdXJlZFZhbHVlc0J5RnVsbE5hbWUpCiAgICAgICAgICAgICAgICAgZnVsbE5hbWVz LnB1c2goZnVsbE5hbWUpOwpJbmRleDogUGVyZm9ybWFuY2VUZXN0cy9yZXNvdXJjZXMvcmVzdWx0 cy10ZW1wbGF0ZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1hbmNlVGVzdHMvcmVzb3VyY2Vz L3Jlc3VsdHMtdGVtcGxhdGUuaHRtbAkocmV2aXNpb24gMjI3NTkwKQorKysgUGVyZm9ybWFuY2VU ZXN0cy9yZXNvdXJjZXMvcmVzdWx0cy10ZW1wbGF0ZS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0y MjcsNyArMjI3LDcgQEAgZnVuY3Rpb24gUGVyZlRlc3RNZXRyaWMobmFtZSwgbWV0cmljKSB7CiAg ICAgdmFyIHRlc3RSZXN1bHRzID0gW107CiAgICAgdmFyIGNhY2hlZFVuaXQgPSBudWxsOwogICAg IHZhciBjYWNoZWRTY2FsaW5nRmFjdG9yID0gbnVsbDsKLSAgICB2YXIgdW5pdCA9IHsnRnJhbWVS YXRlJzogJ2ZwcycsICdSdW5zJzogJ3J1bnMvcycsICdUaW1lJzogJ21zJywgJ01hbGxvYyc6ICdi eXRlcycsICdKU0hlYXAnOiAnYnl0ZXMnfVttZXRyaWNdOworICAgIHZhciB1bml0ID0geydGcmFt ZVJhdGUnOiAnZnBzJywgJ1J1bnMnOiAncnVucy9zJywgJ1Njb3JlJzogJ3B0JywgJ1RpbWUnOiAn bXMnLCAnTWFsbG9jJzogJ2J5dGVzJywgJ0pTSGVhcCc6ICdieXRlcyd9W21ldHJpY107CiAKICAg ICAvLyBXZSBjYW4ndCBkbyB0aGlzIGluIFRlc3RSZXN1bHQgYmVjYXVzZSBhbGwgcmVzdWx0cyBm b3IgZWFjaCB0ZXN0IG5lZWQgdG8gc2hhcmUgdGhlIHNhbWUgdW5pdCBhbmQgdGhlIHNhbWUgc2Nh bGluZyBmYWN0b3IuCiAgICAgZnVuY3Rpb24gY29tcHV0ZVNjYWxpbmdGYWN0b3JJZk5lZWRlZCgp IHsKSW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvcmVzb3VyY2VzL3J1bm5lci5qcwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBQZXJmb3JtYW5jZVRlc3RzL3Jlc291cmNlcy9ydW5uZXIuanMJKHJldmlzaW9uIDIyNzU5 MCkKKysrIFBlcmZvcm1hbmNlVGVzdHMvcmVzb3VyY2VzL3J1bm5lci5qcwkod29ya2luZyBjb3B5 KQpAQCAtMjIzLDcgKzIyMyw3IEBAIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgewogICAgICAgICAg ICAgdmFyIHByZWZpeCA9IGN1cnJlbnRUZXN0Lm5hbWUgfHwgJyc7CiAgICAgICAgICAgICBpZiAo Y3VycmVudFRlc3QuZGVzY3JpcHRpb24pCiAgICAgICAgICAgICAgICAgUGVyZlRlc3RSdW5uZXIu bG9nKCJEZXNjcmlwdGlvbjogIiArIGN1cnJlbnRUZXN0LmRlc2NyaXB0aW9uKTsKLSAgICAgICAg ICAgIG1ldHJpYyA9IHsnZnBzJzogJ0ZyYW1lUmF0ZScsICdydW5zL3MnOiAnUnVucycsICdtcyc6 ICdUaW1lJ31bUGVyZlRlc3RSdW5uZXIudW5pdF07CisgICAgICAgICAgICBtZXRyaWMgPSB7J2Zw cyc6ICdGcmFtZVJhdGUnLCAncnVucy9zJzogJ1J1bnMnLCAncHQnOiAnU2NvcmUnLCAnbXMnOiAn VGltZSd9W1BlcmZUZXN0UnVubmVyLnVuaXRdOwogICAgICAgICAgICAgdmFyIHN1ZmZpeCA9IGN1 cnJlbnRUZXN0LmFnZ3JlZ2F0b3IgPyAnOicgKyBjdXJyZW50VGVzdC5hZ2dyZWdhdG9yIDogJyc7 CiAgICAgICAgICAgICBQZXJmVGVzdFJ1bm5lci5sb2dTdGF0aXN0aWNzKHJlc3VsdHMsIFBlcmZU ZXN0UnVubmVyLnVuaXQsIHByZWZpeCArICI6IiArIG1ldHJpYyArIHN1ZmZpeCk7CiAgICAgICAg ICAgICBpZiAoanNIZWFwUmVzdWx0cy5sZW5ndGgpIHsK