<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>182067</bug_id>
          
          <creation_ts>2018-01-24 15:00:02 -0800</creation_ts>
          <short_desc>Web Inspector: Simplify update-LegacyInspectorBackendCommands.rb</short_desc>
          <delta_ts>2018-01-24 16:22:34 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>DoNotImportToRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Joseph Pecoraro">joepeck</reporter>
          <assigned_to name="Joseph Pecoraro">joepeck</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>bburg</cc>
    
    <cc>commit-queue</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>inspector-bugzilla-changes</cc>
    
    <cc>joepeck</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1392789</commentid>
    <comment_count>0</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2018-01-24 15:00:02 -0800</bug_when>
    <thetext>Simplify update-LegacyInspectorBackendCommands.rb

- It doesn&apos;t need to generate the InspectorBackendDispatcher/InspectorFrontendDispatcher
- The dependency_json is no longer needed and always empty</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1392792</commentid>
    <comment_count>1</comment_count>
      <attachid>332202</attachid>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2018-01-24 15:02:21 -0800</bug_when>
    <thetext>Created attachment 332202
[PATCH] Proposed Fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1392793</commentid>
    <comment_count>2</comment_count>
      <attachid>332203</attachid>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2018-01-24 15:03:20 -0800</bug_when>
    <thetext>Created attachment 332203
[PATCH] Proposed Fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1392795</commentid>
    <comment_count>3</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2018-01-24 15:06:21 -0800</bug_when>
    <thetext>This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1392796</commentid>
    <comment_count>4</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2018-01-24 15:06:33 -0800</bug_when>
    <thetext>Attachment 332203 did not pass style-queue:


ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:199:  [generate_from_specification] Undefined variable &apos;JSBackendCommandsGenerator&apos;  [pylint/E0602] [5]
WARNING: This machine could support 4 simulators, but is only configured for 3.
WARNING: Please see &lt;https://trac.webkit.org/wiki/IncreasingKernelLimits&gt;.
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1392797</commentid>
    <comment_count>5</comment_count>
      <attachid>332203</attachid>
    <who name="Blaze Burg">bburg</who>
    <bug_when>2018-01-24 15:17:38 -0800</bug_when>
    <thetext>Comment on attachment 332203
[PATCH] Proposed Fix

r=me but let&apos;s file a bug against EWS</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1392798</commentid>
    <comment_count>6</comment_count>
    <who name="Blaze Burg">bburg</who>
    <bug_when>2018-01-24 15:18:34 -0800</bug_when>
    <thetext>(In reply to Build Bot from comment #4)
&gt; Attachment 332203 [details] did not pass style-queue:
&gt; 
&gt; 
&gt; ERROR:
&gt; Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.
&gt; py:199:  [generate_from_specification] Undefined variable
&gt; &apos;JSBackendCommandsGenerator&apos;  [pylint/E0602] [5]

This is frivolous, pylint can&apos;t see into the glob import that imports this symbol.

&gt; WARNING: This machine could support 4 simulators, but is only configured for
&gt; 3.
&gt; WARNING: Please see &lt;https://trac.webkit.org/wiki/IncreasingKernelLimits&gt;.
&gt; Total errors found: 1 in 5 files

Um, that&apos;s strange.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1392819</commentid>
    <comment_count>7</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2018-01-24 16:03:42 -0800</bug_when>
    <thetext>&gt; &gt; WARNING: This machine could support 4 simulators, but is only configured for 3.
&gt; &gt; WARNING: Please see &lt;https://trac.webkit.org/wiki/IncreasingKernelLimits&gt;.
&gt; 
&gt; Um, that&apos;s strange.

https://bugs.webkit.org/show_bug.cgi?id=181702 should fix this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1392824</commentid>
    <comment_count>8</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2018-01-24 16:06:21 -0800</bug_when>
    <thetext>&gt; &gt; ERROR:
&gt; &gt; Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.
&gt; &gt; py:199:  [generate_from_specification] Undefined variable
&gt; &gt; &apos;JSBackendCommandsGenerator&apos;  [pylint/E0602] [5]
&gt; 
&gt; This is frivolous, pylint can&apos;t see into the glob import that imports this symbol.

&lt;https://webkit.org/b/182071&gt; check-webkit-style: False positive python undefined variable pylon warning - linter doesn&apos;t seem to follow includes


&gt; &gt; WARNING: This machine could support 4 simulators, but is only configured for 3.
&gt; &gt; WARNING: Please see &lt;https://trac.webkit.org/wiki/IncreasingKernelLimits&gt;.
&gt; &gt; Total errors found: 1 in 5 files
&gt; 
&gt; Um, that&apos;s strange.

&lt;https://webkit.org/b/181702&gt; webkit-patch upload emits irrelevant simulator warnings</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1392829</commentid>
    <comment_count>9</comment_count>
      <attachid>332203</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-01-24 16:22:33 -0800</bug_when>
    <thetext>Comment on attachment 332203
[PATCH] Proposed Fix

Clearing flags on attachment: 332203

Committed r227586: &lt;https://trac.webkit.org/changeset/227586&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1392830</commentid>
    <comment_count>10</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-01-24 16:22:34 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>332202</attachid>
            <date>2018-01-24 15:02:21 -0800</date>
            <delta_ts>2018-01-24 15:03:20 -0800</delta_ts>
            <desc>[PATCH] Proposed Fix</desc>
            <filename>cleanup-1.patch</filename>
            <type>text/plain</type>
            <size>5458</size>
            <attacher name="Joseph Pecoraro">joepeck</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDQwYzZhN2Y1YmMzLi40YjNhYzE3YjMzMyAxMDA2
NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMDEtMjQgIEpvc2Vw
aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y
OiBTaW1wbGlmeSB1cGRhdGUtTGVnYWN5SW5zcGVjdG9yQmFja2VuZENvbW1hbmRzLnJiCisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODIwNjcKKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9z
Y3JpcHRzL2NvZGVnZW4vbW9kZWxzLnB5OgorICAgICAgICAoRnJhbWV3b3JrLmZyb21TdHJpbmcp
OgorICAgICAgICAoRnJhbWV3b3Jrcyk6CisgICAgICAgICogaW5zcGVjdG9yL3NjcmlwdHMvZ2Vu
ZXJhdGUtaW5zcGVjdG9yLXByb3RvY29sLWJpbmRpbmdzLnB5OgorICAgICAgICAoZ2VuZXJhdGVf
ZnJvbV9zcGVjaWZpY2F0aW9uKToKKyAgICAgICAgQWxsb3cgZnJhbWV3b3JrIFdlYkluc3BlY3Rv
clVJIHRvIGdlbmVyYXRlIGp1c3QgdGhlIGJhY2tlbmQgY29tbWFuZHMgZmlsZXMuCisKIDIwMTgt
MDEtMjMgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFVwZGF0ZSBQ
b2lzb25lZCBwb2ludGVycyB0byB0YWtlIGEgUG9pc29uIGNsYXNzIGluc3RlYWQgb2YgYSB1aW50
cHRyX3QmLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3Jp
cHRzL2NvZGVnZW4vbW9kZWxzLnB5IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9z
Y3JpcHRzL2NvZGVnZW4vbW9kZWxzLnB5CmluZGV4IDI0ZDMwYmY1MmU2Li5jYTkxZDcxYzdjNSAx
MDA3NTUKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzL2NvZGVn
ZW4vbW9kZWxzLnB5CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Ivc2NyaXB0
cy9jb2RlZ2VuL21vZGVscy5weQpAQCAtNTUsNiArNTUsOCBAQCBfRlJBTUVXT1JLX0NPTkZJR19N
QVAgPSB7CiAgICAgICAgICJvYmpjX3Byb3RvY29sX2dyb3VwIjogIlJXSSIsCiAgICAgICAgICJv
YmpjX3ByZWZpeCI6ICJSV0kiLAogICAgIH0sCisgICAgIldlYkluc3BlY3RvclVJIjogeworICAg
IH0sCiAgICAgIyBVc2VkIGZvciBjb2RlIGdlbmVyYXRvciB0ZXN0cy4KICAgICAiVGVzdCI6IHsK
ICAgICAgICAgImFsdGVybmF0ZV9kaXNwYXRjaGVycyI6IFRydWUsCkBAIC05NSw2ICs5Nyw5IEBA
IGNsYXNzIEZyYW1ld29yazoKICAgICAgICAgaWYgZnJhbWV3b3JrU3RyaW5nID09ICJXZWJJbnNw
ZWN0b3IiOgogICAgICAgICAgICAgcmV0dXJuIEZyYW1ld29ya3MuV2ViSW5zcGVjdG9yCiAKKyAg
ICAgICAgaWYgZnJhbWV3b3JrU3RyaW5nID09ICJXZWJJbnNwZWN0b3JVSSI6CisgICAgICAgICAg
ICByZXR1cm4gRnJhbWV3b3Jrcy5XZWJJbnNwZWN0b3JVSQorCiAgICAgICAgIGlmIGZyYW1ld29y
a1N0cmluZyA9PSAiVGVzdCI6CiAgICAgICAgICAgICByZXR1cm4gRnJhbWV3b3Jrcy5UZXN0CiAK
QEAgLTEwNiw2ICsxMTEsNyBAQCBjbGFzcyBGcmFtZXdvcmtzOgogICAgIEphdmFTY3JpcHRDb3Jl
ID0gRnJhbWV3b3JrKCJKYXZhU2NyaXB0Q29yZSIpCiAgICAgV2ViS2l0ID0gRnJhbWV3b3JrKCJX
ZWJLaXQiKQogICAgIFdlYkluc3BlY3RvciA9IEZyYW1ld29yaygiV2ViSW5zcGVjdG9yIikKKyAg
ICBXZWJJbnNwZWN0b3JVSSA9IEZyYW1ld29yaygiV2ViSW5zcGVjdG9yVUkiKQogICAgIFRlc3Qg
PSBGcmFtZXdvcmsoIlRlc3QiKQogCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9pbnNwZWN0b3Ivc2NyaXB0cy9nZW5lcmF0ZS1pbnNwZWN0b3ItcHJvdG9jb2wtYmluZGluZ3Mu
cHkgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3NjcmlwdHMvZ2VuZXJhdGUtaW5z
cGVjdG9yLXByb3RvY29sLWJpbmRpbmdzLnB5CmluZGV4IDE4MjEzNWU2NGU2Li5lMDQ1MjM4Y2Zj
MCAxMDA3NTUKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzL2dl
bmVyYXRlLWluc3BlY3Rvci1wcm90b2NvbC1iaW5kaW5ncy5weQorKysgYi9Tb3VyY2UvSmF2YVNj
cmlwdENvcmUvaW5zcGVjdG9yL3NjcmlwdHMvZ2VuZXJhdGUtaW5zcGVjdG9yLXByb3RvY29sLWJp
bmRpbmdzLnB5CkBAIC0xODQsNiArMTg0LDkgQEAgZGVmIGdlbmVyYXRlX2Zyb21fc3BlY2lmaWNh
dGlvbihwcmltYXJ5X3NwZWNpZmljYXRpb25fZmlsZXBhdGg9Tm9uZSwKICAgICAgICAgZ2VuZXJh
dG9ycy5hcHBlbmQoT2JqQ1Byb3RvY29sVHlwZUNvbnZlcnNpb25zSW1wbGVtZW50YXRpb25HZW5l
cmF0b3IoKmdlbmVyYXRvcl9hcmd1bWVudHMpKQogICAgICAgICBnZW5lcmF0b3JzLmFwcGVuZChP
YmpDUHJvdG9jb2xUeXBlc0ltcGxlbWVudGF0aW9uR2VuZXJhdG9yKCpnZW5lcmF0b3JfYXJndW1l
bnRzKSkKIAorICAgIGVsaWYgcHJvdG9jb2wuZnJhbWV3b3JrIGlzIEZyYW1ld29ya3MuV2ViSW5z
cGVjdG9yVUk6CisgICAgICAgIGdlbmVyYXRvcnMuYXBwZW5kKEpTQmFja2VuZENvbW1hbmRzR2Vu
ZXJhdG9yKCpnZW5lcmF0b3JfYXJndW1lbnRzKSkKKwogICAgIGVsaWYgcHJvdG9jb2wuZnJhbWV3
b3JrIGlzIEZyYW1ld29ya3MuV2ViSW5zcGVjdG9yOgogICAgICAgICBnZW5lcmF0b3JzLmFwcGVu
ZChPYmpDQmFja2VuZERpc3BhdGNoZXJIZWFkZXJHZW5lcmF0b3IoKmdlbmVyYXRvcl9hcmd1bWVu
dHMpKQogICAgICAgICBnZW5lcmF0b3JzLmFwcGVuZChPYmpDQmFja2VuZERpc3BhdGNoZXJJbXBs
ZW1lbnRhdGlvbkdlbmVyYXRvcigqZ2VuZXJhdG9yX2FyZ3VtZW50cykpCkBAIC0yMjQsNyArMjI3
LDcgQEAgZGVmIGdlbmVyYXRlX2Zyb21fc3BlY2lmaWNhdGlvbihwcmltYXJ5X3NwZWNpZmljYXRp
b25fZmlsZXBhdGg9Tm9uZSwKIAogCiBpZiBfX25hbWVfXyA9PSAnX19tYWluX18nOgotICAgIGFs
bG93ZWRfZnJhbWV3b3JrX25hbWVzID0gWydKYXZhU2NyaXB0Q29yZScsICdXZWJJbnNwZWN0b3In
LCAnV2ViS2l0JywgJ1Rlc3QnXQorICAgIGFsbG93ZWRfZnJhbWV3b3JrX25hbWVzID0gWydKYXZh
U2NyaXB0Q29yZScsICdXZWJJbnNwZWN0b3InLCAnV2ViSW5zcGVjdG9yVUknLCAnV2ViS2l0Jywg
J1Rlc3QnXQogICAgIGFsbG93ZWRfcGxhdGZvcm1fbmFtZXMgPSBbJ2lPUycsICdtYWNPUycsICdh
bGwnLCAnZ2VuZXJpYyddCiAgICAgY2xpX3BhcnNlciA9IG9wdHBhcnNlLk9wdGlvblBhcnNlcih1
c2FnZT0idXNhZ2U6ICVwcm9nIFtvcHRpb25zXSBQcmltYXJ5UHJvdG9jb2wuanNvbiBbU3VwcGxl
bWVudGFsUHJvdG9jb2wuanNvbiAuLi5dIikKICAgICBjbGlfcGFyc2VyLmFkZF9vcHRpb24oIi1v
IiwgIi0tb3V0cHV0RGlyIiwgaGVscD0iRGlyZWN0b3J5IHdoZXJlIGdlbmVyYXRlZCBmaWxlcyBz
aG91bGQgYmUgd3JpdHRlbi4iKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKaW5kZXggZTM4ZjYxY2Yw
N2QuLjFkZTEyNDY4YjU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdl
TG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNyBA
QAogMjAxOC0wMS0yNCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCisg
ICAgICAgIFdlYiBJbnNwZWN0b3I6IFNpbXBsaWZ5IHVwZGF0ZS1MZWdhY3lJbnNwZWN0b3JCYWNr
ZW5kQ29tbWFuZHMucmIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTE4MjA2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgICogU2NyaXB0cy91cGRhdGUtTGVnYWN5SW5zcGVjdG9yQmFja2VuZENvbW1hbmRzLnJi
OgorICAgICAgICBSZW1vdmUgc3RhbGUgZGVwZW5kZW5jeV9qc29uLCBpdCBoYXMgYWx3YXlzIGJl
ZW4gZW1wdHkgZm9yIGEgd2hpbGUgbm93LgorICAgICAgICBTd2l0Y2ggdG8gZnJhbWV3b3JrIFdl
Ykluc3BlY3RvclVJIHRvIGdlbmVyYXRlIG9ubHkgdGhlIGJhY2tlbmQgY29tbWFuZHMKKyAgICAg
ICAgYW5kIG5vdCBzcGVuZCB0aW1lIGdlbmVyYXRpbmcgYSBidW5jaCBvZiBjcHAgZmlsZXMuCisK
KzIwMTgtMDEtMjQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAg
ICAgICBSZWZlcmVuY2VFcnJvcjrigIsgQ2FuJ3QgZmluZCB2YXJpYWJsZTrigIsgRE9NQWdlbnQg
KGF0IFNjcmlwdFN5bnRheFRyZWUuanM64oCLMTc4OuKAizIyKeKAiwogICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyMDU5CiAKZGlmZiAtLWdpdCBhL1Nv
dXJjZS9XZWJJbnNwZWN0b3JVSS9TY3JpcHRzL3VwZGF0ZS1MZWdhY3lJbnNwZWN0b3JCYWNrZW5k
Q29tbWFuZHMucmIgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvU2NyaXB0cy91cGRhdGUtTGVnYWN5
SW5zcGVjdG9yQmFja2VuZENvbW1hbmRzLnJiCmluZGV4IDk0YzM2NDMyY2I2Li4yOGQzZTJhMzEy
OCAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1NjcmlwdHMvdXBkYXRlLUxlZ2Fj
eUluc3BlY3RvckJhY2tlbmRDb21tYW5kcy5yYgorKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv
U2NyaXB0cy91cGRhdGUtTGVnYWN5SW5zcGVjdG9yQmFja2VuZENvbW1hbmRzLnJiCkBAIC0yOCw4
ICsyOCw3IEBAIGNsYXNzIFRhc2sKICAgICBwdXRzICIje2Rpc3BsYXlfaW5wdXR9IC0+ICN7ZGlz
cGxheV9vdXRwdXR9IgogCiAgICAgRGlyLm1rdG1wZGlyIGRvIHx0bXBkaXJ8Ci0gICAgICBkZXBl
bmRlbmN5ID0gQGRlcGVuZGVuY3lfanNvbl9wYXRoID8gIicje0BkZXBlbmRlbmN5X2pzb25fcGF0
aH0nIiA6ICIiCi0gICAgICBjbWQgPSAiI3skY29kZV9nZW5lcmF0b3JfcGF0aH0gLS1mb3JjZSAt
LW91dHB1dERpciAnI3t0bXBkaXJ9JyAtLWZyYW1ld29yayBKYXZhU2NyaXB0Q29yZSAnI3tAaW5w
dXRfanNvbl9wYXRofScgI3tkZXBlbmRlbmN5fSIKKyAgICAgIGNtZCA9ICIjeyRjb2RlX2dlbmVy
YXRvcl9wYXRofSAtLWZvcmNlIC0tb3V0cHV0RGlyICcje3RtcGRpcn0nIC0tZnJhbWV3b3JrIFdl
Ykluc3BlY3RvclVJICcje0BpbnB1dF9qc29uX3BhdGh9JyIKICAgICAgICV4eyAje2NtZH0gfQog
ICAgICAgaWYgJD8uZXhpdHN0YXR1cyAhPSAwCiAgICAgICAgIHB1dHMgIkVSUk9SOiBFcnJvciBD
b2RlICgjeyQ/LmV4aXRzdGF0dXN9KSBFdmFsdWF0aW5nOiAje2NtZH0iCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>332203</attachid>
            <date>2018-01-24 15:03:20 -0800</date>
            <delta_ts>2018-01-24 16:22:33 -0800</delta_ts>
            <desc>[PATCH] Proposed Fix</desc>
            <filename>better-1.patch</filename>
            <type>text/plain</type>
            <size>5285</size>
            <attacher name="Joseph Pecoraro">joepeck</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDQwYzZhN2Y1YmMzLi40YjNhYzE3YjMzMyAxMDA2
NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMDEtMjQgIEpvc2Vw
aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y
OiBTaW1wbGlmeSB1cGRhdGUtTGVnYWN5SW5zcGVjdG9yQmFja2VuZENvbW1hbmRzLnJiCisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODIwNjcKKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9z
Y3JpcHRzL2NvZGVnZW4vbW9kZWxzLnB5OgorICAgICAgICAoRnJhbWV3b3JrLmZyb21TdHJpbmcp
OgorICAgICAgICAoRnJhbWV3b3Jrcyk6CisgICAgICAgICogaW5zcGVjdG9yL3NjcmlwdHMvZ2Vu
ZXJhdGUtaW5zcGVjdG9yLXByb3RvY29sLWJpbmRpbmdzLnB5OgorICAgICAgICAoZ2VuZXJhdGVf
ZnJvbV9zcGVjaWZpY2F0aW9uKToKKyAgICAgICAgQWxsb3cgZnJhbWV3b3JrIFdlYkluc3BlY3Rv
clVJIHRvIGdlbmVyYXRlIGp1c3QgdGhlIGJhY2tlbmQgY29tbWFuZHMgZmlsZXMuCisKIDIwMTgt
MDEtMjMgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFVwZGF0ZSBQ
b2lzb25lZCBwb2ludGVycyB0byB0YWtlIGEgUG9pc29uIGNsYXNzIGluc3RlYWQgb2YgYSB1aW50
cHRyX3QmLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3Jp
cHRzL2NvZGVnZW4vbW9kZWxzLnB5IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9z
Y3JpcHRzL2NvZGVnZW4vbW9kZWxzLnB5CmluZGV4IDI0ZDMwYmY1MmU2Li5jYTkxZDcxYzdjNSAx
MDA3NTUKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzL2NvZGVn
ZW4vbW9kZWxzLnB5CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Ivc2NyaXB0
cy9jb2RlZ2VuL21vZGVscy5weQpAQCAtNTUsNiArNTUsOCBAQCBfRlJBTUVXT1JLX0NPTkZJR19N
QVAgPSB7CiAgICAgICAgICJvYmpjX3Byb3RvY29sX2dyb3VwIjogIlJXSSIsCiAgICAgICAgICJv
YmpjX3ByZWZpeCI6ICJSV0kiLAogICAgIH0sCisgICAgIldlYkluc3BlY3RvclVJIjogeworICAg
IH0sCiAgICAgIyBVc2VkIGZvciBjb2RlIGdlbmVyYXRvciB0ZXN0cy4KICAgICAiVGVzdCI6IHsK
ICAgICAgICAgImFsdGVybmF0ZV9kaXNwYXRjaGVycyI6IFRydWUsCkBAIC05NSw2ICs5Nyw5IEBA
IGNsYXNzIEZyYW1ld29yazoKICAgICAgICAgaWYgZnJhbWV3b3JrU3RyaW5nID09ICJXZWJJbnNw
ZWN0b3IiOgogICAgICAgICAgICAgcmV0dXJuIEZyYW1ld29ya3MuV2ViSW5zcGVjdG9yCiAKKyAg
ICAgICAgaWYgZnJhbWV3b3JrU3RyaW5nID09ICJXZWJJbnNwZWN0b3JVSSI6CisgICAgICAgICAg
ICByZXR1cm4gRnJhbWV3b3Jrcy5XZWJJbnNwZWN0b3JVSQorCiAgICAgICAgIGlmIGZyYW1ld29y
a1N0cmluZyA9PSAiVGVzdCI6CiAgICAgICAgICAgICByZXR1cm4gRnJhbWV3b3Jrcy5UZXN0CiAK
QEAgLTEwNiw2ICsxMTEsNyBAQCBjbGFzcyBGcmFtZXdvcmtzOgogICAgIEphdmFTY3JpcHRDb3Jl
ID0gRnJhbWV3b3JrKCJKYXZhU2NyaXB0Q29yZSIpCiAgICAgV2ViS2l0ID0gRnJhbWV3b3JrKCJX
ZWJLaXQiKQogICAgIFdlYkluc3BlY3RvciA9IEZyYW1ld29yaygiV2ViSW5zcGVjdG9yIikKKyAg
ICBXZWJJbnNwZWN0b3JVSSA9IEZyYW1ld29yaygiV2ViSW5zcGVjdG9yVUkiKQogICAgIFRlc3Qg
PSBGcmFtZXdvcmsoIlRlc3QiKQogCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9pbnNwZWN0b3Ivc2NyaXB0cy9nZW5lcmF0ZS1pbnNwZWN0b3ItcHJvdG9jb2wtYmluZGluZ3Mu
cHkgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3NjcmlwdHMvZ2VuZXJhdGUtaW5z
cGVjdG9yLXByb3RvY29sLWJpbmRpbmdzLnB5CmluZGV4IDE4MjEzNWU2NGU2Li41NzljMDE4MDFk
MiAxMDA3NTUKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzL2dl
bmVyYXRlLWluc3BlY3Rvci1wcm90b2NvbC1iaW5kaW5ncy5weQorKysgYi9Tb3VyY2UvSmF2YVNj
cmlwdENvcmUvaW5zcGVjdG9yL3NjcmlwdHMvZ2VuZXJhdGUtaW5zcGVjdG9yLXByb3RvY29sLWJp
bmRpbmdzLnB5CkBAIC0xOTUsNiArMTk1LDkgQEAgZGVmIGdlbmVyYXRlX2Zyb21fc3BlY2lmaWNh
dGlvbihwcmltYXJ5X3NwZWNpZmljYXRpb25fZmlsZXBhdGg9Tm9uZSwKICAgICAgICAgZ2VuZXJh
dG9ycy5hcHBlbmQoT2JqQ1Byb3RvY29sVHlwZUNvbnZlcnNpb25zSGVhZGVyR2VuZXJhdG9yKCpn
ZW5lcmF0b3JfYXJndW1lbnRzKSkKICAgICAgICAgZ2VuZXJhdG9ycy5hcHBlbmQoT2JqQ1Byb3Rv
Y29sVHlwZXNJbXBsZW1lbnRhdGlvbkdlbmVyYXRvcigqZ2VuZXJhdG9yX2FyZ3VtZW50cykpCiAK
KyAgICBlbGlmIHByb3RvY29sLmZyYW1ld29yayBpcyBGcmFtZXdvcmtzLldlYkluc3BlY3RvclVJ
OgorICAgICAgICBnZW5lcmF0b3JzLmFwcGVuZChKU0JhY2tlbmRDb21tYW5kc0dlbmVyYXRvcigq
Z2VuZXJhdG9yX2FyZ3VtZW50cykpCisKICAgICBzaW5nbGVfb3V0cHV0X2ZpbGVfY29udGVudHMg
PSBbXQogCiAgICAgZm9yIGdlbmVyYXRvciBpbiBnZW5lcmF0b3JzOgpAQCAtMjI0LDcgKzIyNyw3
IEBAIGRlZiBnZW5lcmF0ZV9mcm9tX3NwZWNpZmljYXRpb24ocHJpbWFyeV9zcGVjaWZpY2F0aW9u
X2ZpbGVwYXRoPU5vbmUsCiAKIAogaWYgX19uYW1lX18gPT0gJ19fbWFpbl9fJzoKLSAgICBhbGxv
d2VkX2ZyYW1ld29ya19uYW1lcyA9IFsnSmF2YVNjcmlwdENvcmUnLCAnV2ViSW5zcGVjdG9yJywg
J1dlYktpdCcsICdUZXN0J10KKyAgICBhbGxvd2VkX2ZyYW1ld29ya19uYW1lcyA9IFsnSmF2YVNj
cmlwdENvcmUnLCAnV2ViSW5zcGVjdG9yJywgJ1dlYkluc3BlY3RvclVJJywgJ1dlYktpdCcsICdU
ZXN0J10KICAgICBhbGxvd2VkX3BsYXRmb3JtX25hbWVzID0gWydpT1MnLCAnbWFjT1MnLCAnYWxs
JywgJ2dlbmVyaWMnXQogICAgIGNsaV9wYXJzZXIgPSBvcHRwYXJzZS5PcHRpb25QYXJzZXIodXNh
Z2U9InVzYWdlOiAlcHJvZyBbb3B0aW9uc10gUHJpbWFyeVByb3RvY29sLmpzb24gW1N1cHBsZW1l
bnRhbFByb3RvY29sLmpzb24gLi4uXSIpCiAgICAgY2xpX3BhcnNlci5hZGRfb3B0aW9uKCItbyIs
ICItLW91dHB1dERpciIsIGhlbHA9IkRpcmVjdG9yeSB3aGVyZSBnZW5lcmF0ZWQgZmlsZXMgc2hv
dWxkIGJlIHdyaXR0ZW4uIikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFu
Z2VMb2cgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGUzOGY2MWNmMDdk
Li4xZGUxMjQ2OGI1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxv
ZworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAK
IDIwMTgtMDEtMjQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAg
ICAgICBXZWIgSW5zcGVjdG9yOiBTaW1wbGlmeSB1cGRhdGUtTGVnYWN5SW5zcGVjdG9yQmFja2Vu
ZENvbW1hbmRzLnJiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0xODIwNjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg
ICAgICAqIFNjcmlwdHMvdXBkYXRlLUxlZ2FjeUluc3BlY3RvckJhY2tlbmRDb21tYW5kcy5yYjoK
KyAgICAgICAgUmVtb3ZlIHN0YWxlIGRlcGVuZGVuY3lfanNvbiwgaXQgaGFzIGFsd2F5cyBiZWVu
IGVtcHR5IGZvciBhIHdoaWxlIG5vdy4KKyAgICAgICAgU3dpdGNoIHRvIGZyYW1ld29yayBXZWJJ
bnNwZWN0b3JVSSB0byBnZW5lcmF0ZSBvbmx5IHRoZSBiYWNrZW5kIGNvbW1hbmRzCisgICAgICAg
IGFuZCBub3Qgc3BlbmQgdGltZSBnZW5lcmF0aW5nIGEgYnVuY2ggb2YgY3BwIGZpbGVzLgorCisy
MDE4LTAxLTI0ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAg
ICAgUmVmZXJlbmNlRXJyb3I64oCLIENhbid0IGZpbmQgdmFyaWFibGU64oCLIERPTUFnZW50IChh
dCBTY3JpcHRTeW50YXhUcmVlLmpzOuKAizE3ODrigIsyMinigIsKICAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjA1OQogCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViSW5zcGVjdG9yVUkvU2NyaXB0cy91cGRhdGUtTGVnYWN5SW5zcGVjdG9yQmFja2VuZENv
bW1hbmRzLnJiIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1NjcmlwdHMvdXBkYXRlLUxlZ2FjeUlu
c3BlY3RvckJhY2tlbmRDb21tYW5kcy5yYgppbmRleCA5NGMzNjQzMmNiNi4uMjhkM2UyYTMxMjgg
MTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9TY3JpcHRzL3VwZGF0ZS1MZWdhY3lJ
bnNwZWN0b3JCYWNrZW5kQ29tbWFuZHMucmIKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Nj
cmlwdHMvdXBkYXRlLUxlZ2FjeUluc3BlY3RvckJhY2tlbmRDb21tYW5kcy5yYgpAQCAtMjgsOCAr
MjgsNyBAQCBjbGFzcyBUYXNrCiAgICAgcHV0cyAiI3tkaXNwbGF5X2lucHV0fSAtPiAje2Rpc3Bs
YXlfb3V0cHV0fSIKIAogICAgIERpci5ta3RtcGRpciBkbyB8dG1wZGlyfAotICAgICAgZGVwZW5k
ZW5jeSA9IEBkZXBlbmRlbmN5X2pzb25fcGF0aCA/ICInI3tAZGVwZW5kZW5jeV9qc29uX3BhdGh9
JyIgOiAiIgotICAgICAgY21kID0gIiN7JGNvZGVfZ2VuZXJhdG9yX3BhdGh9IC0tZm9yY2UgLS1v
dXRwdXREaXIgJyN7dG1wZGlyfScgLS1mcmFtZXdvcmsgSmF2YVNjcmlwdENvcmUgJyN7QGlucHV0
X2pzb25fcGF0aH0nICN7ZGVwZW5kZW5jeX0iCisgICAgICBjbWQgPSAiI3skY29kZV9nZW5lcmF0
b3JfcGF0aH0gLS1mb3JjZSAtLW91dHB1dERpciAnI3t0bXBkaXJ9JyAtLWZyYW1ld29yayBXZWJJ
bnNwZWN0b3JVSSAnI3tAaW5wdXRfanNvbl9wYXRofSciCiAgICAgICAleHsgI3tjbWR9IH0KICAg
ICAgIGlmICQ/LmV4aXRzdGF0dXMgIT0gMAogICAgICAgICBwdXRzICJFUlJPUjogRXJyb3IgQ29k
ZSAoI3skPy5leGl0c3RhdHVzfSkgRXZhbHVhdGluZzogI3tjbWR9Igo=
</data>

          </attachment>
      

    </bug>

</bugzilla>