182066 2018-01-24 14:50:10 -0800 Add logging to facilitate binding of WebContent and Network processes to UI process 2018-01-25 13:31:26 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin bfulgham commit-queue mcatanzaro webkit-bug-importer oldest_to_newest 1392784 0 krollin 2018-01-24 14:50:10 -0800 When examining sysdiagnose logs and tracing events from one process to another, it would be helpful to know which WebKit processes were related to each other. When Safari, Mail, Messages, etc. are all running at the same time, it may otherwise be difficult to know if a particular Network process, for example was associated with Safari or some other application. Add some logging to the creation of WebContent and Network processes to identify their "presenting process" (parent application). 1392825 1 332210 krollin 2018-01-24 16:07:49 -0800 Created attachment 332210 Patch 1392866 2 332210 mcatanzaro 2018-01-24 17:54:36 -0800 Comment on attachment 332210 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332210&action=review > Source/WebKit/NetworkProcess/NetworkProcess.cpp:263 > + RELEASE_LOG(Process, "%p - NetworkProcess::initializeNetworkProcess: Presenting process = %lu", this, static_cast<unsigned long>(WebCore::presentingApplicationPID())); Seems like a good idea, but why are you casting from int to unsigned long and using %lu, instead of just using %d? I know it's weird that WebCore::presentingApplicationPID uses int rather than pid_t or unsigned int... but that really is its type. 1392884 3 332210 bfulgham 2018-01-24 19:05:28 -0800 Comment on attachment 332210 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332210&action=review r=me if you remove the cast and just use %d. >> Source/WebKit/NetworkProcess/NetworkProcess.cpp:263 >> + RELEASE_LOG(Process, "%p - NetworkProcess::initializeNetworkProcess: Presenting process = %lu", this, static_cast<unsigned long>(WebCore::presentingApplicationPID())); > > Seems like a good idea, but why are you casting from int to unsigned long and using %lu, instead of just using %d? I know it's weird that WebCore::presentingApplicationPID uses int rather than pid_t or unsigned int... but that really is its type. That is weird! Especially considering that it is a pid_t in many places. Maybe Andy can tell us why it's just an int in this method. But for this logging purpose, int seems reasonable. 1392935 4 krollin 2018-01-24 23:36:12 -0800 (In reply to Brent Fulgham from comment #3) > > Seems like a good idea, but why are you casting from int to unsigned long and using %lu, instead of just using %d? I know it's weird that WebCore::presentingApplicationPID uses int rather than pid_t or unsigned int... but that really is its type. > > That is weird! Especially considering that it is a pid_t in many places. > Maybe Andy can tell us why it's just an int in this method. But for this > logging purpose, int seems reasonable. I was looking into how to get a PID in WebKit. I had drilled down into RuntimeApplicationChecks.cpp/.h, which called into ProcessID.h. The base type in ProcessID.h is ProcessID, which is an int on Windows but a pid_t elsewhere. I didn't know what type a pid_t was, so I decided to promote it to something that should hold just about any value. I neglected to notice that presentingApplicationPID in RuntimeApplicationChecks silently converts the ProcessID to an int. So making use of that information to remove my cast makes sense. 1393217 5 332303 krollin 2018-01-25 13:04:21 -0800 Created attachment 332303 Patch 1393241 6 332303 commit-queue 2018-01-25 13:30:28 -0800 Comment on attachment 332303 Patch Clearing flags on attachment: 332303 Committed r227627: <https://trac.webkit.org/changeset/227627> 1393242 7 commit-queue 2018-01-25 13:30:30 -0800 All reviewed patches have been landed. Closing bug. 1393244 8 webkit-bug-importer 2018-01-25 13:31:26 -0800 <rdar://problem/36881094> 332210 2018-01-24 16:07:49 -0800 2018-01-25 13:04:19 -0800 Patch bug-182066-20180124160748.patch text/plain 3455 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3NTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDViMGFjOGNjOGVmNzI0OWQ4 MGVkY2VlZTc1OWZjOTQ2NGNkYjdkZWUuLjQwNzk1NDI5NjI4ZTI2ZTRhNWZhM2ZmNjk2ZjIyZjQ2 YzIzZTg1ZjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTgtMDEtMjQgIEtlaXRoIFJv bGxpbiAgPGtyb2xsaW5AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBsb2dnaW5nIHRvIGZhY2ls aXRhdGUgYmluZGluZyBvZiBXZWJDb250ZW50IGFuZCBOZXR3b3JrIHByb2Nlc3NlcyB0byBVSSBw cm9jZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x ODIwNjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX aGVuIGV4YW1pbmluZyBzeXNkaWFnbm9zZSBsb2dzIGFuZCB0cmFjaW5nIGV2ZW50cyBmcm9tIG9u ZSBwcm9jZXNzIHRvCisgICAgICAgIGFub3RoZXIsIGl0IHdvdWxkIGJlIGhlbHBmdWwgdG8ga25v dyB3aGljaCBXZWJLaXQgcHJvY2Vzc2VzIHdlcmUKKyAgICAgICAgcmVsYXRlZCB0byBlYWNoIG90 aGVyLiBXaGVuIFNhZmFyaSwgTWFpbCwgTWVzc2FnZXMsIGV0Yy4gYXJlIGFsbAorICAgICAgICBy dW5uaW5nIGF0IHRoZSBzYW1lIHRpbWUsIGl0IG1heSBvdGhlcndpc2UgYmUgZGlmZmljdWx0IHRv IGtub3cgaWYgYQorICAgICAgICBwYXJ0aWN1bGFyIE5ldHdvcmsgcHJvY2VzcywgZm9yIGV4YW1w bGUgd2FzIGFzc29jaWF0ZWQgd2l0aCBTYWZhcmkgb3IKKyAgICAgICAgc29tZSBvdGhlciBhcHBs aWNhdGlvbi4gQWRkIHNvbWUgbG9nZ2luZyB0byB0aGUgY3JlYXRpb24gb2YgV2ViQ29udGVudAor ICAgICAgICBhbmQgTmV0d29yayBwcm9jZXNzZXMgdG8gaWRlbnRpZnkgdGhlaXIgInByZXNlbnRp bmcgcHJvY2VzcyIgKHBhcmVudAorICAgICAgICBhcHBsaWNhdGlvbikuCisKKyAgICAgICAgKiBO ZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdv cmtQcm9jZXNzOjppbml0aWFsaXplTmV0d29ya1Byb2Nlc3MpOgorICAgICAgICAqIFBsYXRmb3Jt L0xvZ2dpbmcuaDoKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwOgorICAgICAg ICAoV2ViS2l0OjpXZWJQcm9jZXNzOjppbml0aWFsaXplV2ViUHJvY2Vzcyk6CisKIDIwMTgtMDEt MjQgIEphbi1NaWNoYWVsIEJydW1tZXIgIDxqYW4uYnJ1bW1lckB0YWJvcy5vcmc+CiAgICAgICAg IFtHVEtdIFBhZ2UgY3Jhc2ggYWZ0ZXIgc3dpcGUgZ2VzdHVyZSBydW5uaW5nIEdOT01FMyB1bmRl ciB3YXlsYW5kCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0 d29ya1Byb2Nlc3MuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJv Y2Vzcy5jcHAKaW5kZXggMTg1NTg2YjZhMjk4OTYxNTFjMTgzMDgzZTQ2ZWQ1NjQ5NDQxYzQzOC4u YWUxZDQzMWRkMjYzNzk1MDA4MzdlMjA5MzhhMGVmZjg3ZTY3NGUwZSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAKKysrIGIvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAKQEAgLTI1OSw2ICsyNTks OCBAQCB2b2lkIE5ldHdvcmtQcm9jZXNzOjppbml0aWFsaXplTmV0d29ya1Byb2Nlc3MoTmV0d29y a1Byb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMmJgogCiAgICAgZm9yIChhdXRvJiBzdXBwbGVtZW50 IDogbV9zdXBwbGVtZW50cy52YWx1ZXMoKSkKICAgICAgICAgc3VwcGxlbWVudC0+aW5pdGlhbGl6 ZShwYXJhbWV0ZXJzKTsKKworICAgIFJFTEVBU0VfTE9HKFByb2Nlc3MsICIlcCAtIE5ldHdvcmtQ cm9jZXNzOjppbml0aWFsaXplTmV0d29ya1Byb2Nlc3M6IFByZXNlbnRpbmcgcHJvY2VzcyA9ICVs dSIsIHRoaXMsIHN0YXRpY19jYXN0PHVuc2lnbmVkIGxvbmc+KFdlYkNvcmU6OnByZXNlbnRpbmdB cHBsaWNhdGlvblBJRCgpKSk7CiB9CiAKIHZvaWQgTmV0d29ya1Byb2Nlc3M6OmluaXRpYWxpemVD b25uZWN0aW9uKElQQzo6Q29ubmVjdGlvbiogY29ubmVjdGlvbikKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvUGxhdGZvcm0vTG9nZ2luZy5oIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9Mb2dn aW5nLmgKaW5kZXggOGU5MGIwMjQ1M2MxZjRmNTQxMWY3NDdiZDZkMmZmZTEyZGI4YzRkZi4uZjVi YzQwYTViZmIwM2Y2YTMyYTI5M2ZhOWU3OGU0MmM5YTA1ZDI0ZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9QbGF0Zm9ybS9Mb2dnaW5nLmgKKysrIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9M b2dnaW5nLmgKQEAgLTU4LDYgKzU4LDcgQEAgZXh0ZXJuICJDIiB7CiAgICAgTShQZXJmb3JtYW5j ZUxvZ2dpbmcpIFwKICAgICBNKFBsdWdpbnMpIFwKICAgICBNKFByaW50aW5nKSBcCisgICAgTShQ cm9jZXNzKSBcCiAgICAgTShQcm9jZXNzU3VzcGVuc2lvbikgXAogICAgIE0oUmVtb3RlTGF5ZXJU cmVlKSBcCiAgICAgTShSZXNpemUpIFwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJv Y2Vzcy9XZWJQcm9jZXNzLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQcm9jZXNz LmNwcAppbmRleCA5MDc0MjY5N2M1MTA4ZGU5NTYyNGI2OWNmZTUxMGUxMjkwMGM5M2VkLi41Y2Vj MDk4MTkxZTMyMjVhOTM3ZGM2NTdhMDdjYTZiY2FiY2Y0NjhkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQ cm9jZXNzL1dlYlByb2Nlc3MuY3BwCkBAIC00MjYsNiArNDI2LDggQEAgdm9pZCBXZWJQcm9jZXNz Ojppbml0aWFsaXplV2ViUHJvY2VzcyhXZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzJiYgcGFy YW1ldGVycykKICNpZiBIQVZFKENGTkVUV09SS19TVE9SQUdFX1BBUlRJVElPTklORykgJiYgIVJF TEVBU0VfTE9HX0RJU0FCTEVECiAgICAgUmVzb3VyY2VMb2FkT2JzZXJ2ZXI6OnNoYXJlZCgpLnNl dFNob3VsZExvZ1VzZXJJbnRlcmFjdGlvbihwYXJhbWV0ZXJzLnNob3VsZExvZ1VzZXJJbnRlcmFj dGlvbik7CiAjZW5kaWYKKworICAgIFJFTEVBU0VfTE9HKFByb2Nlc3MsICIlcCAtIFdlYlByb2Nl c3M6OmluaXRpYWxpemVXZWJQcm9jZXNzOiBQcmVzZW50aW5nIHByb2Nlc3MgPSAlbHUiLCB0aGlz LCBzdGF0aWNfY2FzdDx1bnNpZ25lZCBsb25nPihXZWJDb3JlOjpwcmVzZW50aW5nQXBwbGljYXRp b25QSUQoKSkpOwogfQogCiB2b2lkIFdlYlByb2Nlc3M6OnJlZ2lzdGVyVVJMU2NoZW1lQXNFbXB0 eURvY3VtZW50KGNvbnN0IFN0cmluZyYgdXJsU2NoZW1lKQo= 332303 2018-01-25 13:04:21 -0800 2018-01-25 13:30:28 -0800 Patch bug-182066-20180125130420.patch text/plain 3396 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3NTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDViMGFjOGNjOGVmNzI0OWQ4 MGVkY2VlZTc1OWZjOTQ2NGNkYjdkZWUuLjA4NTQ1OGQ5NmU2YWUzMThmMTgyMDA4NTdkNzA3OGRj NGFlYTIxMWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTgtMDEtMjUgIEtlaXRoIFJv bGxpbiAgPGtyb2xsaW5AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBsb2dnaW5nIHRvIGZhY2ls aXRhdGUgYmluZGluZyBvZiBXZWJDb250ZW50IGFuZCBOZXR3b3JrIHByb2Nlc3NlcyB0byBVSSBw cm9jZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x ODIwNjYKKworICAgICAgICBSZXZpZXdlZCBieSBCcmVudCBGdWxnaGFtLgorCisgICAgICAgIFdo ZW4gZXhhbWluaW5nIHN5c2RpYWdub3NlIGxvZ3MgYW5kIHRyYWNpbmcgZXZlbnRzIGZyb20gb25l IHByb2Nlc3MgdG8KKyAgICAgICAgYW5vdGhlciwgaXQgd291bGQgYmUgaGVscGZ1bCB0byBrbm93 IHdoaWNoIFdlYktpdCBwcm9jZXNzZXMgd2VyZQorICAgICAgICByZWxhdGVkIHRvIGVhY2ggb3Ro ZXIuIFdoZW4gU2FmYXJpLCBNYWlsLCBNZXNzYWdlcywgZXRjLiBhcmUgYWxsCisgICAgICAgIHJ1 bm5pbmcgYXQgdGhlIHNhbWUgdGltZSwgaXQgbWF5IG90aGVyd2lzZSBiZSBkaWZmaWN1bHQgdG8g a25vdyBpZiBhCisgICAgICAgIHBhcnRpY3VsYXIgTmV0d29yayBwcm9jZXNzLCBmb3IgZXhhbXBs ZSB3YXMgYXNzb2NpYXRlZCB3aXRoIFNhZmFyaSBvcgorICAgICAgICBzb21lIG90aGVyIGFwcGxp Y2F0aW9uLiBBZGQgc29tZSBsb2dnaW5nIHRvIHRoZSBjcmVhdGlvbiBvZiBXZWJDb250ZW50Cisg ICAgICAgIGFuZCBOZXR3b3JrIHByb2Nlc3NlcyB0byBpZGVudGlmeSB0aGVpciAicHJlc2VudGlu ZyBwcm9jZXNzIiAocGFyZW50CisgICAgICAgIGFwcGxpY2F0aW9uKS4KKworICAgICAgICAqIE5l dHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29y a1Byb2Nlc3M6OmluaXRpYWxpemVOZXR3b3JrUHJvY2Vzcyk6CisgICAgICAgICogUGxhdGZvcm0v TG9nZ2luZy5oOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHA6CisgICAgICAg IChXZWJLaXQ6OldlYlByb2Nlc3M6OmluaXRpYWxpemVXZWJQcm9jZXNzKToKKwogMjAxOC0wMS0y NCAgSmFuLU1pY2hhZWwgQnJ1bW1lciAgPGphbi5icnVtbWVyQHRhYm9zLm9yZz4KICAgICAgICAg W0dUS10gUGFnZSBjcmFzaCBhZnRlciBzd2lwZSBnZXN0dXJlIHJ1bm5pbmcgR05PTUUzIHVuZGVy IHdheWxhbmQKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3 b3JrUHJvY2Vzcy5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9j ZXNzLmNwcAppbmRleCAxODU1ODZiNmEyOTg5NjE1MWMxODMwODNlNDZlZDU2NDk0NDFjNDM4Li5k MWQ3OTJlMzE4ZjRjZjJhMjUyMTY4ODUyYTBjYzUwN2RkMjU2NDk5IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNwcApAQCAtMjU5LDYgKzI1OSw4 IEBAIHZvaWQgTmV0d29ya1Byb2Nlc3M6OmluaXRpYWxpemVOZXR3b3JrUHJvY2VzcyhOZXR3b3Jr UHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycyYmCiAKICAgICBmb3IgKGF1dG8mIHN1cHBsZW1lbnQg OiBtX3N1cHBsZW1lbnRzLnZhbHVlcygpKQogICAgICAgICBzdXBwbGVtZW50LT5pbml0aWFsaXpl KHBhcmFtZXRlcnMpOworCisgICAgUkVMRUFTRV9MT0coUHJvY2VzcywgIiVwIC0gTmV0d29ya1By b2Nlc3M6OmluaXRpYWxpemVOZXR3b3JrUHJvY2VzczogUHJlc2VudGluZyBwcm9jZXNzID0gJWQi LCB0aGlzLCBXZWJDb3JlOjpwcmVzZW50aW5nQXBwbGljYXRpb25QSUQoKSk7CiB9CiAKIHZvaWQg TmV0d29ya1Byb2Nlc3M6OmluaXRpYWxpemVDb25uZWN0aW9uKElQQzo6Q29ubmVjdGlvbiogY29u bmVjdGlvbikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vTG9nZ2luZy5oIGIv U291cmNlL1dlYktpdC9QbGF0Zm9ybS9Mb2dnaW5nLmgKaW5kZXggOGU5MGIwMjQ1M2MxZjRmNTQx MWY3NDdiZDZkMmZmZTEyZGI4YzRkZi4uZjViYzQwYTViZmIwM2Y2YTMyYTI5M2ZhOWU3OGU0MmM5 YTA1ZDI0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9Mb2dnaW5nLmgKKysr IGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9Mb2dnaW5nLmgKQEAgLTU4LDYgKzU4LDcgQEAgZXh0 ZXJuICJDIiB7CiAgICAgTShQZXJmb3JtYW5jZUxvZ2dpbmcpIFwKICAgICBNKFBsdWdpbnMpIFwK ICAgICBNKFByaW50aW5nKSBcCisgICAgTShQcm9jZXNzKSBcCiAgICAgTShQcm9jZXNzU3VzcGVu c2lvbikgXAogICAgIE0oUmVtb3RlTGF5ZXJUcmVlKSBcCiAgICAgTShSZXNpemUpIFwKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcCBiL1NvdXJjZS9X ZWJLaXQvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcAppbmRleCA5MDc0MjY5N2M1MTA4ZGU5NTYy NGI2OWNmZTUxMGUxMjkwMGM5M2VkLi43MTliMDE3YzBkMTFmZjZiYTEwZTdlNjZhZDBiMjM3YjQz YTIyZDc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5j cHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwCkBAIC00MjYs NiArNDI2LDggQEAgdm9pZCBXZWJQcm9jZXNzOjppbml0aWFsaXplV2ViUHJvY2VzcyhXZWJQcm9j ZXNzQ3JlYXRpb25QYXJhbWV0ZXJzJiYgcGFyYW1ldGVycykKICNpZiBIQVZFKENGTkVUV09SS19T VE9SQUdFX1BBUlRJVElPTklORykgJiYgIVJFTEVBU0VfTE9HX0RJU0FCTEVECiAgICAgUmVzb3Vy Y2VMb2FkT2JzZXJ2ZXI6OnNoYXJlZCgpLnNldFNob3VsZExvZ1VzZXJJbnRlcmFjdGlvbihwYXJh bWV0ZXJzLnNob3VsZExvZ1VzZXJJbnRlcmFjdGlvbik7CiAjZW5kaWYKKworICAgIFJFTEVBU0Vf TE9HKFByb2Nlc3MsICIlcCAtIFdlYlByb2Nlc3M6OmluaXRpYWxpemVXZWJQcm9jZXNzOiBQcmVz ZW50aW5nIHByb2Nlc3MgPSAlZCIsIHRoaXMsIFdlYkNvcmU6OnByZXNlbnRpbmdBcHBsaWNhdGlv blBJRCgpKTsKIH0KIAogdm9pZCBXZWJQcm9jZXNzOjpyZWdpc3RlclVSTFNjaGVtZUFzRW1wdHlE b2N1bWVudChjb25zdCBTdHJpbmcmIHVybFNjaGVtZSkK