182063 2018-01-24 14:18:08 -0800 [Curl] Implement didSendData client callback. 2018-01-24 20:14:06 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 basuke basuke achristensen basuke commit-queue don.olmstead ews-watchlist galpeter webkit-bug-importer oldest_to_newest 1392753 0 basuke 2018-01-24 14:18:08 -0800 Curl port didn't have this implementation. Now we have. 1392758 1 332199 basuke 2018-01-24 14:21:43 -0800 Created attachment 332199 Patch 1392766 2 332199 achristensen 2018-01-24 14:28:36 -0800 Comment on attachment 332199 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332199&action=review > Source/WebCore/platform/network/curl/ResourceHandleCurlDelegate.cpp:190 > + m_handle->client()->didSendData(m_handle, bytesSent, totalBytesToBeSent); You might want to check these for null. 1392770 3 332199 don.olmstead 2018-01-24 14:33:04 -0800 Comment on attachment 332199 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332199&action=review >> Source/WebCore/platform/network/curl/ResourceHandleCurlDelegate.cpp:190 >> + m_handle->client()->didSendData(m_handle, bytesSent, totalBytesToBeSent); > > You might want to check these for null. Looks like cancelledOrClientless does that correct Basuke? 1392817 4 basuke 2018-01-24 16:00:54 -0800 Null check was done in callClient utility method. It is also guarded by protectThis. 1392818 5 basuke 2018-01-24 16:01:55 -0800 Oh, I misunderstood the point. I'm checking. 1392820 6 basuke 2018-01-24 16:04:06 -0800 Don is correct. It was checked by cancelledOrClientless(). 1392903 7 332199 commit-queue 2018-01-24 20:13:00 -0800 Comment on attachment 332199 Patch Clearing flags on attachment: 332199 Committed r227591: <https://trac.webkit.org/changeset/227591> 1392904 8 commit-queue 2018-01-24 20:13:01 -0800 All reviewed patches have been landed. Closing bug. 1392905 9 webkit-bug-importer 2018-01-24 20:14:06 -0800 <rdar://problem/36853125> 332199 2018-01-24 14:21:43 -0800 2018-01-24 20:13:00 -0800 Patch 182063.diff text/plain 4455 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmMDJlNjIzLi4yMTA3ODdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTgtMDEtMjQgIEJhc3VrZSBTdXp1a2kgIDxCYXN1a2UuU3V6dWtpQHNvbnkuY29tPgor CisgICAgICAgIFtDdXJsXSBJbXBsZW1lbnQgZGlkU2VuZERhdGEgY2xpZW50IGNhbGxiYWNrLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyMDYzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzIChjb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzKS4KKworICAgICAgICAqIHBsYXRmb3JtL25l dHdvcmsvY3VybC9DdXJsRG93bmxvYWQuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2N1 cmwvQ3VybFJlcXVlc3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q3VybFJlcXVlc3Q6OndpbGxT ZW5kRGF0YSk6CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxSZXF1ZXN0Q2xp ZW50Lmg6CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlQ3Vy bERlbGVnYXRlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlQ3VybERlbGVn YXRlOjpjdXJsRGlkU2VuZERhdGEpOgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY3VybC9S ZXNvdXJjZUhhbmRsZUN1cmxEZWxlZ2F0ZS5oOgorCiAyMDE4LTAxLTIzICBCYXN1a2UgU3V6dWtp ICA8QmFzdWtlLlN1enVraUBzb255LmNvbT4KIAogICAgICAgICBbQ3VybF0gRml4IHdyb25nIHJl ZGlyZWN0aW9uIHdpdGggcmVsYXRpdmUgdXJsIHdoZW4gaXQgaGFwcGVucyBmcm9tCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybERvd25sb2FkLmgg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybERvd25sb2FkLmgKaW5k ZXggZDg1MzRhOC4uOGFhZjcwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9jdXJsL0N1cmxEb3dubG9hZC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvY3VybC9DdXJsRG93bmxvYWQuaApAQCAtNzAsNiArNzAsNyBAQCBwdWJsaWM6CiAK IHByaXZhdGU6CiAgICAgUmVmPEN1cmxSZXF1ZXN0PiBjcmVhdGVDdXJsUmVxdWVzdChSZXNvdXJj ZVJlcXVlc3QmKTsKKyAgICB2b2lkIGN1cmxEaWRTZW5kRGF0YSh1bnNpZ25lZCBsb25nIGxvbmcs IHVuc2lnbmVkIGxvbmcgbG9uZykgb3ZlcnJpZGUgeyB9CiAgICAgdm9pZCBjdXJsRGlkUmVjZWl2 ZVJlc3BvbnNlKGNvbnN0IEN1cmxSZXNwb25zZSYpIG92ZXJyaWRlOwogICAgIHZvaWQgY3VybERp ZFJlY2VpdmVCdWZmZXIoUmVmPFNoYXJlZEJ1ZmZlcj4mJikgb3ZlcnJpZGU7CiAgICAgdm9pZCBj dXJsRGlkQ29tcGxldGUoKSBvdmVycmlkZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvY3VybC9DdXJsUmVxdWVzdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybFJlcXVlc3QuY3BwCmluZGV4IGExMWUxMTguLjAyNjlkMTMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsUmVx dWVzdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxS ZXF1ZXN0LmNwcApAQCAtMjYyLDYgKzI2MiwxMCBAQCBzaXplX3QgQ3VybFJlcXVlc3Q6OndpbGxT ZW5kRGF0YShjaGFyKiBidWZmZXIsIHNpemVfdCBibG9ja1NpemUsIHNpemVfdCBudW1iZXJPZgog ICAgICAgICByZXR1cm4gQ1VSTF9SRUFERlVOQ19BQk9SVDsKICAgICB9CiAKKyAgICBjYWxsQ2xp ZW50KFt0aGlzLCB0b3RhbFJlYWRTaXplID0gbV9mb3JtRGF0YVN0cmVhbS50b3RhbFJlYWRTaXpl KCksIHRvdGFsU2l6ZSA9IG1fZm9ybURhdGFTdHJlYW0udG90YWxTaXplKCldKEN1cmxSZXF1ZXN0 Q2xpZW50JiBjbGllbnQpIHsKKyAgICAgICAgY2xpZW50LmN1cmxEaWRTZW5kRGF0YSh0b3RhbFJl YWRTaXplLCB0b3RhbFNpemUpOworICAgIH0pOworCiAgICAgcmV0dXJuICpzZW5kQnl0ZXM7CiB9 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJs UmVxdWVzdENsaWVudC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1 cmxSZXF1ZXN0Q2xpZW50LmgKaW5kZXggZmMzZWZmNS4uMzljMjAyMiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxSZXF1ZXN0Q2xpZW50LmgKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxSZXF1ZXN0Q2xpZW50 LmgKQEAgLTM4LDYgKzM4LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCByZWYoKSA9IDA7 CiAgICAgdmlydHVhbCB2b2lkIGRlcmVmKCkgPSAwOwogCisgICAgdmlydHVhbCB2b2lkIGN1cmxE aWRTZW5kRGF0YSh1bnNpZ25lZCBsb25nIGxvbmcgYnl0ZXNTZW50LCB1bnNpZ25lZCBsb25nIGxv bmcgdG90YWxCeXRlc1RvQmVTZW50KSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIGN1cmxEaWRSZWNl aXZlUmVzcG9uc2UoY29uc3QgQ3VybFJlc3BvbnNlJikgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBj dXJsRGlkUmVjZWl2ZUJ1ZmZlcihSZWY8U2hhcmVkQnVmZmVyPiYmKSA9IDA7CiAgICAgdmlydHVh bCB2b2lkIGN1cmxEaWRDb21wbGV0ZSgpID0gMDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZUN1cmxEZWxlZ2F0ZS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVDdXJsRGVs ZWdhdGUuY3BwCmluZGV4IDM2ZTI1MDEuLjUxNDkzMTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZUN1cmxEZWxlZ2F0ZS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxl Q3VybERlbGVnYXRlLmNwcApAQCAtMTgwLDYgKzE4MCwxNiBAQCBib29sIFJlc291cmNlSGFuZGxl Q3VybERlbGVnYXRlOjpjYW5jZWxsZWRPckNsaWVudGxlc3MoKQogICAgIHJldHVybiAhbV9oYW5k bGUtPmNsaWVudCgpOwogfQogCit2b2lkIFJlc291cmNlSGFuZGxlQ3VybERlbGVnYXRlOjpjdXJs RGlkU2VuZERhdGEodW5zaWduZWQgbG9uZyBsb25nIGJ5dGVzU2VudCwgdW5zaWduZWQgbG9uZyBs b25nIHRvdGFsQnl0ZXNUb0JlU2VudCkKK3sKKyAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOwor CisgICAgaWYgKGNhbmNlbGxlZE9yQ2xpZW50bGVzcygpKQorICAgICAgICByZXR1cm47CisKKyAg ICBtX2hhbmRsZS0+Y2xpZW50KCktPmRpZFNlbmREYXRhKG1faGFuZGxlLCBieXRlc1NlbnQsIHRv dGFsQnl0ZXNUb0JlU2VudCk7Cit9CisKIHZvaWQgUmVzb3VyY2VIYW5kbGVDdXJsRGVsZWdhdGU6 OmN1cmxEaWRSZWNlaXZlUmVzcG9uc2UoY29uc3QgQ3VybFJlc3BvbnNlJiByZWNlaXZlZFJlc3Bv bnNlKQogewogICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVDdXJsRGVsZWdhdGUu aCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZUN1 cmxEZWxlZ2F0ZS5oCmluZGV4IDc3Y2M1ZWMuLmZiZmZhNTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZUN1cmxEZWxlZ2F0ZS5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRs ZUN1cmxEZWxlZ2F0ZS5oCkBAIC03MSw2ICs3MSw3IEBAIHByaXZhdGU6CiAgICAgYm9vbCBjYW5j ZWxsZWRPckNsaWVudGxlc3MoKTsKIAogICAgIFJlZjxDdXJsUmVxdWVzdD4gY3JlYXRlQ3VybFJl cXVlc3QoUmVzb3VyY2VSZXF1ZXN0Jik7CisgICAgdm9pZCBjdXJsRGlkU2VuZERhdGEodW5zaWdu ZWQgbG9uZyBsb25nIGJ5dGVzU2VudCwgdW5zaWduZWQgbG9uZyBsb25nIHRvdGFsQnl0ZXNUb0Jl U2VudCkgb3ZlcnJpZGU7CiAgICAgdm9pZCBjdXJsRGlkUmVjZWl2ZVJlc3BvbnNlKGNvbnN0IEN1 cmxSZXNwb25zZSYpIG92ZXJyaWRlOwogICAgIHZvaWQgY3VybERpZFJlY2VpdmVCdWZmZXIoUmVm PFNoYXJlZEJ1ZmZlcj4mJikgb3ZlcnJpZGU7CiAgICAgdm9pZCBjdXJsRGlkQ29tcGxldGUoKSBv dmVycmlkZTsK