182059 2018-01-24 13:08:55 -0800 ReferenceError:​ Can't find variable:​ DOMAgent (at ScriptSyntaxTree.js:​178:​22)​ 2018-01-24 14:47:46 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=182065 InRadar P2 Normal --- 1 cdumez joepeck commit-queue inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1392705 0 cdumez 2018-01-24 13:08:55 -0800 Web Inspector frequently crashes for me on debug builds when inspecting service workers. The error looks like so: ReferenceError:​ Can't find variable:​ DOMAgent (at ScriptSyntaxTree.js:​178:​22)​ functionReturnDivot @ ScriptSyntaxTree.js:​178:​22 updateTypes @ ScriptSyntaxTree.js:​217:​67 insertAnnotations @ TypeTokenAnnotator.js:​62:​37 ?​ @ TypeTokenAnnotator.js:​50:​43 makeSyntaxTreeAndCallCallback @ Script.js:​213:​21 1392712 1 joepeck 2018-01-24 13:28:55 -0800 DOMAgent won't exist in a ServiceWorker inspector. This is an awkward case where we are checking if the DOMAgent would have had a method just to know if this is an iOS target or not. So just adding a check for DOMAgent itself will be enough for this to work in Page and ServiceWorker contexts. 1392716 2 332190 joepeck 2018-01-24 13:41:44 -0800 Created attachment 332190 [PATCH] Proposed Fix 1392721 3 332190 mattbaker 2018-01-24 13:49:44 -0800 Comment on attachment 332190 [PATCH] Proposed Fix r=me 1392762 4 332190 commit-queue 2018-01-24 14:26:22 -0800 Comment on attachment 332190 [PATCH] Proposed Fix Clearing flags on attachment: 332190 Committed r227572: <https://trac.webkit.org/changeset/227572> 1392763 5 commit-queue 2018-01-24 14:26:24 -0800 All reviewed patches have been landed. Closing bug. 1392765 6 webkit-bug-importer 2018-01-24 14:27:40 -0800 <rdar://problem/36839642> 332190 2018-01-24 13:41:44 -0800 2018-01-24 14:26:22 -0800 [PATCH] Proposed Fix domagent-1.patch text/plain 2056 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDc2Y2FjZDhjMzQ1Li5lMzhmNjFjZjA3ZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDEtMjQgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBSZWZlcmVuY2VFcnJv cjrigIsgQ2FuJ3QgZmluZCB2YXJpYWJsZTrigIsgRE9NQWdlbnQgKGF0IFNjcmlwdFN5bnRheFRy ZWUuanM64oCLMTc4OuKAizIyKeKAiworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTgyMDU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01vZGVscy9TY3JpcHRTeW50YXhUcmVlLmpz OgorICAgICAgICAoV0kuU2NyaXB0U3ludGF4VHJlZS5mdW5jdGlvblJldHVybkRpdm90KToKKyAg ICAgICAgRE9NQWdlbnQgd29uJ3QgYmUgYXZhaWxhYmxlIGluIGEgU2VydmljZVdvcmtlciBvciBK U0NvbnRleHQgaW5zcGVjdG9yLiBTbyBhZGQKKyAgICAgICAgYSBjaGVjayBmb3IgRE9NQWdlbnQs IGFuZCBhc3N1bWUgaWYgRE9NQWdlbnQgZG9lc24ndCBleGlzdCB0aGF0IHdlIHNob3VsZCBmYWxs CisgICAgICAgIGJhY2sgdG8gdGhlIGxhdGVzdCBwYXRoIChub24taU9TIDkpIHRhcmdldC4KKwog MjAxOC0wMS0yMyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAg ICAgIFdlYiBJbnNwZWN0b3I6IE5ldHdvcmsncyBjb2x1bW5zIHNoYWtlIHdoZW4gc2Nyb2xsaW5n IGF0IG5vbi1kZWZhdWx0IHpvb20gbGV2ZWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9TY3JpcHRTeW50YXhUcmVlLmpzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1NjcmlwdFN5bnRheFRyZWUuanMKaW5k ZXggNTk1MWE5YzAxY2EuLjVkZTY0ZThjODFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvU2NyaXB0U3ludGF4VHJlZS5qcworKysgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvU2NyaXB0U3ludGF4VHJlZS5q cwpAQCAtMTc1LDcgKzE3NSw4IEBAIFdJLlNjcmlwdFN5bnRheFRyZWUgPSBjbGFzcyBTY3JpcHRT eW50YXhUcmVlCiAgICAgICAgIC8vIENPTVBBVElCSUxJVFkgKGlPUyA5KTogTGVnYWN5IEJhY2tl bmRzIHZpZXcgdGhlIHJldHVybiB0eXBlIGFzIGJlaW5nIHRoZSBvcGVuaW5nICJ7IiBvZiB0aGUg ZnVuY3Rpb24gYm9keS4KICAgICAgICAgLy8gQWZ0ZXIgaU9TIDksIHRoaXMgaXMgdG8gbW92ZSB0 byB0aGUgc3RhcnQgb2YgdGhlIGZ1bmN0aW9uIHN0YXRlbWVudC9leHByZXNzaW9uLiBTZWUgYmVs b3c6CiAgICAgICAgIC8vIEZJWE1FOiBOZWVkIGEgYmV0dGVyIHdheSB0byBkZXRlcm1pbmUgYmFj a2VuZCB2ZXJzaW9ucy4gVXNpbmcgRE9NLnBzZXVkb0VsZW1lbnQgYmVjYXVzZSB0aGF0IHdhcyBh ZGRlZCBhZnRlciBpT1MgOS4KLSAgICAgICAgaWYgKCFET01BZ2VudC5oYXNFdmVudCgicHNldWRv RWxlbWVudEFkZGVkIikpCisgICAgICAgIC8vIEZJWE1FOiBUaGlzIHdvdWxkbid0IHdvcmsgZm9y IGRlYnVnZ2luZyBhbiBpT1MgOSBvciBlYXJsaWVyIEpTQ29udGV4dCB0YXJnZXQuCisgICAgICAg IGlmICh3aW5kb3cuRE9NQWdlbnQgJiYgIURPTUFnZW50Lmhhc0V2ZW50KCJwc2V1ZG9FbGVtZW50 QWRkZWQiKSkKICAgICAgICAgICAgIHJldHVybiBub2RlLmJvZHkucmFuZ2VbMF07CiAKICAgICAg ICAgLy8gImYiIGluICJmdW5jdGlvbiIuICJzIiBpbiAic2V0Ii4gImciIGluICJnZXQiLiBGaXJz dCBsZXR0ZXIgaW4gYW55IG1ldGhvZCBuYW1lIGZvciBjbGFzc2VzIGFuZCBvYmplY3QgbGl0ZXJh bHMuCg==