182058 2018-01-24 12:58:40 -0800 Web Inspector: Remove duplicate preference update for WebAuthentication value 2018-01-24 14:10:02 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue inspector-bugzilla-changes jiewen_tan joepeck sam webkit-bug-importer oldest_to_newest 1392694 0 joepeck 2018-01-24 12:58:40 -0800 Remove duplicate preference update for WebAuthentication value WebPage::updatePreferences has an explicit update to the WebAuthentication setting, but this is already handled by the generated preferences code from the yaml earlier. 1392696 1 332189 joepeck 2018-01-24 12:59:54 -0800 Created attachment 332189 [PATCH] Proposed Fix The generated line is identical: DerivedSources/WebKit2/WebPageUpdatePreferences.cpp 305: WebCore::RuntimeEnabledFeatures::sharedFeatures().setWebAuthenticationEnabled(store.getBoolValueForKey(WebPreferencesKey::webAuthenticationEnabledKey())); 1392714 2 332189 bburg 2018-01-24 13:33:39 -0800 Comment on attachment 332189 [PATCH] Proposed Fix rs=me 1392731 3 332189 commit-queue 2018-01-24 13:58:38 -0800 Comment on attachment 332189 [PATCH] Proposed Fix Clearing flags on attachment: 332189 Committed r227564: <https://trac.webkit.org/changeset/227564> 1392732 4 commit-queue 2018-01-24 13:58:39 -0800 All reviewed patches have been landed. Closing bug. 1392734 5 webkit-bug-importer 2018-01-24 13:59:28 -0800 <rdar://problem/36838394> 1392747 6 jiewen_tan 2018-01-24 14:10:02 -0800 (In reply to Joseph Pecoraro from comment #0) > Remove duplicate preference update for WebAuthentication value > > WebPage::updatePreferences has an explicit update to the WebAuthentication > setting, but this is already handled by the generated preferences code from > the yaml earlier. Oops. Thanks for fixing this. I was not aware that yaml also does this for me. 332189 2018-01-24 12:59:54 -0800 2018-01-24 13:58:38 -0800 [PATCH] Proposed Fix duplicate-1.patch text/plain 1508 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMTAwOGM4NjEzYjYuLmExNDE4ZTlkNGIwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDE4LTAxLTI0ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3ZlIGR1cGxpY2F0ZSBwcmVmZXJlbmNlIHVw ZGF0ZSBmb3IgV2ViQXV0aGVudGljYXRpb24gdmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjA1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjp1cGRhdGVQcmVmZXJlbmNlcyk6CisgICAgICAg IEFuIGlkZW50aWNhbCB1cGRhdGUgYWxyZWFkeSBoYXBwZW5zIGluIGdlbmVyYXRlZCBjb2RlLgor CiAyMDE4LTAxLTI0ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmVtb3ZlIHVudXNlZCBRVEtpdCBwcmVmZXJlbmNlCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCmluZGV4IGY5ZmQwZmI3MjQwLi4wOTNh MDE3M2FkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5j cHAKQEAgLTMwNzksOCArMzA3OSw2IEBAIHZvaWQgV2ViUGFnZTo6dXBkYXRlUHJlZmVyZW5jZXMo Y29uc3QgV2ViUHJlZmVyZW5jZXNTdG9yZSYgc3RvcmUpCiAgICAgc2V0dGluZ3Muc2V0RGF0YURl dGVjdG9yVHlwZXMoc3RhdGljX2Nhc3Q8RGF0YURldGVjdG9yVHlwZXM+KHN0b3JlLmdldFVJbnQz MlZhbHVlRm9yS2V5KFdlYlByZWZlcmVuY2VzS2V5OjpkYXRhRGV0ZWN0b3JUeXBlc0tleSgpKSkp OwogI2VuZGlmCiAKLSAgICBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzaGFyZWRGZWF0dXJlcygp LnNldFdlYkF1dGhlbnRpY2F0aW9uRW5hYmxlZChzdG9yZS5nZXRCb29sVmFsdWVGb3JLZXkoV2Vi UHJlZmVyZW5jZXNLZXk6OndlYkF1dGhlbnRpY2F0aW9uRW5hYmxlZEtleSgpKSk7Ci0KICAgICBE YXRhYmFzZU1hbmFnZXI6OnNpbmdsZXRvbigpLnNldElzQXZhaWxhYmxlKHN0b3JlLmdldEJvb2xW YWx1ZUZvcktleShXZWJQcmVmZXJlbmNlc0tleTo6ZGF0YWJhc2VzRW5hYmxlZEtleSgpKSk7CiAK ICAgICBtX3RhYlRvTGlua3MgPSBzdG9yZS5nZXRCb29sVmFsdWVGb3JLZXkoV2ViUHJlZmVyZW5j ZXNLZXk6OnRhYnNUb0xpbmtzS2V5KCkpOwo=