182055 2018-01-24 11:17:16 -0800 Fix race-condition in fast/text/click-ellipsis-assertion-failure.html 2018-01-24 14:29:08 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=182062 InRadar P2 Normal --- 1 jbedard jbedard ap commit-queue jlewis3 lforschler megan_gardner ryanhaddad simon.fraser webkit-bug-importer oldest_to_newest 1392641 0 jbedard 2018-01-24 11:17:16 -0800 fast/text/click-ellipsis-assertion-failure.html should wait for it's promise to be fulfilled before finishing the test. If it does not, the subsequent test may crash. 1392644 1 jbedard 2018-01-24 11:17:40 -0800 <rdar://problem/36830203> 1392645 2 332181 jbedard 2018-01-24 11:19:46 -0800 Created attachment 332181 Patch 1392646 3 jbedard 2018-01-24 11:23:01 -0800 I very much doubt that this is the only test suffering from this problem. However, I think we should take these one-at-a-time. This specific bug will look like a flakey crash occurring on the test immediately after the test with the bug. Thankfully, the crashlog of the subsequent test will specifically call out the test with the race condition. 1392727 4 megan_gardner 2018-01-24 13:57:36 -0800 Can we make sure to file a bug about the other tests? There's been a lot more async code in our tests in the last few months, while it makes the tests more readable, I think it will make these races a lot more common, and we should try and keep a handle on it. 1392745 5 jbedard 2018-01-24 14:07:55 -0800 (In reply to Megan Gardner from comment #4) > Can we make sure to file a bug about the other tests? There's been a lot > more async code in our tests in the last few months, while it makes the > tests more readable, I think it will make these races a lot more common, and > we should try and keep a handle on it. I've filed <https://bugs.webkit.org/show_bug.cgi?id=182062>. Ryan and I are working on repaying technical debt in iOS layout tests, this is one class of failures we will be looking for. 1392760 6 332181 commit-queue 2018-01-24 14:25:08 -0800 Comment on attachment 332181 Patch Clearing flags on attachment: 332181 Committed r227571: <https://trac.webkit.org/changeset/227571> 1392761 7 commit-queue 2018-01-24 14:25:10 -0800 All reviewed patches have been landed. Closing bug. 1392767 8 webkit-bug-importer 2018-01-24 14:29:08 -0800 <rdar://problem/36839587> 332181 2018-01-24 11:19:46 -0800 2018-01-24 14:25:08 -0800 Patch bug-182055-20180124111945.patch text/plain 1315 jbedard SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIyNzUzMikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE4LTAxLTI0ICBKb25hdGhhbiBCZWRhcmQg IDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggcmFjZS1jb25kaXRpb24gaW4gZmFz dC90ZXh0L2NsaWNrLWVsbGlwc2lzLWFzc2VydGlvbi1mYWlsdXJlLmh0bWwKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjA1NQorICAgICAgICA8cmRh cjovL3Byb2JsZW0vMzY4MzAyMDM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBmYXN0L3RleHQvY2xpY2stZWxsaXBzaXMtYXNzZXJ0aW9uLWZhaWx1 cmUuaHRtbDogV2FpdCBmb3IgcHJvbWlzZSBiZWZvcmUgZW5kaW5nIHRlc3QuCisKIDIwMTgtMDEt MjQgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEZldGNoIHJl c3BvbnNlIHNob3VsZCBjb3B5IGl0cyB1cmwgZnJvbSB0aGUgcmVxdWVzdCBpZiBudWxsCkluZGV4 OiBMYXlvdXRUZXN0cy9mYXN0L3RleHQvY2xpY2stZWxsaXBzaXMtYXNzZXJ0aW9uLWZhaWx1cmUu aHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3RleHQvY2xpY2stZWxsaXBzaXMt YXNzZXJ0aW9uLWZhaWx1cmUuaHRtbAkocmV2aXNpb24gMjI3NTMyKQorKysgTGF5b3V0VGVzdHMv ZmFzdC90ZXh0L2NsaWNrLWVsbGlwc2lzLWFzc2VydGlvbi1mYWlsdXJlLmh0bWwJKHdvcmtpbmcg Y29weSkKQEAgLTIyLDcgKzIyLDcgQEAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CiAgICAgdGVz dFJ1bm5lci5kdW1wQXNUZXh0KCk7CiAKICAgICB2YXIgZWxsaXBzaXplZFRleHQgPSBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgiZWxsaXBzaXplZFRleHQiKTsKLSAgICBVSUhlbHBlci5hY3RpdmF0 ZUF0KGVsbGlwc2l6ZWRUZXh0Lm9mZnNldExlZnQsIGVsbGlwc2l6ZWRUZXh0Lm9mZnNldFRvcCk7 CisgICAgVUlIZWxwZXIud2FpdChVSUhlbHBlci5hY3RpdmF0ZUF0KGVsbGlwc2l6ZWRUZXh0Lm9m ZnNldExlZnQsIGVsbGlwc2l6ZWRUZXh0Lm9mZnNldFRvcCkpOwogfQogPC9zY3JpcHQ+CiA8L2Jv ZHk+Cg==