182052 2018-01-24 08:58:21 -0800 REGRESSION (r227430): ASSERTION FAILED: !self.zoomToScaleCompletionHandler in TestRunnerWKWebView::zoomToScale 2018-01-24 13:59:29 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=181741 InRadar P2 Normal --- 1 ajuma ajuma ap commit-queue simon.fraser webkit-bug-importer oldest_to_newest 1392588 0 ajuma 2018-01-24 08:58:21 -0800 This regressed with https://trac.webkit.org/changeset/227430. This is happening on the iOS Simulator Debug WK2 bot, on fast/visual-viewport/viewport-dimensions.html (but only when running multiple tests together, e.g. all of fast/visual-viewport, rather than just the one test): ASSERTION FAILED: !self.zoomToScaleCompletionHandler /Volumes/Data/slave/ios-simulator-11-debug/build/Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm(129) : -[TestRunnerWKWebView zoomToScale:animated:completionHandler:] 1 0x10c01fd6d WTFCrash 2 0x10a7789f1 -[TestRunnerWKWebView zoomToScale:animated:completionHandler:] 3 0x10a781b90 WTR::UIScriptController::zoomToScale(double, OpaqueJSValue const*) 4 0x10a739221 WTR::JSUIScriptController::zoomToScale(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) 5 0x10b0e7327 long long JSC::APICallbackFunction::call<JSC::JSCallbackFunction>(JSC::ExecState*) 6 0x7e38d9c4034 7 0x10b0636e1 llint_entry 8 0x10b0636e1 llint_entry 9 0x10b05b5f2 vmEntryToJavaScript 10 0x10b9e9c6e JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) 11 0x10b98f0cd JSC::Interpreter::executeProgram(JSC::SourceCode const&, JSC::ExecState*, JSC::JSObject*) 12 0x10bc42427 JSC::evaluate(JSC::ExecState*, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&) 13 0x10bc425b0 JSC::profiledEvaluate(JSC::ExecState*, JSC::ProfilingReason, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&) 14 0x10b0e5fa3 JSEvaluateScript 15 0x10a779fb4 WTR::UIScriptContext::runUIScript(WTF::String const&, unsigned int) 16 0x10a7755a9 WTR::TestInvocation::runUISideScript(OpaqueWKString const*, unsigned int) 17 0x10a7729f0 WTR::TestInvocation::runUISideScriptAfterUpdateCallback(OpaqueWKError const*, void*) 18 0x1153d9937 WKPageCallAfterNextPresentationUpdate::$_6::operator()(WebKit::CallbackBase::Error) const 19 0x1153d989a WTF::Function<void (WebKit::CallbackBase::Error)>::CallableWrapper<WKPageCallAfterNextPresentationUpdate::$_6>::call(WebKit::CallbackBase::Error) 20 0x114607b81 WTF::Function<void (WebKit::CallbackBase::Error)>::operator()(WebKit::CallbackBase::Error) const 21 0x114a8b2ba WebKit::GenericCallback<>::performCallbackWithReturnValue() 22 0x114a82b75 WebKit::GenericCallback<>::performCallback() 23 0x114a81dc2 WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree(WebKit::RemoteLayerTreeTransaction const&, WebKit::RemoteScrollingCoordinatorTransaction const&) 24 0x114a8dce0 void IPC::callMemberFunctionImpl<WebKit::RemoteLayerTreeDrawingAreaProxy, void (WebKit::RemoteLayerTreeDrawingAreaProxy::*)(WebKit::RemoteLayerTreeTransaction const&, WebKit::RemoteScrollingCoordinatorTransaction const&), std::__1::tuple<WebKit::RemoteLayerTreeTransaction, WebKit::RemoteScrollingCoordinatorTransaction>, 0ul, 1ul>(WebKit::RemoteLayerTreeDrawingAreaProxy*, void (WebKit::RemoteLayerTreeDrawingAreaProxy::*)(WebKit::RemoteLayerTreeTransaction const&, WebKit::RemoteScrollingCoordinatorTransaction const&), std::__1::tuple<WebKit::RemoteLayerTreeTransaction, WebKit::RemoteScrollingCoordinatorTransaction>&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul>) 25 0x114a8d9f0 void IPC::callMemberFunction<WebKit::RemoteLayerTreeDrawingAreaProxy, void (WebKit::RemoteLayerTreeDrawingAreaProxy::*)(WebKit::RemoteLayerTreeTransaction const&, WebKit::RemoteScrollingCoordinatorTransaction const&), std::__1::tuple<WebKit::RemoteLayerTreeTransaction, WebKit::RemoteScrollingCoordinatorTransaction>, std::__1::integer_sequence<unsigned long, 0ul, 1ul> >(std::__1::tuple<WebKit::RemoteLayerTreeTransaction, WebKit::RemoteScrollingCoordinatorTransaction>&&, WebKit::RemoteLayerTreeDrawingAreaProxy*, void (WebKit::RemoteLayerTreeDrawingAreaProxy::*)(WebKit::RemoteLayerTreeTransaction const&, WebKit::RemoteScrollingCoordinatorTransaction const&)) 26 0x114a8d7fe void IPC::handleMessage<Messages::RemoteLayerTreeDrawingAreaProxy::CommitLayerTree, WebKit::RemoteLayerTreeDrawingAreaProxy, void (WebKit::RemoteLayerTreeDrawingAreaProxy::*)(WebKit::RemoteLayerTreeTransaction const&, WebKit::RemoteScrollingCoordinatorTransaction const&)>(IPC::Decoder&, WebKit::RemoteLayerTreeDrawingAreaProxy*, void (WebKit::RemoteLayerTreeDrawingAreaProxy::*)(WebKit::RemoteLayerTreeTransaction const&, WebKit::RemoteScrollingCoordinatorTransaction const&)) 27 0x114a8d594 WebKit::RemoteLayerTreeDrawingAreaProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 28 0x114809c28 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) 29 0x1146fa5b4 WebKit::ChildProcessProxy::dispatchMessage(IPC::Connection&, IPC::Decoder&) 30 0x1151859ba WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 31 0x115185ab4 non-virtual thunk to WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Debug%20WK2%20(Tests)/r227482%20(2286)/fast/visual-viewport/viewport-dimensions-stderr.txt 1392589 1 ajuma 2018-01-24 08:59:47 -0800 It looks like we need to change [TestRunnerWKWebView zoomToScale:animated] so that it doesn't set self.zoomToScaleCompletionHandler when it's going to immediately call that completion handler. I'll upload a patch. 1392591 2 332170 ajuma 2018-01-24 09:03:42 -0800 Created attachment 332170 Patch 1392631 3 332178 ajuma 2018-01-24 10:41:24 -0800 Created attachment 332178 Patch Uploading again to re-trigger the mac-debug EWS bot 1392729 4 332178 commit-queue 2018-01-24 13:58:11 -0800 Comment on attachment 332178 Patch Clearing flags on attachment: 332178 Committed r227563: <https://trac.webkit.org/changeset/227563> 1392730 5 commit-queue 2018-01-24 13:58:12 -0800 All reviewed patches have been landed. Closing bug. 1392735 6 webkit-bug-importer 2018-01-24 13:59:29 -0800 <rdar://problem/36838395> 332170 2018-01-24 09:03:42 -0800 2018-01-24 10:41:22 -0800 Patch bug-182052-20180124120341.patch text/plain 1906 ajuma U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3NTIwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzRhNDE1NjYzYmQ3NjMwOTRiY2YxOWFjOGU2ZTk3NmNl ZmZkNDFiNS4uMGUzYzQ2M2NhNjQ3NjYxZTcyNTZiNTdhMGUwZmM3MDkxZGQ5NTk3MiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE4LTAxLTI0ICBBbGkgSnVtYSAgPGFqdW1hQGNocm9taXVtLm9yZz4KKworICAgICAg ICBSRUdSRVNTSU9OIChyMjI3NDMwKTogQVNTRVJUSU9OIEZBSUxFRDogIXNlbGYuem9vbVRvU2Nh bGVDb21wbGV0aW9uSGFuZGxlciBpbiBUZXN0UnVubmVyV0tXZWJWaWV3Ojp6b29tVG9TY2FsZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyMDUyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG9uJ3Qgc2V0 IHpvb21Ub1NjYWxlQ29tcGxldGlvbkhhbmRsZXIgaW4gem9vbVRvU2NhbGU6YW5pbWF0ZWQgd2hl biBjYWxsaW5nIHRoZSBjb21wbGV0aW9uIGhhbmRsZXIKKyAgICAgICAgaW1tZWRpYXRlbHkuCisK KyAgICAgICAgVGVzdDogZmFzdC92aXN1YWwtdmlld3BvcnQvdmlld3BvcnQtZGltZW5zaW9ucy5o dG1sCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL2NvY29hL1Rlc3RSdW5uZXJXS1dlYlZp ZXcubW06CisgICAgICAgICgtW1Rlc3RSdW5uZXJXS1dlYlZpZXcgem9vbVRvU2NhbGU6YW5pbWF0 ZWQ6Y29tcGxldGlvbkhhbmRsZXI6XSk6CisKIDIwMTgtMDEtMTggIFNlcmdpbyBWaWxsYXIgU2Vu aW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAgICAgICAgW1dlYlZSXSBBZGQgT3BlblZSIHRv IHRoZSB0cmVlIGFuZCB0byB0aGUgYnVpbGQKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RS dW5uZXIvY29jb2EvVGVzdFJ1bm5lcldLV2ViVmlldy5tbSBiL1Rvb2xzL1dlYktpdFRlc3RSdW5u ZXIvY29jb2EvVGVzdFJ1bm5lcldLV2ViVmlldy5tbQppbmRleCBjMWExMjkzMmU1M2U1NGIzNjZi MzQ3ZDI1OTJlZDgzYWU4NTQzOGU2Li5jNmNkNGVkYjk1NDhhMzQzZjIzYmE4YjY4NzY0MjRiMjdh MTkwNjU4IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2NvY29hL1Rlc3RSdW5u ZXJXS1dlYlZpZXcubW0KKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9jb2NvYS9UZXN0UnVu bmVyV0tXZWJWaWV3Lm1tCkBAIC0xMjcsNyArMTI3LDYgQEAgLSAodm9pZClfZGlkRGlzbWlzc0Zv cmNlUHJlc3NQcmV2aWV3CiAtICh2b2lkKXpvb21Ub1NjYWxlOihkb3VibGUpc2NhbGUgYW5pbWF0 ZWQ6KEJPT0wpYW5pbWF0ZWQgY29tcGxldGlvbkhhbmRsZXI6KHZvaWQgKF4pKHZvaWQpKWNvbXBs ZXRpb25IYW5kbGVyCiB7CiAgICAgQVNTRVJUKCFzZWxmLnpvb21Ub1NjYWxlQ29tcGxldGlvbkhh bmRsZXIpOwotICAgIHNlbGYuem9vbVRvU2NhbGVDb21wbGV0aW9uSGFuZGxlciA9IGNvbXBsZXRp b25IYW5kbGVyOwogCiAgICAgaWYgKHNlbGYuc2Nyb2xsVmlldy56b29tU2NhbGUgPT0gc2NhbGUp IHsKICAgICAgICAgZGlzcGF0Y2hfYXN5bmMoZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUoKSwgXnsK QEAgLTEzNiw2ICsxMzUsNyBAQCAtICh2b2lkKXpvb21Ub1NjYWxlOihkb3VibGUpc2NhbGUgYW5p bWF0ZWQ6KEJPT0wpYW5pbWF0ZWQgY29tcGxldGlvbkhhbmRsZXI6KHZvaQogICAgICAgICByZXR1 cm47CiAgICAgfQogCisgICAgc2VsZi56b29tVG9TY2FsZUNvbXBsZXRpb25IYW5kbGVyID0gY29t cGxldGlvbkhhbmRsZXI7CiAgICAgW3NlbGYuc2Nyb2xsVmlldyBzZXRab29tU2NhbGU6c2NhbGUg YW5pbWF0ZWQ6YW5pbWF0ZWRdOwogfQogCg== 332178 2018-01-24 10:41:24 -0800 2018-01-24 13:58:11 -0800 Patch bug-182052-20180124134123.patch text/plain 1906 ajuma U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3NTIwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzRhNDE1NjYzYmQ3NjMwOTRiY2YxOWFjOGU2ZTk3NmNl ZmZkNDFiNS4uMGUzYzQ2M2NhNjQ3NjYxZTcyNTZiNTdhMGUwZmM3MDkxZGQ5NTk3MiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE4LTAxLTI0ICBBbGkgSnVtYSAgPGFqdW1hQGNocm9taXVtLm9yZz4KKworICAgICAg ICBSRUdSRVNTSU9OIChyMjI3NDMwKTogQVNTRVJUSU9OIEZBSUxFRDogIXNlbGYuem9vbVRvU2Nh bGVDb21wbGV0aW9uSGFuZGxlciBpbiBUZXN0UnVubmVyV0tXZWJWaWV3Ojp6b29tVG9TY2FsZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyMDUyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG9uJ3Qgc2V0 IHpvb21Ub1NjYWxlQ29tcGxldGlvbkhhbmRsZXIgaW4gem9vbVRvU2NhbGU6YW5pbWF0ZWQgd2hl biBjYWxsaW5nIHRoZSBjb21wbGV0aW9uIGhhbmRsZXIKKyAgICAgICAgaW1tZWRpYXRlbHkuCisK KyAgICAgICAgVGVzdDogZmFzdC92aXN1YWwtdmlld3BvcnQvdmlld3BvcnQtZGltZW5zaW9ucy5o dG1sCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL2NvY29hL1Rlc3RSdW5uZXJXS1dlYlZp ZXcubW06CisgICAgICAgICgtW1Rlc3RSdW5uZXJXS1dlYlZpZXcgem9vbVRvU2NhbGU6YW5pbWF0 ZWQ6Y29tcGxldGlvbkhhbmRsZXI6XSk6CisKIDIwMTgtMDEtMTggIFNlcmdpbyBWaWxsYXIgU2Vu aW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAgICAgICAgW1dlYlZSXSBBZGQgT3BlblZSIHRv IHRoZSB0cmVlIGFuZCB0byB0aGUgYnVpbGQKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RS dW5uZXIvY29jb2EvVGVzdFJ1bm5lcldLV2ViVmlldy5tbSBiL1Rvb2xzL1dlYktpdFRlc3RSdW5u ZXIvY29jb2EvVGVzdFJ1bm5lcldLV2ViVmlldy5tbQppbmRleCBjMWExMjkzMmU1M2U1NGIzNjZi MzQ3ZDI1OTJlZDgzYWU4NTQzOGU2Li5jNmNkNGVkYjk1NDhhMzQzZjIzYmE4YjY4NzY0MjRiMjdh MTkwNjU4IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2NvY29hL1Rlc3RSdW5u ZXJXS1dlYlZpZXcubW0KKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9jb2NvYS9UZXN0UnVu bmVyV0tXZWJWaWV3Lm1tCkBAIC0xMjcsNyArMTI3LDYgQEAgLSAodm9pZClfZGlkRGlzbWlzc0Zv cmNlUHJlc3NQcmV2aWV3CiAtICh2b2lkKXpvb21Ub1NjYWxlOihkb3VibGUpc2NhbGUgYW5pbWF0 ZWQ6KEJPT0wpYW5pbWF0ZWQgY29tcGxldGlvbkhhbmRsZXI6KHZvaWQgKF4pKHZvaWQpKWNvbXBs ZXRpb25IYW5kbGVyCiB7CiAgICAgQVNTRVJUKCFzZWxmLnpvb21Ub1NjYWxlQ29tcGxldGlvbkhh bmRsZXIpOwotICAgIHNlbGYuem9vbVRvU2NhbGVDb21wbGV0aW9uSGFuZGxlciA9IGNvbXBsZXRp b25IYW5kbGVyOwogCiAgICAgaWYgKHNlbGYuc2Nyb2xsVmlldy56b29tU2NhbGUgPT0gc2NhbGUp IHsKICAgICAgICAgZGlzcGF0Y2hfYXN5bmMoZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUoKSwgXnsK QEAgLTEzNiw2ICsxMzUsNyBAQCAtICh2b2lkKXpvb21Ub1NjYWxlOihkb3VibGUpc2NhbGUgYW5p bWF0ZWQ6KEJPT0wpYW5pbWF0ZWQgY29tcGxldGlvbkhhbmRsZXI6KHZvaQogICAgICAgICByZXR1 cm47CiAgICAgfQogCisgICAgc2VsZi56b29tVG9TY2FsZUNvbXBsZXRpb25IYW5kbGVyID0gY29t cGxldGlvbkhhbmRsZXI7CiAgICAgW3NlbGYuc2Nyb2xsVmlldyBzZXRab29tU2NhbGU6c2NhbGUg YW5pbWF0ZWQ6YW5pbWF0ZWRdOwogfQogCg==