182048 2018-01-24 07:43:27 -0800 Fetch response should copy its url from the request if null 2018-01-25 13:43:29 -0800 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen beidson cdumez commit-queue dbates ews-watchlist japhet ryanhaddad webkit-bug-importer oldest_to_newest 1392561 0 youennf 2018-01-24 07:43:27 -0800 As per fetch spec, fetch response should copy the request url list if its own is empty. In WebKit terms, it means that the response.url() should be copied from request if null. This is done for network loads but not always for service worker loads. 1392562 1 youennf 2018-01-24 07:46:02 -0800 <rdar://problem/36781554> 1392563 2 332163 youennf 2018-01-24 07:46:35 -0800 Created attachment 332163 Patch 1392623 3 332163 commit-queue 2018-01-24 10:10:34 -0800 Comment on attachment 332163 Patch Clearing flags on attachment: 332163 Committed r227531: <https://trac.webkit.org/changeset/227531> 1392624 4 commit-queue 2018-01-24 10:10:35 -0800 All reviewed patches have been landed. Closing bug. 1392864 5 ryanhaddad 2018-01-24 17:50:37 -0800 API test WebKit.PreventImageLoadWithAutoResizingTest is failing the assertion added in this change on macOS bots. TIMEOUT WebKit.PreventImageLoadWithAutoResizingTest ASSERTION FAILED: !response.url().isNull() /Volumes/Data/slave/highsierra-debug/build/Source/WebCore/loader/DocumentLoader.cpp(754) : void WebCore::DocumentLoader::responseReceived(const WebCore::ResourceResponse &) 1 0x1221773fd WTFCrash 2 0x113f19452 WebCore::DocumentLoader::responseReceived(WebCore::ResourceResponse const&) 3 0x113f15528 WebCore::DocumentLoader::handleSubstituteDataLoadNow() 4 0x113f3a466 WTF::RunLoopTimer<WebCore::DocumentLoader>::fired() 5 0x1221d9b51 WTF::timerFired(__CFRunLoopTimer*, void*) 6 0x7fff2853c0a4 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ 7 0x7fff2853bd24 __CFRunLoopDoTimer 8 0x7fff2853b81a __CFRunLoopDoTimers 9 0x7fff28532feb __CFRunLoopRun 10 0x7fff285323d7 CFRunLoopRunSpecific 11 0x7fff2783fe26 RunCurrentEventLoopInMode 12 0x7fff2783fb96 ReceiveNextEventCommon 13 0x7fff2783f914 _BlockUntilNextEventMatchingListInModeWithFilter 14 0x7fff25b0af5f _DPSNextEvent 15 0x7fff262a0b4c -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] 16 0x7fff25affd6d -[NSApplication run] 17 0x7fff25acef1a NSApplicationMain 18 0x7fff501a542f _xpc_objc_main 19 0x7fff501a4082 xpc_main 20 0x10bf3c12b main 21 0x7fff4fed8115 start https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK1%20%28Tests%29/builds/2026 1392865 6 youennf 2018-01-24 17:53:26 -0800 Will look at the failure tomorrow 1393251 7 youennf 2018-01-25 13:43:29 -0800 (In reply to youenn fablet from comment #6) > Will look at the failure tomorrow Patch at https://bugs.webkit.org/show_bug.cgi?id=182112 332163 2018-01-24 07:46:35 -0800 2018-01-24 10:10:34 -0800 Patch bug-182048-20180124074635.patch text/plain 5937 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3NDU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2QzMmM0ZTYzYjI3OTdj ZjY1YTYxZDIxMmI3MzBhNzhkYTFjNDNiNi4uMmEwMGNmNzhjNGQyYzVkMTJmNmQxNzgyYmE2OGRh OTUyM2M1MTM3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTAxLTI0ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBGZXRjaCByZXNwb25zZSBz aG91bGQgY29weSBpdHMgdXJsIGZyb20gdGhlIHJlcXVlc3QgaWYgbnVsbAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyMDQ4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gY2hhbmdlIG9mIGJlaGF2aW9y LgorCisgICAgICAgICogbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkRvY3VtZW50TG9hZGVyOjpyZXNwb25zZVJlY2VpdmVkKTogQWRkIGFzc2VydGlvbiB0byBj aGVjayB0aGF0IHRoZSByZXNwb25zZSBVUkwgaXMgbm90IG51bGwuCisKIDIwMTgtMDEtMjMgIEVy aWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVzaWduIE5v d1BsYXlpbmcgc3RhdHVzIHdoZW4gbm8gbWVkaWEgZWxlbWVudCBpcyBlbGlnaWJsZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpp bmRleCBmMzkzODkwYjgzYTc0NTAzZWFiMmU0NjkwYjhiZmUzYmY5ZWNkMDMxLi45MzEzZGZjNTJk NzVmYTViZTdhMDU0YmUyMzE5ZmNkOWFiZDcyOWQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBA CisyMDE4LTAxLTI0ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAg ICBGZXRjaCByZXNwb25zZSBzaG91bGQgY29weSBpdHMgdXJsIGZyb20gdGhlIHJlcXVlc3QgaWYg bnVsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgy MDQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBX ZWJQcm9jZXNzL1N0b3JhZ2UvU2VydmljZVdvcmtlckNsaWVudEZldGNoLmNwcDoKKyAgICAgICAg KFdlYktpdDo6U2VydmljZVdvcmtlckNsaWVudEZldGNoOjpkaWRSZWNlaXZlUmVzcG9uc2UpOgor CiAyMDE4LTAxLTIzICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAg ICAgICAgIFJlc2lnbiBOb3dQbGF5aW5nIHN0YXR1cyB3aGVuIG5vIG1lZGlhIGVsZW1lbnQgaXMg ZWxpZ2libGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRl ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCmluZGV4IDE4 OWNkYTlkMmI4Y2M5Nzg1MTI3NmQyZDQ2NGU4MzUwM2I2NWIwYmIuLmQyMTliNWUyYWQ4YTIxMDQy ODlkMjAzNmY1YTk3M2Q3NjljNGY3NTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRl ci9Eb2N1bWVudExvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50 TG9hZGVyLmNwcApAQCAtNzUxLDYgKzc1MSw3IEBAIHZvaWQgRG9jdW1lbnRMb2FkZXI6OnJlc3Bv bnNlUmVjZWl2ZWQoY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgcmVzcG9uc2UpCiAgICAgfSBlbHNl IGlmIChyZXNwb25zZS5pc011bHRpcGFydCgpKQogICAgICAgICBtX2lzTG9hZGluZ011bHRpcGFy dENvbnRlbnQgPSB0cnVlOwogCisgICAgQVNTRVJUKCFyZXNwb25zZS51cmwoKS5pc051bGwoKSk7 CiAgICAgbV9yZXNwb25zZSA9IHJlc3BvbnNlOwogCiAgICAgaWYgKG1faWRlbnRpZmllckZvckxv YWRXaXRob3V0UmVzb3VyY2VMb2FkZXIpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2Vi UHJvY2Vzcy9TdG9yYWdlL1NlcnZpY2VXb3JrZXJDbGllbnRGZXRjaC5jcHAgYi9Tb3VyY2UvV2Vi S2l0L1dlYlByb2Nlc3MvU3RvcmFnZS9TZXJ2aWNlV29ya2VyQ2xpZW50RmV0Y2guY3BwCmluZGV4 IDExY2NiYTIxMWQ5MDU1Mjg1NjAzNWIwODk3ZjRiODVjMjc3YzdiMmIuLjUxYzg3OWEyMjhmZGNk MDVmMDA3MDFiMzAxZjQyMWI0NDhiYmQ5ODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2Vi UHJvY2Vzcy9TdG9yYWdlL1NlcnZpY2VXb3JrZXJDbGllbnRGZXRjaC5jcHAKKysrIGIvU291cmNl L1dlYktpdC9XZWJQcm9jZXNzL1N0b3JhZ2UvU2VydmljZVdvcmtlckNsaWVudEZldGNoLmNwcApA QCAtMTM2LDYgKzEzNiwxMCBAQCB2b2lkIFNlcnZpY2VXb3JrZXJDbGllbnRGZXRjaDo6ZGlkUmVj ZWl2ZVJlc3BvbnNlKFJlc291cmNlUmVzcG9uc2UmJiByZXNwb25zZSkKICAgICB9CiAgICAgcmVz cG9uc2Uuc2V0U291cmNlKFJlc291cmNlUmVzcG9uc2U6OlNvdXJjZTo6U2VydmljZVdvcmtlcik7 CiAKKyAgICAvLyBBcyBwZXIgaHR0cHM6Ly9mZXRjaC5zcGVjLndoYXR3Zy5vcmcvI21haW4tZmV0 Y2ggc3RlcCA5LCBjb3B5IHJlcXVlc3QncyB1cmwgbGlzdCBpbiByZXNwb25zZSdzIHVybCBsaXN0 IGlmIGVtcHR5LgorICAgIGlmIChyZXNwb25zZS51cmwoKS5pc051bGwoKSkKKyAgICAgICAgcmVz cG9uc2Uuc2V0VVJMKG1fbG9hZGVyLT5yZXF1ZXN0KCkudXJsKCkpOworCiAgICAgbV9sb2FkZXIt PmRpZFJlY2VpdmVSZXNwb25zZShyZXNwb25zZSk7CiAgICAgaWYgKGF1dG8gY2FsbGJhY2sgPSBX VEZNb3ZlKG1fY2FsbGJhY2spKQogICAgICAgICBjYWxsYmFjayhSZXN1bHQ6OlN1Y2NlZWRlZCk7 CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKaW5kZXggNGFmOWJlMDU5OWNkODY5OWNlYWIxMWZjM2FhMDFiZmJlZjc3M2IwNS4uZjI5MjVh ZTRiZWQyZmMzOWNkNThmNmNhMmIwNzBkZDNjYzllMmIyYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBA CisyMDE4LTAxLTI0ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAg ICBGZXRjaCByZXNwb25zZSBzaG91bGQgY29weSBpdHMgdXJsIGZyb20gdGhlIHJlcXVlc3QgaWYg bnVsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgy MDQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBo dHRwL3Rlc3RzL3dvcmtlcnMvc2VydmljZS9iYXNpYy1mZXRjaC5odHRwcy1leHBlY3RlZC50eHQ6 CisgICAgICAgICogaHR0cC90ZXN0cy93b3JrZXJzL3NlcnZpY2UvcmVzb3VyY2VzL2Jhc2ljLWZl dGNoLmpzOgorICAgICAgICAoYXN5bmMudGVzdCk6CisKIDIwMTgtMDEtMjMgIE1hdHQgTGV3aXMg IDxqbGV3aXMzQGFwcGxlLmNvbT4KIAogICAgICAgICBTa2lwcGVkIGZhc3QvZXZlbnRzL21lc3Nh Z2UtcG9ydC5odG1sIG9uIG1hY09TCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3Rz L3dvcmtlcnMvc2VydmljZS9iYXNpYy1mZXRjaC5odHRwcy1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL3dvcmtlcnMvc2VydmljZS9iYXNpYy1mZXRjaC5odHRwcy1leHBlY3Rl ZC50eHQKaW5kZXggNjhmMDU4NTllM2ZiZmU2YjVhODg3N2EyNGI4ODNiM2UzM2RlYWJlMy4uNTk3 NDkxNjZlMzllZTNmYThhZGFiMTk5ZjNmODBiMWQ0NGNjMzg2MyAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy93b3JrZXJzL3NlcnZpY2UvYmFzaWMtZmV0Y2guaHR0cHMtZXhwZWN0 ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd29ya2Vycy9zZXJ2aWNlL2Jhc2lj LWZldGNoLmh0dHBzLWV4cGVjdGVkLnR4dApAQCAtMSwxMiArMSwxNSBAQAogCit0ZXN0MSB1cmw6 IGh0dHBzOi8vMTI3LjAuMC4xOjg0NDMvd29ya2Vycy9zZXJ2aWNlL3Jlc291cmNlcy90ZXN0MQog dGVzdDEgc3RhdHVzIGNvZGU6IDIwMAogdGVzdDEgc3RhdHVzIHRleHQ6IEhlbGxvIGZyb20gc2Vy dmljZSB3b3JrZXIKIHRlc3QxIGhlYWRlciBIZWxsbzogV29ybGQKIHRlc3QxIHNvdXJjZTogU2Vy dmljZSB3b3JrZXIKK3Rlc3QyIHVybDogaHR0cHM6Ly8xMjcuMC4wLjE6ODQ0My93b3JrZXJzL3Nl cnZpY2UvcmVzb3VyY2VzL3Rlc3QyCiB0ZXN0MiBzdGF0dXMgY29kZTogNTAwCiB0ZXN0MiBzdGF0 dXMgdGV4dDogRXJyb3IgZnJvbSBzZXJ2aWNlIHdvcmtlcgogdGVzdDIgc291cmNlOiBTZXJ2aWNl IHdvcmtlcgogUEFTUzogdGVzdDMgZmV0Y2ggZmFpbGVkIGFzIGV4cGVjdGVkCit0ZXN0NCB1cmw6 IGh0dHBzOi8vMTI3LjAuMC4xOjg0NDMvd29ya2Vycy9zZXJ2aWNlL3Jlc291cmNlcy90ZXN0NAog dGVzdDQgc3RhdHVzIGNvZGU6IDQwNAogUEFTUzogdGVzdDUgZmV0Y2ggZmFpbGVkIGFzIGV4cGVj dGVkCiBQQVNTOiAvIGZldGNoIGZhaWxlZCBhcyBleHBlY3RlZApkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy93b3JrZXJzL3NlcnZpY2UvcmVzb3VyY2VzL2Jhc2ljLWZldGNoLmpz IGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy93b3JrZXJzL3NlcnZpY2UvcmVzb3VyY2VzL2Jhc2lj LWZldGNoLmpzCmluZGV4IDJmZjYwNDYxYTBlYjFlMjQ0NWE4MjU4ZGI2ODcwYzUzODQ5NWRjN2Eu LjFmZTEzZDBhYTg2N2M0ZmNiMTA1NDgxNDY3ZTM3MWY0OGYzMzQ4NGQgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL2h0dHAvdGVzdHMvd29ya2Vycy9zZXJ2aWNlL3Jlc291cmNlcy9iYXNpYy1mZXRj aC5qcworKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dvcmtlcnMvc2VydmljZS9yZXNvdXJj ZXMvYmFzaWMtZmV0Y2guanMKQEAgLTUsNiArNSw3IEBAIGFzeW5jIGZ1bmN0aW9uIHRlc3QoKQog ICAgICAgICB2YXIgZmV0Y2ggPSBmcmFtZS5jb250ZW50V2luZG93LmZldGNoOwogCiAgICAgICAg IHZhciByZXNwb25zZSA9IGF3YWl0IGZldGNoKCJ0ZXN0MSIpOworICAgICAgICBsb2coInRlc3Qx IHVybDogIiArIHJlc3BvbnNlLnVybCk7CiAgICAgICAgIGxvZygidGVzdDEgc3RhdHVzIGNvZGU6 ICIgKyByZXNwb25zZS5zdGF0dXMpOwogICAgICAgICBsb2coInRlc3QxIHN0YXR1cyB0ZXh0OiAi ICsgcmVzcG9uc2Uuc3RhdHVzVGV4dCk7CiAgICAgICAgIGxvZygidGVzdDEgaGVhZGVyIEhlbGxv OiAiICsgcmVzcG9uc2UuaGVhZGVycy5nZXQoImhlbGxvIikpOwpAQCAtMTMsNiArMTQsNyBAQCBh c3luYyBmdW5jdGlvbiB0ZXN0KCkKICAgICAgICAgICAgIGxvZygidGVzdDEgc291cmNlOiAiICsg aW50ZXJuYWxzLmZldGNoUmVzcG9uc2VTb3VyY2UocmVzcG9uc2UpKTsKIAogICAgICAgICB2YXIg cmVzcG9uc2UgPSBhd2FpdCBmZXRjaCgidGVzdDIiKTsKKyAgICAgICAgbG9nKCJ0ZXN0MiB1cmw6 ICIgKyByZXNwb25zZS51cmwpOwogICAgICAgICBsb2coInRlc3QyIHN0YXR1cyBjb2RlOiAiICsg cmVzcG9uc2Uuc3RhdHVzKTsKICAgICAgICAgbG9nKCJ0ZXN0MiBzdGF0dXMgdGV4dDogIiArIHJl c3BvbnNlLnN0YXR1c1RleHQpOwogCkBAIC0zMCw2ICszMiw3IEBAIGFzeW5jIGZ1bmN0aW9uIHRl c3QoKQogICAgICAgICB9CiAKICAgICAgICAgdmFyIHJlc3BvbnNlID0gYXdhaXQgZmV0Y2goInRl c3Q0Iik7CisgICAgICAgIGxvZygidGVzdDQgdXJsOiAiICsgcmVzcG9uc2UudXJsKTsKICAgICAg ICAgbG9nKCJ0ZXN0NCBzdGF0dXMgY29kZTogIiArIHJlc3BvbnNlLnN0YXR1cyk7CiAKICAgICAg ICAgdHJ5IHsK