182038 2018-01-23 22:55:22 -0800 REGRESSION(r227457): Release assert in updateLayout while destructing a media element 2018-01-25 11:27:40 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 181914 1 rniwa eric.carlson commit-queue eric.carlson jeremyj-wk jer.noble ryanhaddad simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1392446 0 rniwa 2018-01-23 22:55:22 -0800 I'm hitting the following assertion by running LayoutTests/media. Application Specific Information: CRASHING TEST: media/video-main-content-autoplay.html Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x00000006dd693ed4 WTFCrash + 36 (Assertions.cpp:272) 1 com.apple.JavaScriptCore 0x00000006dd693ee9 WTFCrashWithSecurityImplication + 9 2 com.apple.WebCore 0x00000006cee11026 WebCore::Document::updateLayout() + 246 (Document.cpp:1980) 3 com.apple.WebCore 0x00000006cfff9b26 WebCore::RenderView::hitTest(WebCore::HitTestRequest const&, WebCore::HitTestLocation const&, WebCore::HitTestResult&) + 54 (RenderView.cpp:143) 4 com.apple.WebCore 0x00000006cfff9ae4 WebCore::RenderView::hitTest(WebCore::HitTestRequest const&, WebCore::HitTestResult&) + 68 (RenderView.cpp:138) 5 com.apple.WebCore 0x00000006cf2730b9 WebCore::isMainContentForPurposesOfAutoplay(WebCore::HTMLMediaElement const&) + 617 (MediaElementSession.cpp:737) 6 com.apple.WebCore 0x00000006cf270d8b WebCore::MediaElementSession::updateIsMainContent() const + 43 (MediaElementSession.cpp:827) 7 com.apple.WebCore 0x00000006cf2704bc WebCore::MediaElementSession::playbackPermitted(WebCore::HTMLMediaElement const&) const + 412 (MediaElementSession.cpp:176) 8 com.apple.WebCore 0x00000006cf271928 WebCore::MediaElementSession::canShowControlsManager(WebCore::MediaElementSession::PlaybackControlsPurpose) const + 776 (MediaElementSession.cpp:343) 9 com.apple.WebCore 0x00000006cf1aa4c9 WebCore::mediaElementSessionInfoForSession(WebCore::MediaElementSession const&, WebCore::MediaElementSession::PlaybackControlsPurpose) + 89 (HTMLMediaElement.cpp:393) 10 com.apple.WebCore 0x00000006cf1aa273 WebCore::HTMLMediaElement::bestMediaElementForShowingPlaybackControlsManager(WebCore::MediaElementSession::PlaybackControlsPurpose) + 179 (HTMLMediaElement.cpp:691) 11 com.apple.WebCore 0x00000006cd6710d8 WebCore::MediaSessionManagerMac::nowPlayingEligibleSession() + 24 (MediaSessionManagerMac.mm:110) 12 com.apple.WebCore 0x00000006cd6701c8 WebCore::MediaSessionManagerMac::updateNowPlayingInfo() + 56 (MediaSessionManagerMac.mm:124) 13 com.apple.WebCore 0x00000006cd6710ac WebCore::MediaSessionManagerMac::clientCharacteristicsChanged(WebCore::PlatformMediaSession&) + 60 (MediaSessionManagerMac.mm:106) 14 com.apple.WebCore 0x00000006cf8eb1d4 WebCore::PlatformMediaSession::clientCharacteristicsChanged() + 52 (PlatformMediaSession.cpp:371) 15 com.apple.WebCore 0x00000006cf1ad20a WebCore::HTMLMediaElement::removedFromAncestor(WebCore::Node::RemovalType, WebCore::ContainerNode&) + 746 (HTMLMediaElement.cpp:977) 16 com.apple.WebCore 0x00000006cedcab4b WebCore::notifyNodeRemovedFromDocument(WebCore::ContainerNode&, WebCore::TreeScopeChange, WebCore::Node&) + 187 (ContainerNodeAlgorithms.cpp:116) 17 com.apple.WebCore 0x00000006cedcac18 WebCore::notifyNodeRemovedFromDocument(WebCore::ContainerNode&, WebCore::TreeScopeChange, WebCore::Node&) + 392 18 com.apple.WebCore 0x00000006cedcac18 WebCore::notifyNodeRemovedFromDocument(WebCore::ContainerNode&, WebCore::TreeScopeChange, WebCore::Node&) + 392 19 com.apple.WebCore 0x00000006cedcaa31 WebCore::notifyChildNodeRemoved(WebCore::ContainerNode&, WebCore::Node&) + 177 (ContainerNodeAlgorithms.cpp:161) 20 com.apple.WebCore 0x00000006cedcb0e5 WebCore::addChildNodesToDeletionQueue(WebCore::Node*&, WebCore::Node*&, WebCore::ContainerNode&) + 533 21 com.apple.WebCore 0x00000006cedc3c90 WebCore::removeDetachedChildrenInContainer(WebCore::ContainerNode&) + 48 (ContainerNodeAlgorithms.cpp:213) 22 com.apple.WebCore 0x00000006cedc3c22 WebCore::ContainerNode::removeDetachedChildren() + 114 (ContainerNode.cpp:232) 23 com.apple.WebCore 0x00000006cee0c161 WebCore::Document::removedLastRef() + 529 (Document.cpp:678) 24 com.apple.WebCore 0x00000006cef3daf7 WebCore::Node::removedLastRef() + 55 (Node.cpp:2480) 25 com.apple.WebCore 0x00000006cd09f9c3 WebCore::Node::deref() + 371 (Node.h:727) 26 com.apple.WebCore 0x00000006cef33e25 WebCore::Node::derefEventTarget() + 21 (Node.cpp:757) 27 com.apple.WebCore 0x00000006cd3d2d26 WebCore::EventTarget::deref() + 22 (EventTarget.h:64) 28 com.apple.WebCore 0x00000006cd3d2cff WTF::Ref<WebCore::EventTarget, WTF::DumbPtrTraits<WebCore::EventTarget> >::~Ref() + 47 (Ref.h:62) 29 com.apple.WebCore 0x00000006cd3c0985 WTF::Ref<WebCore::EventTarget, WTF::DumbPtrTraits<WebCore::EventTarget> >::~Ref() + 21 (Ref.h:62) 30 com.apple.WebCore 0x00000006cd87bd29 WebCore::JSDOMWrapper<WebCore::EventTarget>::~JSDOMWrapper() + 25 (JSDOMWrapper.h:79) 31 com.apple.WebCore 0x00000006cd87bd05 WebCore::JSEventTarget::~JSEventTarget() + 21 (JSEventTarget.h:30) 32 com.apple.WebCore 0x00000006cd879be5 WebCore::JSEventTarget::~JSEventTarget() + 21 (JSEventTarget.h:30) 33 com.apple.WebCore 0x00000006cd87683d WebCore::JSEventTarget::destroy(JSC::JSCell*) + 29 (JSEventTarget.cpp:203) 34 com.apple.JavaScriptCore 0x00000006dd234c2a JSC::JSDestructibleObjectDestroyFunc::operator()(JSC::VM&, JSC::JSCell*) const + 42 (JSDestructibleObjectHeapCellType.cpp:38) 35 com.apple.JavaScriptCore 0x00000006dd23c2a5 void JSC::MarkedBlock::Handle::specializedSweep<false, (JSC::MarkedBlock::Handle::EmptyMode)0, (JSC::MarkedBlock::Handle::SweepMode)0, (JSC::MarkedBlock::Handle::SweepDestructionMode)0, (JSC::MarkedBlock::Handle::ScribbleMode)0, (JSC::MarkedBlock::Handle::NewlyAllocatedMode)0, (JSC::MarkedBlock::Handle::MarksMode)0, JSC::JSDestructibleObjectDestroyFunc>(JSC::FreeList*, JSC::MarkedBlock::Handle::EmptyMode, JSC::MarkedBlock::Handle::SweepMode, JSC::MarkedBlock::Handle::SweepDestructionMode, JSC::MarkedBlock::Handle::ScribbleMode, JSC::MarkedBlock::Handle::NewlyAllocatedMode, JSC::MarkedBlock::Handle::MarksMode, JSC::JSDestructibleObjectDestroyFunc const&)::'lambda'(void*)::operator()(void*) const + 69 (MarkedBlockInlines.h:254) 36 com.apple.JavaScriptCore 0x00000006dd236d92 void JSC::MarkedBlock::Handle::specializedSweep<false, (JSC::MarkedBlock::Handle::EmptyMode)0, (JSC::MarkedBlock::Handle::SweepMode)0, (JSC::MarkedBlock::Handle::SweepDestructionMode)0, (JSC::MarkedBlock::Handle::ScribbleMode)0, (JSC::MarkedBlock::Handle::NewlyAllocatedMode)0, (JSC::MarkedBlock::Handle::MarksMode)0, JSC::JSDestructibleObjectDestroyFunc>(JSC::FreeList*, JSC::MarkedBlock::Handle::EmptyMode, JSC::MarkedBlock::Handle::SweepMode, JSC::MarkedBlock::Handle::SweepDestructionMode, JSC::MarkedBlock::Handle::ScribbleMode, JSC::MarkedBlock::Handle::NewlyAllocatedMode, JSC::MarkedBlock::Handle::MarksMode, JSC::JSDestructibleObjectDestroyFunc const&) + 706 (MarkedBlockInlines.h:286) 37 com.apple.JavaScriptCore 0x00000006dd234bc0 void JSC::MarkedBlock::Handle::finishSweepKnowingHeapCellType<JSC::JSDestructibleObjectDestroyFunc>(JSC::FreeList*, JSC::JSDestructibleObjectDestroyFunc const&) + 304 (MarkedBlockInlines.h:430) 38 com.apple.JavaScriptCore 0x00000006dd234a88 JSC::JSDestructibleObjectHeapCellType::finishSweep(JSC::MarkedBlock::Handle&, JSC::FreeList*) + 40 (JSDestructibleObjectHeapCellType.cpp:53) 39 com.apple.JavaScriptCore 0x00000006dcdf3326 JSC::Subspace::finishSweep(JSC::MarkedBlock::Handle&, JSC::FreeList*) + 70 (Subspace.cpp:66) 40 com.apple.JavaScriptCore 0x00000006dcdd0585 JSC::MarkedBlock::Handle::sweep(JSC::FreeList*) + 581 (MarkedBlock.cpp:411) 41 com.apple.JavaScriptCore 0x00000006dcdbb8d7 JSC::IncrementalSweeper::sweepNextBlock() + 183 (IncrementalSweeper.cpp:91) 42 com.apple.JavaScriptCore 0x00000006dcdbb782 JSC::IncrementalSweeper::doSweep(WTF::MonotonicTime) + 34 (IncrementalSweeper.cpp:60) 43 com.apple.JavaScriptCore 0x00000006dcdbb74c JSC::IncrementalSweeper::doWork() + 44 (IncrementalSweeper.cpp:56) 44 com.apple.JavaScriptCore 0x00000006dd2c8eae JSC::JSRunLoopTimer::timerDidFire() + 174 (JSRunLoopTimer.cpp:65) 45 com.apple.JavaScriptCore 0x00000006dd2c933c JSC::JSRunLoopTimer::timerDidFireCallback(__CFRunLoopTimer*, void*) + 28 (JSRunLoopTimer.cpp:105) 46 com.apple.CoreFoundation 0x00007fff3f56fdd4 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20 47 com.apple.CoreFoundation 0x00007fff3f56fa47 __CFRunLoopDoTimer + 1095 48 com.apple.CoreFoundation 0x00007fff3f56f54a __CFRunLoopDoTimers + 346 49 com.apple.CoreFoundation 0x00007fff3f566b4b __CFRunLoopRun + 2427 50 com.apple.CoreFoundation 0x00007fff3f565f43 CFRunLoopRunSpecific + 483 51 com.apple.HIToolbox 0x00007fff3e87de26 RunCurrentEventLoopInMode + 286 52 com.apple.HIToolbox 0x00007fff3e87db96 ReceiveNextEventCommon + 613 53 com.apple.HIToolbox 0x00007fff3e87d914 _BlockUntilNextEventMatchingListInModeWithFilter + 64 54 com.apple.AppKit 0x00007fff3cb48f5f _DPSNextEvent + 2085 55 com.apple.AppKit 0x00007fff3d2deb4c -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 3044 56 com.apple.AppKit 0x00007fff3cb3dd6d -[NSApplication run] + 764 57 com.apple.AppKit 0x00007fff3cb0cf1a NSApplicationMain + 804 58 libxpc.dylib 0x00007fff672ac42f _xpc_objc_main + 580 59 libxpc.dylib 0x00007fff672ab082 xpc_main + 417 60 com.apple.WebKit.WebContent 0x0000000100c8514b main + 1195 (XPCServiceMain.mm:148) 61 libdyld.dylib 0x00007fff66fdf115 start + 1 1392447 1 rniwa 2018-01-23 22:58:20 -0800 It looks like MediaSessionManagerMac::clientCharacteristicsChanged just needs to call scheduleUpdateNowPlayingInfo() instead of updateNowPlayingInfo()? 1392451 2 webkit-bug-importer 2018-01-23 23:02:23 -0800 <rdar://problem/36812083> 1392532 3 eric.carlson 2018-01-24 06:48:53 -0800 The assert is RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(isSafeToUpdateStyleOrLayout()) which is interesting because isMainContentForPurposesOfAutoplay returns early when "!document.isSafeToUpdateStyleOrLayout()" 1392535 4 eric.carlson 2018-01-24 06:54:39 -0800 I can't reproduce with run-webkit-tests -fg --iter 10 --no-retry LayoutTests/media/video-main-content*.html 1392538 5 332156 eric.carlson 2018-01-24 07:02:01 -0800 Created attachment 332156 Patch 1392617 6 332156 commit-queue 2018-01-24 10:07:22 -0800 Comment on attachment 332156 Patch Clearing flags on attachment: 332156 Committed r227529: <https://trac.webkit.org/changeset/227529> 1392618 7 commit-queue 2018-01-24 10:07:24 -0800 All reviewed patches have been landed. Closing bug. 1392870 8 ryanhaddad 2018-01-24 18:02:33 -0800 It looks like this introduced an API test failure on Sierra: FAIL NowPlayingControlsTests.NowPlayingControlsDoNotShowForForegroundPage /Volumes/Data/slave/sierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:106 Value of: webView.get().lastUpdatedTitle.UTF8String Actual: "" Expected: "foo" https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20%28Tests%29/builds/7160 1393050 9 eric.carlson 2018-01-25 07:54:33 -0800 Reopening to attach new patch. 1393051 10 332267 eric.carlson 2018-01-25 07:54:35 -0800 Created attachment 332267 Patch 1393133 11 332267 ryanhaddad 2018-01-25 11:16:01 -0800 Comment on attachment 332267 Patch The mac-debug failure appears to be a bot-specific issue. Marking cq+. 1393148 12 332267 commit-queue 2018-01-25 11:27:38 -0800 Comment on attachment 332267 Patch Clearing flags on attachment: 332267 Committed r227616: <https://trac.webkit.org/changeset/227616> 1393149 13 commit-queue 2018-01-25 11:27:40 -0800 All reviewed patches have been landed. Closing bug. 332156 2018-01-24 07:02:01 -0800 2018-01-25 07:55:20 -0800 Patch bug-182038-20180124090200.patch text/plain 3097 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3NTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDA0OWQxZmYxN2QwMTJk NTU3MGIzZWNhM2IxMjU2ZDgyNTRiNGQ3Mi4uYzAyYWU0NTIwZGZjNjBlYWI4ZTBmNTNlMTkzYThh NmZlYmYxN2U5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTAxLTI0ICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04o cjIyNzQ1Nyk6IFJlbGVhc2UgYXNzZXJ0IGluIHVwZGF0ZUxheW91dCB3aGlsZSBkZXN0cnVjdGlu ZyBhIG1lZGlhIGVsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4MjAzOAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzY4MTIwODM+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodG1sL01lZGlh RWxlbWVudFNlc3Npb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6aXNNYWluQ29udGVudEZvclB1 cnBvc2VzT2ZBdXRvcGxheSk6IEVhcmx5IHJldHVybiBpZiBlbGVtZW50LmlzU3VzcGVuZGVkKCku CisgICAgICAgICogcGxhdGZvcm0vYXVkaW8vbWFjL01lZGlhU2Vzc2lvbk1hbmFnZXJNYWMubW06 CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVNlc3Npb25NYW5hZ2VyTWFjOjpjbGllbnRDaGFyYWN0 ZXJpc3RpY3NDaGFuZ2VkKTogQ2FsbCBzY2hlZHVsZVVwZGF0ZU5vd1BsYXlpbmdJbmZvCisgICAg ICAgIGluc3RlYWQgb2YgdXBkYXRlTm93UGxheWluZ0luZm8uCisKIDIwMTgtMDEtMjMgIFdlbnNv biBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgSGFyZGVuIGFnYWlu c3QgbGF5b3V0IHBhc3NlcyB0cmlnZ2VyZWQgd2hlbiBpdGVyYXRpbmcgdGhyb3VnaCBIVE1MRm9y bUVsZW1lbnQ6OmFzc29jaWF0ZWRFbGVtZW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aHRtbC9NZWRpYUVsZW1lbnRTZXNzaW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvTWVkaWFF bGVtZW50U2Vzc2lvbi5jcHAKaW5kZXggNGFiODVhZmM3NWY0YTJiYWYzMzM1MGZjNzVjMTQyZTgz YzUxYzI1Mi4uNzZlZjUzZGNlY2Q1YjVlOWY2MDczNGQwYzc5ZGRmYjVjYTVkMzg1NiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9NZWRpYUVsZW1lbnRTZXNzaW9uLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9odG1sL01lZGlhRWxlbWVudFNlc3Npb24uY3BwCkBAIC02OTUsNyArNjk1 LDcgQEAgc2l6ZV90IE1lZGlhRWxlbWVudFNlc3Npb246Om1heGltdW1NZWRpYVNvdXJjZUJ1ZmZl clNpemUoY29uc3QgU291cmNlQnVmZmVyJiBidWYKIHN0YXRpYyBib29sIGlzTWFpbkNvbnRlbnRG b3JQdXJwb3Nlc09mQXV0b3BsYXkoY29uc3QgSFRNTE1lZGlhRWxlbWVudCYgZWxlbWVudCkKIHsK ICAgICBEb2N1bWVudCYgZG9jdW1lbnQgPSBlbGVtZW50LmRvY3VtZW50KCk7Ci0gICAgaWYgKCFk b2N1bWVudC5pc1NhZmVUb1VwZGF0ZVN0eWxlT3JMYXlvdXQoKSB8fCAhZWxlbWVudC5oYXNBdWRp bygpIHx8ICFlbGVtZW50Lmhhc1ZpZGVvKCkpCisgICAgaWYgKGVsZW1lbnQuaXNTdXNwZW5kZWQo KSB8fCAhZWxlbWVudC5oYXNBdWRpbygpIHx8ICFlbGVtZW50Lmhhc1ZpZGVvKCkpCiAgICAgICAg IHJldHVybiBmYWxzZTsKIAogICAgIC8vIEVsZW1lbnRzIHdoaWNoIGhhdmUgbm90IHlldCBiZWVu IGxhaWQgb3V0LCBvciB3aGljaCBhcmUgbm90IHlldCBpbiB0aGUgRE9NLCBjYW5ub3QgYmUgbWFp biBjb250ZW50LgpAQCAtNzE1LDcgKzcxNSw3IEBAIHN0YXRpYyBib29sIGlzTWFpbkNvbnRlbnRG b3JQdXJwb3Nlc09mQXV0b3BsYXkoY29uc3QgSFRNTE1lZGlhRWxlbWVudCYgZWxlbWVudCkKICAg ICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgLy8gTWFpbiBjb250ZW50IGVsZW1lbnRzIG11c3Qg YmUgaW4gdGhlIG1haW4gZnJhbWUuCi0gICAgaWYgKCFkb2N1bWVudC5mcmFtZSgpIHx8ICFkb2N1 bWVudC5mcmFtZSgpLT5pc01haW5GcmFtZSgpKQorICAgIGlmICghZG9jdW1lbnQuZnJhbWUoKSB8 fCAhZG9jdW1lbnQuZnJhbWUoKS0+aXNNYWluRnJhbWUoKSB8fCAhZG9jdW1lbnQuaXNTYWZlVG9V cGRhdGVTdHlsZU9yTGF5b3V0KCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIE1haW5G cmFtZSYgbWFpbkZyYW1lID0gZG9jdW1lbnQuZnJhbWUoKS0+bWFpbkZyYW1lKCk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9tYWMvTWVkaWFTZXNzaW9uTWFuYWdl ck1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL21hYy9NZWRpYVNlc3Npb25N YW5hZ2VyTWFjLm1tCmluZGV4IGU1MTYwNTM5NjI3MWEwYWFkYTMzNjg4MmE4MTYxMTkwNmY0N2I3 OTIuLjEwNmY5NWE4Yjk0ZDlmMzQ0MjQyZDBlYjMwZmU1ZWQ4MTVjY2ExMDMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL21hYy9NZWRpYVNlc3Npb25NYW5hZ2VyTWFj Lm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL21hYy9NZWRpYVNlc3Npb25N YW5hZ2VyTWFjLm1tCkBAIC0xMDIsNyArMTAyLDcgQEAgdm9pZCBNZWRpYVNlc3Npb25NYW5hZ2Vy TWFjOjpzZXNzaW9uV2lsbEVuZFBsYXliYWNrKFBsYXRmb3JtTWVkaWFTZXNzaW9uJiBzZXNzaW8K IHZvaWQgTWVkaWFTZXNzaW9uTWFuYWdlck1hYzo6Y2xpZW50Q2hhcmFjdGVyaXN0aWNzQ2hhbmdl ZChQbGF0Zm9ybU1lZGlhU2Vzc2lvbiYpCiB7CiAgICAgTE9HKE1lZGlhLCAiTWVkaWFTZXNzaW9u TWFuYWdlck1hYzo6Y2xpZW50Q2hhcmFjdGVyaXN0aWNzQ2hhbmdlZCIpOwotICAgIHVwZGF0ZU5v d1BsYXlpbmdJbmZvKCk7CisgICAgc2NoZWR1bGVVcGRhdGVOb3dQbGF5aW5nSW5mbygpOwogfQog CiBQbGF0Zm9ybU1lZGlhU2Vzc2lvbiogTWVkaWFTZXNzaW9uTWFuYWdlck1hYzo6bm93UGxheWlu Z0VsaWdpYmxlU2Vzc2lvbigpCg== 332267 2018-01-25 07:54:35 -0800 2018-01-25 11:27:38 -0800 Patch bug-182038-20180125095434.patch text/plain 1626 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3NjA2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjlmMzZmNDgxZTFkOWNmMzkwMDE0MWQ4ZjAwODgwNDY2 ODUzYmQ2YS4uYjRlZThlZmE5NGExNmU4YThhNzJiMjNhM2ZkMGYzMTkwNmI0Zjc3ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE4LTAxLTI1ICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgor CisgICAgICAgIFJFR1JFU1NJT04ocjIyNzQ1Nyk6IFJlbGVhc2UgYXNzZXJ0IGluIHVwZGF0ZUxh eW91dCB3aGlsZSBkZXN0cnVjdGluZyBhIG1lZGlhIGVsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjAzOAorICAgICAgICA8cmRhcjovL3By b2JsZW0vMzY4MTIwODM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL05vd1BsYXlpbmdDb250 cm9sc1Rlc3RzLm1tOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVCk6IFNob3cvaGlkZSBw YWdlIHNvIGNvbnRyb2xzIGFyZSBhbHdheXMgdXBkYXRlZC4KKwogMjAxOC0wMS0yNSAgQ2FybG9z IEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgV2ViRHJpdmVy OiBhZGQgc3VwcG9ydCBmb3Igc2xvdyB0ZXN0cwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Ob3dQbGF5aW5nQ29udHJvbHNUZXN0cy5tbSBiL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvTm93UGxheWluZ0NvbnRyb2xzVGVzdHMu bW0KaW5kZXggYzZmZDg3NjQ3ZmU3Nzg5ODY1YjhhNGJjMjJmZGQzYWE0YzJmZWM0YS4uMjMwMDY5 YTZlZjhjZDA1YWUwMzFiODVhMmFiNTM1YmQ4Y2EyMWU0MCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Ob3dQbGF5aW5nQ29udHJvbHNUZXN0cy5tbQor KysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL05vd1BsYXlpbmdDb250 cm9sc1Rlc3RzLm1tCkBAIC05OSw2ICs5OSwxMCBAQCBURVNUKE5vd1BsYXlpbmdDb250cm9sc1Rl c3RzLCBOb3dQbGF5aW5nQ29udHJvbHNEb05vdFNob3dGb3JGb3JlZ3JvdW5kUGFnZSkKICAgICBb d2ViVmlldyBsb2FkVGVzdFBhZ2VOYW1lZDpAImxhcmdlLXZpZGVvLXRlc3Qtbm93LXBsYXlpbmci XTsKICAgICBbd2ViVmlldyB3YWl0Rm9yTWVzc2FnZTpAInBsYXlpbmciXTsKIAorICAgIFt3ZWJW aWV3IHNldFdpbmRvd1Zpc2libGU6Tk9dOworICAgIFt3ZWJWaWV3LmdldCgpLndpbmRvdyByZXNp Z25LZXlXaW5kb3ddOworICAgIFt3ZWJWaWV3IGV4cGVjdEhhc0FjdGl2ZU5vd1BsYXlpbmdTZXNz aW9uOllFU107CisKICAgICBbd2ViVmlldyBzZXRXaW5kb3dWaXNpYmxlOllFU107CiAgICAgW3dl YlZpZXcuZ2V0KCkud2luZG93IG1ha2VLZXlXaW5kb3ddOwogICAgIFt3ZWJWaWV3IGV4cGVjdEhh c0FjdGl2ZU5vd1BsYXlpbmdTZXNzaW9uOk5PXTsK