182033 2018-01-23 18:15:53 -0800 REGRESSION (r222961?): sRGB images shown in WebGL are over-saturated on a wide gamut monitor 2018-01-24 13:58:03 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino graouts simon.fraser oldest_to_newest 1392400 0 dino 2018-01-23 18:15:53 -0800 REGRESSION (r222961?): sRGB images shown in WebGL are over-saturated on a wide gamut monitor 1392403 1 dino 2018-01-23 18:17:34 -0800 <rdar://problem/36377780> 1392405 2 332113 dino 2018-01-23 18:23:28 -0800 Created attachment 332113 Patch 1392594 3 dino 2018-01-24 09:15:28 -0800 Committed r227524: <https://trac.webkit.org/changeset/227524> 1392728 4 332113 simon.fraser 2018-01-24 13:58:03 -0800 Comment on attachment 332113 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332113&action=review > Source/WebCore/platform/graphics/cocoa/WebGLLayer.mm:163 > + IOSurfaceSetValue(_contentsBuffer->surface(), kIOSurfaceColorSpace, sRGBDetails.get()); This code should live in WebCore::IOSurface(). 332113 2018-01-23 18:23:28 -0800 2018-01-23 23:39:14 -0800 Patch bug-182033-20180124132326.patch text/plain 5246 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3MjY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGJmY2E1NzYzMmVjYzQ2 ODMxNGIxZDQyODI3YzJmOGQzMjhjNmMyNi4uYmIwMDg1Y2M4YjQwMTM2ZDZjZTFiYTExZTIyNmYw ZDY2ZTkzOTQ1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE4LTAxLTIzICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjIyOTYx Pyk6IHNSR0IgaW1hZ2VzIHNob3duIGluIFdlYkdMIGFyZSBvdmVyLXNhdHVyYXRlZCBvbiBhIHdp ZGUgZ2FtdXQgbW9uaXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTgyMDMzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNjM3Nzc4MD4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNeSBmaXggZm9yIFlv dVR1YmUzNjAgY2hhbmdlZCB0aGUgd2F5IHdlIGNvbXBvc2l0ZSBXZWJHTCBvbiBtYWNPUy4gVW5m b3J0dW5hdGVseSBpdCBkcm9wcGVkCisgICAgICAgIGEgZmxhZyB0ZWxsaW5nIHRoZSBjb21wb3Np dG9yIHRoZSBjb2xvcnNwYWNlIG9mIHRoZSBjb250ZW50IHNob3VsZCBiZSBzUkdCLiBSZWluc3Rh dGUgdGhpcworICAgICAgICBieSBleHBsaWNpdGx5IHNldHRpbmcgdGhlIGNvbG9yc3BhY2Ugb24g dGhlIElPU3VyZmFjZSB3ZSB1c2UgZm9yIFdlYkdMIGJhY2sgYnVmZmVycy4KKworICAgICAgICBU aGlzICpzaG91bGQqIGJlIGNvdmVyZWQgYnkgdGhlIHRlc3QgaW46CisgICAgICAgIGZhc3QvY2Fu dmFzL3dlYmdsL21hdGNoLXBhZ2UtY29sb3Itc3BhY2UuaHRtbAorICAgICAgICAuLi4gaG93ZXZl ciwgaXQgc2hvd3MgYSBwcm9ibGVtIHdpdGggb3VyIHRlc3RpbmcgaW5mcmFzdHJ1Y3R1cmUuIEFz IGxvbmcgYXMgaXQgaXMgbm90CisgICAgICAgIHRlc3Rpbmcgb24gYSBXaWRlIEdhbXV0IGRpc3Bs YXksIGFuZCBleHBsaWNpdGx5IHNldHRpbmcgdGhlIGNvbG9yIHByb2ZpbGUsIGFuIGF1dG9tYXRl ZAorICAgICAgICB0ZXN0IHdvbid0IHBpY2sgdXAgdGhpcyByZWdyZXNzaW9uLiBJIGNvdWxkIGFk ZCBhbiBJbnRlcm5hbHMgaGVscGVyIHRvIHF1ZXJ5IHRoZSBjb2xvcnNwYWNlCisgICAgICAgIG9m IHRoZSBXZWJHTCBjb250ZW50LCBidXQgdGhhdCBkb2Vzbid0IGFjdHVhbGx5IHZlcmlmeSB0aGUg Y29tcG9zaXRlZCByZXN1bHQsIHdoaWNoIGlzCisgICAgICAgIGFsbCB0aGF0IG1hdHRlcnMuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9XZWJHTExheWVyLm1tOgorICAgICAg ICAoLVtXZWJHTExheWVyIGFsbG9jYXRlSU9TdXJmYWNlQmFja2luZ1N0b3JlV2l0aFNpemU6dXNp bmdBbHBoYTpdKToKKwogMjAxOC0wMS0xOSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFw cGxlLmNvbT4KIAogICAgICAgICBbbWFjT1NdIFtXSzJdIERyYWcgbG9jYXRpb24gaXMgY29tcHV0 ZWQgaW5jb3JyZWN0bHkgd2hlbiBkcmFnZ2luZyBjb250ZW50IGZyb20gc3ViZnJhbWVzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvUEFM L0NoYW5nZUxvZwppbmRleCBjYzkxYzVlOGQ4MDdiMmM1MDI1MGFiZDM0MGVjMDYzMjFhN2Y2OTJj Li45MmFmNTg1Y2VhNWFhYWViMDY0Y2QwNjU4NDBjY2NjMjM4MGVmOWM5IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxOC0wMS0yMyAgRGVhbiBKYWNrc29uICA8ZGlub0Bh cHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjIyMjk2MT8pOiBzUkdCIGltYWdlcyBz aG93biBpbiBXZWJHTCBhcmUgb3Zlci1zYXR1cmF0ZWQgb24gYSB3aWRlIGdhbXV0IG1vbml0b3IK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjAzMwor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzYzNzc3ODA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRXhwb3NlIGFuIElPU3VyZmFjZSBjb2xvcnNwYWNl IHByb3BlcnR5IG5hbWUsIGFuZCBhIGZ1bmN0aW9uIHRvIHNlcmlhbGl6ZSBhIENHQ29sb3JTcGFj ZS4KKworICAgICAgICAqIHBhbC9zcGkvY2cvQ29yZUdyYXBoaWNzU1BJLmg6CisgICAgICAgICog cGFsL3NwaS9jb2NvYS9JT1N1cmZhY2VTUEkuaDoKKwogMjAxOC0wMS0xOCAgRGFuIEJlcm5zdGVp biAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFtYY29kZV0gU3RyZWFtbGluZSBhbmQgZnV0 dXJlLXByb29mIHRhcmdldC1tYWNPUy12ZXJzaW9uLWRlcGVuZGVudCBidWlsZCBzZXR0aW5nIGRl ZmluaXRpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9jZy9Db3Jl R3JhcGhpY3NTUEkuaCBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL2NnL0NvcmVHcmFwaGlj c1NQSS5oCmluZGV4IDg4NDFkNmRjNmE3YWQyYmRhYzE3YTE0ZmIyYzk4ZjI1N2RiYmUzM2UuLjIw OTY4YTFhY2ExNTg0NzUwMjRkOWU1ZmM3ZmEzMDVlOWFiZTRjZTggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL1BBTC9wYWwvc3BpL2NnL0NvcmVHcmFwaGljc1NQSS5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL1BBTC9wYWwvc3BpL2NnL0NvcmVHcmFwaGljc1NQSS5oCkBAIC0yNjcsNiArMjY3LDcg QEAgQ0dDb2xvclNwYWNlUmVmIENHSU9TdXJmYWNlQ29udGV4dEdldENvbG9yU3BhY2UoQ0dDb250 ZXh0UmVmKTsKIAogI2lmIFBMQVRGT1JNKENPQ09BKQogQ0dDb2xvclNwYWNlUmVmIENHQ29udGV4 dENvcHlEZXZpY2VDb2xvclNwYWNlKENHQ29udGV4dFJlZik7CitDRlByb3BlcnR5TGlzdFJlZiBD R0NvbG9yU3BhY2VDb3B5UHJvcGVydHlMaXN0KENHQ29sb3JTcGFjZVJlZik7CiBDR0Vycm9yIENH U05ld1JlZ2lvbldpdGhSZWN0KGNvbnN0IENHUmVjdCosIENHUmVnaW9uUmVmKik7CiBDR0Vycm9y IENHU1BhY2thZ2VzRW5hYmxlQ29ubmVjdGlvbk9jY2x1c2lvbk5vdGlmaWNhdGlvbnMoQ0dTQ29u bmVjdGlvbklELCBib29sIGZsYWcsIGJvb2wqIG91dEN1cnJlbnRWaXNpYmlsaXR5U3RhdGUpOwog Q0dFcnJvciBDR1NQYWNrYWdlc0VuYWJsZUNvbm5lY3Rpb25XaW5kb3dNb2RpZmljYXRpb25Ob3Rp ZmljYXRpb25zKENHU0Nvbm5lY3Rpb25JRCwgYm9vbCBmbGFnLCBib29sKiBvdXRDb25uZWN0aW9u SXNDdXJyZW50bHlJZGxlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3Bp L2NvY29hL0lPU3VyZmFjZVNQSS5oIGIvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvY29jb2Ev SU9TdXJmYWNlU1BJLmgKaW5kZXggZDhiMWJjOTIyZWEyNWIzZjI1ZGFkOTM4ZWQ5YzUzZmY5OTgx YjAxNC4uZTcyZjRkMjY3NDM5YjlmYjU1ZjQ5OTAyNWI1OTJiYTEzMDY5NjlmZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvY29jb2EvSU9TdXJmYWNlU1BJLmgKKysrIGIv U291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvY29jb2EvSU9TdXJmYWNlU1BJLmgKQEAgLTU0LDYg KzU0LDcgQEAgZXh0ZXJuIGNvbnN0IENGU3RyaW5nUmVmIGtJT1N1cmZhY2VBbGxvY1NpemU7CiBl eHRlcm4gY29uc3QgQ0ZTdHJpbmdSZWYga0lPU3VyZmFjZUJ5dGVzUGVyRWxlbWVudDsKIGV4dGVy biBjb25zdCBDRlN0cmluZ1JlZiBrSU9TdXJmYWNlQnl0ZXNQZXJSb3c7CiBleHRlcm4gY29uc3Qg Q0ZTdHJpbmdSZWYga0lPU3VyZmFjZUNhY2hlTW9kZTsKK2V4dGVybiBjb25zdCBDRlN0cmluZ1Jl ZiBrSU9TdXJmYWNlQ29sb3JTcGFjZTsKIGV4dGVybiBjb25zdCBDRlN0cmluZ1JlZiBrSU9TdXJm YWNlSGVpZ2h0OwogZXh0ZXJuIGNvbnN0IENGU3RyaW5nUmVmIGtJT1N1cmZhY2VQaXhlbEZvcm1h dDsKIGV4dGVybiBjb25zdCBDRlN0cmluZ1JlZiBrSU9TdXJmYWNlV2lkdGg7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9XZWJHTExheWVyLm1tIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvV2ViR0xMYXllci5tbQppbmRl eCA4NTE3MTEyNTEyZDFkOTYzODFkMDY4OTljODRmZjcwYzQ2MDgxZWUyLi40YzQzNmRiYzIwOWU2 ZTczM2UzODdiYmY4NDI0ZjFiODliNzYzYTNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9XZWJHTExheWVyLm1tCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL1dlYkdMTGF5ZXIubW0KQEAgLTE1NCw5ICsxNTQsMTUg QEAgc3RhdGljIHZvaWQgZnJlZURhdGEodm9pZCAqLCBjb25zdCB2b2lkICpkYXRhLCBzaXplX3Qg Lyogc2l6ZSAqLykKICAgICBfY29udGVudHNCdWZmZXIgPSBXZWJDb3JlOjpJT1N1cmZhY2U6OmNy ZWF0ZShzaXplLCBzUkdCQ29sb3JTcGFjZVJlZigpKTsKICAgICBfZHJhd2luZ0J1ZmZlciA9IFdl YkNvcmU6OklPU3VyZmFjZTo6Y3JlYXRlKHNpemUsIHNSR0JDb2xvclNwYWNlUmVmKCkpOwogICAg IF9zcGFyZUJ1ZmZlciA9IFdlYkNvcmU6OklPU3VyZmFjZTo6Y3JlYXRlKHNpemUsIHNSR0JDb2xv clNwYWNlUmVmKCkpOworCiAgICAgQVNTRVJUKF9jb250ZW50c0J1ZmZlcik7CiAgICAgQVNTRVJU KF9kcmF3aW5nQnVmZmVyKTsKICAgICBBU1NFUlQoX3NwYXJlQnVmZmVyKTsKKworICAgIGF1dG8g c1JHQkRldGFpbHMgPSBhZG9wdENGKENHQ29sb3JTcGFjZUNvcHlQcm9wZXJ0eUxpc3Qoc1JHQkNv bG9yU3BhY2VSZWYoKSkpOworICAgIElPU3VyZmFjZVNldFZhbHVlKF9jb250ZW50c0J1ZmZlci0+ c3VyZmFjZSgpLCBrSU9TdXJmYWNlQ29sb3JTcGFjZSwgc1JHQkRldGFpbHMuZ2V0KCkpOworICAg IElPU3VyZmFjZVNldFZhbHVlKF9kcmF3aW5nQnVmZmVyLT5zdXJmYWNlKCksIGtJT1N1cmZhY2VD b2xvclNwYWNlLCBzUkdCRGV0YWlscy5nZXQoKSk7CisgICAgSU9TdXJmYWNlU2V0VmFsdWUoX3Nw YXJlQnVmZmVyLT5zdXJmYWNlKCksIGtJT1N1cmZhY2VDb2xvclNwYWNlLCBzUkdCRGV0YWlscy5n ZXQoKSk7CiB9CiAKIC0gKHZvaWQpYmluZEZyYW1lYnVmZmVyVG9OZXh0QXZhaWxhYmxlU3VyZmFj ZQo=