<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>182030</bug_id>
          
          <creation_ts>2018-01-23 17:34:51 -0800</creation_ts>
          <short_desc>Layout Test http/tests/workers/service/basic-unregister-then-register-again-reuse.html is flaky</short_desc>
          <delta_ts>2018-01-24 13:26:52 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Service Workers</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Matt Lewis">jlewis3</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>beidson</cc>
    
    <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>lforschler</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1392382</commentid>
    <comment_count>0</comment_count>
    <who name="Matt Lewis">jlewis3</who>
    <bug_when>2018-01-23 17:34:51 -0800</bug_when>
    <thetext>The following layout test is flaky on macOS WK2

http/tests/workers/service/basic-unregister-then-register-again-reuse.html

Probable cause:

This seems to have recently started. The change in https://trac.webkit.org/changeset/227275/webkit is related via service workers, however it doesn&apos;t seem to be a cause.

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&amp;tests=http%2Ftests%2Fworkers%2Fservice%2Fbasic-unregister-then-register-again-reuse.html

Diff:

--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/workers/service/basic-unregister-then-register-again-reuse-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/workers/service/basic-unregister-then-register-again-reuse-actual.txt
@@ -1,5 +1,5 @@
 PASS: registration1 should not have an installing worker
 PASS: registration1 should not have a waiting worker
 PASS: registration1 should have an active worker
-PASS: Registration was reused
+FAIL: Registration was not reused</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1392383</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-01-23 17:37:05 -0800</bug_when>
    <thetext>&lt;rdar://problem/36802933&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1392464</commentid>
    <comment_count>2</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2018-01-24 00:00:18 -0800</bug_when>
    <thetext>(In reply to Matt Lewis from comment #0)
&gt; The following layout test is flaky on macOS WK2
&gt; 
&gt; http/tests/workers/service/basic-unregister-then-register-again-reuse.html
&gt; 
&gt; Probable cause:
&gt; 
&gt; This seems to have recently started. The change in
&gt; https://trac.webkit.org/changeset/227275/webkit is related via service
&gt; workers, however it doesn&apos;t seem to be a cause.

227275 is not related to SW - it was a no-behavior-change for SW&gt;

&gt; 
&gt; Flakiness Dashboard:
&gt; 
&gt; https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
&gt; html#showAllRuns=true&amp;tests=http%2Ftests%2Fworkers%2Fservice%2Fbasic-
&gt; unregister-then-register-again-reuse.html
&gt; 
&gt; Diff:
&gt; 
&gt; ---
&gt; /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/
&gt; http/tests/workers/service/basic-unregister-then-register-again-reuse-
&gt; expected.txt
&gt; +++
&gt; /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/
&gt; http/tests/workers/service/basic-unregister-then-register-again-reuse-actual.
&gt; txt
&gt; @@ -1,5 +1,5 @@
&gt;  PASS: registration1 should not have an installing worker
&gt;  PASS: registration1 should not have a waiting worker
&gt;  PASS: registration1 should have an active worker
&gt; -PASS: Registration was reused
&gt; +FAIL: Registration was not reused</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1392634</commentid>
    <comment_count>3</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2018-01-24 10:50:36 -0800</bug_when>
    <thetext>Will try and look into this today.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1392656</commentid>
    <comment_count>4</comment_count>
      <attachid>332183</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2018-01-24 11:54:07 -0800</bug_when>
    <thetext>Created attachment 332183
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1392710</commentid>
    <comment_count>5</comment_count>
      <attachid>332183</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-01-24 13:26:51 -0800</bug_when>
    <thetext>Comment on attachment 332183
Patch

Clearing flags on attachment: 332183

Committed r227557: &lt;https://trac.webkit.org/changeset/227557&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1392711</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-01-24 13:26:52 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>332183</attachid>
            <date>2018-01-24 11:54:07 -0800</date>
            <delta_ts>2018-01-24 13:26:51 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-182030-20180124115406.patch</filename>
            <type>text/plain</type>
            <size>2005</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3NTMyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu
Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzMzMThjYjY0NzcxMGM4YjYwNjZl
NzI2YmUzOWY1ZjE5OTFlZTJhZi4uZjE2N2U1YjViNjI4NzkwNmQxNWI4ZjFkZTc1NDU0NDE5MjUw
ZTgwYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTAxLTI0ICBDaHJpcyBEdW1leiAgPGNk
dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0IFRlc3QgaHR0cC90ZXN0cy93b3JrZXJz
L3NlcnZpY2UvYmFzaWMtdW5yZWdpc3Rlci10aGVuLXJlZ2lzdGVyLWFnYWluLXJldXNlLmh0bWwg
aXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTE4MjAzMAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzY4MDI5MzM+CisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHNlcnZpY2Ugd29ya2VyIHdh
cyBvbmx5IGV4dGVuZGluZyBpdHMgbGlmZXRpbWUgdXNpbmcgd2FpdFVudGlsKCkgZm9yIDEwIHNl
Y29uZHMuIE9uIHRoZSBmbGFraW5lc3MKKyAgICAgICAgZGFzaGJvYXJkLCBJIHNlZSB0aGF0IHRo
ZSB0ZXN0IHNvbWV0aW1lcyB0YWtlcyBtb3JlIHRoYW4gMTAgc2Vjb25kcyB0byBydW4gb24gc29t
ZSBib3RzLCB3aGljaCBjYW4KKyAgICAgICAgY2F1c2UgdGhlIHRlc3QgdG8gZmFpbCBzaW5jZSB0
aGUgc2VydmljZSB3b3JrZXIgaXMgbm90IGtlZXBpbmcgdGhlIHJlZ2lzdHJhdGlvbiBhbGl2ZSBh
bnltb3JlLgorICAgICAgICBUbyBhZGRyZXNzIHRoZSBpc3N1ZSwgcmFpc2UgdGhlIGxpZmV0aW1l
IHRvIDMwIHNlY29uZHMuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL3dvcmtlcnMvc2VydmljZS9y
ZXNvdXJjZXMvYmFzaWMtdW5yZWdpc3Rlci10aGVuLXJlZ2lzdGVyLWFnYWluLXJldXNlLXdvcmtl
ci5qczoKKyAgICAgICAgKGV2ZW50LndhaXRVbnRpbC5uZXcuUHJvbWlzZSk6CisKIDIwMTgtMDEt
MjQgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEZldGNoIHJl
c3BvbnNlIHNob3VsZCBjb3B5IGl0cyB1cmwgZnJvbSB0aGUgcmVxdWVzdCBpZiBudWxsCmRpZmYg
LS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dvcmtlcnMvc2VydmljZS9yZXNvdXJjZXMv
YmFzaWMtdW5yZWdpc3Rlci10aGVuLXJlZ2lzdGVyLWFnYWluLXJldXNlLXdvcmtlci5qcyBiL0xh
eW91dFRlc3RzL2h0dHAvdGVzdHMvd29ya2Vycy9zZXJ2aWNlL3Jlc291cmNlcy9iYXNpYy11bnJl
Z2lzdGVyLXRoZW4tcmVnaXN0ZXItYWdhaW4tcmV1c2Utd29ya2VyLmpzCmluZGV4IDRiNzlhZmRj
M2NhOTMxMWFlZDE2MWUwNzM4NGM4NWUzZDEwY2E2NDYuLmE0ZmI3NmFhMjcwYzc5YzAzOTUwMTg1
MDI0OWYzNjFjMTZiMzQ2MGEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd29y
a2Vycy9zZXJ2aWNlL3Jlc291cmNlcy9iYXNpYy11bnJlZ2lzdGVyLXRoZW4tcmVnaXN0ZXItYWdh
aW4tcmV1c2Utd29ya2VyLmpzCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd29ya2Vycy9z
ZXJ2aWNlL3Jlc291cmNlcy9iYXNpYy11bnJlZ2lzdGVyLXRoZW4tcmVnaXN0ZXItYWdhaW4tcmV1
c2Utd29ya2VyLmpzCkBAIC0yLDcgKzIsNyBAQCBzZWxmLmFkZEV2ZW50TGlzdGVuZXIoIm1lc3Nh
Z2UiLCBmdW5jdGlvbihldmVudCkgewogICAgIGV2ZW50LndhaXRVbnRpbChuZXcgUHJvbWlzZSgo
cmVzb2x2ZSwgcmVqZWN0KSA9PiB7CiAgICAgICAgIHNldFRpbWVvdXQoKCkgPT4gewogICAgICAg
ICAgICAgcmVzb2x2ZSgpOwotICAgICAgICB9LCAxMDAwMCk7CisgICAgICAgIH0sIDMwMDAwKTsK
ICAgICB9KSk7CiAgICAgY2xpZW50ID0gZXZlbnQuc291cmNlOwogICAgIHNldFRpbWVvdXQoZnVu
Y3Rpb24oKSB7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>