182005 2018-01-23 12:50:57 -0800 [GTK] MiniBrowser settings are just a list of names 2018-02-01 01:44:53 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jidanni webkit-unassigned bugs-noreply cgarcia mcatanzaro svillar oldest_to_newest 1392215 0 jidanni 2018-01-23 12:50:57 -0800 Please see https://bugzilla.gnome.org/attachment.cgi?id=367332&action=edit Nobody can inspect or change the values of items in MiniBrowser, only see their names. 1392396 1 mcatanzaro 2018-01-23 18:12:11 -0800 There is a hidden horizontal scrollbar you can use. Agreed this ought to be better. 1392567 2 jidanni 2018-01-24 07:53:31 -0800 Also that "WebKit View Settings" window: 1. Cannot be expanded, not via a nonexistant fullscreen icon, as all there is is an "X" to close it. Nor does grabbing on its sides actually work! 2. On some screens the "Value" column is visible, on some not. So the smaller terminal people, if never discovering the almost hidden slider, will think there is no value column. And if they discover the slider and slide to see the value, they will have to slide back again to see the name, unless they remember it. 1395393 3 332859 cgarcia 2018-02-01 01:35:06 -0800 Created attachment 332859 Patch 1395395 4 332859 svillar 2018-02-01 01:40:12 -0800 Comment on attachment 332859 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332859&action=review > Tools/ChangeLog:7 > + Nit, I'd add something here, just because there is absolutely no connection between the bug title and the fixes you describe bellow. 1395397 5 cgarcia 2018-02-01 01:44:53 -0800 Committed r227957: <https://trac.webkit.org/changeset/227957> 332859 2018-02-01 01:35:06 -0800 2018-02-01 01:40:12 -0800 Patch mb-settings-dialog.diff text/plain 2063 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmYTQx Y2E5NjZmYi4uOGYxMDRhY2FhYmMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxOC0wMi0wMSAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gTWluaUJyb3dz ZXIgc2V0dGluZ3MgYXJlIGp1c3QgYSBsaXN0IG9mIG5hbWVzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODIwMDUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE1pbmlCcm93c2VyL2d0ay9Ccm93c2VyU2V0 dGluZ3NEaWFsb2cuYzoKKyAgICAgICAgKGJyb3dzZXJfc2V0dGluZ3NfZGlhbG9nX2luaXQpOiBV c2UgNjAweDQwMCBhcyBkZWZhdWx0IHNpemUuCisgICAgICAgIChicm93c2VyU2V0dGluZ3NEaWFs b2dDb25zdHJ1Y3RlZCk6IENoYWluIHVwIHRvIHBhcmVudCBjb25zdHJ1Y3RlZC4KKwogMjAxOC0w MS0zMSAgQW5kcmVzIEdvbWV6ICA8YWdvbWV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZC4gUmVtb3ZlIFdlYkluc3BlY3RvclVJIHdhdGNobGlzdCBhbmQgcmVtb3ZlIG15c2VsZiBm cm9tIDIgd2F0Y2hsaXN0cyBtb3JlCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9ndGsv QnJvd3NlclNldHRpbmdzRGlhbG9nLmMgYi9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlclNl dHRpbmdzRGlhbG9nLmMKaW5kZXggNTExYjNkYjA0ZmIuLmY5MzUwZjhlYzYyIDEwMDY0NAotLS0g YS9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlclNldHRpbmdzRGlhbG9nLmMKKysrIGIvVG9v bHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJTZXR0aW5nc0RpYWxvZy5jCkBAIC0xMjYsNyArMTI2 LDggQEAgc3RhdGljIHZvaWQgYnJvd3Nlcl9zZXR0aW5nc19kaWFsb2dfaW5pdChCcm93c2VyU2V0 dGluZ3NEaWFsb2cgKmRpYWxvZykKICAgICBHdGtCb3ggKmNvbnRlbnRBcmVhID0gR1RLX0JPWChn dGtfZGlhbG9nX2dldF9jb250ZW50X2FyZWEoR1RLX0RJQUxPRyhkaWFsb2cpKSk7CiAgICAgZ3Rr X2JveF9zZXRfc3BhY2luZyhjb250ZW50QXJlYSwgMik7CiAKLSAgICBndGtfd2luZG93X3NldF9k ZWZhdWx0X3NpemUoR1RLX1dJTkRPVyhkaWFsb2cpLCA0MDAsIDMwMCk7CisgICAgZ3RrX3dpbmRv d19zZXRfZGVmYXVsdF9zaXplKEdUS19XSU5ET1coZGlhbG9nKSwgNjAwLCA0MDApOworICAgIGd0 a193aW5kb3dfc2V0X3R5cGVfaGludChHVEtfV0lORE9XKGRpYWxvZyksIEdES19XSU5ET1dfVFlQ RV9ISU5UX0RJQUxPRyk7CiAgICAgZ3RrX3dpbmRvd19zZXRfdGl0bGUoR1RLX1dJTkRPVyhkaWFs b2cpLCAiV2ViS2l0IFZpZXcgU2V0dGluZ3MiKTsKICAgICBndGtfd2luZG93X3NldF9kZXN0cm95 X3dpdGhfcGFyZW50KEdUS19XSU5ET1coZGlhbG9nKSwgVFJVRSk7CiAgICAgZ3RrX2NvbnRhaW5l cl9zZXRfYm9yZGVyX3dpZHRoKEdUS19DT05UQUlORVIoZGlhbG9nKSwgNSk7CkBAIC0xNjAsNiAr MTYxLDggQEAgc3RhdGljIHZvaWQgYnJvd3Nlcl9zZXR0aW5nc19kaWFsb2dfaW5pdChCcm93c2Vy U2V0dGluZ3NEaWFsb2cgKmRpYWxvZykKIAogc3RhdGljIHZvaWQgYnJvd3NlclNldHRpbmdzRGlh bG9nQ29uc3RydWN0ZWQoR09iamVjdCAqb2JqZWN0KQogeworICAgIEdfT0JKRUNUX0NMQVNTKGJy b3dzZXJfc2V0dGluZ3NfZGlhbG9nX3BhcmVudF9jbGFzcyktPmNvbnN0cnVjdGVkKG9iamVjdCk7 CisKICAgICBCcm93c2VyU2V0dGluZ3NEaWFsb2cgKmRpYWxvZyA9IEJST1dTRVJfU0VUVElOR1Nf RElBTE9HKG9iamVjdCk7CiAgICAgV2ViS2l0U2V0dGluZ3MgKnNldHRpbmdzID0gZGlhbG9nLT5z ZXR0aW5nczsKICAgICBHdGtMaXN0U3RvcmUgKm1vZGVsID0gZ3RrX2xpc3Rfc3RvcmVfbmV3KFNF VFRJTkdTX0xJU1RfTl9DT0xVTU5TLCBHX1RZUEVfU1RSSU5HLCBHX1RZUEVfU1RSSU5HLCBHX1RZ UEVfU1RSSU5HLAo=