181998 2018-01-23 11:21:24 -0800 Web Inspector: Network's columns shake when scrolling at non-default zoom level 2018-01-23 16:46:45 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck mattbaker nvasilyev webkit-bug-importer oldest_to_newest 1392142 0 joepeck 2018-01-23 11:21:24 -0800 Network's columns shake when scrolling at non-default zoom level Steps to reproduce: 1. Inspect a page with my network requests (<http://nytimes.com>) 2. Show Network tab 3. Scroll Network table => All is good 4. ⌘+ to zoom in a few times 5. Scroll Network table => Columns shaking Notes: • Seeing an assertion in this case: Table.js:811:27: CONSOLE ERROR Should not have undistributed pixels. • getBoundingClientRect values appear to be fractional which is unaccounted for in the pixel distribution algorithm 1392143 1 joepeck 2018-01-23 11:21:30 -0800 <rdar://problem/36449808> 1392147 2 332045 joepeck 2018-01-23 11:24:40 -0800 Created attachment 332045 [PATCH] Proposed Fix 1392276 3 nvasilyev 2018-01-23 15:01:28 -0800 Nice! I just tried the patch and I can confirm that such bug exists and this patch indeed fixes it. I can't r+ since I'm still not a reviewer. 1392327 4 332045 mattbaker 2018-01-23 16:22:19 -0800 Comment on attachment 332045 [PATCH] Proposed Fix r=me. I wonder if there are other places in the UI suffering from this same problem. If so it could warrant a utility function. 1392345 5 332045 commit-queue 2018-01-23 16:46:44 -0800 Comment on attachment 332045 [PATCH] Proposed Fix Clearing flags on attachment: 332045 Committed r227463: <https://trac.webkit.org/changeset/227463> 1392346 6 commit-queue 2018-01-23 16:46:45 -0800 All reviewed patches have been landed. Closing bug. 332045 2018-01-23 11:24:40 -0800 2018-01-23 16:46:44 -0800 [PATCH] Proposed Fix shakyness-1.patch text/plain 1635 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGJiN2I3ZThhZDZmLi5kMmIxNTM1Y2I1OCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDEtMjMgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBOZXR3b3JrJ3MgY29sdW1ucyBzaGFrZSB3aGVuIHNjcm9sbGluZyBhdCBub24tZGVmYXVsdCB6 b29tIGxldmVsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xODE5OTgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM2NDQ5ODA4PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3 cy9UYWJsZS5qczoKKyAgICAgICAgV2hlbiB6b29tZWQgdGhlIGJvdW5kaW5nIGNsaWVudCByZWN0 IHZhbHVlcyB3ZXJlIGZyYWN0aW9uYWwsIHdoaWNoIHdhcworICAgICAgICB1bmV4cGVjdGVkIGJ5 IHRoaXMgYXJlYSBvZiBjb2RlLiBGbG9vciB0aGUgdmFsdWVzIHRvIGdldCBhIHZhbHVlIHdlIGV4 cGVjdAorICAgICAgICB0byBiZSBhYmxlIHRvIGV2ZW5seSBkaXN0cmlidXRlLgorCiAyMDE4LTAx LTE5ICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBMYXllcnMgdGFiIHNob3VsZCBkbyBhd2F5IHdpdGggcG9wb3ZlcnMgKGlm IHBvc3NpYmxlKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvVGFibGUuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9UYWJsZS5qcwppbmRleCBkMGM4YmUyOTVlNC4uODY5OTZhZmMyYzcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYmxlLmpzCisrKyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYmxlLmpzCkBAIC03 MDksOCArNzA5LDggQEAgV0kuVGFibGUgPSBjbGFzcyBUYWJsZSBleHRlbmRzIFdJLlZpZXcKIAog ICAgICAgICBpZiAoaXNOYU4odGhpcy5fY2FjaGVkV2lkdGgpKSB7CiAgICAgICAgICAgICBsZXQg Ym91bmRpbmdDbGllbnRSZWN0ID0gdGhpcy5fc2Nyb2xsQ29udGFpbmVyRWxlbWVudC5nZXRCb3Vu ZGluZ0NsaWVudFJlY3QoKTsKLSAgICAgICAgICAgIHRoaXMuX2NhY2hlZFdpZHRoID0gYm91bmRp bmdDbGllbnRSZWN0LndpZHRoOwotICAgICAgICAgICAgdGhpcy5fY2FjaGVkSGVpZ2h0ID0gYm91 bmRpbmdDbGllbnRSZWN0LmhlaWdodDsKKyAgICAgICAgICAgIHRoaXMuX2NhY2hlZFdpZHRoID0g TWF0aC5mbG9vcihib3VuZGluZ0NsaWVudFJlY3Qud2lkdGgpOworICAgICAgICAgICAgdGhpcy5f Y2FjaGVkSGVpZ2h0ID0gTWF0aC5mbG9vcihib3VuZGluZ0NsaWVudFJlY3QuaGVpZ2h0KTsKICAg ICAgICAgfQogCiAgICAgICAgIC8vIE5vdCB2aXNpYmxlIHlldC4K