181997 2018-01-23 11:15:25 -0800 Rollout r219636 2018-01-23 12:50:02 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=174516 P2 Normal --- 1 rmorisset rmorisset commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1392138 0 rmorisset 2018-01-23 11:15:25 -0800 A bug was found in it and patching it is not trivial, so let's revert it in the meantime. 1392141 1 332044 rmorisset 2018-01-23 11:21:15 -0800 Created attachment 332044 Patch 1392146 2 332044 mark.lam 2018-01-23 11:24:37 -0800 Comment on attachment 332044 Patch Clear the review flag because rollouts not require a review. 1392149 3 rmorisset 2018-01-23 11:25:07 -0800 <rdar://problem/35883022> 1392150 4 332044 commit-queue 2018-01-23 11:27:23 -0800 Comment on attachment 332044 Patch Rejecting attachment 332044 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 332044, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/JavaScriptCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/6184589 1392159 5 332048 rmorisset 2018-01-23 11:41:19 -0800 Created attachment 332048 Patch 1392211 6 332048 commit-queue 2018-01-23 12:49:30 -0800 Comment on attachment 332048 Patch Clearing flags on attachment: 332048 Committed r227435: <https://trac.webkit.org/changeset/227435> 1392212 7 commit-queue 2018-01-23 12:49:31 -0800 All reviewed patches have been landed. Closing bug. 332044 2018-01-23 11:21:15 -0800 2018-01-23 11:41:15 -0800 Patch bug-181997-20180123202114.patch text/plain 3638 rmorisset SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI3NDI0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE4LTAxLTIzICBSb2JpbiBNb3Jpc3NldCAgPHJtb3Jpc3NldEBhcHBsZS5jb20+CisKKyAg ICAgICAgUm9sbG91dCByMjE5NjM2CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODE5OTcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM1ODgzMDIyPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RG R1NwZWN1bGF0aXZlSklULmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6 ZW1pdEFsbG9jYXRlUmF3T2JqZWN0KToKKyAgICAgICAgKiBydW50aW1lL0pTQXJyYXkuY3BwOgor ICAgICAgICAoSlNDOjpKU0FycmF5Ojp0cnlDcmVhdGVVbmluaXRpYWxpemVkUmVzdHJpY3RlZCk6 CisgICAgICAgICogcnVudGltZS9KU0FycmF5Lmg6CisgICAgICAgIChKU0M6OkpTQXJyYXk6OnRy eUNyZWF0ZSk6CisgICAgICAgICogcnVudGltZS9KU09iamVjdC5jcHA6CisgICAgICAgIChKU0M6 OkpTT2JqZWN0OjplbnN1cmVMZW5ndGhTbG93KToKKwogMjAxOC0wMS0yMyAgRmlsaXAgUGl6bG8g IDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEpTQyBzaG91bGQgdXNlIGEgc3BlY3VsYXRp b24gZmVuY2Ugb24gVk0gZW50cnkvZXhpdApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAJKHJldmlzaW9uIDIyNzQyMCkKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xNDQsNyArMTQ0LDcgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6ZW1pdEFsbG9jYXRlUmF3 T2JqZQogICAgICAgICBzbG93Q2FzZXMsIHRoaXMsIG9wZXJhdGlvbk5ld1Jhd09iamVjdCwgcmVz dWx0R1BSLCBzdG9yYWdlR1BSLAogICAgICAgICBzdHJ1Y3R1cmUsIHZlY3Rvckxlbmd0aCkpOwog Ci0gICAgaWYgKG51bUVsZW1lbnRzIDwgdmVjdG9yTGVuZ3RoICYmIExJS0VMWSghaGFzVW5kZWNp ZGVkKHN0cnVjdHVyZS0+aW5kZXhpbmdUeXBlKCkpKSkgeworICAgIGlmIChudW1FbGVtZW50cyA8 IHZlY3Rvckxlbmd0aCkgewogI2lmIFVTRShKU1ZBTFVFNjQpCiAgICAgICAgIGlmIChoYXNEb3Vi bGUoc3RydWN0dXJlLT5pbmRleGluZ1R5cGUoKSkpCiAgICAgICAgICAgICBtX2ppdC5tb3ZlKFRy dXN0ZWRJbW02NChiaXR3aXNlX2Nhc3Q8aW50NjRfdD4oUE5hTikpLCBzY3JhdGNoR1BSKTsKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuY3BwCShyZXZpc2lvbiAy Mjc0MjApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmNwcAkod29y a2luZyBjb3B5KQpAQCAtOTEsNyArOTEsNyBAQCBKU0FycmF5KiBKU0FycmF5Ojp0cnlDcmVhdGVV bmluaXRpYWxpemVkCiAgICAgICAgIGlmIChoYXNEb3VibGUoaW5kZXhpbmdUeXBlKSkgewogICAg ICAgICAgICAgZm9yICg7IGkgPCB2ZWN0b3JMZW5ndGg7ICsraSkKICAgICAgICAgICAgICAgICBi dXR0ZXJmbHktPmNvbnRpZ3VvdXNEb3VibGUoKS5hdChzdGQ6Om51bWVyaWNfbGltaXRzPHVpbnQz Ml90Pjo6bWF4KCksIGkpID0gUE5hTjsKLSAgICAgICAgfSBlbHNlIGlmIChMSUtFTFkoIWhhc1Vu ZGVjaWRlZChpbmRleGluZ1R5cGUpKSkgeworICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAg Zm9yICg7IGkgPCB2ZWN0b3JMZW5ndGg7ICsraSkKICAgICAgICAgICAgICAgICBidXR0ZXJmbHkt PmNvbnRpZ3VvdXMoKS5hdChzdGQ6Om51bWVyaWNfbGltaXRzPHVpbnQzMl90Pjo6bWF4KCksIGkp LmNsZWFyKCk7CiAgICAgICAgIH0KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0pTQXJyYXkuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9K U0FycmF5LmgJKHJldmlzaW9uIDIyNzQyMCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0pTQXJyYXkuaAkod29ya2luZyBjb3B5KQpAQCAtMjQ3LDcgKzI0Nyw3IEBAIGlubGluZSBK U0FycmF5KiBKU0FycmF5Ojp0cnlDcmVhdGUoVk0mIHYKICAgICAgICAgYnV0dGVyZmx5LT5zZXRQ dWJsaWNMZW5ndGgoaW5pdGlhbExlbmd0aCk7CiAgICAgICAgIGlmIChoYXNEb3VibGUoaW5kZXhp bmdUeXBlKSkKICAgICAgICAgICAgIGNsZWFyQXJyYXkoYnV0dGVyZmx5LT5jb250aWd1b3VzRG91 YmxlKCkuZGF0YSgpLCB2ZWN0b3JMZW5ndGgpOwotICAgICAgICBlbHNlIGlmIChMSUtFTFkoIWhh c1VuZGVjaWRlZChpbmRleGluZ1R5cGUpKSkKKyAgICAgICAgZWxzZQogICAgICAgICAgICAgY2xl YXJBcnJheShidXR0ZXJmbHktPmNvbnRpZ3VvdXMoKS5kYXRhKCksIHZlY3Rvckxlbmd0aCk7CiAg ICAgfSBlbHNlIHsKICAgICAgICAgQVNTRVJUKApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvSlNPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0pTT2JqZWN0LmNwcAkocmV2aXNpb24gMjI3NDIwKQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMjIyLDcg KzMyMjIsNyBAQCBib29sIEpTT2JqZWN0OjplbnN1cmVMZW5ndGhTbG93KFZNJiB2bSwgCiAgICAg aWYgKGhhc0RvdWJsZShpbmRleGluZ1R5cGUoKSkpIHsKICAgICAgICAgZm9yICh1bnNpZ25lZCBp ID0gb2xkVmVjdG9yTGVuZ3RoOyBpIDwgbmV3VmVjdG9yTGVuZ3RoOyArK2kpCiAgICAgICAgICAg ICBidXR0ZXJmbHktPmluZGV4aW5nUGF5bG9hZDxkb3VibGU+KClbaV0gPSBQTmFOOwotICAgIH0g ZWxzZSBpZiAoTElLRUxZKCFoYXNVbmRlY2lkZWQoaW5kZXhpbmdUeXBlKCkpKSkgeworICAgIH0g ZWxzZSB7CiAgICAgICAgIGZvciAodW5zaWduZWQgaSA9IG9sZFZlY3Rvckxlbmd0aDsgaSA8IG5l d1ZlY3Rvckxlbmd0aDsgKytpKQogICAgICAgICAgICAgYnV0dGVyZmx5LT5pbmRleGluZ1BheWxv YWQ8V3JpdGVCYXJyaWVyPFVua25vd24+PigpW2ldLmNsZWFyKCk7CiAgICAgfQo= 332048 2018-01-23 11:41:19 -0800 2018-01-23 12:49:30 -0800 Patch bug-181997-20180123204117.patch text/plain 3642 rmorisset SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI3NDI0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE4LTAxLTIzICBSb2JpbiBNb3Jpc3NldCAgPHJtb3Jpc3NldEBhcHBsZS5jb20+CisKKyAg ICAgICAgUm9sbG91dCByMjE5NjM2CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODE5OTcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM1ODgzMDIyPgor CisgICAgICAgIFVucmV2aWV3ZWQsIGFzIGl0IGlzIGEgcm9sbG91dC4KKworICAgICAgICAqIGRm Zy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVK SVQ6OmVtaXRBbGxvY2F0ZVJhd09iamVjdCk6CisgICAgICAgICogcnVudGltZS9KU0FycmF5LmNw cDoKKyAgICAgICAgKEpTQzo6SlNBcnJheTo6dHJ5Q3JlYXRlVW5pbml0aWFsaXplZFJlc3RyaWN0 ZWQpOgorICAgICAgICAqIHJ1bnRpbWUvSlNBcnJheS5oOgorICAgICAgICAoSlNDOjpKU0FycmF5 Ojp0cnlDcmVhdGUpOgorICAgICAgICAqIHJ1bnRpbWUvSlNPYmplY3QuY3BwOgorICAgICAgICAo SlNDOjpKU09iamVjdDo6ZW5zdXJlTGVuZ3RoU2xvdyk6CisKIDIwMTgtMDEtMjMgIEZpbGlwIFBp emxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBKU0Mgc2hvdWxkIHVzZSBhIHNwZWN1 bGF0aW9uIGZlbmNlIG9uIFZNIGVudHJ5L2V4aXQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCShyZXZpc2lvbiAyMjc0MjApCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTQ0LDcgKzE0NCw3IEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmVtaXRBbGxvY2F0 ZVJhd09iamUKICAgICAgICAgc2xvd0Nhc2VzLCB0aGlzLCBvcGVyYXRpb25OZXdSYXdPYmplY3Qs IHJlc3VsdEdQUiwgc3RvcmFnZUdQUiwKICAgICAgICAgc3RydWN0dXJlLCB2ZWN0b3JMZW5ndGgp KTsKIAotICAgIGlmIChudW1FbGVtZW50cyA8IHZlY3Rvckxlbmd0aCAmJiBMSUtFTFkoIWhhc1Vu ZGVjaWRlZChzdHJ1Y3R1cmUtPmluZGV4aW5nVHlwZSgpKSkpIHsKKyAgICBpZiAobnVtRWxlbWVu dHMgPCB2ZWN0b3JMZW5ndGgpIHsKICNpZiBVU0UoSlNWQUxVRTY0KQogICAgICAgICBpZiAoaGFz RG91YmxlKHN0cnVjdHVyZS0+aW5kZXhpbmdUeXBlKCkpKQogICAgICAgICAgICAgbV9qaXQubW92 ZShUcnVzdGVkSW1tNjQoYml0d2lzZV9jYXN0PGludDY0X3Q+KFBOYU4pKSwgc2NyYXRjaEdQUik7 CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmNwcAkocmV2aXNp b24gMjI3NDIwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNBcnJheS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTkxLDcgKzkxLDcgQEAgSlNBcnJheSogSlNBcnJheTo6dHJ5Q3Jl YXRlVW5pbml0aWFsaXplZAogICAgICAgICBpZiAoaGFzRG91YmxlKGluZGV4aW5nVHlwZSkpIHsK ICAgICAgICAgICAgIGZvciAoOyBpIDwgdmVjdG9yTGVuZ3RoOyArK2kpCiAgICAgICAgICAgICAg ICAgYnV0dGVyZmx5LT5jb250aWd1b3VzRG91YmxlKCkuYXQoc3RkOjpudW1lcmljX2xpbWl0czx1 aW50MzJfdD46Om1heCgpLCBpKSA9IFBOYU47Ci0gICAgICAgIH0gZWxzZSBpZiAoTElLRUxZKCFo YXNVbmRlY2lkZWQoaW5kZXhpbmdUeXBlKSkpIHsKKyAgICAgICAgfSBlbHNlIHsKICAgICAgICAg ICAgIGZvciAoOyBpIDwgdmVjdG9yTGVuZ3RoOyArK2kpCiAgICAgICAgICAgICAgICAgYnV0dGVy Zmx5LT5jb250aWd1b3VzKCkuYXQoc3RkOjpudW1lcmljX2xpbWl0czx1aW50MzJfdD46Om1heCgp LCBpKS5jbGVhcigpOwogICAgICAgICB9CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9KU0FycmF5LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvSlNBcnJheS5oCShyZXZpc2lvbiAyMjc0MjApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9KU0FycmF5LmgJKHdvcmtpbmcgY29weSkKQEAgLTI0Nyw3ICsyNDcsNyBAQCBpbmxp bmUgSlNBcnJheSogSlNBcnJheTo6dHJ5Q3JlYXRlKFZNJiB2CiAgICAgICAgIGJ1dHRlcmZseS0+ c2V0UHVibGljTGVuZ3RoKGluaXRpYWxMZW5ndGgpOwogICAgICAgICBpZiAoaGFzRG91YmxlKGlu ZGV4aW5nVHlwZSkpCiAgICAgICAgICAgICBjbGVhckFycmF5KGJ1dHRlcmZseS0+Y29udGlndW91 c0RvdWJsZSgpLmRhdGEoKSwgdmVjdG9yTGVuZ3RoKTsKLSAgICAgICAgZWxzZSBpZiAoTElLRUxZ KCFoYXNVbmRlY2lkZWQoaW5kZXhpbmdUeXBlKSkpCisgICAgICAgIGVsc2UKICAgICAgICAgICAg IGNsZWFyQXJyYXkoYnV0dGVyZmx5LT5jb250aWd1b3VzKCkuZGF0YSgpLCB2ZWN0b3JMZW5ndGgp OwogICAgIH0gZWxzZSB7CiAgICAgICAgIEFTU0VSVCgKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9KU09iamVjdC5jcHAJKHJldmlzaW9uIDIyNzQyMCkKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzIy Miw3ICszMjIyLDcgQEAgYm9vbCBKU09iamVjdDo6ZW5zdXJlTGVuZ3RoU2xvdyhWTSYgdm0sIAog ICAgIGlmIChoYXNEb3VibGUoaW5kZXhpbmdUeXBlKCkpKSB7CiAgICAgICAgIGZvciAodW5zaWdu ZWQgaSA9IG9sZFZlY3Rvckxlbmd0aDsgaSA8IG5ld1ZlY3Rvckxlbmd0aDsgKytpKQogICAgICAg ICAgICAgYnV0dGVyZmx5LT5pbmRleGluZ1BheWxvYWQ8ZG91YmxlPigpW2ldID0gUE5hTjsKLSAg ICB9IGVsc2UgaWYgKExJS0VMWSghaGFzVW5kZWNpZGVkKGluZGV4aW5nVHlwZSgpKSkpIHsKKyAg ICB9IGVsc2UgewogICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSBvbGRWZWN0b3JMZW5ndGg7IGkg PCBuZXdWZWN0b3JMZW5ndGg7ICsraSkKICAgICAgICAgICAgIGJ1dHRlcmZseS0+aW5kZXhpbmdQ YXlsb2FkPFdyaXRlQmFycmllcjxVbmtub3duPj4oKVtpXS5jbGVhcigpOwogICAgIH0K