181992 2018-01-23 10:36:57 -0800 Web Inspector: Window resizing is broken after detaching to separate window 2018-01-23 12:08:41 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer wenson_hsieh oldest_to_newest 1392117 0 joepeck 2018-01-23 10:36:57 -0800 Window resizing is broken after detaching to separate window Steps to Reproduce: 1. Inspect <http://webkit.org> starting with a detached window 2. Attach to bottom 3. Detach 4. Attempt to resize the window => Broken UI Notes: • Resizing works at (1) but is broken at (4) • Attaching the window (2) changes the WKWebView's autoresizingMask • Restoring the autoresizingMask to the initial value behaves as expected 1392118 1 joepeck 2018-01-23 10:37:10 -0800 <rdar://problem/36714840> 1392119 2 332037 joepeck 2018-01-23 10:39:42 -0800 Created attachment 332037 [PATCH] Proposed Fix I suppose an alternative fix would be to put this line in WebInspectorProxyMac::platformCreateFrontendWindow when the view gets added to the window, but I thought this location made more sense, since it balances the changes made in platformAttach with an equivalent property change in platformDetach. 1392161 3 332037 bburg 2018-01-23 11:45:04 -0800 Comment on attachment 332037 [PATCH] Proposed Fix r=me 1392183 4 332037 commit-queue 2018-01-23 12:08:40 -0800 Comment on attachment 332037 [PATCH] Proposed Fix Clearing flags on attachment: 332037 Committed r227429: <https://trac.webkit.org/changeset/227429> 1392184 5 commit-queue 2018-01-23 12:08:41 -0800 All reviewed patches have been landed. Closing bug. 332037 2018-01-23 10:39:42 -0800 2018-01-23 12:08:40 -0800 [PATCH] Proposed Fix resizing-1.patch text/plain 1592 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZmQ1NWQzNzAwYmMuLjI1MzM4YWZlOWNhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE3IEBACisyMDE4LTAxLTIzICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogV2luZG93IHJlc2l6aW5nIGlzIGJyb2tlbiBhZnRl ciBkZXRhY2hpbmcgdG8gc2VwYXJhdGUgd2luZG93CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODE5OTIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM2 NzE0ODQwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVUlQcm9jZXNzL21hYy9XZWJJbnNwZWN0b3JQcm94eU1hYy5tbToKKyAgICAgICAgKFdlYktp dDo6V2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtRGV0YWNoKToKKyAgICAgICAgUmVzdG9yZSB0 aGUgaW5zcGVjdG9yIHZpZXcncyBhdXRvcmVzaXppbmdNYXNrIHRvIHRoZSBpbml0aWFsIHZhbHVl CisgICAgICAgIHRoYXQgd29ya3Mgd2l0aCBhIGRldGFjaGVkIHdpbmRvdy4gVGhpcyBnZXRzIGNo YW5nZWQgd2hlbiB0aGUgdmlldworICAgICAgICBnZXRzIGF0dGFjaGVkIHRvIGJvdHRvbS9zaWRl LCBzbyB3ZSBuZWVkIHRvIHJldmVydCBpdCBvbiBkZXRhY2hpbmcuCisKIDIwMTgtMDEtMjIgIEJy ZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgW21hY09TLCBpT1Nd IEFsbG93IGFjY3NzIHRvIEFWRm91bmRhdGlvbiBwcmVmZXJlbmNlCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW0gYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW0KaW5kZXggODIwZGFm NjU4ZjUuLmE4YmZjMDVlMTkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9t YWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv bWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1tCkBAIC02MDcsNiArNjA3LDggQEAgdm9pZCBXZWJJ bnNwZWN0b3JQcm94eTo6cGxhdGZvcm1EZXRhY2goKQogCiAgICAgW2luc3BlY3RvclZpZXcgcmVt b3ZlRnJvbVN1cGVydmlld107CiAKKyAgICBbaW5zcGVjdG9yVmlldyBzZXRBdXRvcmVzaXppbmdN YXNrOk5TVmlld1dpZHRoU2l6YWJsZSB8IE5TVmlld0hlaWdodFNpemFibGVdOworCiAgICAgLy8g TWFrZSBzdXJlIHRoYXQgd2Ugc2l6ZSB0aGUgaW5zcGVjdGVkIHZpZXcncyBmcmFtZSBhZnRlciBk ZXRhY2hpbmcgc28gdGhhdCBpdCB0YWtlcyB1cCB0aGUgc3BhY2UgdGhhdCB0aGUKICAgICAvLyBh dHRhY2hlZCBpbnNwZWN0b3IgdXNlZCB0by4gUHJlc2VydmUgdGhlIHRvcCBwb3NpdGlvbiBvZiB0 aGUgaW5zcGVjdGVkIHZpZXcgc28gYmFubmVycyBpbiBTYWZhcmkgc3RpbGwgd29yay4KIAo=