181991 2018-01-23 10:09:59 -0800 JSC should use a speculation fence on VM entry/exit 2018-01-23 12:50:47 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo fpizlo benjamin cdumez cmarcelo dbates ews-watchlist jfbastien keith_miller mark.lam msaboff pvollan saam webkit-bug-importer oldest_to_newest 1392103 0 fpizlo 2018-01-23 10:09:59 -0800 Patch forthcoming. 1392104 1 332035 fpizlo 2018-01-23 10:12:04 -0800 Created attachment 332035 the patch 1392105 2 fpizlo 2018-01-23 10:12:11 -0800 <rdar://problem/36304751> 1392106 3 webkit-bug-importer 2018-01-23 10:12:48 -0800 <rdar://problem/36781062> 1392107 4 332035 jfbastien 2018-01-23 10:16:46 -0800 Comment on attachment 332035 the patch r=me 1392109 5 332035 mark.lam 2018-01-23 10:17:21 -0800 Comment on attachment 332035 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=332035&action=review > Source/JavaScriptCore/ChangeLog:10 > + For a microbenchmark that just calls a native function (supplied via a Objective-C block) in a /a Objective-C/an Objective-C/. > Source/JavaScriptCore/ChangeLog:11 > + tight loop from JS is a 0% regression on x86 and a 11% regression on ARM64. I suggest /JS is a 0%/JS, performance shows a 0%/. 1392115 6 fpizlo 2018-01-23 10:30:13 -0800 Landed in https://trac.webkit.org/changeset/227424/webkit 1392205 7 332035 saam 2018-01-23 12:39:24 -0800 Comment on attachment 332035 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=332035&action=review > Source/WTF/wtf/Atomics.h:285 > +#if !OS(WINDOWS) Should we have someone who works on Windows implement this for them? 1392210 8 332035 saam 2018-01-23 12:42:31 -0800 Comment on attachment 332035 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=332035&action=review > Source/JavaScriptCore/runtime/JSLock.cpp:126 > + WTF::speculationFence(); Do we not want this for entry/exit in and out of other native code. E.g, WebCore bindings? 332035 2018-01-23 10:12:04 -0800 2018-01-23 10:16:46 -0800 the patch blah.patch text/plain 3763 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI3NDIyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE4LTAxLTIzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg SlNDIHNob3VsZCB1c2UgYSBzcGVjdWxhdGlvbiBmZW5jZSBvbiBWTSBlbnRyeS9leGl0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODE5OTEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFRoaXMg YWRkcyBhIFdURjo6c3BlY3VsYXRpb25GZW5jZSBvbiBWTSBlbnRyeSBhbmQgZXhpdC4KKyAgICAg ICAgCisgICAgICAgIEZvciBhIG1pY3JvYmVuY2htYXJrIHRoYXQganVzdCBjYWxscyBhIG5hdGl2 ZSBmdW5jdGlvbiAoc3VwcGxpZWQgdmlhIGEgT2JqZWN0aXZlLUMgYmxvY2spIGluIGEKKyAgICAg ICAgdGlnaHQgbG9vcCBmcm9tIEpTIGlzIGEgMCUgcmVncmVzc2lvbiBvbiB4ODYgYW5kIGEgMTEl IHJlZ3Jlc3Npb24gb24gQVJNNjQuCisgICAgICAgIAorICAgICAgICAqIHJ1bnRpbWUvSlNMb2Nr LmNwcDoKKyAgICAgICAgKEpTQzo6SlNMb2NrOjpkaWRBY3F1aXJlTG9jayk6CisgICAgICAgIChK U0M6OkpTTG9jazo6d2lsbFJlbGVhc2VMb2NrKToKKwogMjAxOC0wMS0yMyAgWXVzdWtlIFN1enVr aSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBbSlNDXSBKSVQgcmVxdWlyZXMg c2l6ZW9mKGJvb2wpID09IDEKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pT TG9jay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNM b2NrLmNwcAkocmV2aXNpb24gMjI3NDE1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvSlNMb2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTIzLDYgKzEyMyw4IEBAIHZvaWQgSlNM b2NrOjpsb2NrKGludHB0cl90IGxvY2tDb3VudCkKIAogdm9pZCBKU0xvY2s6OmRpZEFjcXVpcmVM b2NrKCkKIHsKKyAgICBXVEY6OnNwZWN1bGF0aW9uRmVuY2UoKTsKKyAgICAKICAgICAvLyBGSVhN RTogV2hhdCBzaG91bGQgaGFwcGVuIHRvIHRoZSBwZXItdGhyZWFkIGlkZW50aWZpZXIgdGFibGUg aWYgd2UgZG9uJ3QgaGF2ZSBhIFZNPwogICAgIGlmICghbV92bSkKICAgICAgICAgcmV0dXJuOwpA QCAtMTkxLDYgKzE5Myw4IEBAIHZvaWQgSlNMb2NrOjp1bmxvY2soaW50cHRyX3QgdW5sb2NrQ291 bnQKIAogdm9pZCBKU0xvY2s6OndpbGxSZWxlYXNlTG9jaygpCiB7CisgICAgV1RGOjpzcGVjdWxh dGlvbkZlbmNlKCk7CisgICAgCiAgICAgUmVmUHRyPFZNPiB2bSA9IG1fdm07CiAgICAgaWYgKHZt KSB7CiAgICAgICAgIHZtLT5kcmFpbk1pY3JvdGFza3MoKTsKSW5kZXg6IFNvdXJjZS9XVEYvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjc0 MTUpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3 IEBACisyMDE4LTAxLTIzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAg ICAgSlNDIHNob3VsZCB1c2UgYSBzcGVjdWxhdGlvbiBmZW5jZSBvbiBWTSBlbnRyeS9leGl0Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODE5OTEKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIElt cGxlbWVudCBzcGVjdWxhdGlvbkZlbmNlIGFzIGxmZW5jZSBvbiB4ODYgYW5kIGlzYiBvbiBBUk02 NC4gSSdtIG5vdCBzdXJlIGlmIGlzYiBpcworICAgICAgICBhcHByb3ByaWF0ZSBmb3IgYWxsIEFS TTY0J3MuCisKKyAgICAgICAgKiB3dGYvQXRvbWljcy5oOgorICAgICAgICAoV1RGOjpzcGVjdWxh dGlvbkZlbmNlKToKKyAgICAgICAgKFdURjo6eDg2X2xmZW5jZSk6CisKIDIwMTgtMDEtMjIgIEFs ZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBCZWdp biByZW1vdmluZyBRVEtpdCBjb2RlCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9BdG9taWNzLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dURi93dGYvQXRvbWljcy5oCShyZXZpc2lvbiAyMjc0MTUpCisr KyBTb3VyY2UvV1RGL3d0Zi9BdG9taWNzLmgJKHdvcmtpbmcgY29weSkKQEAgLTI3Niw5ICsyNzYs MTcgQEAgaW5saW5lIHZvaWQgc3RvcmVTdG9yZUZlbmNlKCkgeyBhcm1fZG1iXwogaW5saW5lIHZv aWQgbWVtb3J5QmFycmllckFmdGVyTG9jaygpIHsgYXJtX2RtYigpOyB9CiBpbmxpbmUgdm9pZCBt ZW1vcnlCYXJyaWVyQmVmb3JlVW5sb2NrKCkgeyBhcm1fZG1iKCk7IH0KIGlubGluZSB2b2lkIGNy b3NzTW9kaWZ5aW5nQ29kZUZlbmNlKCkgeyBhcm1faXNiKCk7IH0KK2lubGluZSB2b2lkIHNwZWN1 bGF0aW9uRmVuY2UoKSB7IGFybV9pc2IoKTsgfQogCiAjZWxpZiBDUFUoWDg2KSB8fCBDUFUoWDg2 XzY0KQogCitpbmxpbmUgdm9pZCB4ODZfbGZlbmNlKCkKK3sKKyNpZiAhT1MoV0lORE9XUykKKyAg ICBhc20gdm9sYXRpbGUoImxmZW5jZSIgOjo6ICJtZW1vcnkiKTsKKyNlbmRpZgorfQorCiBpbmxp bmUgdm9pZCB4ODZfb3J0b3AoKQogewogI2lmIE9TKFdJTkRPV1MpCkBAIC0zMjYsNiArMzM0LDcg QEAgaW5saW5lIHZvaWQgc3RvcmVTdG9yZUZlbmNlKCkgeyBjb21waWxlcgogaW5saW5lIHZvaWQg bWVtb3J5QmFycmllckFmdGVyTG9jaygpIHsgY29tcGlsZXJGZW5jZSgpOyB9CiBpbmxpbmUgdm9p ZCBtZW1vcnlCYXJyaWVyQmVmb3JlVW5sb2NrKCkgeyBjb21waWxlckZlbmNlKCk7IH0KIGlubGlu ZSB2b2lkIGNyb3NzTW9kaWZ5aW5nQ29kZUZlbmNlKCkgeyB4ODZfY3B1aWQoKTsgfQoraW5saW5l IHZvaWQgc3BlY3VsYXRpb25GZW5jZSgpIHsgeDg2X2xmZW5jZSgpOyB9CiAKICNlbHNlCiAKQEAg LTMzNiw2ICszNDUsNyBAQCBpbmxpbmUgdm9pZCBzdG9yZVN0b3JlRmVuY2UoKSB7IHN0ZDo6YXRv CiBpbmxpbmUgdm9pZCBtZW1vcnlCYXJyaWVyQWZ0ZXJMb2NrKCkgeyBzdGQ6OmF0b21pY190aHJl YWRfZmVuY2Uoc3RkOjptZW1vcnlfb3JkZXJfc2VxX2NzdCk7IH0KIGlubGluZSB2b2lkIG1lbW9y eUJhcnJpZXJCZWZvcmVVbmxvY2soKSB7IHN0ZDo6YXRvbWljX3RocmVhZF9mZW5jZShzdGQ6Om1l bW9yeV9vcmRlcl9zZXFfY3N0KTsgfQogaW5saW5lIHZvaWQgY3Jvc3NNb2RpZnlpbmdDb2RlRmVu Y2UoKSB7IHN0ZDo6YXRvbWljX3RocmVhZF9mZW5jZShzdGQ6Om1lbW9yeV9vcmRlcl9zZXFfY3N0 KTsgfSAvLyBQcm9iYWJseSBub3Qgc3Ryb25nIGVub3VnaC4KK2lubGluZSB2b2lkIHNwZWN1bGF0 aW9uRmVuY2UoKSB7IH0gLy8gUHJvYmFibHkgbm90IHN0cm9uZyBlbm91Z2guCiAKICNlbmRpZgog Cg==