181939 2018-01-22 12:31:57 -0800 AudioBufferSourceNode start method causes OfflineAudioContext to start running 2018-04-02 08:40:26 -0700 1 1 1 Unclassified WebKit Web Audio Safari 11 iPhone / iPad iOS 11 RESOLVED FIXED InRadar P2 Major --- 1 yotammann jer.noble commit-queue eric.carlson jer.noble spwilliamsiam webkit-bug-importer yotammann oldest_to_newest 1391746 0 yotammann 2018-01-22 12:31:57 -0800 The OfflineAudioContext.state should be "suspended" and not increment the currentTime until `startRendering` is invoked. The issue is that as soon as AudioBufferSourceNode.start is invoked, the OfflineAudioContext.state returns "running" and the OfflineAudioContext.currentTime starts incrementing usually much faster than real time. This makes it impossible to schedule anything after an AudioBufferSourceNode is started since the scheduled time will usually be in the past. Test case: https://jsfiddle.net/3h8e3bcg/ Should print to the console: "should be suspended: suspended" then "should still be suspended: suspended" PASSES on Chrome, Firefox and Safari 11 on Desktop. FAILS on Safari on iOS 11. prints: "should be suspended: suspended" then "should still be suspended: running" 1391881 1 webkit-bug-importer 2018-01-22 16:56:58 -0800 <rdar://problem/36755393> 1409212 2 spwilliamsiam 2018-03-25 14:40:50 -0700 =---------------------------= F I X S O O N P L E A S E F I X S O O N P L E A S E F I X S O O N P L E A S E =---------------------------= But really, please do fix soon, as this bug is SO ANNOYING!!! https://jsfiddle.net/ayunami2000/c5xdL6xL/ This is where I discovered the bug. Everything else in the JSFiddle works, but offlineAudioContext's oncomplete event never fires. Also, https://codepen.io/tomduncalf/pen/GmvPNp works on iOS!!! =---------------------------= F I X S O O N P L E A S E F I X S O O N P L E A S E F I X S O O N P L E A S E =---------------------------= 1409340 3 336527 jer.noble 2018-03-26 11:14:07 -0700 Created attachment 336527 Patch 1409552 4 336527 eric.carlson 2018-03-27 08:52:00 -0700 Comment on attachment 336527 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336527&action=review > LayoutTests/webaudio/offlineaudiocontext-restriction.html:18 > +var calledResumeWithUserGesture = false; Nit: this isn't used. 1411085 5 336527 commit-queue 2018-04-02 08:40:25 -0700 Comment on attachment 336527 Patch Clearing flags on attachment: 336527 Committed r230158: <https://trac.webkit.org/changeset/230158> 1411086 6 commit-queue 2018-04-02 08:40:26 -0700 All reviewed patches have been landed. Closing bug. 336527 2018-03-26 11:14:07 -0700 2018-04-02 08:40:25 -0700 Patch bug-181939-20180326111406.patch text/plain 6245 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODA2NjAxMTY3MGVkY2Nm ODNjODEwZGM2ZDgxNDliYTNkYjkzNWEzZi4uMDMzY2UzOGRjN2ZhNzg4ZGMzZDFiNDVkNjk0ZGMy Nzg0OWJlMGRkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE4LTAzLTI2ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIEF1ZGlvQnVmZmVyU291cmNl Tm9kZSBzdGFydCBtZXRob2QgY2F1c2VzIE9mZmxpbmVBdWRpb0NvbnRleHQgdG8gc3RhcnQgcnVu bmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgx OTM5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNjc1NTM5Mz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiB3ZWJhdWRpby9vZmZsaW5lYXVk aW9jb250ZXh0LXJlc3RyaWN0aW9uLmh0bWwKKworICAgICAgICBEb24ndCByZXNwZWN0IHBsYXli YWNrIHJlc3RyaWN0aW9ucyBmb3Igb2ZmbGluZSBBdWRpb0NvbnRleHRzLgorCisgICAgICAgICog TW9kdWxlcy93ZWJhdWRpby9BdWRpb0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXVk aW9Db250ZXh0Ojpjb25zdHJ1Y3RDb21tb24pOgorICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8v QXVkaW9Db250ZXh0Lmg6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb0NvbnRleHQ6OmlzT2ZmbGlu ZUNvbnRleHQgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9Db250ZXh0Ojp1c2VyR2Vz dHVyZVJlcXVpcmVkRm9yQXVkaW9TdGFydCBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpBdWRp b0NvbnRleHQ6OnBhZ2VDb25zZW50UmVxdWlyZWRGb3JBdWRpb1N0YXJ0IGNvbnN0KToKKyAgICAg ICAgKFdlYkNvcmU6OkF1ZGlvQ29udGV4dDo6aXNPZmZsaW5lQ29udGV4dCk6IERlbGV0ZWQuCisK IDIwMTgtMDMtMTYgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAg TWFrZSBGdWxsc2NyZWVuIEFQSSBhbiBFeHBlcmltZW50YWwgRmVhdHVyZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb0NvbnRleHQuY3BwIGIvU291cmNl L1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb0NvbnRleHQuY3BwCmluZGV4IGRjNjQ2MmIy ODAwM2FjMzFkZGE3N2Q5Mzk4ZDkwMTE4MjY0MzZkNjEuLjViYjJiMDM2YjZkYTFhMjE0YmE2MGEx MWY2MDQxNGRlMTY2Y2M1ZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2Vi YXVkaW8vQXVkaW9Db250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1 ZGlvL0F1ZGlvQ29udGV4dC5jcHAKQEAgLTE2NiwxMiArMTY2LDEwIEBAIHZvaWQgQXVkaW9Db250 ZXh0Ojpjb25zdHJ1Y3RDb21tb24oKQogICAgIAogICAgIG1fbGlzdGVuZXIgPSBBdWRpb0xpc3Rl bmVyOjpjcmVhdGUoKTsKIAotI2lmIFBMQVRGT1JNKElPUykKLSAgICBpZiAoZG9jdW1lbnQoKS0+ c2V0dGluZ3MoKS5hdWRpb1BsYXliYWNrUmVxdWlyZXNVc2VyR2VzdHVyZSgpKQorICAgIGlmIChk b2N1bWVudCgpLT5hdWRpb1BsYXliYWNrUmVxdWlyZXNVc2VyR2VzdHVyZSgpKQogICAgICAgICBh ZGRCZWhhdmlvclJlc3RyaWN0aW9uKFJlcXVpcmVVc2VyR2VzdHVyZUZvckF1ZGlvU3RhcnRSZXN0 cmljdGlvbik7CiAgICAgZWxzZQogICAgICAgICBtX3Jlc3RyaWN0aW9ucyA9IE5vUmVzdHJpY3Rp b25zOwotI2VuZGlmCiAKICNpZiBQTEFURk9STShDT0NPQSkKICAgICBhZGRCZWhhdmlvclJlc3Ry aWN0aW9uKFJlcXVpcmVQYWdlQ29uc2VudEZvckF1ZGlvU3RhcnRSZXN0cmljdGlvbik7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQ29udGV4dC5oIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb0NvbnRleHQuaAppbmRleCAwY2Mw NzdmOWUxMmVlNTc3NjY4MWUxNjQyOGYzODNjZmRmMjYzYzUxLi4yYjhhMmIxMDhjZDBkMWFkZmU4 ZmI5MTJiZmVkMmQzZjlhMWM4MzNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L3dlYmF1ZGlvL0F1ZGlvQ29udGV4dC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2Vi YXVkaW8vQXVkaW9Db250ZXh0LmgKQEAgLTg1LDcgKzg1LDcgQEAgcHVibGljOgogCiAgICAgYm9v bCBpc0luaXRpYWxpemVkKCkgY29uc3Q7CiAgICAgCi0gICAgYm9vbCBpc09mZmxpbmVDb250ZXh0 KCkgeyByZXR1cm4gbV9pc09mZmxpbmVDb250ZXh0OyB9CisgICAgYm9vbCBpc09mZmxpbmVDb250 ZXh0KCkgY29uc3QgeyByZXR1cm4gbV9pc09mZmxpbmVDb250ZXh0OyB9CiAKICAgICBEb2N1bWVu dCogZG9jdW1lbnQoKSBjb25zdDsgLy8gQVNTRVJUcyBpZiBkb2N1bWVudCBubyBsb25nZXIgZXhp c3RzLgogCkBAIC0yNzYsOCArMjc2LDggQEAgcHJpdmF0ZToKICAgICBib29sIHdpbGxCZWdpblBs YXliYWNrKCk7CiAgICAgYm9vbCB3aWxsUGF1c2VQbGF5YmFjaygpOwogCi0gICAgYm9vbCB1c2Vy R2VzdHVyZVJlcXVpcmVkRm9yQXVkaW9TdGFydCgpIGNvbnN0IHsgcmV0dXJuIG1fcmVzdHJpY3Rp b25zICYgUmVxdWlyZVVzZXJHZXN0dXJlRm9yQXVkaW9TdGFydFJlc3RyaWN0aW9uOyB9Ci0gICAg Ym9vbCBwYWdlQ29uc2VudFJlcXVpcmVkRm9yQXVkaW9TdGFydCgpIGNvbnN0IHsgcmV0dXJuIG1f cmVzdHJpY3Rpb25zICYgUmVxdWlyZVBhZ2VDb25zZW50Rm9yQXVkaW9TdGFydFJlc3RyaWN0aW9u OyB9CisgICAgYm9vbCB1c2VyR2VzdHVyZVJlcXVpcmVkRm9yQXVkaW9TdGFydCgpIGNvbnN0IHsg cmV0dXJuICFpc09mZmxpbmVDb250ZXh0KCkgJiYgbV9yZXN0cmljdGlvbnMgJiBSZXF1aXJlVXNl ckdlc3R1cmVGb3JBdWRpb1N0YXJ0UmVzdHJpY3Rpb247IH0KKyAgICBib29sIHBhZ2VDb25zZW50 UmVxdWlyZWRGb3JBdWRpb1N0YXJ0KCkgY29uc3QgeyByZXR1cm4gIWlzT2ZmbGluZUNvbnRleHQo KSAmJiBtX3Jlc3RyaWN0aW9ucyAmIFJlcXVpcmVQYWdlQ29uc2VudEZvckF1ZGlvU3RhcnRSZXN0 cmljdGlvbjsgfQogCiAgICAgdm9pZCBzZXRTdGF0ZShTdGF0ZSk7CiAKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA3MWFiMTFi OTg2MTBhNDVhNThhMjk4NjhiNDlhZDlkZThjNjU0NWEzLi5kMzYyYjVjYzZmOWRiMGRhYmNiODgx NDA2YTFmMDNmYWM0N2JhYzM4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysr IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMDMtMjYgIEpl ciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgQXVkaW9CdWZmZXJTb3Vy Y2VOb2RlIHN0YXJ0IG1ldGhvZCBjYXVzZXMgT2ZmbGluZUF1ZGlvQ29udGV4dCB0byBzdGFydCBy dW5uaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x ODE5MzkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM2NzU1MzkzPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd2ViYXVkaW8vb2ZmbGluZWF1ZGlv Y29udGV4dC1yZXN0cmljdGlvbi1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHdlYmF1 ZGlvL29mZmxpbmVhdWRpb2NvbnRleHQtcmVzdHJpY3Rpb24uaHRtbDogQWRkZWQuCisKIDIwMTgt MDMtMjEgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVT U0lPTiAocjIyNjA1OT8pOiBbbWFjT1MgV0syXSBMYXlvdXQgVGVzdCBmYXN0L21lZGlhc3RyZWFt L01lZGlhU3RyZWFtLU1lZGlhRWxlbWVudC1zZXRPYmplY3QtbnVsbC5odG1sIGlzIGZsYWt5CmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy93ZWJhdWRpby9vZmZsaW5lYXVkaW9jb250ZXh0LXJlc3Ry aWN0aW9uLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3dlYmF1ZGlvL29mZmxpbmVhdWRpb2Nv bnRleHQtcmVzdHJpY3Rpb24tZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmM5Y2NmNGVjOGU5ZmM1 YmU3MTU0MTVmODk5OTY5MDQ1ZWY5NjhiOWIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy93ZWJhdWRpby9vZmZsaW5lYXVkaW9jb250ZXh0LXJlc3RyaWN0aW9uLWV4cGVjdGVkLnR4dApA QCAtMCwwICsxLDE0IEBACitPZmZsaW5lQXVkaW9Db250ZXh0cyBzaG91bGQgbm90IGhhdmUgYmVo YXZpb3IgcmVzdHJpY3Rpb25zLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMg b2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKK1BBU1Mg Y29udGV4dC5zdGF0ZSBpcyAic3VzcGVuZGVkIgorbm9kZS5jb25uZWN0KGNvbnRleHQuZGVzdGlu YXRpb24pCitub2RlLnN0YXJ0KCkKK1BBU1MgY29udGV4dC5zdGF0ZSBpcyAic3VzcGVuZGVkIgor Q2FsbGluZyBjb250ZXh0LnN0YXJ0UmVuZGVyaW5nKCkgd2l0aG91dCBhIHVzZXIgZ2VzdHVyZQor UEFTUyBjb250ZXh0LnN0YXRlIGlzICJydW5uaW5nIgorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQg aXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3dlYmF1 ZGlvL29mZmxpbmVhdWRpb2NvbnRleHQtcmVzdHJpY3Rpb24uaHRtbCBiL0xheW91dFRlc3RzL3dl YmF1ZGlvL29mZmxpbmVhdWRpb2NvbnRleHQtcmVzdHJpY3Rpb24uaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5m OWQ2YTZmOThhYzJhYTY4ODg5M2FhZTA3ZGQzNTAzZjM0ZjE1YTI1Ci0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvd2ViYXVkaW8vb2ZmbGluZWF1ZGlvY29udGV4dC1yZXN0cmljdGlvbi5o dG1sCkBAIC0wLDAgKzEsNDUgQEAKKzwhRE9DVFlQRSBodG1sPgorCis8aHRtbD4KKzxoZWFkPgor PHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9qcy10ZXN0LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQg dHlwZT0idGV4dC9qYXZhc2NyaXB0IiBzcmM9InJlc291cmNlcy9hdWRpby10ZXN0aW5nLmpzIj48 L3NjcmlwdD4KKzwvaGVhZD4KKworPGJvZHk+Cis8ZGl2IGlkPSJkZXNjcmlwdGlvbiI+PC9kaXY+ Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKworPHNjcmlwdD4KK2Rlc2NyaXB0aW9uKCdPZmZs aW5lQXVkaW9Db250ZXh0cyBzaG91bGQgbm90IGhhdmUgYmVoYXZpb3IgcmVzdHJpY3Rpb25zLicp OworCit2YXIgY29udGV4dCA9IG51bGw7Cit2YXIgbm9kZSA9IG51bGw7Cit2YXIgY2FsbGVkUmVz dW1lV2l0aFVzZXJHZXN0dXJlID0gZmFsc2U7CisKK2Z1bmN0aW9uIHJ1blRlc3QoKSB7CisgICAg d2luZG93LmpzVGVzdElzQXN5bmMgPSB0cnVlOworCisgICAgY29udGV4dCA9IG5ldyB3ZWJraXRP ZmZsaW5lQXVkaW9Db250ZXh0KDIsIDEwMDAsIDQ0MTAwKTsKKworICAgIGlmICh3aW5kb3cuaW50 ZXJuYWxzKQorICAgICAgICBpbnRlcm5hbHMuc2V0QXVkaW9Db250ZXh0UmVzdHJpY3Rpb25zKGNv bnRleHQsICdSZXF1aXJlVXNlckdlc3R1cmVGb3JBdWRpb1N0YXJ0Jyk7CisKKyAgICBzaG91bGRC ZSgnY29udGV4dC5zdGF0ZScsICcic3VzcGVuZGVkIicpOworCisgICAgbm9kZSA9IGNvbnRleHQu Y3JlYXRlQnVmZmVyU291cmNlKCk7CisgICAgZXZhbEFuZExvZygnbm9kZS5jb25uZWN0KGNvbnRl eHQuZGVzdGluYXRpb24pJyk7CisgICAgZXZhbEFuZExvZygnbm9kZS5zdGFydCgpJyk7CisgICAg c2hvdWxkQmUoJ2NvbnRleHQuc3RhdGUnLCAnInN1c3BlbmRlZCInKTsKKworICAgIGRlYnVnKCdD YWxsaW5nIGNvbnRleHQuc3RhcnRSZW5kZXJpbmcoKSB3aXRob3V0IGEgdXNlciBnZXN0dXJlJyk7 CisgICAgY29udGV4dC5zdGFydFJlbmRlcmluZygpOworICAgIHNob3VsZEJlKCdjb250ZXh0LnN0 YXRlJywgJyJydW5uaW5nIicpOworICAgIGZpbmlzaEpTVGVzdCgpOworfQorCitydW5UZXN0KCk7 CisKKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=