181932 2018-01-22 05:01:08 -0800 StyleBench: Separate test for :nth pseudo classes 2018-01-22 12:22:21 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned cdumez commit-queue ews-watchlist rniwa sam webkit-bug-importer zalan oldest_to_newest 1391600 0 koivisto 2018-01-22 05:01:08 -0800 Optimization strategies for nth are different from other structural pseudo classes (:first-child etc). Move them to a separate test. 1391601 1 331916 koivisto 2018-01-22 05:03:40 -0800 Created attachment 331916 patch 1391736 2 331916 commit-queue 2018-01-22 12:18:38 -0800 Comment on attachment 331916 patch Clearing flags on attachment: 331916 Committed r227347: <https://trac.webkit.org/changeset/227347> 1391737 3 commit-queue 2018-01-22 12:18:40 -0800 All reviewed patches have been landed. Closing bug. 1391740 4 webkit-bug-importer 2018-01-22 12:22:21 -0800 <rdar://problem/36743864> 331916 2018-01-22 05:03:40 -0800 2018-01-22 12:18:38 -0800 patch stylebench-separate-nth.patch text/plain 2798 koivisto SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjcyODgpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE4LTAxLTIyICBB bnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBTdHlsZUJlbmNoOiBT ZXBhcmF0ZSB0ZXN0IGZvciA6bnRoIHBzZXVkbyBjbGFzc2VzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODE5MzIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPcHRpbWl6YXRpb24gc3RyYXRlZ2llcyBmb3Ig bnRoIGFyZSBkaWZmZXJlbnQgZnJvbSBvdGhlciBzdHJ1Y3R1cmFsIHBzZXVkbyBjbGFzc2VzICg6 Zmlyc3QtY2hpbGQgZXRjKS4gTW92ZSB0aGVtIHRvIGEgc2VwYXJhdGUgdGVzdC4KKworICAgICAg ICAqIFN0eWxlQmVuY2gvcmVzb3VyY2VzL3N0eWxlLWJlbmNoLmpzOgorICAgICAgICAoc3RydWN0 dXJhbFBzZXVkb0NsYXNzQ29uZmlndXJhdGlvbik6CisgICAgICAgIChudGhQc2V1ZG9DbGFzc0Nv bmZpZ3VyYXRpb24pOgorCisgICAgICAgICAgICBBZGQgYSBuZXcgY29uZmlndXJhdGlvbi4KKwor ICAgICAgICAocHJlZGVmaW5lZENvbmZpZ3VyYXRpb25zKToKKyAgICAgICAgKHBzZXVkb0NsYXNz Q29uZmlndXJhdGlvbik6IERlbGV0ZWQuCisKIDIwMTgtMDEtMTcgIFJ5b3N1a2UgTml3YSAgPHJu aXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVGVtcG9yYXJpbHkgc2tpcCBTcGVlZG9tZXRlciB1 bnRpbCB3ZSBmaXggdGhlIG1ldHJpY3MuCkluZGV4OiBQZXJmb3JtYW5jZVRlc3RzL1N0eWxlQmVu Y2gvcmVzb3VyY2VzL3N0eWxlLWJlbmNoLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1hbmNlVGVz dHMvU3R5bGVCZW5jaC9yZXNvdXJjZXMvc3R5bGUtYmVuY2guanMJKHJldmlzaW9uIDIyNzI4NykK KysrIFBlcmZvcm1hbmNlVGVzdHMvU3R5bGVCZW5jaC9yZXNvdXJjZXMvc3R5bGUtYmVuY2guanMJ KHdvcmtpbmcgY29weSkKQEAgLTgzLDE2ICs4MywxMiBAQCBjbGFzcyBTdHlsZUJlbmNoCiAgICAg ICAgIH0pOwogICAgIH0KIAotICAgIHN0YXRpYyBwc2V1ZG9DbGFzc0NvbmZpZ3VyYXRpb24oKQor ICAgIHN0YXRpYyBzdHJ1Y3R1cmFsUHNldWRvQ2xhc3NDb25maWd1cmF0aW9uKCkKICAgICB7CiAg ICAgICAgIHJldHVybiBPYmplY3QuYXNzaWduKHRoaXMuZGVmYXVsdENvbmZpZ3VyYXRpb24oKSwg ewotICAgICAgICAgICAgbmFtZTogJ1Bvc2l0aW9uYWwgcHNldWRvIGNsYXNzZXMnLAorICAgICAg ICAgICAgbmFtZTogJ1N0cnVjdHVyYWwgcHNldWRvIGNsYXNzZXMnLAogICAgICAgICAgICAgcHNl dWRvQ2xhc3NDaGFuY2U6IDAuMSwKICAgICAgICAgICAgIHBzZXVkb0NsYXNzZXM6IFsKLSAgICAg ICAgICAgICAgICAnbnRoLWNoaWxkKDJuKzEpJywKLSAgICAgICAgICAgICAgICAnbnRoLWxhc3Qt Y2hpbGQoM24pJywKLSAgICAgICAgICAgICAgICAnbnRoLW9mLXR5cGUoM24pJywKLSAgICAgICAg ICAgICAgICAnbnRoLWxhc3Qtb2YtdHlwZSg0biknLAogICAgICAgICAgICAgICAgICdmaXJzdC1j aGlsZCcsCiAgICAgICAgICAgICAgICAgJ2xhc3QtY2hpbGQnLAogICAgICAgICAgICAgICAgICdm aXJzdC1vZi10eXBlJywKQEAgLTEwMyw2ICs5OSwyMCBAQCBjbGFzcyBTdHlsZUJlbmNoCiAgICAg ICAgIH0pOwogICAgIH0KIAorICAgIHN0YXRpYyBudGhQc2V1ZG9DbGFzc0NvbmZpZ3VyYXRpb24o KQorICAgIHsKKyAgICAgICAgcmV0dXJuIE9iamVjdC5hc3NpZ24odGhpcy5kZWZhdWx0Q29uZmln dXJhdGlvbigpLCB7CisgICAgICAgICAgICBuYW1lOiAnOm50aCBwc2V1ZG8gY2xhc3NlcycsCisg ICAgICAgICAgICBwc2V1ZG9DbGFzc0NoYW5jZTogMC4xLAorICAgICAgICAgICAgcHNldWRvQ2xh c3NlczogWworICAgICAgICAgICAgICAgICdudGgtY2hpbGQoMm4rMSknLAorICAgICAgICAgICAg ICAgICdudGgtbGFzdC1jaGlsZCgzbiknLAorICAgICAgICAgICAgICAgICdudGgtb2YtdHlwZSgz biknLAorICAgICAgICAgICAgICAgICdudGgtbGFzdC1vZi10eXBlKDRuKScsCisgICAgICAgICAg ICBdLAorICAgICAgICB9KTsKKyAgICB9CisKICAgICBzdGF0aWMgYmVmb3JlQW5kQWZ0ZXJDb25m aWd1cmF0aW9uKCkKICAgICB7CiAgICAgICAgIHJldHVybiBPYmplY3QuYXNzaWduKHRoaXMuZGVm YXVsdENvbmZpZ3VyYXRpb24oKSwgewpAQCAtMTE2LDcgKzEyNiw4IEBAIGNsYXNzIFN0eWxlQmVu Y2gKICAgICAgICAgcmV0dXJuIFsKICAgICAgICAgICAgIHRoaXMuZGVzY2VuZGFudENvbWJpbmF0 b3JDb25maWd1cmF0aW9uKCksCiAgICAgICAgICAgICB0aGlzLnNpYmxpbmdDb21iaW5hdG9yQ29u ZmlndXJhdGlvbigpLAotICAgICAgICAgICAgdGhpcy5wc2V1ZG9DbGFzc0NvbmZpZ3VyYXRpb24o KSwKKyAgICAgICAgICAgIHRoaXMuc3RydWN0dXJhbFBzZXVkb0NsYXNzQ29uZmlndXJhdGlvbigp LAorICAgICAgICAgICAgdGhpcy5udGhQc2V1ZG9DbGFzc0NvbmZpZ3VyYXRpb24oKSwKICAgICAg ICAgICAgIHRoaXMuYmVmb3JlQW5kQWZ0ZXJDb25maWd1cmF0aW9uKCksCiAgICAgICAgIF07CiAg ICAgfQo=