181912 2018-01-20 17:41:57 -0800 Uncaught Exception: TypeError: this._textEditor.toggleUnexecutedCodeHighlights().then is not a function 2018-03-22 18:00:50 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 183887 1 nvasilyev nvasilyev commit-queue inspector-bugzilla-changes mattbaker webkit-bug-importer oldest_to_newest 1391436 0 nvasilyev 2018-01-20 17:41:57 -0800 ------- Inspected URL: file:///tmp/slow-console.html Loading completed: true Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/605.1.16+ (KHTML, like Gecko) Uncaught Exceptions: - TypeError: this._textEditor.toggleUnexecutedCodeHighlights().then is not a function. (In 'this._textEditor.toggleUnexecutedCodeHighlights().then(() => { this._codeCoverageButtonNavigationItem.enabled = true; })', 'this._textEditor.toggleUnexecutedCodeHighlights().then' is undefined) (at TextResourceContentView.js:238:63) _toggleUnexecutedCodeHighlights @ TextResourceContentView.js:238:63 dispatch @ Object.js:170:30 dispatchEventToListeners @ Object.js:177:17 _mouseClicked @ ButtonNavigationItem.js:138:38 _mouseClicked @ [native code] ------- * STEPS TO REPRODUCE 1. Save http://nv.github.io/webkit-inspector-bugs/slow-console/ locally so its JS can be edited in Web Inspector. 2. Open the saved HTML page using the file scheme. 3. Edit index.js (e.g. add a comment) 4. Press on the [c] icon to enable code coverage profiler. Expected: It's fine if [c] gets grayed out after editing a script so it can't be enabled. 1391437 1 webkit-bug-importer 2018-01-20 17:42:15 -0800 <rdar://problem/36700022> 1408267 2 nvasilyev 2018-03-21 18:48:50 -0700 This is poorly architectured (likely by me 3 years ago). The [c] icon can only have 3 states: - gray: disabled, can't be activated. - black: not activated. - blue: activated. The icon updates on setting change. The setting can only have two states: - enabled. - disabled. The setting change is used to update the icon state. Which is wrong, it doesn't even have all 3 states. The setting should only indicate user preference: enabled (when possible) and disabled. Instead, the setting is user as a communication channel to set the icon to deactivated state. Currently, the setting gets set to disabled when: - Enabling pretty-print. - Editing a script. Pretty-printing and editing shouldn't change the setting, yet these actions should set the icon to disabled state. 1408274 3 nvasilyev 2018-03-21 18:59:32 -0700 (In reply to Nikita Vasilyev from comment #2) > The icon updates on setting change. The setting can only have two states: > - enabled. > - disabled. To clarify, by the setting I mean WI.enableControlFlowProfilerSetting object. It's not related to the settings GUI. 1408283 4 336257 nvasilyev 2018-03-21 19:47:57 -0700 Created attachment 336257 Patch 1408570 5 336257 mattbaker 2018-03-22 17:35:28 -0700 Comment on attachment 336257 Patch r=me 1408571 6 336257 commit-queue 2018-03-22 18:00:48 -0700 Comment on attachment 336257 Patch Clearing flags on attachment: 336257 Committed r229874: <https://trac.webkit.org/changeset/229874> 1408572 7 commit-queue 2018-03-22 18:00:50 -0700 All reviewed patches have been landed. Closing bug. 336257 2018-03-21 19:47:57 -0700 2018-03-22 18:00:48 -0700 Patch patch.txt text/plain 2279 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDZkMjg1MjQuLmRlMzY5OGQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTAzLTIxICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFVuY2F1Z2h0IEV4Y2VwdGlvbjog VHlwZUVycm9yOiB0aGlzLl90ZXh0RWRpdG9yLnRvZ2dsZVVuZXhlY3V0ZWRDb2RlSGlnaGxpZ2h0 cygpLnRoZW4gaXMgbm90IGEgZnVuY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4MTkxMgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzY3MDAw MjI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhl IHVuY2F1Z2h0IGV4Y2VwdGlvbiB3YXMgY2F1c2VkIGJ5IHJldHVybmluZyBgZmFsc2VgIGluc3Rl YWQgb2YgYSBwcm9taXNlIG9iamVjdC4KKyAgICAgICAgVGhpcyBwYXRjaCBvbmx5IGZpeGVzIHRo ZSBleGNlcHRpb24uIEZ1cnRoZXIgZW5oYW5jZW1lbnRzIHNob3VsZCBiZSBkb25lIGluIDxodHRw czovL3dlYmtpdC5vcmcvYi8xODM4ODc+LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3 cy9Tb3VyY2VDb2RlVGV4dEVkaXRvci5qczoKKyAgICAgICAgKFdJLlNvdXJjZUNvZGVUZXh0RWRp dG9yLnByb3RvdHlwZS50b2dnbGVUeXBlQW5ub3RhdGlvbnMpOgorICAgICAgICAoV0kuU291cmNl Q29kZVRleHRFZGl0b3IucHJvdG90eXBlLnRvZ2dsZVVuZXhlY3V0ZWRDb2RlSGlnaGxpZ2h0cyk6 CisKIDIwMTgtMDMtMjAgIE5pa2l0YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CiAK ICAgICAgICAgV2ViIEluc3BlY3RvcjogU3R5bGVzOiBMb3NlcyBmb2N1cyB3aGVuIGVkaXRpbmcg YSBwcm9wZXJ0eSB3aGlsZSBwYWdlIGlzIGJlaW5nIGxvYWRlZApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlQ29kZVRleHRFZGl0b3Iu anMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Tb3VyY2VDb2Rl VGV4dEVkaXRvci5qcwppbmRleCA0OTQzZTc2Li45NjUzYjk1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Tb3VyY2VDb2RlVGV4dEVkaXRvci5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Tb3VyY2VD b2RlVGV4dEVkaXRvci5qcwpAQCAtMzA5LDcgKzMwOSw3IEBAIFdJLlNvdXJjZUNvZGVUZXh0RWRp dG9yID0gY2xhc3MgU291cmNlQ29kZVRleHRFZGl0b3IgZXh0ZW5kcyBXSS5UZXh0RWRpdG9yCiAg ICAgdG9nZ2xlVHlwZUFubm90YXRpb25zKCkKICAgICB7CiAgICAgICAgIGlmICghdGhpcy5fdHlw ZVRva2VuQW5ub3RhdG9yKQotICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICAgICAg cmV0dXJuIFByb21pc2UucmVqZWN0KG5ldyBFcnJvcigiVHlwZVRva2VuQW5ub3RhdG9yIGlzIG5v dCBpbml0aWFsaXplZC4iKSk7CiAKICAgICAgICAgdmFyIG5ld0FjdGl2YXRlZFN0YXRlID0gIXRo aXMuX3R5cGVUb2tlbkFubm90YXRvci5pc0FjdGl2ZSgpOwogICAgICAgICBpZiAobmV3QWN0aXZh dGVkU3RhdGUgJiYgdGhpcy5faXNQcm9iYWJseU1pbmlmaWVkICYmICF0aGlzLmZvcm1hdHRlZCkg ewpAQCAtMzI1LDcgKzMyNSw3IEBAIFdJLlNvdXJjZUNvZGVUZXh0RWRpdG9yID0gY2xhc3MgU291 cmNlQ29kZVRleHRFZGl0b3IgZXh0ZW5kcyBXSS5UZXh0RWRpdG9yCiAgICAgdG9nZ2xlVW5leGVj dXRlZENvZGVIaWdobGlnaHRzKCkKICAgICB7CiAgICAgICAgIGlmICghdGhpcy5fYmFzaWNCbG9j a0Fubm90YXRvcikKLSAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgICAgIHJldHVy biBQcm9taXNlLnJlamVjdChuZXcgRXJyb3IoIkJhc2ljQmxvY2tBbm5vdGF0b3IgaXMgbm90IGlu aXRpYWxpemVkLiIpKTsKIAogICAgICAgICBsZXQgbmV3QWN0aXZhdGVkU3RhdGUgPSAhdGhpcy5f YmFzaWNCbG9ja0Fubm90YXRvci5pc0FjdGl2ZSgpOwogICAgICAgICBpZiAobmV3QWN0aXZhdGVk U3RhdGUgJiYgdGhpcy5faXNQcm9iYWJseU1pbmlmaWVkICYmICF0aGlzLmZvcm1hdHRlZCkgewo=