181909 2018-01-20 16:02:23 -0800 Fix broken unit-tests after r227192 2018-01-21 00:58:27 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=181787 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain cgarcia commit-queue lforschler webkit-bug-importer oldest_to_newest 1391424 0 aakash_jain 2018-01-20 16:02:23 -0800 https://trac.webkit.org/changeset/227192/webkit broke few unit-tests. e.g.: FAIL: test_builder GTK Linux 64-bit Release (Tests) (__main__.BuildStepsTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "./steps_unittest.py", line 488, in doTest self.assertListEqual(expected_build_steps[builder['name']], buildSteps) AssertionError: Lists differ: ['configure build', 'svn', 'ki... != ['configure build', 'svn', 'ki... Second list contains 1 additional elements. First extra element 19: webdriver-test ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'jhbuild', 'download-built-product', 'extract-built-product', 'jscore-test', 'layout-test', 'webkitpy-test', 'webkitperl-test', 'bindings-generation-tests', 'builtins-generator-tests', 'dashboard-tests', 'archive-test-results', 'upload', 'MasterShellCommand', - 'API tests'] ? ^ + 'API tests', ? ^ + 'webdriver-test'] 1391425 1 331849 aakash_jain 2018-01-20 16:04:41 -0800 Created attachment 331849 Proposed patch 1391449 2 331849 cgarcia 2018-01-21 00:33:43 -0800 Comment on attachment 331849 Proposed patch Sorry, I didn't notice it. Thanks for fixing it. 1391457 3 331849 commit-queue 2018-01-21 00:57:21 -0800 Comment on attachment 331849 Proposed patch Clearing flags on attachment: 331849 Committed r227276: <https://trac.webkit.org/changeset/227276> 1391458 4 commit-queue 2018-01-21 00:57:22 -0800 All reviewed patches have been landed. Closing bug. 1391459 5 webkit-bug-importer 2018-01-21 00:58:27 -0800 <rdar://problem/36704843> 331849 2018-01-20 16:04:41 -0800 2018-01-21 00:57:21 -0800 Proposed patch fix_unit-test_r227192.patch text/plain 6424 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyNzI3MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE4LTAxLTIwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBGaXggYnJva2VuIHVuaXQtdGVzdHMgYWZ0ZXIgcjIyNzE5MgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxOTA5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3Vw cG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9zdGVwc191bml0dGVzdC5weToKKwogMjAxOC0w MS0yMCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEFQSSB0ZXN0 IFVSTFNjaGVtZUhhbmRsZXIuTGVha3MxIGlzIHRpbWluZyBvdXQgb24gaU9TIHNpbXVsYXRvciBk ZWJ1ZwpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m aWcvc3RlcHNfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvc3RlcHNfdW5pdHRlc3QucHkJKHJldmlzaW9uIDIy NzI3MykKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmln L3N0ZXBzX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC00NTMsMTYgKzQ1MywxNiBAQCBl eHBlY3RlZF9idWlsZF9zdGVwcyA9IHsKICAgICAnSlNDT25seSBMaW51eCBBQXJjaDY0IFJlbGVh c2UnOiBbJ2NvbmZpZ3VyZSBidWlsZCcsICd3YWl0LWZvci1zdm4tc2VydmVyJywgJ3N2bicsICdk ZWxldGUgV2ViS2l0QnVpbGQgZGlyZWN0b3J5JywgJ2RlbGV0ZSBzdGFsZSBidWlsZCBmaWxlcycs ICdjb21waWxlLXdlYmtpdCcsICdqc2NvcmUtdGVzdCddLAogICAgICdKU0NPbmx5IExpbnV4IE1J UFMzMmVsIFJlbGVhc2UnOiBbJ2NvbmZpZ3VyZSBidWlsZCcsICdzdm4nLCAnZGVsZXRlIFdlYktp dEJ1aWxkIGRpcmVjdG9yeScsICdkZWxldGUgc3RhbGUgYnVpbGQgZmlsZXMnLCAnY29tcGlsZS13 ZWJraXQnLCAnanNjb3JlLXRlc3QnXSwKIAotICAgICdHVEsgTGludXggMzItYml0IFJlbGVhc2Un OiBbJ2NvbmZpZ3VyZSBidWlsZCcsICdzdm4nLCAna2lsbCBvbGQgcHJvY2Vzc2VzJywgJ2RlbGV0 ZSBXZWJLaXRCdWlsZCBkaXJlY3RvcnknLCAnZGVsZXRlIHN0YWxlIGJ1aWxkIGZpbGVzJywgJ2po YnVpbGQnLCAnY29tcGlsZS13ZWJraXQnLCAnanNjb3JlLXRlc3QnLCAnd2Via2l0cHktdGVzdCcs ICd3ZWJraXRwZXJsLXRlc3QnLCAnYmluZGluZ3MtZ2VuZXJhdGlvbi10ZXN0cycsICdidWlsdGlu cy1nZW5lcmF0b3ItdGVzdHMnLCAnZGFzaGJvYXJkLXRlc3RzJywgJ0FQSSB0ZXN0cyddLAorICAg ICdHVEsgTGludXggMzItYml0IFJlbGVhc2UnOiBbJ2NvbmZpZ3VyZSBidWlsZCcsICdzdm4nLCAn a2lsbCBvbGQgcHJvY2Vzc2VzJywgJ2RlbGV0ZSBXZWJLaXRCdWlsZCBkaXJlY3RvcnknLCAnZGVs ZXRlIHN0YWxlIGJ1aWxkIGZpbGVzJywgJ2poYnVpbGQnLCAnY29tcGlsZS13ZWJraXQnLCAnanNj b3JlLXRlc3QnLCAnd2Via2l0cHktdGVzdCcsICd3ZWJraXRwZXJsLXRlc3QnLCAnYmluZGluZ3Mt Z2VuZXJhdGlvbi10ZXN0cycsICdidWlsdGlucy1nZW5lcmF0b3ItdGVzdHMnLCAnZGFzaGJvYXJk LXRlc3RzJywgJ0FQSSB0ZXN0cycsICd3ZWJkcml2ZXItdGVzdCddLAogICAgICdHVEsgTGludXgg NjQtYml0IERlYnVnIChCdWlsZCknOiBbJ2NvbmZpZ3VyZSBidWlsZCcsICdzdm4nLCAna2lsbCBv bGQgcHJvY2Vzc2VzJywgJ2RlbGV0ZSBXZWJLaXRCdWlsZCBkaXJlY3RvcnknLCAnZGVsZXRlIHN0 YWxlIGJ1aWxkIGZpbGVzJywgJ2poYnVpbGQnLCAnY29tcGlsZS13ZWJraXQnLCAnYXJjaGl2ZS1i dWlsdC1wcm9kdWN0JywgJ3VwbG9hZCcsICd0cmFuc2Zlci10by1zMycsICd0cmlnZ2VyJ10sCi0g ICAgJ0dUSyBMaW51eCA2NC1iaXQgRGVidWcgKFRlc3RzKSc6IFsnY29uZmlndXJlIGJ1aWxkJywg J3N2bicsICdraWxsIG9sZCBwcm9jZXNzZXMnLCAnZGVsZXRlIFdlYktpdEJ1aWxkIGRpcmVjdG9y eScsICdkZWxldGUgc3RhbGUgYnVpbGQgZmlsZXMnLCAnamhidWlsZCcsICdkb3dubG9hZC1idWls dC1wcm9kdWN0JywgJ2V4dHJhY3QtYnVpbHQtcHJvZHVjdCcsICdqc2NvcmUtdGVzdCcsICdsYXlv dXQtdGVzdCcsICd3ZWJraXRweS10ZXN0JywgJ3dlYmtpdHBlcmwtdGVzdCcsICdiaW5kaW5ncy1n ZW5lcmF0aW9uLXRlc3RzJywgJ2J1aWx0aW5zLWdlbmVyYXRvci10ZXN0cycsICdkYXNoYm9hcmQt dGVzdHMnLCAnYXJjaGl2ZS10ZXN0LXJlc3VsdHMnLCAndXBsb2FkJywgJ01hc3RlclNoZWxsQ29t bWFuZCcsICdBUEkgdGVzdHMnXSwKKyAgICAnR1RLIExpbnV4IDY0LWJpdCBEZWJ1ZyAoVGVzdHMp JzogWydjb25maWd1cmUgYnVpbGQnLCAnc3ZuJywgJ2tpbGwgb2xkIHByb2Nlc3NlcycsICdkZWxl dGUgV2ViS2l0QnVpbGQgZGlyZWN0b3J5JywgJ2RlbGV0ZSBzdGFsZSBidWlsZCBmaWxlcycsICdq aGJ1aWxkJywgJ2Rvd25sb2FkLWJ1aWx0LXByb2R1Y3QnLCAnZXh0cmFjdC1idWlsdC1wcm9kdWN0 JywgJ2pzY29yZS10ZXN0JywgJ2xheW91dC10ZXN0JywgJ3dlYmtpdHB5LXRlc3QnLCAnd2Via2l0 cGVybC10ZXN0JywgJ2JpbmRpbmdzLWdlbmVyYXRpb24tdGVzdHMnLCAnYnVpbHRpbnMtZ2VuZXJh dG9yLXRlc3RzJywgJ2Rhc2hib2FyZC10ZXN0cycsICdhcmNoaXZlLXRlc3QtcmVzdWx0cycsICd1 cGxvYWQnLCAnTWFzdGVyU2hlbGxDb21tYW5kJywgJ0FQSSB0ZXN0cycsICd3ZWJkcml2ZXItdGVz dCddLAogICAgICdHVEsgTGludXggNjQtYml0IFJlbGVhc2UgKEJ1aWxkKSc6IFsnY29uZmlndXJl IGJ1aWxkJywgJ3N2bicsICdraWxsIG9sZCBwcm9jZXNzZXMnLCAnZGVsZXRlIFdlYktpdEJ1aWxk IGRpcmVjdG9yeScsICdkZWxldGUgc3RhbGUgYnVpbGQgZmlsZXMnLCAnamhidWlsZCcsICdjb21w aWxlLXdlYmtpdCcsICdhcmNoaXZlLWJ1aWx0LXByb2R1Y3QnLCAndXBsb2FkJywgJ3RyYW5zZmVy LXRvLXMzJywgJ3RyaWdnZXInXSwKICAgICAnR1RLIExpbnV4IDY0LWJpdCBSZWxlYXNlIChQZXJm KSc6IFsnY29uZmlndXJlIGJ1aWxkJywgJ3N2bicsICdraWxsIG9sZCBwcm9jZXNzZXMnLCAnZGVs ZXRlIFdlYktpdEJ1aWxkIGRpcmVjdG9yeScsICdkZWxldGUgc3RhbGUgYnVpbGQgZmlsZXMnLCAn amhidWlsZCcsICdkb3dubG9hZC1idWlsdC1wcm9kdWN0JywgJ2V4dHJhY3QtYnVpbHQtcHJvZHVj dCcsICdwZXJmLXRlc3QnLCAnYmVuY2htYXJrLXRlc3QnXSwKLSAgICAnR1RLIExpbnV4IDY0LWJp dCBSZWxlYXNlIChUZXN0cyknOiBbJ2NvbmZpZ3VyZSBidWlsZCcsICdzdm4nLCAna2lsbCBvbGQg cHJvY2Vzc2VzJywgJ2RlbGV0ZSBXZWJLaXRCdWlsZCBkaXJlY3RvcnknLCAnZGVsZXRlIHN0YWxl IGJ1aWxkIGZpbGVzJywgJ2poYnVpbGQnLCAnZG93bmxvYWQtYnVpbHQtcHJvZHVjdCcsICdleHRy YWN0LWJ1aWx0LXByb2R1Y3QnLCAnanNjb3JlLXRlc3QnLCAnbGF5b3V0LXRlc3QnLCAnd2Via2l0 cHktdGVzdCcsICd3ZWJraXRwZXJsLXRlc3QnLCAnYmluZGluZ3MtZ2VuZXJhdGlvbi10ZXN0cycs ICdidWlsdGlucy1nZW5lcmF0b3ItdGVzdHMnLCAnZGFzaGJvYXJkLXRlc3RzJywgJ2FyY2hpdmUt dGVzdC1yZXN1bHRzJywgJ3VwbG9hZCcsICdNYXN0ZXJTaGVsbENvbW1hbmQnLCAnQVBJIHRlc3Rz J10sCi0gICAgJ0dUSyBMaW51eCA2NC1iaXQgUmVsZWFzZSBXYXlsYW5kIChUZXN0cyknOiBbJ2Nv bmZpZ3VyZSBidWlsZCcsICdzdm4nLCAna2lsbCBvbGQgcHJvY2Vzc2VzJywgJ2RlbGV0ZSBXZWJL aXRCdWlsZCBkaXJlY3RvcnknLCAnZGVsZXRlIHN0YWxlIGJ1aWxkIGZpbGVzJywgJ2poYnVpbGQn LCAnZG93bmxvYWQtYnVpbHQtcHJvZHVjdCcsICdleHRyYWN0LWJ1aWx0LXByb2R1Y3QnLCAnanNj b3JlLXRlc3QnLCAnbGF5b3V0LXRlc3QnLCAnd2Via2l0cHktdGVzdCcsICd3ZWJraXRwZXJsLXRl c3QnLCAnYmluZGluZ3MtZ2VuZXJhdGlvbi10ZXN0cycsICdidWlsdGlucy1nZW5lcmF0b3ItdGVz dHMnLCAnZGFzaGJvYXJkLXRlc3RzJywgJ2FyY2hpdmUtdGVzdC1yZXN1bHRzJywgJ3VwbG9hZCcs ICdNYXN0ZXJTaGVsbENvbW1hbmQnLCAnQVBJIHRlc3RzJ10sCisgICAgJ0dUSyBMaW51eCA2NC1i aXQgUmVsZWFzZSAoVGVzdHMpJzogWydjb25maWd1cmUgYnVpbGQnLCAnc3ZuJywgJ2tpbGwgb2xk IHByb2Nlc3NlcycsICdkZWxldGUgV2ViS2l0QnVpbGQgZGlyZWN0b3J5JywgJ2RlbGV0ZSBzdGFs ZSBidWlsZCBmaWxlcycsICdqaGJ1aWxkJywgJ2Rvd25sb2FkLWJ1aWx0LXByb2R1Y3QnLCAnZXh0 cmFjdC1idWlsdC1wcm9kdWN0JywgJ2pzY29yZS10ZXN0JywgJ2xheW91dC10ZXN0JywgJ3dlYmtp dHB5LXRlc3QnLCAnd2Via2l0cGVybC10ZXN0JywgJ2JpbmRpbmdzLWdlbmVyYXRpb24tdGVzdHMn LCAnYnVpbHRpbnMtZ2VuZXJhdG9yLXRlc3RzJywgJ2Rhc2hib2FyZC10ZXN0cycsICdhcmNoaXZl LXRlc3QtcmVzdWx0cycsICd1cGxvYWQnLCAnTWFzdGVyU2hlbGxDb21tYW5kJywgJ0FQSSB0ZXN0 cycsICd3ZWJkcml2ZXItdGVzdCddLAorICAgICdHVEsgTGludXggNjQtYml0IFJlbGVhc2UgV2F5 bGFuZCAoVGVzdHMpJzogWydjb25maWd1cmUgYnVpbGQnLCAnc3ZuJywgJ2tpbGwgb2xkIHByb2Nl c3NlcycsICdkZWxldGUgV2ViS2l0QnVpbGQgZGlyZWN0b3J5JywgJ2RlbGV0ZSBzdGFsZSBidWls ZCBmaWxlcycsICdqaGJ1aWxkJywgJ2Rvd25sb2FkLWJ1aWx0LXByb2R1Y3QnLCAnZXh0cmFjdC1i dWlsdC1wcm9kdWN0JywgJ2pzY29yZS10ZXN0JywgJ2xheW91dC10ZXN0JywgJ3dlYmtpdHB5LXRl c3QnLCAnd2Via2l0cGVybC10ZXN0JywgJ2JpbmRpbmdzLWdlbmVyYXRpb24tdGVzdHMnLCAnYnVp bHRpbnMtZ2VuZXJhdG9yLXRlc3RzJywgJ2Rhc2hib2FyZC10ZXN0cycsICdhcmNoaXZlLXRlc3Qt cmVzdWx0cycsICd1cGxvYWQnLCAnTWFzdGVyU2hlbGxDb21tYW5kJywgJ0FQSSB0ZXN0cycsICd3 ZWJkcml2ZXItdGVzdCddLAogICAgICdHVEsgTGludXggNjQtYml0IFJlbGVhc2UgVWJ1bnR1IExU UyAoQnVpbGQpJzogWydjb25maWd1cmUgYnVpbGQnLCAnc3ZuJywgJ2tpbGwgb2xkIHByb2Nlc3Nl cycsICdkZWxldGUgV2ViS2l0QnVpbGQgZGlyZWN0b3J5JywgJ2RlbGV0ZSBzdGFsZSBidWlsZCBm aWxlcycsICdjb21waWxlLXdlYmtpdCddLAogICAgICdHVEsgTGludXggNjQtYml0IFJlbGVhc2Ug RGViaWFuIFN0YWJsZSAoQnVpbGQpJzogWydjb25maWd1cmUgYnVpbGQnLCAnc3ZuJywgJ2tpbGwg b2xkIHByb2Nlc3NlcycsICdkZWxldGUgV2ViS2l0QnVpbGQgZGlyZWN0b3J5JywgJ2RlbGV0ZSBz dGFsZSBidWlsZCBmaWxlcycsICdjb21waWxlLXdlYmtpdCddLAotICAgICdHVEsgTGludXggQVJN IFJlbGVhc2UnOiBbJ2NvbmZpZ3VyZSBidWlsZCcsICdzdm4nLCAna2lsbCBvbGQgcHJvY2Vzc2Vz JywgJ2RlbGV0ZSBXZWJLaXRCdWlsZCBkaXJlY3RvcnknLCAnZGVsZXRlIHN0YWxlIGJ1aWxkIGZp bGVzJywgJ2poYnVpbGQnLCAnY29tcGlsZS13ZWJraXQnLCAnanNjb3JlLXRlc3QnLCAnd2Via2l0 cHktdGVzdCcsICd3ZWJraXRwZXJsLXRlc3QnLCAnYmluZGluZ3MtZ2VuZXJhdGlvbi10ZXN0cycs ICdidWlsdGlucy1nZW5lcmF0b3ItdGVzdHMnLCAnZGFzaGJvYXJkLXRlc3RzJywgJ0FQSSB0ZXN0 cyddLAorICAgICdHVEsgTGludXggQVJNIFJlbGVhc2UnOiBbJ2NvbmZpZ3VyZSBidWlsZCcsICdz dm4nLCAna2lsbCBvbGQgcHJvY2Vzc2VzJywgJ2RlbGV0ZSBXZWJLaXRCdWlsZCBkaXJlY3Rvcnkn LCAnZGVsZXRlIHN0YWxlIGJ1aWxkIGZpbGVzJywgJ2poYnVpbGQnLCAnY29tcGlsZS13ZWJraXQn LCAnanNjb3JlLXRlc3QnLCAnd2Via2l0cHktdGVzdCcsICd3ZWJraXRwZXJsLXRlc3QnLCAnYmlu ZGluZ3MtZ2VuZXJhdGlvbi10ZXN0cycsICdidWlsdGlucy1nZW5lcmF0b3ItdGVzdHMnLCAnZGFz aGJvYXJkLXRlc3RzJywgJ0FQSSB0ZXN0cycsICd3ZWJkcml2ZXItdGVzdCddLAogCiAgICAgJ1dp bkNhaXJvIDY0LUJpdCBSZWxlYXNlJzogWydjb25maWd1cmUgYnVpbGQnLCAnc3ZuJywgJ2tpbGwg b2xkIHByb2Nlc3NlcycsICdkZWxldGUgV2ViS2l0QnVpbGQgZGlyZWN0b3J5JywgJ2RlbGV0ZSBz dGFsZSBidWlsZCBmaWxlcycsICdjb21waWxlLXdlYmtpdCddLAogCg==