181904 2018-01-19 23:42:48 -0800 [GTK] WebDriver: test imported/w3c/webdriver/tests/sessions/new_session/response.py is crashing in the bots 2018-01-22 06:07:17 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://github.com/w3c/web-platform-tests/pull/9122 Gtk, InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg bugs-noreply clopez ews-watchlist webkit-bug-importer oldest_to_newest 1391374 0 cgarcia 2018-01-19 23:42:48 -0800 This doesn't happen for me locally, but managed to reproduce it in another system. This is causing all other tests run after this one to fail, so we have two things to fix here: - A test causing a crash in the driver process makes all other tests to fail with connection refused error. This should be handled by the test runner, by launching a new driver process. I'll file a different a bug for this. - We are not handling the case of the browser failing to launch. We pass nullptr as the error to spawn and then use the returned value unconditionally. Thread 1 (Thread 0x7f0a0e6e6880 (LWP 29784)): #0 0x00007f0a0b2ace25 in g_mutex_lock () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gthread-posix.c:1336 ---Type <return> to continue, or q <return> to quit--- #1 0x00007f0a0b80bc23 in g_subprocess_wait_async () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gsubprocess.c:904 #2 0x000055a3ea11cf06 in WebDriver::SessionHost::launchBrowser(WTF::Function<void (WebDriver::SessionHost::Succeeded)>&&) () #3 0x000055a3ea118e15 in WebDriver::WebDriverService::newSession(WTF::RefPtr<WTF::JSONImpl::Object, WTF::DumbPtrTraits<WTF::JSONImpl::Object> >&&, WTF::Function<void (WebDriver::CommandResult&&)>&&) () #4 0x000055a3ea11a0f6 in WebDriver::WebDriverService::handleRequest(WebDriver::HTTPRequestHandler::Request&&, WTF::Function<void (WebDriver::HTTPRequestHandler::Response&&)>&&) () #5 0x000055a3ea12021d in WebDriver::HTTPServer::listen(unsigned int)::{lambda(_SoupServer*, _SoupMessage*, char const*, _GHashTable*, SoupClientContext*, void*)#1}::_FUN(_SoupServer*, _SoupMessage*, char const*, _GHashTable*, SoupClientContext*, void*) () #6 0x00007f0a0e28108f in call_handler () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/libsoup-2.57.1/libsoup/soup-server.c:1259 #7 got_body () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/libsoup-2.57.1/libsoup/soup-server.c:1400 #8 0x00007f0a0b542605 in g_closure_invoke () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gobject/gclosure.c:804 #9 0x00007f0a0b554482 in signal_emit_unlocked_R () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gobject/gsignal.c:3635 #10 0x00007f0a0b55d021 in g_signal_emit_valist () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gobject/gsignal.c:3391 #11 0x00007f0a0b55d432 in g_signal_emit () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gobject/gsignal.c:3447 #12 0x00007f0a0e279b32 in io_read () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/libsoup-2.57.1/libsoup/soup-message-io.c:792 #13 0x00007f0a0e27a01d in io_run_until () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/libsoup-2.57.1/libsoup/soup-message-io.c:988 #14 0x00007f0a0e27ac3b in io_run () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/libsoup-2.57.1/libsoup/soup-message-io.c:1059 #15 0x00007f0a0e27bea7 in soup_message_read_request () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/libsoup-2.57.1/libsoup/soup-message-server-io.c:304 #16 0x00007f0a0b54566e in g_cclosure_marshal_VOID__OBJECTv () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gobject/gmarshal.c:2102 #17 0x00007f0a0b542834 in _g_closure_invoke_va () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gobject/gclosure.c:867 #18 0x00007f0a0b55cd0c in g_signal_emit_valist () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gobject/gsignal.c:3300 #19 0x00007f0a0b55d432 in g_signal_emit () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gobject/gsignal.c:3447 #20 0x00007f0a0e28e06f in listen_watch () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/libsoup-2.57.1/libsoup/soup-socket.c:1237 #21 0x00007f0a0b2685da in g_main_dispatch () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3148 #22 g_main_context_dispatch () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3813 #23 0x00007f0a0b268968 in g_main_context_iterate () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3886 #24 0x00007f0a0b268c82 in g_main_loop_run () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:4082 #25 0x000055a3ea15afe0 in WTF::RunLoop::run() () #26 0x000055a3ea112108 in WebDriver::WebDriverService::run(int, char**) () #27 0x000055a3ea0f0227 in main () 1391375 1 cgarcia 2018-01-19 23:45:57 -0800 I've skipped the test in r227267. I'll investigate the issue next week. 1391612 2 331921 cgarcia 2018-01-22 05:43:16 -0800 Created attachment 331921 Patch 1391613 3 ews-watchlist 2018-01-22 05:45:25 -0800 Attachment 331921 did not pass style-queue: ERROR: Source/WebDriver/glib/SessionHostGlib.cpp:101: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/glib/SessionHostGlib.cpp:112: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/glib/SessionHostGlib.cpp:123: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/glib/SessionHostGlib.cpp:138: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/SessionHost.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/SessionHost.h:79: Extra space before ( in function call [whitespace/parens] [4] WARNING: This machine could support 4 simulators, but is only configured for 3. WARNING: Please see <https://trac.webkit.org/wiki/IncreasingKernelLimits>. Total errors found: 6 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1391618 4 cgarcia 2018-01-22 06:04:57 -0800 Committed r227290: <https://trac.webkit.org/changeset/227290> 1391619 5 webkit-bug-importer 2018-01-22 06:07:17 -0800 <rdar://problem/36731452> 331921 2018-01-22 05:43:16 -0800 2018-01-22 06:00:31 -0800 Patch wd-session-crash.diff text/plain 9843 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKaW5kZXggYTMxZGE1M2NiYTEuLjk2MTRiNDY1ZTQwIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDI2IEBACisyMDE4LTAxLTIyICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBXZWJEcml2ZXI6IHRlc3QgaW1wb3J0 ZWQvdzNjL3dlYmRyaXZlci90ZXN0cy9zZXNzaW9ucy9uZXdfc2Vzc2lvbi9yZXNwb25zZS5weSBp cyBjcmFzaGluZyBpbiB0aGUgYm90cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTgxOTA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgSGFuZGxlIHRoZSBjYXNlIG9mIGZhaWxpbmcgdG8gbGF1bmNoIHRoZSBi cm93c2VyLiBUaGUgdGVzdCBpcyBhY3R1YWxseSBmYWlsaW5nIGJlY2F1c2UgaXQncyBzZW5kaW5n IHdyb25nCisgICAgICAgIGNhcGFiaWxpdGllcywgdGhlIGRyaXZlciB0cmllcyB0byBmYWxsIGJh Y2sgdG8gdGhlIGRlZmF1bHQgZHJpdmVyLCBidXQgc2luY2UgV2ViS2l0IGlzIG5vdCBpbnN0YWxs ZWQgaW4gdGhlCisgICAgICAgIGJvdHMsIGl0IGZhaWxzIHRvIGZpbmQgdGhlIE1pbmlCcm93c2Vy LiBUaGUgdGVzdCBuZWVkcyB0byBiZSBmaXhlZCwgYnV0IHdlIHNob3VsZG4ndCBjcmFzaCB3aGVu IHRoZSBicm93c2VyCisgICAgICAgIGNhbid0IGJlIHNwYXduZWQgZm9yIHdoYXRldmVyIHJlYXNv biBpbiBhbnkgY2FzZS4gVGhpcyBwYXRjaCBoYW5kbGVzIHRoYXQgY2FzZSBhbmQgY2hhbmdlcyB0 aGUgYm9vbGVhbiByZXN1bHQgb2YKKyAgICAgICAgY29ubmVjdFRvQnJvd3NlciB0byBiZSBhbiBv cHRpb25hbCBlcnJvciBzdHJpbmcgaW5zdGVhZC4gVGhpcyB3YXkgd2UgY2FuIHByb3ZpZGUgbW9y ZSBkZXRhaWxlZCBlcnJvciBtZXNzYWdlCisgICAgICAgIHdoZW4gd2UgcmVqZWN0IHRoZSBzZXNz aW9uIGNyZWF0aW9uIGJlY2F1c2UgdGhlIGJyb3dzZXIgZmFpbGVkIHRvIHN0YXJ0LgorCisgICAg ICAgICogU2Vzc2lvbkhvc3QuaDoKKyAgICAgICAgKiBXZWJEcml2ZXJTZXJ2aWNlLmNwcDoKKyAg ICAgICAgKFdlYkRyaXZlcjo6V2ViRHJpdmVyU2VydmljZTo6bmV3U2Vzc2lvbik6CisgICAgICAg ICogZ2xpYi9TZXNzaW9uSG9zdEdsaWIuY3BwOgorICAgICAgICAoV2ViRHJpdmVyOjpTZXNzaW9u SG9zdDo6Y29ubmVjdFRvQnJvd3Nlcik6CisgICAgICAgIChXZWJEcml2ZXI6OkNvbm5lY3RUb0Jy b3dzZXJBc3luY0RhdGE6OkNvbm5lY3RUb0Jyb3dzZXJBc3luY0RhdGEpOgorICAgICAgICAoV2Vi RHJpdmVyOjpTZXNzaW9uSG9zdDo6bGF1bmNoQnJvd3Nlcik6CisgICAgICAgIChXZWJEcml2ZXI6 OlNlc3Npb25Ib3N0OjpzZXR1cENvbm5lY3Rpb24pOgorCiAyMDE4LTAxLTExICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBXZWJEcml2ZXI6IGlt cGxlbWVudCBnZXQgdGltZW91dHMgY29tbWFuZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkRyaXZl ci9TZXNzaW9uSG9zdC5oIGIvU291cmNlL1dlYkRyaXZlci9TZXNzaW9uSG9zdC5oCmluZGV4IGUy YjhhOWQwZjQzLi5jYmIwNTEyZWQyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkRyaXZlci9TZXNz aW9uSG9zdC5oCisrKyBiL1NvdXJjZS9XZWJEcml2ZXIvU2Vzc2lvbkhvc3QuaApAQCAtNTMsOCAr NTMsNyBAQCBwdWJsaWM6CiAKICAgICBjb25zdCBDYXBhYmlsaXRpZXMmIGNhcGFiaWxpdGllcygp IGNvbnN0IHsgcmV0dXJuIG1fY2FwYWJpbGl0aWVzOyB9CiAKLSAgICBlbnVtIGNsYXNzIFN1Y2Nl ZWRlZCB7IE5vLCBZZXMgfTsKLSAgICB2b2lkIGNvbm5lY3RUb0Jyb3dzZXIoRnVuY3Rpb248dm9p ZCAoU3VjY2VlZGVkKT4mJik7CisgICAgdm9pZCBjb25uZWN0VG9Ccm93c2VyKEZ1bmN0aW9uPHZv aWQgKHN0ZDo6b3B0aW9uYWw8U3RyaW5nPiBlcnJvcik+JiYpOwogICAgIHZvaWQgc3RhcnRBdXRv bWF0aW9uU2Vzc2lvbihjb25zdCBTdHJpbmcmIHNlc3Npb25JRCwgRnVuY3Rpb248dm9pZCAoc3Rk OjpvcHRpb25hbDxTdHJpbmc+KT4mJik7CiAKICAgICBzdHJ1Y3QgQ29tbWFuZFJlc3BvbnNlIHsK QEAgLTc3LDEwICs3NiwxMCBAQCBwcml2YXRlOgogI2lmIFVTRShHTElCKQogICAgIHN0YXRpYyB2 b2lkIGRidXNDb25uZWN0aW9uQ2xvc2VkQ2FsbGJhY2soU2Vzc2lvbkhvc3QqKTsKICAgICBzdGF0 aWMgY29uc3QgR0RCdXNJbnRlcmZhY2VWVGFibGUgc19pbnRlcmZhY2VWVGFibGU7Ci0gICAgdm9p ZCBsYXVuY2hCcm93c2VyKEZ1bmN0aW9uPHZvaWQgKFN1Y2NlZWRlZCk+JiYpOworICAgIHZvaWQg bGF1bmNoQnJvd3NlcihGdW5jdGlvbjx2b2lkIChzdGQ6Om9wdGlvbmFsPFN0cmluZz4gZXJyb3Ip PiYmKTsKICAgICB2b2lkIGNvbm5lY3RUb0Jyb3dzZXIoc3RkOjp1bmlxdWVfcHRyPENvbm5lY3RU b0Jyb3dzZXJBc3luY0RhdGE+JiYpOwogICAgIHN0ZDo6b3B0aW9uYWw8U3RyaW5nPiBtYXRjaENh cGFiaWxpdGllcyhHVmFyaWFudCopOwotICAgIHZvaWQgc2V0dXBDb25uZWN0aW9uKEdSZWZQdHI8 R0RCdXNDb25uZWN0aW9uPiYmLCBGdW5jdGlvbjx2b2lkIChTdWNjZWVkZWQpPiYmKTsKKyAgICB2 b2lkIHNldHVwQ29ubmVjdGlvbihHUmVmUHRyPEdEQnVzQ29ubmVjdGlvbj4mJik7CiAgICAgdm9p ZCBzZXRUYXJnZXRMaXN0KHVpbnQ2NF90IGNvbm5lY3Rpb25JRCwgVmVjdG9yPFRhcmdldD4mJik7 CiAgICAgdm9pZCBzZW5kTWVzc2FnZVRvRnJvbnRlbmQodWludDY0X3QgY29ubmVjdGlvbklELCB1 aW50NjRfdCB0YXJnZXRJRCwgY29uc3QgY2hhciogbWVzc2FnZSk7CiAjZW5kaWYKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJEcml2ZXIvV2ViRHJpdmVyU2VydmljZS5jcHAgYi9Tb3VyY2UvV2ViRHJp dmVyL1dlYkRyaXZlclNlcnZpY2UuY3BwCmluZGV4IDY1NTNjNzBiMzE5Li45NjUwMWZlZGM1YyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkRyaXZlci9XZWJEcml2ZXJTZXJ2aWNlLmNwcAorKysgYi9T b3VyY2UvV2ViRHJpdmVyL1dlYkRyaXZlclNlcnZpY2UuY3BwCkBAIC02MTEsOSArNjExLDkgQEAg dm9pZCBXZWJEcml2ZXJTZXJ2aWNlOjpuZXdTZXNzaW9uKFJlZlB0cjxKU09OOjpPYmplY3Q+JiYg cGFyYW1ldGVycywgRnVuY3Rpb248dm8KICAgICBwYXJzZUNhcGFiaWxpdGllcygqbWF0Y2hlZENh cGFiaWxpdGllcywgY2FwYWJpbGl0aWVzKTsKICAgICBhdXRvIHNlc3Npb25Ib3N0ID0gc3RkOjpt YWtlX3VuaXF1ZTxTZXNzaW9uSG9zdD4oV1RGTW92ZShjYXBhYmlsaXRpZXMpKTsKICAgICBhdXRv KiBzZXNzaW9uSG9zdFB0ciA9IHNlc3Npb25Ib3N0LmdldCgpOwotICAgIHNlc3Npb25Ib3N0UHRy LT5jb25uZWN0VG9Ccm93c2VyKFt0aGlzLCBzZXNzaW9uSG9zdCA9IFdURk1vdmUoc2Vzc2lvbkhv c3QpLCBjb21wbGV0aW9uSGFuZGxlciA9IFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpXShTZXNz aW9uSG9zdDo6U3VjY2VlZGVkIHN1Y2NlZWRlZCkgbXV0YWJsZSB7Ci0gICAgICAgIGlmIChzdWNj ZWVkZWQgPT0gU2Vzc2lvbkhvc3Q6OlN1Y2NlZWRlZDo6Tm8pIHsKLSAgICAgICAgICAgIGNvbXBs ZXRpb25IYW5kbGVyKENvbW1hbmRSZXN1bHQ6OmZhaWwoQ29tbWFuZFJlc3VsdDo6RXJyb3JDb2Rl OjpTZXNzaW9uTm90Q3JlYXRlZCwgU3RyaW5nKCJGYWlsZWQgdG8gY29ubmVjdCB0byBicm93c2Vy IikpKTsKKyAgICBzZXNzaW9uSG9zdFB0ci0+Y29ubmVjdFRvQnJvd3NlcihbdGhpcywgc2Vzc2lv bkhvc3QgPSBXVEZNb3ZlKHNlc3Npb25Ib3N0KSwgY29tcGxldGlvbkhhbmRsZXIgPSBXVEZNb3Zl KGNvbXBsZXRpb25IYW5kbGVyKV0oc3RkOjpvcHRpb25hbDxTdHJpbmc+IGVycm9yKSBtdXRhYmxl IHsKKyAgICAgICAgaWYgKGVycm9yKSB7CisgICAgICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihD b21tYW5kUmVzdWx0OjpmYWlsKENvbW1hbmRSZXN1bHQ6OkVycm9yQ29kZTo6U2Vzc2lvbk5vdENy ZWF0ZWQsIG1ha2VTdHJpbmcoIkZhaWxlZCB0byBjb25uZWN0IHRvIGJyb3dzZXI6ICIsIGVycm9y LnZhbHVlKCkpKSk7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkRyaXZlci9nbGliL1Nlc3Npb25Ib3N0R2xpYi5jcHAgYi9Tb3VyY2UvV2Vi RHJpdmVyL2dsaWIvU2Vzc2lvbkhvc3RHbGliLmNwcAppbmRleCA1OGVmOWU3OTE3Ni4uYjJiNDE0 YzZlYjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJEcml2ZXIvZ2xpYi9TZXNzaW9uSG9zdEdsaWIu Y3BwCisrKyBiL1NvdXJjZS9XZWJEcml2ZXIvZ2xpYi9TZXNzaW9uSG9zdEdsaWIuY3BwCkBAIC05 OCw3ICs5OCw3IEBAIGNvbnN0IEdEQnVzSW50ZXJmYWNlVlRhYmxlIFNlc3Npb25Ib3N0OjpzX2lu dGVyZmFjZVZUYWJsZSA9IHsKICAgICB7IDAgfQogfTsKIAotdm9pZCBTZXNzaW9uSG9zdDo6Y29u bmVjdFRvQnJvd3NlcihGdW5jdGlvbjx2b2lkIChTdWNjZWVkZWQpPiYmIGNvbXBsZXRpb25IYW5k bGVyKQordm9pZCBTZXNzaW9uSG9zdDo6Y29ubmVjdFRvQnJvd3NlcihGdW5jdGlvbjx2b2lkIChz dGQ6Om9wdGlvbmFsPFN0cmluZz4gZXJyb3IpPiYmIGNvbXBsZXRpb25IYW5kbGVyKQogewogICAg IGxhdW5jaEJyb3dzZXIoV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcikpOwogfQpAQCAtMTA5LDcg KzEwOSw3IEBAIGJvb2wgU2Vzc2lvbkhvc3Q6OmlzQ29ubmVjdGVkKCkgY29uc3QKIH0KIAogc3Ry dWN0IENvbm5lY3RUb0Jyb3dzZXJBc3luY0RhdGEgewotICAgIENvbm5lY3RUb0Jyb3dzZXJBc3lu Y0RhdGEoU2Vzc2lvbkhvc3QqIHNlc3Npb25Ib3N0LCBHVW5pcXVlUHRyPGNoYXI+JiYgZGJ1c0Fk ZHJlc3MsIEdDYW5jZWxsYWJsZSogY2FuY2VsbGFibGUsIEZ1bmN0aW9uPHZvaWQgKFNlc3Npb25I b3N0OjpTdWNjZWVkZWQpPiYmIGNvbXBsZXRpb25IYW5kbGVyKQorICAgIENvbm5lY3RUb0Jyb3dz ZXJBc3luY0RhdGEoU2Vzc2lvbkhvc3QqIHNlc3Npb25Ib3N0LCBHVW5pcXVlUHRyPGNoYXI+JiYg ZGJ1c0FkZHJlc3MsIEdDYW5jZWxsYWJsZSogY2FuY2VsbGFibGUsIEZ1bmN0aW9uPHZvaWQgKHN0 ZDo6b3B0aW9uYWw8U3RyaW5nPiBlcnJvcik+JiYgY29tcGxldGlvbkhhbmRsZXIpCiAgICAgICAg IDogc2Vzc2lvbkhvc3Qoc2Vzc2lvbkhvc3QpCiAgICAgICAgICwgZGJ1c0FkZHJlc3MoV1RGTW92 ZShkYnVzQWRkcmVzcykpCiAgICAgICAgICwgY2FuY2VsbGFibGUoY2FuY2VsbGFibGUpCkBAIC0x MjAsNyArMTIwLDcgQEAgc3RydWN0IENvbm5lY3RUb0Jyb3dzZXJBc3luY0RhdGEgewogICAgIFNl c3Npb25Ib3N0KiBzZXNzaW9uSG9zdDsKICAgICBHVW5pcXVlUHRyPGNoYXI+IGRidXNBZGRyZXNz OwogICAgIEdSZWZQdHI8R0NhbmNlbGxhYmxlPiBjYW5jZWxsYWJsZTsKLSAgICBGdW5jdGlvbjx2 b2lkIChTZXNzaW9uSG9zdDo6U3VjY2VlZGVkKT4gY29tcGxldGlvbkhhbmRsZXI7CisgICAgRnVu Y3Rpb248dm9pZCAoc3RkOjpvcHRpb25hbDxTdHJpbmc+IGVycm9yKT4gY29tcGxldGlvbkhhbmRs ZXI7CiB9OwogCiBzdGF0aWMgZ3VpbnQxNiBmcmVlUG9ydCgpCkBAIC0xMzUsNyArMTM1LDcgQEAg c3RhdGljIGd1aW50MTYgZnJlZVBvcnQoKQogICAgIHJldHVybiBnX2luZXRfc29ja2V0X2FkZHJl c3NfZ2V0X3BvcnQoR19JTkVUX1NPQ0tFVF9BRERSRVNTKGFkZHJlc3MuZ2V0KCkpKTsKIH0KIAot dm9pZCBTZXNzaW9uSG9zdDo6bGF1bmNoQnJvd3NlcihGdW5jdGlvbjx2b2lkIChTdWNjZWVkZWQp PiYmIGNvbXBsZXRpb25IYW5kbGVyKQordm9pZCBTZXNzaW9uSG9zdDo6bGF1bmNoQnJvd3NlcihG dW5jdGlvbjx2b2lkIChzdGQ6Om9wdGlvbmFsPFN0cmluZz4gZXJyb3IpPiYmIGNvbXBsZXRpb25I YW5kbGVyKQogewogICAgIG1fY2FuY2VsbGFibGUgPSBhZG9wdEdSZWYoZ19jYW5jZWxsYWJsZV9u ZXcoKSk7CiAgICAgR1JlZlB0cjxHU3VicHJvY2Vzc0xhdW5jaGVyPiBsYXVuY2hlciA9IGFkb3B0 R1JlZihnX3N1YnByb2Nlc3NfbGF1bmNoZXJfbmV3KEdfU1VCUFJPQ0VTU19GTEFHU19OT05FKSk7 CkBAIC0xNTIsNyArMTUyLDEzIEBAIHZvaWQgU2Vzc2lvbkhvc3Q6OmxhdW5jaEJyb3dzZXIoRnVu Y3Rpb248dm9pZCAoU3VjY2VlZGVkKT4mJiBjb21wbGV0aW9uSGFuZGxlcikKICAgICBmb3IgKHVu c2lnbmVkIGkgPSAwOyBpIDwgYnJvd3NlckFyZ3VtZW50cy5zaXplKCk7ICsraSkKICAgICAgICAg YXJncy5nZXQoKVtpICsgMV0gPSBnX3N0cmR1cChicm93c2VyQXJndW1lbnRzW2ldLnV0ZjgoKS5k YXRhKCkpOwogCi0gICAgbV9icm93c2VyID0gYWRvcHRHUmVmKGdfc3VicHJvY2Vzc19sYXVuY2hl cl9zcGF3bnYobGF1bmNoZXIuZ2V0KCksIGFyZ3MuZ2V0KCksIG51bGxwdHIpKTsKKyAgICBHVW5p cXVlT3V0UHRyPEdFcnJvcj4gZXJyb3I7CisgICAgbV9icm93c2VyID0gYWRvcHRHUmVmKGdfc3Vi cHJvY2Vzc19sYXVuY2hlcl9zcGF3bnYobGF1bmNoZXIuZ2V0KCksIGFyZ3MuZ2V0KCksICZlcnJv ci5vdXRQdHIoKSkpOworICAgIGlmIChlcnJvcikgeworICAgICAgICBjb21wbGV0aW9uSGFuZGxl cihTdHJpbmc6OmZyb21VVEY4KGVycm9yLT5tZXNzYWdlKSk7CisgICAgICAgIHJldHVybjsKKyAg ICB9CisKICAgICBnX3N1YnByb2Nlc3Nfd2FpdF9hc3luYyhtX2Jyb3dzZXIuZ2V0KCksIG1fY2Fu Y2VsbGFibGUuZ2V0KCksIFtdKEdPYmplY3QqIGJyb3dzZXIsIEdBc3luY1Jlc3VsdCogcmVzdWx0 LCBncG9pbnRlciB1c2VyRGF0YSkgewogICAgICAgICBHVW5pcXVlT3V0UHRyPEdFcnJvcj4gZXJy b3I7CiAgICAgICAgIGdfc3VicHJvY2Vzc193YWl0X2ZpbmlzaChHX1NVQlBST0NFU1MoYnJvd3Nl ciksIHJlc3VsdCwgJmVycm9yLm91dFB0cigpKTsKQEAgLTE5MCwxMCArMTk2LDExIEBAIHZvaWQg U2Vzc2lvbkhvc3Q6OmNvbm5lY3RUb0Jyb3dzZXIoc3RkOjp1bmlxdWVfcHRyPENvbm5lY3RUb0Jy b3dzZXJBc3luY0RhdGE+JiYKICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAg ICAgICAgICAgICAgICAgfQogCi0gICAgICAgICAgICAgICAgICAgIGRhdGEtPmNvbXBsZXRpb25I YW5kbGVyKFN1Y2NlZWRlZDo6Tm8pOworICAgICAgICAgICAgICAgICAgICBkYXRhLT5jb21wbGV0 aW9uSGFuZGxlcihTdHJpbmc6OmZyb21VVEY4KGVycm9yLT5tZXNzYWdlKSk7CiAgICAgICAgICAg ICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgICAgICB9Ci0gICAgICAgICAgICAgICAgZGF0 YS0+c2Vzc2lvbkhvc3QtPnNldHVwQ29ubmVjdGlvbihXVEZNb3ZlKGNvbm5lY3Rpb24pLCBXVEZN b3ZlKGRhdGEtPmNvbXBsZXRpb25IYW5kbGVyKSk7CisgICAgICAgICAgICAgICAgZGF0YS0+c2Vz c2lvbkhvc3QtPnNldHVwQ29ubmVjdGlvbihXVEZNb3ZlKGNvbm5lY3Rpb24pKTsKKyAgICAgICAg ICAgICAgICBkYXRhLT5jb21wbGV0aW9uSGFuZGxlcihzdGQ6Om51bGxvcHQpOwogICAgICAgICB9 LCBkYXRhKTsKICAgICB9KTsKIH0KQEAgLTIxMiw3ICsyMTksNyBAQCBzdGF0aWMgdm9pZCBkYnVz Q29ubmVjdGlvbkNhbGxBc3luY1JlYWR5Q2FsbGJhY2soR09iamVjdCogc291cmNlLCBHQXN5bmNS ZXN1bHQqCiAgICAgICAgIFdURkxvZ0Fsd2F5cygiUmVtb3RlSW5zcGVjdG9yU2VydmVyIGZhaWxl ZCB0byBzZW5kIERCdXMgbWVzc2FnZTogJXMiLCBlcnJvci0+bWVzc2FnZSk7CiB9CiAKLXZvaWQg U2Vzc2lvbkhvc3Q6OnNldHVwQ29ubmVjdGlvbihHUmVmUHRyPEdEQnVzQ29ubmVjdGlvbj4mJiBj b25uZWN0aW9uLCBGdW5jdGlvbjx2b2lkIChTdWNjZWVkZWQpPiYmIGNvbXBsZXRpb25IYW5kbGVy KQordm9pZCBTZXNzaW9uSG9zdDo6c2V0dXBDb25uZWN0aW9uKEdSZWZQdHI8R0RCdXNDb25uZWN0 aW9uPiYmIGNvbm5lY3Rpb24pCiB7CiAgICAgQVNTRVJUKCFtX2RidXNDb25uZWN0aW9uKTsKICAg ICBBU1NFUlQoY29ubmVjdGlvbik7CkBAIC0yMjUsOCArMjMyLDYgQEAgdm9pZCBTZXNzaW9uSG9z dDo6c2V0dXBDb25uZWN0aW9uKEdSZWZQdHI8R0RCdXNDb25uZWN0aW9uPiYmIGNvbm5lY3Rpb24s IEZ1bmN0aW8KICAgICAgICAgaW50cm9zcGVjdGlvbkRhdGEgPSBnX2RidXNfbm9kZV9pbmZvX25l d19mb3JfeG1sKGludHJvc3BlY3Rpb25YTUwsIG51bGxwdHIpOwogCiAgICAgZ19kYnVzX2Nvbm5l Y3Rpb25fcmVnaXN0ZXJfb2JqZWN0KG1fZGJ1c0Nvbm5lY3Rpb24uZ2V0KCksIFJFTU9URV9JTlNQ RUNUT1JfQ0xJRU5UX09CSkVDVF9QQVRILCBpbnRyb3NwZWN0aW9uRGF0YS0+aW50ZXJmYWNlc1sw XSwgJnNfaW50ZXJmYWNlVlRhYmxlLCB0aGlzLCBudWxscHRyLCBudWxscHRyKTsKLQotICAgIGNv bXBsZXRpb25IYW5kbGVyKFN1Y2NlZWRlZDo6WWVzKTsKIH0KIAogc3RkOjpvcHRpb25hbDxTdHJp bmc+IFNlc3Npb25Ib3N0OjptYXRjaENhcGFiaWxpdGllcyhHVmFyaWFudCogY2FwYWJpbGl0aWVz KQpkaWZmIC0tZ2l0IGEvV2ViRHJpdmVyVGVzdHMvQ2hhbmdlTG9nIGIvV2ViRHJpdmVyVGVzdHMv Q2hhbmdlTG9nCmluZGV4IDVkZWY3YTEyY2JlLi45Y2Y1ZGZmZGI4OSAxMDA2NDQKLS0tIGEvV2Vi RHJpdmVyVGVzdHMvQ2hhbmdlTG9nCisrKyBiL1dlYkRyaXZlclRlc3RzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE0IEBACisyMDE4LTAxLTIyICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBXZWJEcml2ZXI6IHRlc3QgaW1wb3J0ZWQvdzNj L3dlYmRyaXZlci90ZXN0cy9zZXNzaW9ucy9uZXdfc2Vzc2lvbi9yZXNwb25zZS5weSBpcyBjcmFz aGluZyBpbiB0aGUgYm90cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTgxOTA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVW5za2lwIGltcG9ydGVkL3czYy93ZWJkcml2ZXIvdGVzdHMvc2Vzc2lvbnMvbmV3 X3Nlc3Npb24vcmVzcG9uc2UucHkuCisKKyAgICAgICAgKiBUZXN0RXhwZWN0YXRpb25zLmpzb246 CisKIDIwMTgtMDEtMTkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCiAgICAgICAgIFVucmV2aWV3ZWQgR1RLKyBnYXJkZW5pbmcuIFNraXAgaW1wb3J0ZWQvdzNj L3dlYmRyaXZlci90ZXN0cy9zZXNzaW9ucy9uZXdfc2Vzc2lvbi9yZXNwb25zZS5weS4KZGlmZiAt LWdpdCBhL1dlYkRyaXZlclRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMuanNvbiBiL1dlYkRyaXZlclRl c3RzL1Rlc3RFeHBlY3RhdGlvbnMuanNvbgppbmRleCBiMWY4MmViZDlmNi4uMjRmMzk5ZWExMWYg MTAwNjQ0Ci0tLSBhL1dlYkRyaXZlclRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMuanNvbgorKysgYi9X ZWJEcml2ZXJUZXN0cy9UZXN0RXhwZWN0YXRpb25zLmpzb24KQEAgLTM1Myw3ICszNTMsNiBAQAog ICAgICAgICB9CiAgICAgfSwKICAgICAiaW1wb3J0ZWQvdzNjL3dlYmRyaXZlci90ZXN0cy9zZXNz aW9ucy9uZXdfc2Vzc2lvbi9yZXNwb25zZS5weSI6IHsKLSAgICAgICAgImV4cGVjdGVkIjogeyJn dGsiOiB7InN0YXR1cyI6IFsiU0tJUCJdLCAiYnVnIjogIndlYmtpdC5vcmcvYi8xODE5MDQifX0s CiAgICAgICAgICJzdWJ0ZXN0cyI6IHsKICAgICAgICAgICAgICJ0ZXN0X3Jlc3BfY2FwYWJpbGl0 ZXMiOiB7CiAgICAgICAgICAgICAgICAgImV4cGVjdGVkIjogeyJhbGwiOiB7InN0YXR1cyI6IFsi RkFJTCJdLCAiYnVnIjogIndlYmtpdC5vcmcvYi8xODA0MDgifX0K