181896 2018-01-19 19:47:37 -0800 [macOS] [WK2] Drag location is computed incorrectly when dragging content from subframes 2018-01-22 10:40:48 -0800 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh aakash_jain andrew lforschler rniwa simon.fraser thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1391328 0 wenson_hsieh 2018-01-19 19:47:37 -0800 When dragging content from an iframe on macOS, the drag image location is computed incorrectly if the iframe is not at (0, 0). To reproduce, try dragging the logo in <https://www.w3schools.com/html/tryit.asp?filename=tryhtml5_draganddrop>. Reproduces on Safari 11 and later (on macOS 10.13, the drag image is clamped to the mouse cursor with an animation, so it looks like the drag image flies in from offscreen). 1391329 1 wenson_hsieh 2018-01-19 19:48:21 -0800 This is fallout from refactoring in r218837. 1391333 2 331828 wenson_hsieh 2018-01-19 19:51:42 -0800 Created attachment 331828 Reduced test case 1391340 3 wenson_hsieh 2018-01-19 20:02:57 -0800 <rdar://problem/35479043> 1391353 4 331830 wenson_hsieh 2018-01-19 20:37:43 -0800 Created attachment 331830 Patch 1391359 5 wenson_hsieh 2018-01-19 22:30:05 -0800 *** Bug 179733 has been marked as a duplicate of this bug. *** 1391365 6 331830 wenson_hsieh 2018-01-19 22:54:59 -0800 Comment on attachment 331830 Patch Thanks for the review! 1391372 7 331830 wenson_hsieh 2018-01-19 23:26:02 -0800 Comment on attachment 331830 Patch Manually landed r227266: <https://trac.webkit.org/changeset/227266> Commit queue doesn't seem to be processing this patch... 1391405 8 aakash_jain 2018-01-20 08:50:19 -0800 > Commit queue doesn't seem to be processing this patch... Tracking in https://bugs.webkit.org/show_bug.cgi?id=181907 1391705 9 331830 simon.fraser 2018-01-22 10:36:12 -0800 Comment on attachment 331830 Patch No test? 1391713 10 wenson_hsieh 2018-01-22 10:40:48 -0800 (In reply to Simon Fraser (smfr) from comment #9) > Comment on attachment 331830 [details] > Patch > > No test? (from the ChangeLog:) "Since this bug only affects drag and drop in the macOS WebKit2 port, there's currently no way to test this. I'll be using <https://bugs.webkit.org/show_bug.cgi?id=181898> to track adding test support for drag and drop on macOS WebKit2. Manually tested dragging in both WebKit1 and WebKit2 on macOS. dragLocationInWindowCoordinates isn't used at all for iOS drag and drop." I've begun investigating drag and drop testing support for macOS using WebKit2, but this would require significant (feature level) work, which I don't think this fix should be blocked on. The infrastructure needed to write cross-platform WebKit2 drag and drop tests is something I'm actively working towards. 331828 2018-01-19 19:51:42 -0800 2018-01-19 19:51:42 -0800 Reduced test case drag-drop-iframe-offset.html text/html 730 wenson_hsieh PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KPHN0eWxlPgpib2R5IHsKICAgIHdpZHRoOiAx MDAlOwogICAgaGVpZ2h0OiAxMDAlOwogICAgbWFyZ2luOiAwOwogICAgcG9zaXRpb246IGFic29s dXRlOwp9CgppZnJhbWUgewogICAgcG9zaXRpb246IGFic29sdXRlOwogICAgcmlnaHQ6IDA7CiAg ICBib3R0b206IDA7Cn0KPC9zdHlsZT4KPC9oZWFkPgo8aWZyYW1lIHN0eWxlPSJoZWlnaHQ6IDIw MHB4OyB3aWR0aDogMjAwcHg7IiBzcmM9ImRhdGE6dGV4dC9odG1sLAo8Ym9keSBzdHlsZT0nd2lk dGg6IDEwMCU7IGhlaWdodDogMTAwJTsgbWFyZ2luOiAwOyc+CjxkaXYgaWQ9J3NvdXJjZScgc3R5 bGU9J3dpZHRoOiAxMDAlOyBoZWlnaHQ6IDEwMCU7IGJhY2tncm91bmQtY29sb3I6IGdyZWVuOycg ZHJhZ2dhYmxlPSd0cnVlJyBvbmRyYWdzdGFydD0nc3RhcnREcmFnKGV2ZW50KSc+PC9kaXY+Cjwv Ym9keT4KPHNjcmlwdD4KZnVuY3Rpb24gc3RhcnREcmFnKGV2ZW50KSB7CiAgICBldmVudC5kYXRh VHJhbnNmZXIuc2V0RGF0YSgndGV4dCcsICdoZWxsbyB3b3JsZCcpOwp9CgpmdW5jdGlvbiBkcm9w KGV2ZW50KSB7CiAgICBldmVudC50YXJnZXQuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoZXZlbnQuZGF0YVRyYW5zZmVyLmdldERhdGEoJ3RleHQnKSkpOwogICAgZXZlbnQucHJl dmVudERlZmF1bHQoKTsKfQo8L3NjcmlwdD4iPgo8L2lmcmFtZT4KPC9odG1sPg== 331830 2018-01-19 20:37:43 -0800 2018-01-19 23:26:02 -0800 Patch bug-181896-20180119203743.patch text/plain 5629 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3MTQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTNmZmFkODhiMWU0MzZj MTZmOWQwMTk4MzZjOWI1ODI2YmU4YjFiOC4uMWRiNWQ2NmIwNjFmNDM1NmNlOThiMmY0ODc5NDRk MGI0NGQ3ZWM3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM1IEBACisyMDE4LTAxLTE5ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFttYWNPU10gW1dL Ml0gRHJhZyBsb2NhdGlvbiBpcyBjb21wdXRlZCBpbmNvcnJlY3RseSB3aGVuIGRyYWdnaW5nIGNv bnRlbnQgZnJvbSBzdWJmcmFtZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE4MTg5NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzU0NzkwNDM+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gcjIxODgz NywgSSBwYWNrYWdlZCBtb3N0IG9mIHRoZSBpbmZvcm1hdGlvbiBuZWVkZWQgdG8gc3RhcnQgYSBk cmFnIGludG8gRHJhZ0l0ZW0sIHdoaWNoIGlzIHByb3BhZ2F0ZWQgdG8gdGhlIGNsaWVudCBsYXll cgorICAgICAgICB2aWEgdGhlIHN0YXJ0RHJhZyBjb2RlcGF0aC4gSG93ZXZlciwgdGhpcyBpbnRy b2R1Y2VkIGEgYnVnIGluIGNvbXB1dGluZyB0aGUgZXZlbnQgcG9zaXRpb24gYW5kIGRyYWcgbG9j YXRpb24gaW4gd2luZG93CisgICAgICAgIGNvb3JkaW5hdGVzLiBDb25zaWRlciB0aGUgY2FzZSB3 aGVyZSB3ZSdyZSBkZXRlcm1pbmluZyB0aGUgZHJhZyBpbWFnZSBvZmZzZXQgZm9yIGEgZHJhZ2dl ZCBlbGVtZW50IGluIGEgc3ViZnJhbWU6CisKKyAgICAgICAgQmVmb3JlIHRoZSBwYXRjaCwgdGhl IGRyYWcgbG9jYXRpb24gKHdoaWNoIHN0YXJ0cyBvdXQgaW4gdGhlIHN1YmZyYW1lJ3MgY29udGVu dCBjb29yZGluYXRlcykgd291bGQgYmUgY29udmVydGVkIHRvIHJvb3QgdmlldworICAgICAgICBj b29yZGluYXRlcywgd2hpY2ggd291bGQgdGhlbiBiZSBjb252ZXJ0ZWQgdG8gbWFpbmZyYW1lIGNv bnRlbnQgY29vcmRpbmF0ZXMsIHdoaWNoIHdvdWxkIHRoZW4gYmUgY29udmVydGVkIHRvIHdpbmRv dyBjb29yZGluYXRlcworICAgICAgICB1c2luZyB0aGUgbWFpbmZyYW1lJ3Mgdmlldy4gQWZ0ZXIg dGhlIHBhdGNoLCB3ZSBjYXJyeSBvdXQgdGhlIHNhbWUgbWF0aCB1bnRpbCB0aGUgbGFzdCBzdGVw LCB3aGVyZSB3ZSBlcnJvbmVvdXNseSB1c2UgdGhlCisgICAgICAgIF9zdWJmcmFtZSdzXyB2aWV3 IHRvIGNvbnZlcnQgdG8gd2luZG93IGNvb3JkaW5hdGVzIGZyb20gY29udGVudCBjb29yZGluYXRl cy4gVGhpcyByZXN1bHRzIGluIHRoZSBwb3NpdGlvbiBvZiB0aGUgaWZyYW1lIHJlbGF0aXZlCisg ICAgICAgIHRvIHRoZSBtYWluZnJhbWUgYmVpbmcgYWNjb3VudGVkIGZvciB0d2ljZS4KKworICAg ICAgICBUbyBmaXggdGhpcywgd2Ugc2ltcGx5IHVzZSB0aGUgbWFpbiBmcmFtZSdzIHZpZXcgdG8g Y29udmVydCBmcm9tIG1haW5mcmFtZSBjb250ZW50IGNvb3JkaW5hdGVzIHRvIHdpbmRvdyBjb29y ZGluYXRlcyB3aGlsZQorICAgICAgICBjb21wdXRpbmcgdGhlIGRyYWcgbG9jYXRpb24uIEFzIGZv ciB0aGUgZXZlbnQgcG9zaXRpb24gaW4gd2luZG93IGNvb3JkaW5hdGVzLCB0aGlzIGlzIGN1cnJl bnRseSB1bnVzZWQgYnkgYW55IGNvZGVwYXRoIGluIFdlYktpdCwKKyAgICAgICAgc28gd2UgY2Fu IGp1c3QgcmVtb3ZlIGl0IGFsdG9nZXRoZXIuCisKKyAgICAgICAgU2luY2UgdGhpcyBidWcgb25s eSBhZmZlY3RzIGRyYWcgYW5kIGRyb3AgaW4gdGhlIG1hY09TIFdlYktpdDIgcG9ydCwgdGhlcmUn cyBjdXJyZW50bHkgbm8gd2F5IHRvIHRlc3QgdGhpcy4gSSdsbCBiZSB1c2luZworICAgICAgICA8 aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MTg5OD4gdG8gdHJhY2sg YWRkaW5nIHRlc3Qgc3VwcG9ydCBmb3IgZHJhZyBhbmQgZHJvcCBvbiBtYWNPUyBXZWJLaXQyLiBN YW51YWxseSB0ZXN0ZWQKKyAgICAgICAgZHJhZ2dpbmcgaW4gYm90aCBXZWJLaXQxIGFuZCBXZWJL aXQyIG9uIG1hY09TLiBkcmFnTG9jYXRpb25JbldpbmRvd0Nvb3JkaW5hdGVzIGlzbid0IHVzZWQg YXQgYWxsIGZvciBpT1MgZHJhZyBhbmQgZHJvcC4KKworICAgICAgICAqIHBhZ2UvRHJhZ0NvbnRy b2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RHJhZ0NvbnRyb2xsZXI6OmRvU3lzdGVtRHJh Zyk6CisgICAgICAgICogcGxhdGZvcm0vRHJhZ0l0ZW0uaDoKKyAgICAgICAgKFdlYkNvcmU6OkRy YWdJdGVtOjplbmNvZGUgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6RHJhZ0l0ZW06OmRlY29k ZSk6CisKIDIwMTgtMDEtMTggIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAg ICAgIFtQYXltZW50IFJlcXVlc3RdIFN1cHBvcnQgYSBkZWZhdWx0IHNoaXBwaW5nIGFkZHJlc3Mg Zm9yIEFwcGxlIFBheQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9EcmFnQ29udHJv bGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RyYWdDb250cm9sbGVyLmNwcAppbmRleCA0 ZWVmYmFiMjA1Nzc0NmE2OTkxZmFhNTM5NGM4YjA4ZTg1NGRmMDhhLi5hYzUyMjViMDMxM2I4NGNl YmUxYzZiMWRiN2Q2ZmQwMWUzN2U1ZDkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdl L0RyYWdDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RyYWdDb250cm9s bGVyLmNwcApAQCAtMTIyNyw4ICsxMjI3LDcgQEAgdm9pZCBEcmFnQ29udHJvbGxlcjo6ZG9TeXN0 ZW1EcmFnKERyYWdJbWFnZSBpbWFnZSwgY29uc3QgSW50UG9pbnQmIGRyYWdMb2MsIGNvbnMKICAg ICBhdXRvIGRyYWdMb2NhdGlvbkluUm9vdFZpZXdDb29yZGluYXRlcyA9IGZyYW1lLnZpZXcoKS0+ Y29udGVudHNUb1Jvb3RWaWV3KGRyYWdMb2MpOwogICAgIGl0ZW0uZXZlbnRQb3NpdGlvbkluQ29u dGVudENvb3JkaW5hdGVzID0gdmlld1Byb3RlY3Rvci0+cm9vdFZpZXdUb0NvbnRlbnRzKGV2ZW50 UG9zaXRpb25JblJvb3RWaWV3Q29vcmRpbmF0ZXMpOwogICAgIGl0ZW0uZHJhZ0xvY2F0aW9uSW5D b250ZW50Q29vcmRpbmF0ZXMgPSB2aWV3UHJvdGVjdG9yLT5yb290Vmlld1RvQ29udGVudHMoZHJh Z0xvY2F0aW9uSW5Sb290Vmlld0Nvb3JkaW5hdGVzKTsKLSAgICBpdGVtLmV2ZW50UG9zaXRpb25J bldpbmRvd0Nvb3JkaW5hdGVzID0gZnJhbWUudmlldygpLT5jb250ZW50c1RvV2luZG93KGl0ZW0u ZXZlbnRQb3NpdGlvbkluQ29udGVudENvb3JkaW5hdGVzKTsKLSAgICBpdGVtLmRyYWdMb2NhdGlv bkluV2luZG93Q29vcmRpbmF0ZXMgPSBmcmFtZS52aWV3KCktPmNvbnRlbnRzVG9XaW5kb3coaXRl bS5kcmFnTG9jYXRpb25JbkNvbnRlbnRDb29yZGluYXRlcyk7CisgICAgaXRlbS5kcmFnTG9jYXRp b25JbldpbmRvd0Nvb3JkaW5hdGVzID0gdmlld1Byb3RlY3Rvci0+Y29udGVudHNUb1dpbmRvdyhp dGVtLmRyYWdMb2NhdGlvbkluQ29udGVudENvb3JkaW5hdGVzKTsKICAgICBpZiAoYXV0byBlbGVt ZW50ID0gc3RhdGUuc291cmNlKSB7CiAgICAgICAgIGF1dG8gZGF0YVRyYW5zZmVySW1hZ2VFbGVt ZW50ID0gc3RhdGUuZGF0YVRyYW5zZmVyLT5kcmFnSW1hZ2VFbGVtZW50KCk7CiAgICAgICAgIGlm IChzdGF0ZS50eXBlID09IERyYWdTb3VyY2VBY3Rpb25ESFRNTCkgewpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vRHJhZ0l0ZW0uaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L0RyYWdJdGVtLmgKaW5kZXggODQ0MDVmNmY3ODFjNzY5YzUwOTc0MTZkYjVmOGYzNTNmMzY3OWYy MC4uYTAyYTNlYTdhYzRlYTExMDkyNTJlMGEwMWZmNjNiZGY0MDAwMmJmMyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRHJhZ0l0ZW0uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9EcmFnSXRlbS5oCkBAIC00Myw3ICs0Myw2IEBAIHN0cnVjdCBEcmFnSXRlbSBmaW5h bCB7CiAgICAgRHJhZ1NvdXJjZUFjdGlvbiBzb3VyY2VBY3Rpb24geyBEcmFnU291cmNlQWN0aW9u Tm9uZSB9OwogICAgIEludFBvaW50IGV2ZW50UG9zaXRpb25JbkNvbnRlbnRDb29yZGluYXRlczsK ICAgICBJbnRQb2ludCBkcmFnTG9jYXRpb25JbkNvbnRlbnRDb29yZGluYXRlczsKLSAgICBJbnRQ b2ludCBldmVudFBvc2l0aW9uSW5XaW5kb3dDb29yZGluYXRlczsKICAgICBJbnRQb2ludCBkcmFn TG9jYXRpb25JbldpbmRvd0Nvb3JkaW5hdGVzOwogICAgIFN0cmluZyB0aXRsZTsKICAgICBVUkwg dXJsOwpAQCAtNjIsNyArNjEsNyBAQCB2b2lkIERyYWdJdGVtOjplbmNvZGUoRW5jb2RlciYgZW5j b2RlcikgY29uc3QKICAgICAvLyBGSVhNRSgxNzM4MTUpOiBXZSBzaG91bGQgZW5jb2RlIGFuZCBk ZWNvZGUgUGFzdGVib2FyZFdyaXRlckRhdGEgYW5kIHBsYXRmb3JtIGRyYWcgaW1hZ2UgZGF0YQog ICAgIC8vIGhlcmUgdG9vLCBhcyBwYXJ0IG9mIG1vdmluZyBvZmYgb2YgdGhlIGxlZ2FjeSBkcmFn Z2luZyBjb2RlcGF0aC4KICAgICBlbmNvZGVyLmVuY29kZUVudW0oc291cmNlQWN0aW9uKTsKLSAg ICBlbmNvZGVyIDw8IGltYWdlQW5jaG9yUG9pbnQgPDwgZXZlbnRQb3NpdGlvbkluQ29udGVudENv b3JkaW5hdGVzIDw8IGRyYWdMb2NhdGlvbkluQ29udGVudENvb3JkaW5hdGVzIDw8IGV2ZW50UG9z aXRpb25JbldpbmRvd0Nvb3JkaW5hdGVzIDw8IGRyYWdMb2NhdGlvbkluV2luZG93Q29vcmRpbmF0 ZXMgPDwgdGl0bGUgPDwgdXJsIDw8IGRyYWdQcmV2aWV3RnJhbWVJblJvb3RWaWV3Q29vcmRpbmF0 ZXM7CisgICAgZW5jb2RlciA8PCBpbWFnZUFuY2hvclBvaW50IDw8IGV2ZW50UG9zaXRpb25JbkNv bnRlbnRDb29yZGluYXRlcyA8PCBkcmFnTG9jYXRpb25JbkNvbnRlbnRDb29yZGluYXRlcyA8PCBk cmFnTG9jYXRpb25JbldpbmRvd0Nvb3JkaW5hdGVzIDw8IHRpdGxlIDw8IHVybCA8PCBkcmFnUHJl dmlld0ZyYW1lSW5Sb290Vmlld0Nvb3JkaW5hdGVzOwogICAgIGJvb2wgaGFzSW5kaWNhdG9yRGF0 YSA9IGltYWdlLmhhc0luZGljYXRvckRhdGEoKTsKICAgICBlbmNvZGVyIDw8IGhhc0luZGljYXRv ckRhdGE7CiAgICAgaWYgKGhhc0luZGljYXRvckRhdGEpCkBAIC04MSw4ICs4MCw2IEBAIGJvb2wg RHJhZ0l0ZW06OmRlY29kZShEZWNvZGVyJiBkZWNvZGVyLCBEcmFnSXRlbSYgcmVzdWx0KQogICAg ICAgICByZXR1cm4gZmFsc2U7CiAgICAgaWYgKCFkZWNvZGVyLmRlY29kZShyZXN1bHQuZHJhZ0xv Y2F0aW9uSW5Db250ZW50Q29vcmRpbmF0ZXMpKQogICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAg aWYgKCFkZWNvZGVyLmRlY29kZShyZXN1bHQuZXZlbnRQb3NpdGlvbkluV2luZG93Q29vcmRpbmF0 ZXMpKQotICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgaWYgKCFkZWNvZGVyLmRlY29kZShyZXN1 bHQuZHJhZ0xvY2F0aW9uSW5XaW5kb3dDb29yZGluYXRlcykpCiAgICAgICAgIHJldHVybiBmYWxz ZTsKICAgICBpZiAoIWRlY29kZXIuZGVjb2RlKHJlc3VsdC50aXRsZSkpCg==