181877 2018-01-19 13:12:11 -0800 Kill ArithNegate's ArithProfile assert inside BytecodeParser 2018-01-19 14:30:50 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff rmorisset ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1391127 0 saam 2018-01-19 13:12:11 -0800 We assert that op_negate's result ArithProfile only produces number. It's logically true that negate only produces a number. However, the DFG may incorrectly pick this ArithProfile when doing OSR exit profiling. So we'll end up profiling something that's likely the input to negate. I think we just need to kill this assert and live with the possibility of this happening since Graph::methodOfGettingAValueProfileFor is entirely heuristic based causing it to be imprecise. 1391142 1 saam 2018-01-19 13:19:40 -0800 <rdar://problem/36630552> 1391151 2 331780 saam 2018-01-19 13:24:27 -0800 Created attachment 331780 patch 1391155 3 331780 mark.lam 2018-01-19 13:30:07 -0800 Comment on attachment 331780 patch r=me 1391185 4 331780 commit-queue 2018-01-19 14:30:49 -0800 Comment on attachment 331780 patch Clearing flags on attachment: 331780 Committed r227236: <https://trac.webkit.org/changeset/227236> 1391186 5 commit-queue 2018-01-19 14:30:50 -0800 All reviewed patches have been landed. Closing bug. 331780 2018-01-19 13:24:27 -0800 2018-01-19 14:30:49 -0800 patch c-backup.diff text/plain 4259 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMjcyMzApCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDIwIEBACisyMDE4LTAxLTE5ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIEtpbGwgQXJpdGhOZWdhdGUncyBBcml0aFByb2ZpbGUgYXNzZXJ0IGlu c2lkZSBCeXRlY29kZVBhcnNlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTgxODc3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNjYzMDU1Mj4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9h cml0aC1wcm9maWxlLWZvci1uZWdhdGUtY2FuLXNlZS1ub24tbnVtYmVyLWR1ZS10by1kZmctb3Ny LWV4aXQtcHJvZmlsaW5nLmpzOiBBZGRlZC4KKyAgICAgICAgKHJ1bk5lYXJTdGFja0xpbWl0KToK KyAgICAgICAgKGYxKToKKyAgICAgICAgKGYyKToKKyAgICAgICAgKGYzKToKKyAgICAgICAgKGku Y2F0Y2gpOgorICAgICAgICAoaS50cnkucnVuTmVhclN0YWNrTGltaXQpOgorICAgICAgICAoY2F0 Y2gpOgorCiAyMDE4LTAxLTE5ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAg ICAgICAgIFNwcmVhZCdzIGVmZmVjdHMgYXJlIG1vZGVsZWQgaW5jb3JyZWN0bHkgYm90aCBpbiBB SSBhbmQgaW4gQ2xvYmJlcml6ZQpJbmRleDogSlNUZXN0cy9zdHJlc3MvYXJpdGgtcHJvZmlsZS1m b3ItbmVnYXRlLWNhbi1zZWUtbm9uLW51bWJlci1kdWUtdG8tZGZnLW9zci1leGl0LXByb2ZpbGlu Zy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9hcml0aC1wcm9maWxlLWZvci1uZWdh dGUtY2FuLXNlZS1ub24tbnVtYmVyLWR1ZS10by1kZmctb3NyLWV4aXQtcHJvZmlsaW5nLmpzCShu b25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL2FyaXRoLXByb2ZpbGUtZm9yLW5lZ2F0ZS1j YW4tc2VlLW5vbi1udW1iZXItZHVlLXRvLWRmZy1vc3ItZXhpdC1wcm9maWxpbmcuanMJKHdvcmtp bmcgY29weSkKQEAgLTAsMCArMSwzMiBAQAorZnVuY3Rpb24gcnVuTmVhclN0YWNrTGltaXQoZikg eworICAgIHRyeSB7CisgICAgICAgIHJldHVybiB0KCk7CisgICAgfSBjYXRjaCAoZSkgeworICAg ICAgICByZXR1cm4gZigpOworICAgIH0KK30KK2xldCBmbGFnID0gZmFsc2U7CitmdW5jdGlvbiBm MSgpIHsKKyAgICByZXR1cm4gZmxhZyA/IHt9IDogMTA7Cit9Citub0lubGluZShmMSk7CisKK2Z1 bmN0aW9uIGYyKCkgeworfQorCitmdW5jdGlvbiBmMyhhcmcpIHsKKyAgICBsZXQgciA9IC0oYXJn ID8gZjEoKSA6IGYyKCkpOworfQorCitmb3IgKGxldCBpID0gMDsgaSA8IDEwMDAwMDsgKytpKSB7 CisgICAgdHJ5IHsKKyAgICAgICAgZjMoISEoaSAlIDIpKTsKKyAgICB9IGNhdGNoIChlKSB7fQor fSAKKworZmxhZyA9IHRydWU7Citmb3IgKGxldCBpID0gMDsgaSA8IDEwMDAwMDsgKytpKSB0cnkg eworICAgIHJ1bk5lYXJTdGFja0xpbWl0KCgpID0+IHsKKyAgICAgICAgcmV0dXJuIGYzKCEhKGkg JSAyKSk7CisgICAgfSk7Cit9IGNhdGNoIChlKSB7fQpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCShyZXZpc2lvbiAyMjcyMTYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTgtMDEtMTkgIFNhYW0gQmFyYXRp ICA8c2JhcmF0aUBhcHBsZS5jb20+CisKKyAgICAgICAgS2lsbCBBcml0aE5lZ2F0ZSdzIEFyaXRo UHJvZmlsZSBhc3NlcnQgaW5zaWRlIEJ5dGVjb2RlUGFyc2VyCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODE4NzcKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzM2NjMwNTUyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEJlZm9yZSB0aGlzIHBhdGNoLCB3ZSB1c2VkIHRvIGFzc2VydCB0aGF0IG9wX25lZ2F0 ZSdzIHJlc3VsdCBBcml0aFByb2ZpbGUKKyAgICAgICAgb25seSBwcm9kdWNlcyBudW1iZXIuIEl0 J3MgbG9naWNhbGx5IHRydWUgdGhhdCBuZWdhdGUgb25seSBwcm9kdWNlcyBhIG51bWJlci4KKyAg ICAgICAgSG93ZXZlciwgdGhlIERGRyBtYXkgaW5jb3JyZWN0bHkgcGljayB0aGlzIEFyaXRoUHJv ZmlsZSB3aGVuIGRvaW5nIE9TUiBleGl0CisgICAgICAgIHByb2ZpbGluZy4gU28gd2UnbGwgZW5k IHVwIHByb2ZpbGluZyBzb21ldGhpbmcgdGhhdCdzIGxpa2VseSB0aGUgaW5wdXQgdG8KKyAgICAg ICAgbmVnYXRlLiBUaGlzIHBhdGNoIHJlbW92ZXMgdGhlIGFzc2VydC4gV2UgY2VkZSB0byB0aGUg ZmFjdCB0aGF0IEdyYXBoOjptZXRob2RPZkdldHRpbmdBVmFsdWVQcm9maWxlRm9yCisgICAgICAg IGlzIGVudGlyZWx5IGhldXJpc3RpYyBiYXNlZCwgcG90ZW50aWFsbHkgbGVhZGluZyB0byBwcm9m aWxpbmcgcmVzdWx0cyBiZWluZyBpbXByZWNpc2UuCisKKyAgICAgICAgKiBkZmcvREZHQnl0ZUNv ZGVQYXJzZXIuY3BwOgorICAgICAgICAoSlNDOjpERkc6OkJ5dGVDb2RlUGFyc2VyOjptYWtlU2Fm ZSk6CisKIDIwMTgtMDEtMTkgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+ CiAKICAgICAgICAgSGF2ZUludGVybmFsU0RLIGluY2x1ZGVzIHNob3VsZCBiZSAiI2luY2x1ZGU/ IgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNl ci5jcHAJKHJldmlzaW9uIDIyNzIxNikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH Qnl0ZUNvZGVQYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05NDAsOCArOTQwLDEwIEBAIHBy aXZhdGU6CiAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgIH0KICAg ICAgICAgICAgICAgICBjYXNlIEFyaXRoTmVnYXRlOiB7Ci0gICAgICAgICAgICAgICAgICAgIEFT U0VSVF9XSVRIX01FU1NBR0UoIWFyaXRoUHJvZmlsZS0+ZGlkT2JzZXJ2ZU5vbk51bWJlcigpLCAi b3BfbmVnYXRlIHN0YXJ0cyB3aXRoIGEgdG9OdW1iZXIoKSBvbiB0aGUgYXJndW1lbnQsIGl0IHNo b3VsZCBvbmx5IHByb2R1Y2UgbnVtYmVycy4iKTsKLQorICAgICAgICAgICAgICAgICAgICAvLyBX ZSdkIGxpa2UgdG8gYXNzZXJ0IGhlcmUgdGhhdCB0aGUgYXJpdGggcHJvZmlsZSBmb3IgdGhlIHJl c3VsdCBvZiBuZWdhdGUgbmV2ZXIKKyAgICAgICAgICAgICAgICAgICAgLy8gc2VlcyBhIG5vbi1u dW1iZXIsIGJ1dCB3ZSBjYW4ndC4gSXQncyB0cnVlIHRoYXQgbmVnYXRlIG5ldmVyIHByb2R1Y2Vz IGEgbm9uLW51bWJlci4KKyAgICAgICAgICAgICAgICAgICAgLy8gQnV0IHNvbWV0aW1lcyB3ZSds bCBlbmQgdXAgZ3JhYmJpbmcgdGhlIHdyb25nIEFyaXRoUHJvZmlsZSBkdXJpbmcgT1NSIGV4aXQs IGFuZAorICAgICAgICAgICAgICAgICAgICAvLyBwcm9maWxpbmcgdGhlIHdyb25nIHZhbHVlLCBs ZWFkaW5nIHRoZSBBcml0aFByb2ZpbGUgdG8gdGhpbmsgaXQgb2JzZXJ2ZWQgYSBub24tbnVtYmVy IHJlc3VsdC4KICAgICAgICAgICAgICAgICAgICAgaWYgKGFyaXRoUHJvZmlsZS0+bGhzT2JzZXJ2 ZWRUeXBlKCkuc2F3TnVtYmVyKCkgfHwgYXJpdGhQcm9maWxlLT5kaWRPYnNlcnZlRG91YmxlKCkp CiAgICAgICAgICAgICAgICAgICAgICAgICBub2RlLT5tZXJnZUZsYWdzKE5vZGVNYXlIYXZlRG91 YmxlUmVzdWx0KTsKICAgICAgICAgICAgICAgICAgICAgaWYgKGFyaXRoUHJvZmlsZS0+ZGlkT2Jz ZXJ2ZU5lZ1plcm9Eb3VibGUoKSB8fCBtX2lubGluZVN0YWNrVG9wLT5tX2V4aXRQcm9maWxlLmhh c0V4aXRTaXRlKG1fY3VycmVudEluZGV4LCBOZWdhdGl2ZVplcm8pKQo=